xiaoxiang781216 commented on issue #1144:
URL:
https://github.com/apache/incubator-nuttx/issues/1144#issuecomment-721553181
related issue: https://github.com/apache/incubator-nuttx/issues/2213
This is an automated message fr
xiaoxiang781216 opened a new issue #2213:
URL: https://github.com/apache/incubator-nuttx/issues/2213
Right now, NuttX support one big spin lock:
```
irqstate_t spin_lock_irqsave(void);
void spin_unlock_irqrestore(irqstate_t flags);
```
Which isn't good for SMP machine. Compare
xiaoxiang781216 commented on pull request #2129:
URL: https://github.com/apache/incubator-nuttx/pull/2129#issuecomment-721526096
@v01d should we rebase the PR? I think all dependence has been merged.
This is an automated mess
xiaoxiang781216 merged pull request #461:
URL: https://github.com/apache/incubator-nuttx-apps/pull/461
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new ee7b0fc nxplayer & nxrecorder:
masayuki2009 commented on pull request #2124:
URL: https://github.com/apache/incubator-nuttx/pull/2124#issuecomment-721511490
>You should also update apps,:
>
>apache/incubator-nuttx-apps#461
@GUIDINGLI
Thanks, it works now!
GUIDINGLI commented on pull request #2124:
URL: https://github.com/apache/incubator-nuttx/pull/2124#issuecomment-721506417
@masayuki2009
You should also update apps,:
https://github.com/apache/incubator-nuttx-apps/pull/461
GUIDINGLI opened a new pull request #461:
URL: https://github.com/apache/incubator-nuttx-apps/pull/461
## Summary
nxplayer & nxrecorder: make main thread configurable, set to default
## Impact
This should be commit with:
https://github.com/apache/incubator-nuttx/pull/
masayuki2009 commented on pull request #2124:
URL: https://github.com/apache/incubator-nuttx/pull/2124#issuecomment-721503976
>Have you pick another patch for increase stack size ?
@GUIDINGLI
Yes, because I checked out your repository and branch.
GUIDINGLI commented on pull request #2124:
URL: https://github.com/apache/incubator-nuttx/pull/2124#issuecomment-721501909
@masayuki2009
Have you pick another patch for increase stack size ?
https://github.com/apache/incubator-nuttx/pull/2124/commits/d86d7bc177d9180022549d4d44
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r517081420
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r517081420
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r517081420
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r517081420
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r517081420
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r517081420
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
masayuki2009 commented on pull request #2124:
URL: https://github.com/apache/incubator-nuttx/pull/2124#issuecomment-72149
> > I tried this PR with ubuntu18.04 x86_64, but nuttx crashed when playback
an WAV file via hostfs.
> > Could you tell me what environment are you using?
> >
v01d commented on pull request #2189:
URL: https://github.com/apache/incubator-nuttx/pull/2189#issuecomment-721489545
Yes, the datasheet is really unclear but after looking around the nordic
infocenter it was really easy. For now I tested just restarting transactions
manually, but you coul
btashton commented on pull request #2189:
URL: https://github.com/apache/incubator-nuttx/pull/2189#issuecomment-721489114
Oh cool, is this the DMA array list feature? That was on my list. I just
wanted to prevent the broken behavior first.
I have a setup with requirements for long D
btashton edited a comment on pull request #2189:
URL: https://github.com/apache/incubator-nuttx/pull/2189#issuecomment-721489114
Oh cool, is this the DMA array list feature? That was on my list. I just
wanted to prevent the broken behavior first with long transfers.
I have a setup w
v01d commented on pull request #2189:
URL: https://github.com/apache/incubator-nuttx/pull/2189#issuecomment-721487157
BTW, if you find the issue and it is a simple fix, let me know, I can apply
it an make the PR. I also found that the SPIM supports sending transactions
larger than 255 byte
GUIDINGLI edited a comment on pull request #2124:
URL: https://github.com/apache/incubator-nuttx/pull/2124#issuecomment-721485562
> @masayuki2009
> I tried this PR with ubuntu18.04 x86_64, but nuttx crashed when playback
an WAV file via hostfs.
> Could you tell me what environment ar
GUIDINGLI edited a comment on pull request #2124:
URL: https://github.com/apache/incubator-nuttx/pull/2124#issuecomment-721485562
> I tried this PR with ubuntu18.04 x86_64, but nuttx crashed when playback
an WAV file via hostfs.
> Could you tell me what environment are you using?
GUIDINGLI commented on pull request #2124:
URL: https://github.com/apache/incubator-nuttx/pull/2124#issuecomment-721485562
> @GUIDINGLI @xiaoxiang781216
> I tried this PR with ubuntu18.04 x86_64, but nuttx crashed when playback
an WAV file via hostfs.
> Could you tell me what environm
xiaoxiang781216 commented on issue #2203:
URL:
https://github.com/apache/incubator-nuttx/issues/2203#issuecomment-721478840
@v01d , Ok, I will provide a patch to preallocate stdin/stdout/stderr, so
the printf don't crash at least.
-
masayuki2009 commented on pull request #2124:
URL: https://github.com/apache/incubator-nuttx/pull/2124#issuecomment-721475927
@GUIDINGLI @xiaoxiang781216
I tried this PR with ubuntu18.04 x86_64, but nuttx crashed when playback an
WAV file via hostfs.
Could you tell me what environmen
v01d commented on issue #2203:
URL:
https://github.com/apache/incubator-nuttx/issues/2203#issuecomment-721469081
Ok, I avoided the crash if I do enable DEV_CONSOLE but enable
console->syslog redirection. It seems the problem is missing /dev/console.
Maybe this shouldn't be an option?
B
v01d edited a comment on issue #2203:
URL:
https://github.com/apache/incubator-nuttx/issues/2203#issuecomment-721466210
As I suspected, I'm getting bit by the same bug. In my case I disabled
console since I'm working with a device with inaccessible UART. The moment I do
a printf() from my
v01d commented on issue #2203:
URL:
https://github.com/apache/incubator-nuttx/issues/2203#issuecomment-721466210
As I suspected, I'm getting bit by the same bug. In my case I disabled
console since I'm working with a device with inaccessible UART. The moment I do
a printf() from my app it
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 0785e6c Publishing web
v01d commented on pull request #2189:
URL: https://github.com/apache/incubator-nuttx/pull/2189#issuecomment-721416719
It supposedly is correct according to my debugging. There was an
uninitialized variable somewhere which may have affected this but it seems it
didnt.
btashton commented on pull request #2189:
URL: https://github.com/apache/incubator-nuttx/pull/2189#issuecomment-721415821
> @btashton can you confirm SPI still works for you?
> It goes to STARTED but never ends and CLK does not clock anything.
> Note that there are a few copy paste er
v01d edited a comment on pull request #2189:
URL: https://github.com/apache/incubator-nuttx/pull/2189#issuecomment-721411759
@btashton can you confirm SPI still works for you?
It goes to STARTED but never ends and CLK does not clock anything.
Note that there are a few copy paste error
v01d commented on pull request #2189:
URL: https://github.com/apache/incubator-nuttx/pull/2189#issuecomment-721414608
Here's the patch with changes so far. I can't figure how this broke, can't
find anything else wrong.
Reverting this PR (and applying a hacky approach to not define MISO)
v01d commented on pull request #2189:
URL: https://github.com/apache/incubator-nuttx/pull/2189#issuecomment-721411759
@btashton can you confirm SPI still works for you?
It goes to STARTED when never ends and CLK does not clock anything.
Note that there are a few copy paste errors I al
acassis commented on a change in pull request #2212:
URL: https://github.com/apache/incubator-nuttx/pull/2212#discussion_r516983350
##
File path: arch/arm/src/imxrt/imxrt_wdog.c
##
@@ -40,28 +40,346 @@
#include
#include
-#include
+#include
+
+#include
#include
+#incl
Ouss4 merged pull request #2138:
URL: https://github.com/apache/incubator-nuttx/pull/2138
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 9dadfc5 stm32f7/stm32_serial.c: fix console re-initialisation if DMA
enabled
add b54f0ed xtensa
NicholasChin opened a new pull request #2212:
URL: https://github.com/apache/incubator-nuttx/pull/2212
Based on work done by Jake Choy.
## Summary
Adds lower-half driver implementation for Watchdog 1 for IMXRT family.
## Impact
Does not affect existing watchdog code in im
v01d opened a new issue #2211:
URL: https://github.com/apache/incubator-nuttx/issues/2211
It seems up_head.c is built separately that to any other .c file in sim,
without adding it to CSRCS. Thus, it is not added to Make.dep.
This can bring problems when configuration changes and up_head
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 1ce75cc arch/arm/src/stm32/stm32_adc.c: do not allow negative ref
count
add 9dadfc5 stm32f7/stm32_s
davids5 closed issue #1598:
URL: https://github.com/apache/incubator-nuttx/issues/1598
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
davids5 merged pull request #2209:
URL: https://github.com/apache/incubator-nuttx/pull/2209
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
acassis commented on pull request #2209:
URL: https://github.com/apache/incubator-nuttx/pull/2209#issuecomment-721331684
> > Hi @davids5 and @lukegluke doesn't SERIAL_HAVE_CONSOLE_DMA imply both TX
and RX? BTW, if it fixes your issue and doesn't introduce any issue on PX4
side, it is fine.
acassis commented on pull request #2210:
URL: https://github.com/apache/incubator-nuttx/pull/2210#issuecomment-721328885
Good finding, thank you!
This is an automated message from the Apache Git Service.
To respond to the mes
acassis merged pull request #2210:
URL: https://github.com/apache/incubator-nuttx/pull/2210
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 1ce75cc arch/arm/src/stm32/stm32_adc.
btashton commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r516870521
##
File path: arch/sim/src/sim/up_i2cbuslinux.c
##
@@ -0,0 +1,310 @@
+/**
btashton commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r516833381
##
File path: arch/sim/src/sim/up_i2cbuslinux.c
##
@@ -0,0 +1,310 @@
+/**
xiaoxiang781216 commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r516865137
##
File path: arch/sim/src/sim/up_i2cbuslinux.c
##
@@ -0,0 +1,310 @@
+/***
xiaoxiang781216 commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r516865137
##
File path: arch/sim/src/sim/up_i2cbuslinux.c
##
@@ -0,0 +1,310 @@
+/***
v01d commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r516862889
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
{
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r516861739
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
v01d commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r516862354
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
{
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r516861739
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r516853464
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r516853464
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r516853464
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
Ouss4 commented on issue #2206:
URL:
https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-721286467
> Note that a similar script could be useful for applications. In this case
it is not necessary to supporting copying any existing application, but a
specific one can be used
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r516853464
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r516853464
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r516853464
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
Ouss4 commented on issue #2206:
URL:
https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-721281740
> Ah, that is nice. How do things change now for custom boards?
Before that refactoring, there were some hard-coded links in Make.defs
files. Those were also another tra
v01d commented on issue #2206:
URL:
https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-721278578
> Note, that most of that has been refactored in tools/Config.mk.
Ah, that is nice. How do things change now for custom boards?
> > All of this could indeed by made
Ouss4 commented on issue #2206:
URL:
https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-721277220
> You mean common right? Yes this was missing, thank you a lot for help :D
Sorry, yes I meant `common`. Is everything building now?
> Note that I would prefer con
btashton commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r516843469
##
File path: arch/sim/src/sim/up_i2cbuslinux.c
##
@@ -0,0 +1,310 @@
+/**
btashton commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r516842752
##
File path: arch/sim/src/sim/up_i2cbuslinux.c
##
@@ -0,0 +1,310 @@
+/**
v01d commented on issue #2206:
URL:
https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-721273611
Note that a similar script could be useful for applications. In this case it
is not necessary to supporting copying any existing application, but a specific
one can be used (I'
v01d commented on issue #2206:
URL:
https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-721272547
Well the configure script already needs to know if it is an out of tree
board or not, since it will have to setup things differently. This is fact why
using an ouf-of-tree boar
w8jcik edited a comment on issue #2206:
URL:
https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-721269344
> If you are configuring an out-of-tree board it does not make any sense to
interpret the configuration as an in-tree board.
I am not sure if I understand. Is th
w8jcik edited a comment on issue #2206:
URL:
https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-721269344
> If you are configuring an out-of-tree board it does not make any sense to
interpret the configuration as an in-tree board.
I am not sure if I understand. Is th
w8jcik edited a comment on issue #2206:
URL:
https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-721269344
> If you are configuring an out-of-tree board it does not make any sense to
interpret the configuration as an in-tree board.
I am not sure if I understand. Is th
w8jcik commented on issue #2206:
URL:
https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-721269344
> If you are configuring an out-of-tree board it does not make any sense to
interpret the configuration as an in-tree board.
I am not sure if I understand. Is there som
btashton commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r516834090
##
File path: arch/sim/src/sim/up_i2cbuslinux.c
##
@@ -0,0 +1,288 @@
+/**
btashton commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r516784765
##
File path: arch/sim/src/sim/up_i2cbuslinux.c
##
@@ -0,0 +1,288 @@
+/**
btashton commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r516833381
##
File path: arch/sim/src/sim/up_i2cbuslinux.c
##
@@ -0,0 +1,310 @@
+/**
v01d commented on issue #2206:
URL:
https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-721267843
Note that I would prefer configure.sh to deal with this. If you are
configuring an out-of-tree board it does not make any sense to interpret the
configuration as an in-tree boa
w8jcik edited a comment on issue #2206:
URL:
https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-721264846
@Ouss4 regarding the issue of mine:
> Please, make sure you are setting the paths correctly: "No directory at
/home/user/dev/project/base/nuttx//src"
I di
w8jcik edited a comment on issue #2206:
URL:
https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-721264846
@Ouss4 regarding the issue of mine:
> Please, make sure you are setting the paths correctly: "No directory at
/home/user/dev/project/base/nuttx//src"
I di
w8jcik edited a comment on issue #2206:
URL:
https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-721264846
@Ouss4 regarding the issue of mine:
> Please, make sure you are setting the paths correctly: "No directory at
/home/user/dev/project/base/nuttx//src"
I di
w8jcik commented on issue #2206:
URL:
https://github.com/apache/incubator-nuttx/issues/2206#issuecomment-721264846
@Ouss4 regarding the issue of mine:
> Please, make sure you are setting the paths correctly: "No directory at
/home/user/dev/project/base/nuttx//src"
I didn't pu
btashton commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r516829473
##
File path: arch/sim/src/sim/up_i2cbuslinux.c
##
@@ -0,0 +1,310 @@
+/**
v01d commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r516829340
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
{
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r516825901
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r516825901
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r516825901
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
btashton commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r516822652
##
File path: arch/sim/src/sim/up_i2cbuslinux.c
##
@@ -0,0 +1,310 @@
+/**
btashton commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r516821219
##
File path: arch/sim/src/sim/up_i2cbuslinux.c
##
@@ -0,0 +1,310 @@
+/**
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r516816640
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
v01d commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r516819366
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
{
btashton commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r516818473
##
File path: arch/sim/src/sim/up_i2cbuslinux.c
##
@@ -0,0 +1,310 @@
+/**
btashton commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r516815035
##
File path: arch/sim/src/sim/up_i2cbuslinux.c
##
@@ -0,0 +1,310 @@
+/**
btashton commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r516817425
##
File path: arch/sim/src/sim/up_i2cbuslinux.c
##
@@ -0,0 +1,310 @@
+/**
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r516816640
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
xiaoxiang781216 commented on a change in pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#discussion_r516816640
##
File path: drivers/lcd/lcd_dev.c
##
@@ -123,20 +123,56 @@ static int lcddev_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
btashton commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r516815907
##
File path: arch/sim/src/sim/up_i2cbuslinux.c
##
@@ -0,0 +1,310 @@
+/**
btashton commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r516815035
##
File path: arch/sim/src/sim/up_i2cbuslinux.c
##
@@ -0,0 +1,310 @@
+/**
btashton commented on a change in pull request #2158:
URL: https://github.com/apache/incubator-nuttx/pull/2158#discussion_r516815035
##
File path: arch/sim/src/sim/up_i2cbuslinux.c
##
@@ -0,0 +1,310 @@
+/**
juniskane opened a new pull request #2210:
URL: https://github.com/apache/incubator-nuttx/pull/2210
## Summary
When HAVE_HSI_CONTROL, adc_reset_hsi_disable() calls adc_reset()
followed by adc_shutdown() and this combination is called before
adc_setup() by upper level ADC driver. Wit
v01d commented on pull request #2208:
URL: https://github.com/apache/incubator-nuttx/pull/2208#issuecomment-721245367
Ok, I applied all changes except the one about LCD framebuffer.
This is an automated message from the Apach
1 - 100 of 222 matches
Mail list logo
