[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1355: vfs: Make the filesystem query API confirm POSIX standard

2020-07-03 Thread GitBox
xiaoxiang781216 commented on a change in pull request #1355: URL: https://github.com/apache/incubator-nuttx/pull/1355#discussion_r449744533 ## File path: include/sys/statvfs.h ## @@ -49,7 +49,14 @@ * Pre-processor Definitions

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1355: vfs: Make the filesystem query API confirm POSIX standard

2020-07-03 Thread GitBox
xiaoxiang781216 commented on a change in pull request #1355: URL: https://github.com/apache/incubator-nuttx/pull/1355#discussion_r449744290 ## File path: arch/sim/src/sim/up_hostfs.c ## @@ -432,32 +432,35 @@ int host_closedir(void *dirp) } /*

[incubator-nuttx] branch master updated: libs/libc/semaphore/sem_getvalue: correct get_value descriptions

2020-07-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 9761235 libs/libc/semaphore/sem_get

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1357: libs/libc/semaphore/sem_getvalue: correct get_value descriptions

2020-07-03 Thread GitBox
xiaoxiang781216 merged pull request #1357: URL: https://github.com/apache/incubator-nuttx/pull/1357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #319: make import: enhance make import

2020-07-03 Thread GitBox
xiaoxiang781216 merged pull request #319: URL: https://github.com/apache/incubator-nuttx-apps/pull/319 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-nuttx] branch master updated: sim: Fix 32-bit module build

2020-07-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 749e871 sim: Fix 32-bit module buil

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1362: sim: Fix 32-bit module build

2020-07-03 Thread GitBox
xiaoxiang781216 merged pull request #1362: URL: https://github.com/apache/incubator-nuttx/pull/1362 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx-apps] 02/04: make/import: add post build support

2020-07-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit fde8f24f2ac4f357d9848da7ff64c4ffd574be2f Author: chao.an AuthorDate: Wed Jul 1 11:32:21 2020 +0800

[incubator-nuttx-apps] 04/04: make/import: support import zip use relative path

2020-07-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit c723283340bd371db8375fff64f754d91cf56cfc Author: chao.an AuthorDate: Wed Jul 1 17:04:53 2020 +0800

[incubator-nuttx-apps] 01/04: make/import: move the binary install to the top Makefile

2020-07-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit aaa61346c932409918b3a5a094dd480d96619071 Author: chao.an AuthorDate: Tue Jun 30 21:20:29 2020 +0800

[incubator-nuttx-apps] 03/04: make/import: copy the exported buildin registers

2020-07-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit a5bae8b8eeae513f882076beeb26e8f48fb90538 Author: chao.an AuthorDate: Wed Jul 1 14:00:15 2020 +0800

[incubator-nuttx-apps] branch master updated (4e10b69 -> c723283)

2020-07-03 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from 4e10b69 example/helloxx: Remove EXAMPLES_HELLOXX_NOSTACKCONST new aaa6134 make/import: move t

[GitHub] [incubator-nuttx] btashton opened a new issue #1363: zipme.sh is removing required release files

2020-07-03 Thread GitBox
btashton opened a new issue #1363: URL: https://github.com/apache/incubator-nuttx/issues/1363 @liuguo09 noticed this issue with the 9.1.0 RC1 release tarball. We are removing important files like the rcS initd file from the sim:nsh build. When I ran a diff against the tarball and the git

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #1355: vfs: Make the filesystem query API confirm POSIX standard

2020-07-03 Thread GitBox
yamt commented on a change in pull request #1355: URL: https://github.com/apache/incubator-nuttx/pull/1355#discussion_r449730036 ## File path: arch/sim/src/sim/up_hostfs.c ## @@ -432,32 +432,35 @@ int host_closedir(void *dirp) } /

[GitHub] [incubator-nuttx] yamt merged pull request #1321: libc: Refine the inline handling

2020-07-03 Thread GitBox
yamt merged pull request #1321: URL: https://github.com/apache/incubator-nuttx/pull/1321 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-nuttx] branch master updated: libc: Refine the inline handling

2020-07-03 Thread yamamoto
This is an automated email from the ASF dual-hosted git repository. yamamoto pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 60fe0a0 libc: Refine the inline hand

[GitHub] [incubator-nuttx] yamt commented on pull request #1342: sim: CMODULEFLAGS fixes for Linux

2020-07-03 Thread GitBox
yamt commented on pull request #1342: URL: https://github.com/apache/incubator-nuttx/pull/1342#issuecomment-653708269 @liuguo09 https://github.com/apache/incubator-nuttx/pull/1362 This is an automated message from the Apache

[GitHub] [incubator-nuttx] yamt opened a new pull request #1362: sim: Fix 32-bit module build

2020-07-03 Thread GitBox
yamt opened a new pull request #1362: URL: https://github.com/apache/incubator-nuttx/pull/1362 ## Summary Specify -mcmodel=large only on 64-bit case. (x86-64) The code model is not available for 32-bit. This fixes the following error: MODULECC: chardev.c cc1: e

[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1349: script to check NuttX release candidates (SHA512, GPG sigs, required files)

2020-07-03 Thread GitBox
adamfeuer commented on pull request #1349: URL: https://github.com/apache/incubator-nuttx/pull/1349#issuecomment-653706064 @Ouss4 Thanks for catching the license header thing– I'll fix it tomorrow, I don't have time tonight. I'll also add APL 2.0 headers to my checklist of things to do bef

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #1359: Many IOCTL handlers do not validate the address of their argument

2020-07-03 Thread GitBox
patacongo edited a comment on issue #1359: URL: https://github.com/apache/incubator-nuttx/issues/1359#issuecomment-653672158 > > > Ah, it is indeed. My apologies. I did not review the existing list of issues before filing this one. Yes, it is the same root issue: This PR sp

[GitHub] [incubator-nuttx] patacongo commented on issue #1359: Many IOCTL handlers do not validate the address of their argument

2020-07-03 Thread GitBox
patacongo commented on issue #1359: URL: https://github.com/apache/incubator-nuttx/issues/1359#issuecomment-653672158 > > > Ah, it is indeed. My apologies. I did not review the existing list of issues before filing this one. Yes, it is the same root issues: This PR specific

[GitHub] [incubator-nuttx] jeremyncc commented on issue #1359: Many IOCTL handlers do not validate the address of their argument

2020-07-03 Thread GitBox
jeremyncc commented on issue #1359: URL: https://github.com/apache/incubator-nuttx/issues/1359#issuecomment-653669811 Ah, it is indeed. My apologies. I did not review the existing list of issues before filing this one. This

[GitHub] [incubator-nuttx] antmerlino opened a new pull request #1361: pthread: Adds typedef pthread_trampoline_t and fixes other build errors.

2020-07-03 Thread GitBox
antmerlino opened a new pull request #1361: URL: https://github.com/apache/incubator-nuttx/pull/1361 ## Summary Fixes build errors introduced in draft code. ## Impact ## Testing This is an automated messa

[GitHub] [incubator-nuttx] patacongo commented on issue #1359: Many IOCTL handlers do not validate the address of their argument

2020-07-03 Thread GitBox
patacongo commented on issue #1359: URL: https://github.com/apache/incubator-nuttx/issues/1359#issuecomment-653665637 This is pretty similar to Issue #1329 This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-nuttx] patacongo commented on issue #1329: System calls require address checks

2020-07-03 Thread GitBox
patacongo commented on issue #1329: URL: https://github.com/apache/incubator-nuttx/issues/1329#issuecomment-653665705 Related to Issue #1359 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-nuttx] jeremyncc opened a new issue #1360: Arguments passed to IOCTL handlers may be vulnerable to time-of-check-time-of-use race conditions

2020-07-03 Thread GitBox
jeremyncc opened a new issue #1360: URL: https://github.com/apache/incubator-nuttx/issues/1360 ### Location: https://github.com/apache/incubator-nuttx/blob/master/drivers/mtd/smart.c#L4931 ### Impact: In architectures that support multi-processing, a malicious user spa

[GitHub] [incubator-nuttx] jeremyncc opened a new issue #1359: Many IOCTL handlers do not validate the address of their argument

2020-07-03 Thread GitBox
jeremyncc opened a new issue #1359: URL: https://github.com/apache/incubator-nuttx/issues/1359 ### Location: https://github.com/apache/incubator-nuttx/blob/master/drivers/mtd/smart.c#L5552 ### Impact: A malicious user space application can corrupt kernel memory by pass

[GitHub] [incubator-nuttx] jeremyncc opened a new issue #1358: NuttX kernel syscall dispatcher does not validate the syscall ID

2020-07-03 Thread GitBox
jeremyncc opened a new issue #1358: URL: https://github.com/apache/incubator-nuttx/issues/1358 ### Location: https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/armv7-m/arm_svcall.c#L81 ### Impact: In the NuttX kernel, syscall numbers are not properly v

[GitHub] [incubator-nuttx] patacongo commented on pull request #1328: pthread_cleanup functions must be called from user space

2020-07-03 Thread GitBox
patacongo commented on pull request #1328: URL: https://github.com/apache/incubator-nuttx/pull/1328#issuecomment-653646516 @antmerlino The branch is ready for your use: https://github.com/apache/incubator-nuttx/tree/feature/pthread-user We need to thank @Ouss4 for doing that for us. --

[incubator-nuttx] 01/02: pthread_cleanup functions must be called from user space

2020-07-03 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch feature/pthread-user in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit ead6090e78cdadb517a73a09b76fc64d8fcb09d7 Author: Gregory Nutt AuthorDate: Mon Jun 29 08:26:2

[incubator-nuttx] branch feature/pthread-user updated (993591d -> be0ff4d)

2020-07-03 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch feature/pthread-user in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 993591d arch/x86_64: Fix Warning: ignoring changed section attributes new ead6090

[incubator-nuttx] 02/02: Correct/Improve some comments

2020-07-03 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch feature/pthread-user in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit be0ff4dfe3c96c98a9b946b3c61b370be149e5bb Author: Gustavo Henrique Nihei <38959758+ghn-ce...@u

[GitHub] [incubator-nuttx] Ouss4 merged pull request #1328: [DRAFT] pthread_cleanup functions must be called from user space

2020-07-03 Thread GitBox
Ouss4 merged pull request #1328: URL: https://github.com/apache/incubator-nuttx/pull/1328 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-nuttx] branch feature/pthread-user created (now 993591d)

2020-07-03 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch feature/pthread-user in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at 993591d arch/x86_64: Fix Warning: ignoring changed section attributes No new revisions

[incubator-nuttx] branch pthread-user created (now 993591d)

2020-07-03 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch pthread-user in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at 993591d arch/x86_64: Fix Warning: ignoring changed section attributes No new revisions were add

[GitHub] [incubator-nuttx] Ouss4 edited a comment on issue #1356: drivers: mtd: align spi and qspi

2020-07-03 Thread GitBox
Ouss4 edited a comment on issue #1356: URL: https://github.com/apache/incubator-nuttx/issues/1356#issuecomment-653633067 > That's pretty much the same way how these kind of things are implemented in Linux kernel. This is also used in many drivers in NuttX, where usually the board lo

[GitHub] [incubator-nuttx] Ouss4 edited a comment on issue #1356: drivers: mtd: align spi and qspi

2020-07-03 Thread GitBox
Ouss4 edited a comment on issue #1356: URL: https://github.com/apache/incubator-nuttx/issues/1356#issuecomment-653633067 > That's pretty much the same way how these kind of things are implemented in Linux kernel. This is also used in many drivers in NuttX, where usually the board lo

[GitHub] [incubator-nuttx] Ouss4 commented on issue #1356: drivers: mtd: align spi and qspi

2020-07-03 Thread GitBox
Ouss4 commented on issue #1356: URL: https://github.com/apache/incubator-nuttx/issues/1356#issuecomment-653633067 > That's pretty much the same way how these kind of things are implemented in Linux kernel. This is also used in many drivers in NuttX, where usually the board logic pr

[GitHub] [incubator-nuttx] lukegluke opened a new pull request #1357: libs/libc/semaphore/sem_getvalue: correct get_value descriptions

2020-07-03 Thread GitBox
lukegluke opened a new pull request #1357: URL: https://github.com/apache/incubator-nuttx/pull/1357 avoid possible confusion and follow the description POSIX.1-2017 https://pubs.opengroup.org/onlinepubs/9699919799/functions/sem_getvalue.html PR as we discuss in #1354

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #325: Change all statfs to statvfs

2020-07-03 Thread GitBox
xiaoxiang781216 opened a new pull request #325: URL: https://github.com/apache/incubator-nuttx-apps/pull/325 ## Summary follow up the kernel side change ## Impact ## Testing This is an automated messa

[GitHub] [incubator-nuttx] patacongo commented on issue #1354: Bug in can driver: wrong use of nxsem_get_value

2020-07-03 Thread GitBox
patacongo commented on issue #1354: URL: https://github.com/apache/incubator-nuttx/issues/1354#issuecomment-653572428 > The DEBUGASSERT to cd_nrxwaiters < 255 is there to guarantee we will have less than 255 threads reading the data. There is no particular limit. But cs_nrxwaiters

[GitHub] [incubator-nuttx] dieselburner opened a new issue #1356: drivers: mtd: align spi and qspi

2020-07-03 Thread GitBox
dieselburner opened a new issue #1356: URL: https://github.com/apache/incubator-nuttx/issues/1356 **Issue:** Currently there's a misalignment in MTD drivers, where some drivers are written exclusively for QSPI interfaces, while others are using standard SPI. As you know, (nearly?) a

[GitHub] [incubator-nuttx] acassis commented on issue #1354: Bug in can driver: wrong use of nxsem_get_value

2020-07-03 Thread GitBox
acassis commented on issue #1354: URL: https://github.com/apache/incubator-nuttx/issues/1354#issuecomment-653553094 Damn it, so we still limited, because you are right again! This DEBUGASSERT is a case where it will not protect us in the wild. Should be replaced with ASSERT. -

[GitHub] [incubator-nuttx] acassis edited a comment on issue #1354: Bug in can driver: wrong use of nxsem_get_value

2020-07-03 Thread GitBox
acassis edited a comment on issue #1354: URL: https://github.com/apache/incubator-nuttx/issues/1354#issuecomment-653530715 Hi Olev, Yes, you are right: https://pubs.opengroup.org/onlinepubs/9699919799/functions/sem_getvalue.html Please submit a patch to fix the text. The DEBUG

[GitHub] [incubator-nuttx] lukegluke commented on issue #1354: Bug in can driver: wrong use of nxsem_get_value

2020-07-03 Thread GitBox
lukegluke commented on issue #1354: URL: https://github.com/apache/incubator-nuttx/issues/1354#issuecomment-653547987 > Yes, you are right: https://pubs.opengroup.org/onlinepubs/9699919799/functions/sem_getvalue.html If thoughts converge then they are limited :) > The DEBUGAS

[GitHub] [incubator-nuttx] acassis edited a comment on issue #1354: Bug in can driver: wrong use of nxsem_get_value

2020-07-03 Thread GitBox
acassis edited a comment on issue #1354: URL: https://github.com/apache/incubator-nuttx/issues/1354#issuecomment-653530715 Hi Olev, Yes, you are right: https://pubs.opengroup.org/onlinepubs/9699919799/functions/sem_getvalue.html Please submit a patch to fix the text. The DEBUG

[GitHub] [incubator-nuttx] acassis commented on issue #1354: Bug in can driver: wrong use of nxsem_get_value

2020-07-03 Thread GitBox
acassis commented on issue #1354: URL: https://github.com/apache/incubator-nuttx/issues/1354#issuecomment-653530715 Hi Olev, Yes, you are right: https://pubs.opengroup.org/onlinepubs/9699919799/functions/sem_getvalue.html Please submit a patch to fix the text. The DEBUGASSERT

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1349: script to check NuttX release candidates (SHA512, GPG sigs, required files)

2020-07-03 Thread GitBox
Ouss4 commented on pull request #1349: URL: https://github.com/apache/incubator-nuttx/pull/1349#issuecomment-653486497 The license needs to be ALv2. Here is the ASF header: https://github.com/apache/incubator-nuttx/blob/993591dca14a822b48be44513fa01d7ad10e0c61/sched/sched/sched_getcpu.c#L2

[incubator-nuttx] branch master updated (deb3b13 -> 993591d)

2020-07-03 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from deb3b13 Udate TODO List add 993591d arch/x86_64: Fix Warning: ignoring changed section attribute

[GitHub] [incubator-nuttx] Ouss4 merged pull request #1351: arch/x86_64: Fix Warning: ignoring changed section attributes

2020-07-03 Thread GitBox
Ouss4 merged pull request #1351: URL: https://github.com/apache/incubator-nuttx/pull/1351 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] lukegluke commented on issue #1354: Bug in can driver: wrong use of nxsem_get_value

2020-07-03 Thread GitBox
lukegluke commented on issue #1354: URL: https://github.com/apache/incubator-nuttx/issues/1354#issuecomment-653444362 Other questions about can driver: 1. For what purpose is cd_nrxwaiters? In fact it used only for debug asserts https://github.com/apache/incubator-nuttx/blob/57bc329a

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1355: vfs: Make the filesystem query API confirm POSIX standard

2020-07-03 Thread GitBox
xiaoxiang781216 opened a new pull request #1355: URL: https://github.com/apache/incubator-nuttx/pull/1355 ## Summary specified here: https://pubs.opengroup.org/onlinepubs/009695399/basedefs/sys/statvfs.h.html ## Impact No, just change the struct and function name ## Te