lukegluke commented on issue #1354:
URL: 
https://github.com/apache/incubator-nuttx/issues/1354#issuecomment-653547987


   > Yes, you are right: 
https://pubs.opengroup.org/onlinepubs/9699919799/functions/sem_getvalue.html
   
   If thoughts converge then they are limited :)
   
   > The DEBUGASSERT to cd_nrxwaiters < 255 is there to guarantee we will have 
less than 255 threads reading the data.
   
   I fully understand this. I just meant that if we are not debugging, 
cd_nrxwaiters modifications are done in vain.
   
   > When the can_poll() receives a signal it will return in the same as it 
returns when you get data
   
   In serial driver, uart_takesem can check returned value on EINTR, but it's 
still not used in uart_poll also with same awkward comment. But I'm not good in 
semaphores and poll processes, maybe it's all right and it works as should.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to