[MariaDB commits] Re: Review of MDL scalability regression after backup locks

2025-04-14 Thread Michael Widenius via commits
Hi! On Mon, Apr 14, 2025 at 9:51 AM Marko Mäkelä wrote: > > Hi Monty, > > Thank you for the review. I will revise > https://github.com/MariaDB/server/pull/3966/ accordingly. > > When it comes to the C++11 noexcept keyword, I believe that there was > a reason why -fno-exceptions was included in al

[MariaDB commits] Re: Review of MDL scalability regression after backup locks

2025-04-14 Thread Vladislav Vaintroub via commits
These -fno-exception thing is per-file setting, or can be made a per-target cmake setting. If one target, rocksdb must compile with -fexceptions, there is no reason for anything else to compile with it. Or connect, I think it is also using exceptions. Or this single file in tpool, which only ca