Hi! On Mon, Apr 14, 2025 at 9:51 AM Marko Mäkelä <marko.mak...@mariadb.com> wrote: > > Hi Monty, > > Thank you for the review. I will revise > https://github.com/MariaDB/server/pull/3966/ accordingly. > > When it comes to the C++11 noexcept keyword, I believe that there was > a reason why -fno-exceptions was included in all the applicable build > scripts in the very first public revision of MySQL ...
Note that I am not against adding noexcept keyword to functions. I just not want to do this in one only place and as part of working on something completely different. We should consider adding noexcept to functions in a separate commit or alternately go back to using --fno-exceptions and fix wsrep-lib and tpool_generic.cc to not use exceptions. The only other software that we have that is using exceptions is rocksdb. For builds with rocksdb we could enable exceptions. I think it would be preferably to fix the few cases we have that uses exceptions instead of having to add noexpect to EVERY other functions in MariaDB. Regards, Monty _______________________________________________ commits mailing list -- commits@lists.mariadb.org To unsubscribe send an email to commits-le...@lists.mariadb.org
