[GitHub] [inlong] healchow commented on a diff in pull request #8201: [INLONG-8200][Manager] Add tenant permission filter

2023-06-09 Thread via GitHub
healchow commented on code in PR #8201: URL: https://github.com/apache/inlong/pull/8201#discussion_r1223924151 ## inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/InlongUserRoleEntityMapper.java: ## @@ -30,6 +30,8 @@ public interface InlongUserRoleEn

[GitHub] [inlong] fuweng11 commented on a diff in pull request #8203: [INLONG-8202][Manager] Extract public parseFormat method to optimize NodeProvider

2023-06-09 Thread via GitHub
fuweng11 commented on code in PR #8203: URL: https://github.com/apache/inlong/pull/8203#discussion_r1223960767 ## inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/node/provider/KafkaProvider.java: ## @@ -113,11 +98,61 @@ public LoadNode createLoadNod

[GitHub] [inlong] chestnut-c commented on a diff in pull request #8203: [INLONG-8202][Manager] Extract public parseFormat method to optimize NodeProvider

2023-06-09 Thread via GitHub
chestnut-c commented on code in PR #8203: URL: https://github.com/apache/inlong/pull/8203#discussion_r1223964864 ## inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/node/provider/KafkaProvider.java: ## @@ -113,11 +98,61 @@ public LoadNode createLoadN

[GitHub] [inlong] chestnut-c commented on a diff in pull request #8203: [INLONG-8202][Manager] Extract public parseFormat method to optimize NodeProvider

2023-06-09 Thread via GitHub
chestnut-c commented on code in PR #8203: URL: https://github.com/apache/inlong/pull/8203#discussion_r1223973749 ## inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/node/provider/KafkaProvider.java: ## @@ -113,11 +98,61 @@ public LoadNode createLoadN

[GitHub] [inlong] bluewang opened a new pull request, #8205: [INLONG-8204][Dashboard] Support querying audit information by sink id

2023-06-09 Thread via GitHub
bluewang opened a new pull request, #8205: URL: https://github.com/apache/inlong/pull/8205 ### Prepare a Pull Request *(Change the title refer to the following example)* - Title Example: [INLONG-XYZ][Component] Title of the pull request *(The following *XYZ* should be replace

[GitHub] [inlong] Yizhou-Yang opened a new pull request, #8206: Kafka partition

2023-06-09 Thread via GitHub
Yizhou-Yang opened a new pull request, #8206: URL: https://github.com/apache/inlong/pull/8206 ### Prepare a Pull Request - Fixes #7900 ### Motivation See issue. ### Modifications Added PrimaryKeyPartitioner, and made modifications to support upsert-kafka ###

[GitHub] [inlong] Yizhou-Yang closed pull request #8206: Kafka partition

2023-06-09 Thread via GitHub
Yizhou-Yang closed pull request #8206: Kafka partition URL: https://github.com/apache/inlong/pull/8206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

[GitHub] [inlong] vernedeng commented on a diff in pull request #8201: [INLONG-8200][Manager] Add tenant permission filter

2023-06-09 Thread via GitHub
vernedeng commented on code in PR #8201: URL: https://github.com/apache/inlong/pull/8201#discussion_r1223990007 ## inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/InlongUserRoleEntityMapper.java: ## @@ -30,6 +30,8 @@ public interface InlongUserRoleE

[GitHub] [inlong] vernedeng commented on a diff in pull request #8201: [INLONG-8200][Manager] Add tenant permission filter

2023-06-09 Thread via GitHub
vernedeng commented on code in PR #8201: URL: https://github.com/apache/inlong/pull/8201#discussion_r1223990904 ## inlong-manager/manager-dao/src/main/resources/mappers/TenantUserRoleEntityMapper.xml: ## @@ -91,4 +90,13 @@ from tenant_user_role where id = #{id,

[GitHub] [inlong] Yizhou-Yang opened a new pull request, #8208: [INLONG-7900][Sort] Support partition by primary key when upsert single table of Kafka

2023-06-09 Thread via GitHub
Yizhou-Yang opened a new pull request, #8208: URL: https://github.com/apache/inlong/pull/8208 ### Prepare a Pull Request - Fixes #7900 ### Motivation See issue. ### Modifications Added PrimaryKeyPartitioner, and made modifications to support upsert-kafka ###

[GitHub] [inlong] vernedeng commented on a diff in pull request #8201: [INLONG-8200][Manager] Add tenant permission filter

2023-06-09 Thread via GitHub
vernedeng commented on code in PR #8201: URL: https://github.com/apache/inlong/pull/8201#discussion_r1224010747 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/tenant/InlongTenantServiceImpl.java: ## @@ -45,6 +45,9 @@ public class InlongTenantSe

[GitHub] [inlong] Yizhou-Yang closed pull request #8208: [INLONG-7900][Sort] Support partition by primary key when upsert single table of Kafka

2023-06-09 Thread via GitHub
Yizhou-Yang closed pull request #8208: [INLONG-7900][Sort] Support partition by primary key when upsert single table of Kafka URL: https://github.com/apache/inlong/pull/8208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [inlong] Yizhou-Yang opened a new pull request, #8209: [INLONG-7900][Sort] Support partition by primary key when upsert single table of Kafka

2023-06-09 Thread via GitHub
Yizhou-Yang opened a new pull request, #8209: URL: https://github.com/apache/inlong/pull/8209 ### Prepare a Pull Request - Fixes #7900 ### Motivation See issue. ### Modifications Added PrimaryKeyPartitioner, and made modifications to support upsert-kafka ###

[GitHub] [inlong] vernedeng commented on a diff in pull request #8201: [INLONG-8200][Manager] Add tenant permission filter

2023-06-09 Thread via GitHub
vernedeng commented on code in PR #8201: URL: https://github.com/apache/inlong/pull/8201#discussion_r1224023901 ## inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/auth/InlongShiroImpl.java: ## @@ -135,4 +156,17 @@ public AuthorizationAttributeSourceAdvisor

[GitHub] [inlong] vernedeng commented on a diff in pull request #8201: [INLONG-8200][Manager] Add tenant permission filter

2023-06-09 Thread via GitHub
vernedeng commented on code in PR #8201: URL: https://github.com/apache/inlong/pull/8201#discussion_r1224024951 ## inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/auth/tenant/TenantAuthenticatingFilter.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apac

[GitHub] [inlong] gong commented on a diff in pull request #8207: [INLONG-8199][Manager] Supports get brief information of inlong stream

2023-06-09 Thread via GitHub
gong commented on code in PR #8207: URL: https://github.com/apache/inlong/pull/8207#discussion_r1224078301 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/heartbeat/HeartbeatManager.java: ## @@ -231,7 +231,8 @@ private void evictClusterNode(Hear

[inlong] branch master updated: [INLONG-8202][Manager] Optimize Provider code to extract public parseFormat class. (#8203)

2023-06-09 Thread pacinogong
This is an automated email from the ASF dual-hosted git repository. pacinogong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/inlong.git The following commit(s) were added to refs/heads/master by this push: new 396a6a5a60 [INLONG-8202][Manager] Optimize P

[GitHub] [inlong] gong merged pull request #8203: [INLONG-8202][Manager] Extract public parseFormat method to optimize NodeProvider

2023-06-09 Thread via GitHub
gong merged PR #8203: URL: https://github.com/apache/inlong/pull/8203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.

[GitHub] [inlong] healchow commented on a diff in pull request #8207: [INLONG-8199][Manager] Supports get brief information of inlong stream

2023-06-09 Thread via GitHub
healchow commented on code in PR #8207: URL: https://github.com/apache/inlong/pull/8207#discussion_r1224113285 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/stream/InlongStreamServiceImpl.java: ## @@ -277,6 +277,32 @@ public InlongStreamInfo g

[GitHub] [inlong] healchow commented on a diff in pull request #8207: [INLONG-8199][Manager] Supports get brief information of inlong stream

2023-06-09 Thread via GitHub
healchow commented on code in PR #8207: URL: https://github.com/apache/inlong/pull/8207#discussion_r1224113686 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/stream/InlongStreamServiceImpl.java: ## @@ -277,6 +277,32 @@ public InlongStreamInfo g

[GitHub] [inlong] fuweng11 commented on a diff in pull request #8207: [INLONG-8199][Manager] Supports get brief information of inlong stream

2023-06-09 Thread via GitHub
fuweng11 commented on code in PR #8207: URL: https://github.com/apache/inlong/pull/8207#discussion_r1224115941 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/heartbeat/HeartbeatManager.java: ## @@ -231,7 +231,8 @@ private void evictClusterNode(

[GitHub] [inlong] fuweng11 commented on a diff in pull request #8207: [INLONG-8199][Manager] Supports get brief information of inlong stream

2023-06-09 Thread via GitHub
fuweng11 commented on code in PR #8207: URL: https://github.com/apache/inlong/pull/8207#discussion_r1224116119 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/stream/InlongStreamServiceImpl.java: ## @@ -277,6 +277,32 @@ public InlongStreamInfo g

[GitHub] [inlong] fuweng11 opened a new pull request, #8211: [INLONG-8210][Manager] Support configure expiration time of the compost heartbeat information

2023-06-09 Thread via GitHub
fuweng11 opened a new pull request, #8211: URL: https://github.com/apache/inlong/pull/8211 ### Prepare a Pull Request - Fixes #8210 ### Motivation Support configure expiration time of the compost heartbeat information. ### Modifications Support conf

[GitHub] [inlong] fuweng11 closed pull request #8211: [INLONG-8210][Manager] Support configure expiration time of the compost heartbeat information

2023-06-09 Thread via GitHub
fuweng11 closed pull request #8211: [INLONG-8210][Manager] Support configure expiration time of the compost heartbeat information URL: https://github.com/apache/inlong/pull/8211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [inlong] fuweng11 commented on a diff in pull request #8201: [INLONG-8200][Manager] Add tenant permission filter

2023-06-09 Thread via GitHub
fuweng11 commented on code in PR #8201: URL: https://github.com/apache/inlong/pull/8201#discussion_r1224051755 ## inlong-manager/manager-dao/src/main/resources/mappers/InlongTenantEntityMapper.xml: ## @@ -97,7 +97,6 @@ update inlong_tenant set description = #{desc

[GitHub] [inlong] fuweng11 commented on a diff in pull request #8201: [INLONG-8200][Manager] Add tenant permission filter

2023-06-09 Thread via GitHub
fuweng11 commented on code in PR #8201: URL: https://github.com/apache/inlong/pull/8201#discussion_r1224148463 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/user/UserServiceImpl.java: ## @@ -167,15 +167,15 @@ public UserInfo getById(Integer us

[GitHub] [inlong] fuweng11 commented on a diff in pull request #8201: [INLONG-8200][Manager] Add tenant permission filter

2023-06-09 Thread via GitHub
fuweng11 commented on code in PR #8201: URL: https://github.com/apache/inlong/pull/8201#discussion_r1224150325 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/user/UserServiceImpl.java: ## @@ -167,15 +167,15 @@ public UserInfo getById(Integer us

[GitHub] [inlong] vernedeng commented on a diff in pull request #8201: [INLONG-8200][Manager] Add tenant permission filter

2023-06-09 Thread via GitHub
vernedeng commented on code in PR #8201: URL: https://github.com/apache/inlong/pull/8201#discussion_r1224152100 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/user/UserServiceImpl.java: ## @@ -167,15 +167,15 @@ public UserInfo getById(Integer u

[GitHub] [inlong] vernedeng commented on a diff in pull request #8201: [INLONG-8200][Manager] Add tenant permission filter

2023-06-09 Thread via GitHub
vernedeng commented on code in PR #8201: URL: https://github.com/apache/inlong/pull/8201#discussion_r1224165885 ## inlong-manager/manager-dao/src/main/resources/mappers/InlongTenantEntityMapper.xml: ## @@ -97,7 +97,6 @@ update inlong_tenant set description = #{des

[GitHub] [inlong] fuweng11 commented on a diff in pull request #8201: [INLONG-8200][Manager] Add tenant permission filter

2023-06-09 Thread via GitHub
fuweng11 commented on code in PR #8201: URL: https://github.com/apache/inlong/pull/8201#discussion_r1224226010 ## inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongTenantController.java: ## @@ -50,7 +50,7 @@ public class InlongTenantControll

[GitHub] [inlong] fuweng11 commented on a diff in pull request #8201: [INLONG-8200][Manager] Add tenant permission filter

2023-06-09 Thread via GitHub
fuweng11 commented on code in PR #8201: URL: https://github.com/apache/inlong/pull/8201#discussion_r1224226010 ## inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongTenantController.java: ## @@ -50,7 +50,7 @@ public class InlongTenantControll