[GitHub] [inlong] chestnut-c commented on a diff in pull request #8203: [INLONG-8202][Manager] Extract public parseFormat method to optimize NodeProvider

[via GitHub]

chestnut-c commented on code in PR #8203:
URL: https://github.com/apache/inlong/pull/8203#discussion_r1223973749


##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/node/provider/KafkaProvider.java:
##########
@@ -113,11 +98,61 @@ public LoadNode createLoadNode(StreamNode nodeInfo, 
Map<String, StreamField> con
         Map<String, String> properties = 
parseProperties(kafkaSink.getProperties());
         List<FieldInfo> fieldInfos = 
parseSinkFieldInfos(kafkaSink.getSinkFieldList(), kafkaSink.getSinkName());
         List<FieldRelation> fieldRelations = 
parseSinkFields(kafkaSink.getSinkFieldList(), constantFieldMap);
-        Integer sinkParallelism = null;
-        if (StringUtils.isNotEmpty(kafkaSink.getPartitionNum())) {
-            sinkParallelism = Integer.parseInt(kafkaSink.getPartitionNum());
+
+        String partitionNum = kafkaSink.getPartitionNum();

Review Comment:
   > Integer
   
   
   partitionNum is defined as String in KafkaSink, theoretically it should be 
defined as Integer, next modification



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org