[GitHub] [inlong] fuweng11 commented on a diff in pull request #7390: [INLONG-7389][Manager][Sort] Add audit id info for source

2023-03-08 Thread via GitHub
fuweng11 commented on code in PR #7390: URL: https://github.com/apache/inlong/pull/7390#discussion_r1129099648 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/sort/DefaultSortConfigOperator.java: ## @@ -121,6 +124,15 @@ private GroupInf

[GitHub] [inlong] EMsnap opened a new pull request, #7552: [INLONG-7503][Sort] support multiple audit ids in source connectors

2023-03-08 Thread via GitHub
EMsnap opened a new pull request, #7552: URL: https://github.com/apache/inlong/pull/7552 - Fixes #7503 ### Motivation support multiple audit ids in source connectors We only support a constant audit id for source or sink in one group. However, one group can contain mult

[GitHub] [inlong] healchow commented on a diff in pull request #7552: [INLONG-7503][Sort] support multiple audit ids in pulsar source connector and introduce timestamped collector

2023-03-08 Thread via GitHub
healchow commented on code in PR #7552: URL: https://github.com/apache/inlong/pull/7552#discussion_r1129191212 ## inlong-sort/sort-formats/format-base/src/main/java/org/apache/inlong/sort/formats/base/collectors/TimeStampedCollector.java: ## @@ -0,0 +1,30 @@ +/* + * Licensed to

[GitHub] [inlong] healchow commented on a diff in pull request #7552: [INLONG-7503][Sort] support multiple audit ids in pulsar source connector and introduce timestamped collector

2023-03-08 Thread via GitHub
healchow commented on code in PR #7552: URL: https://github.com/apache/inlong/pull/7552#discussion_r1129191212 ## inlong-sort/sort-formats/format-base/src/main/java/org/apache/inlong/sort/formats/base/collectors/TimeStampedCollector.java: ## @@ -0,0 +1,30 @@ +/* + * Licensed to

[GitHub] [inlong] dockerzhang commented on a diff in pull request #7552: [INLONG-7503][Sort] Support multiple audit ids and introduce timestamp collector

2023-03-08 Thread via GitHub
dockerzhang commented on code in PR #7552: URL: https://github.com/apache/inlong/pull/7552#discussion_r1129231256 ## inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java: ## @@ -149,6 +148,12 @@ public final class Constants {

[GitHub] [inlong] dockerzhang merged pull request #7390: [INLONG-7389][Manager][Sort] Add audit id info for source

2023-03-08 Thread via GitHub
dockerzhang merged PR #7390: URL: https://github.com/apache/inlong/pull/7390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.

[inlong] branch master updated: [INLONG-7389][Manager][Sort] Add audit id info for source (#7390)

2023-03-08 Thread dockerzhang
This is an automated email from the ASF dual-hosted git repository. dockerzhang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/inlong.git The following commit(s) were added to refs/heads/master by this push: new 0e2fa1f9b [INLONG-7389][Manager][Sort] Add

[GitHub] [inlong] gong commented on a diff in pull request #7549: [INLONG-7548][Agent][Manager] Use try-with-resource to close resources

2023-03-08 Thread via GitHub
gong commented on code in PR #7549: URL: https://github.com/apache/inlong/pull/7549#discussion_r1129401143 ## inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/PostgresDialect.java: ## @@ -165,8 +165,9 @@ public List unsupportedTypes() { @Ov

[GitHub] [inlong] gong commented on a diff in pull request #7549: [INLONG-7548][Agent][Manager] Use try-with-resource to close resources

2023-03-08 Thread via GitHub
gong commented on code in PR #7549: URL: https://github.com/apache/inlong/pull/7549#discussion_r1129400873 ## inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/MySQLDialect.java: ## @@ -156,9 +156,10 @@ public List unsupportedTypes() { @Ov

[GitHub] [inlong] TYzzt commented on a diff in pull request #7549: [INLONG-7548][Agent][Manager] Use try-with-resource to close resources

2023-03-08 Thread via GitHub
TYzzt commented on code in PR #7549: URL: https://github.com/apache/inlong/pull/7549#discussion_r1129482377 ## inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/PostgresDialect.java: ## @@ -165,8 +165,9 @@ public List unsupportedTypes() { @O

[GitHub] [inlong] EMsnap commented on a diff in pull request #7552: [INLONG-7503][Sort] Support multiple audit ids and introduce timestamp collector

2023-03-08 Thread via GitHub
EMsnap commented on code in PR #7552: URL: https://github.com/apache/inlong/pull/7552#discussion_r1130303038 ## inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java: ## @@ -149,6 +148,12 @@ public final class Constants {

[GitHub] [inlong] fuweng11 opened a new pull request, #7556: [INLONG-7555][Manager] Fix the ttl time is invalid in clickhouse

2023-03-08 Thread via GitHub
fuweng11 opened a new pull request, #7556: URL: https://github.com/apache/inlong/pull/7556 ### Prepare a Pull Request - Fixes #7555 ### Motivation Fix the ttl time is invalid in clickhouse. ### Modifications Fix the ttl time is invalid in clickhouse