[GitHub] [inlong] TYzzt commented on a diff in pull request #7549: [INLONG-7548][Agent][Manager] Use try-with-resource to close resources

[via GitHub]

TYzzt commented on code in PR #7549:
URL: https://github.com/apache/inlong/pull/7549#discussion_r1129482377


##########
inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/PostgresDialect.java:
##########
@@ -165,8 +165,9 @@ public List<LogicalTypeRoot> unsupportedTypes() {
     @Override
     public PreparedStatement setQueryPrimaryKeySql(Connection conn,
             String tableIdentifier) throws SQLException {
-        PreparedStatement st = conn.prepareStatement(QUERY_PRIMARY_KEY_SQL);
-        st.setString(1, 
JdbcMultiBatchingComm.getTableNameFromIdentifier(tableIdentifier));
-        return st;
+        try (PreparedStatement st = 
conn.prepareStatement(QUERY_PRIMARY_KEY_SQL)) {
+            st.setString(1, 
JdbcMultiBatchingComm.getTableNameFromIdentifier(tableIdentifier));
+            return st;
+        }
     }

Review Comment:
   restored



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org