[I] [Improvement] Docker version [gravitino]

2025-02-20 Thread via GitHub
youngyjd opened a new issue, #6491: URL: https://github.com/apache/gravitino/issues/6491 ### What would you like to be improved? 1. List what docker versions are required to run the integration tests. 2. Support Docker version < 20.10+ if possible. Our CI runs Docker version 19.03.

Re: [I] [Improvement] support different Docker versions for integration tests [gravitino]

2025-02-20 Thread via GitHub
youngyjd commented on issue #6491: URL: https://github.com/apache/gravitino/issues/6491#issuecomment-2672916961 Seems there is a potential solution for older version Docker? https://github.com/docker/cli/issues/2664 -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [#6486] feat(iceberg): supports change Iceberg request in pre event listener [gravitino]

2025-02-20 Thread via GitHub
FANNG1 commented on code in PR #6485: URL: https://github.com/apache/gravitino/pull/6485#discussion_r1964588161 ## iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/listener/api/event/IcebergCreateTablePreEvent.java: ## @@ -42,6 +43,10 @@ public OperationType operat

Re: [PR] [#5873] feat(gvfs-fuse): add debug log for FuseApiHandle [gravitino]

2025-02-20 Thread via GitHub
diqiu50 commented on PR #5905: URL: https://github.com/apache/gravitino/pull/5905#issuecomment-2673201367 > * nable max_level = IINFO for all crates and modules We don’t need to enable logging for all crates, as that might result in an overwhelming amount of logs. Typically, logs from

Re: [PR] [#5873] feat(gvfs-fuse): add debug log for FuseApiHandle [gravitino]

2025-02-20 Thread via GitHub
diqiu50 commented on code in PR #5905: URL: https://github.com/apache/gravitino/pull/5905#discussion_r1964983024 ## clients/filesystem-fuse/src/fuse_api_handle_debug.rs: ## @@ -0,0 +1,871 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] [#5873] feat(gvfs-fuse): add debug log for FuseApiHandle [gravitino]

2025-02-20 Thread via GitHub
diqiu50 commented on code in PR #5905: URL: https://github.com/apache/gravitino/pull/5905#discussion_r1964983024 ## clients/filesystem-fuse/src/fuse_api_handle_debug.rs: ## @@ -0,0 +1,871 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] [#5873] feat(gvfs-fuse): add debug log for FuseApiHandle [gravitino]

2025-02-20 Thread via GitHub
diqiu50 commented on code in PR #5905: URL: https://github.com/apache/gravitino/pull/5905#discussion_r1964988320 ## clients/filesystem-fuse/src/fuse_api_handle_debug.rs: ## @@ -0,0 +1,871 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] [#6481] improve(CLI): Refactor table output format [gravitino]

2025-02-20 Thread via GitHub
Abyss-lord commented on PR #6483: URL: https://github.com/apache/gravitino/pull/6483#issuecomment-2673561869 @justinmclean should we add table, schema list\detail command Table output in this pr? or create a new one? -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [#6475] improvement: Disable the ryuk [gravitino]

2025-02-20 Thread via GitHub
jerqi closed pull request #6480: [#6475] improvement: Disable the ryuk URL: https://github.com/apache/gravitino/pull/6480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [#6475] improvement: Disable the ryuk [gravitino]

2025-02-20 Thread via GitHub
jerqi commented on PR #6480: URL: https://github.com/apache/gravitino/pull/6480#issuecomment-2673266352 I have added the comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [I] [Improvement] `TestChainedAuthorizationIT` missing annotation `@Tag("gravitino-docker-test")` [gravitino]

2025-02-20 Thread via GitHub
jerryshao closed issue #6484: [Improvement] `TestChainedAuthorizationIT` missing annotation `@Tag("gravitino-docker-test")` URL: https://github.com/apache/gravitino/issues/6484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] [Improvement] `TestChainedAuthorizationIT` missing annotation `@Tag("gravitino-docker-test")` [gravitino]

2025-02-20 Thread via GitHub
jerryshao closed issue #6484: [Improvement] `TestChainedAuthorizationIT` missing annotation `@Tag("gravitino-docker-test")` URL: https://github.com/apache/gravitino/issues/6484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

(gravitino) branch main updated (e8d06f4c18 -> 02a20b7536)

2025-02-20 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git from e8d06f4c18 [#6404] feat (gvfs-fuse): Add Readme document of gvfs-fuse (#6405) add 02a20b7536 Added @Tag("graviti

Re: [PR] Added @Tag("gravitino-docker-test") to TestChainedAuthorizationIT #6484 [gravitino]

2025-02-20 Thread via GitHub
jerryshao merged PR #6489: URL: https://github.com/apache/gravitino/pull/6489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] Added @Tag("gravitino-docker-test") to TestChainedAuthorizationIT #6484 [gravitino]

2025-02-20 Thread via GitHub
jerryshao closed pull request #6492: Added @Tag("gravitino-docker-test") to TestChainedAuthorizationIT #6484 URL: https://github.com/apache/gravitino/pull/6492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] Added @Tag("gravitino-docker-test") to TestChainedAuthorizationIT #6484 [gravitino]

2025-02-20 Thread via GitHub
github-actions[bot] opened a new pull request, #6492: URL: https://github.com/apache/gravitino/pull/6492 ### What changes were proposed in this pull request? - Added `@Tag("gravitino-docker-test")` to `TestChainedAuthorizationIT` ### Why are the changes needed? - The test

(gravitino) branch cherry-pick-branch-0.8-02a20b75369034476f3c1de05d65d6acc60c2c28 created (now 1b51a7e848)

2025-02-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch cherry-pick-branch-0.8-02a20b75369034476f3c1de05d65d6acc60c2c28 in repository https://gitbox.apache.org/repos/asf/gravitino.git at 1b51a7e848 Added @Tag("gravitino-docker-test") to Te

Re: [PR] [#6487] improvement(hadoop-catalog): Close FileSystem instance manually. [gravitino]

2025-02-20 Thread via GitHub
jerryshao commented on PR #6488: URL: https://github.com/apache/gravitino/pull/6488#issuecomment-2673179349 My concern is that creating and closing the fs each time will introduce unnecessary overheads. I remembered that 1: Hadoop FS has cache mechanism. 2: If we don't leverage Hadoop's cac

Re: [PR] [#6475] improvement: Disable the ryuk [gravitino]

2025-02-20 Thread via GitHub
jerryshao commented on PR #6480: URL: https://github.com/apache/gravitino/pull/6480#issuecomment-2673181954 I agree with @tengqm that we should add comments to explain why do we need to add this configuration. -- This is an automated message from the Apache Git Service. To respond to the