FANNG1 commented on code in PR #6485:
URL: https://github.com/apache/gravitino/pull/6485#discussion_r1964588161


##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/listener/api/event/IcebergCreateTablePreEvent.java:
##########
@@ -42,6 +43,10 @@ public OperationType operationType() {
   }
 
   public CreateTableRequest createTableRequest() {
-    return createTableRequest;
+    return createTableRequestWrapper.get();
+  }
+
+  public ObjectWrapper<CreateTableRequest> createTableRequestWrapper() {

Review Comment:
   There is no upcoming changes, it's the responsibility of end users to 
provide custom event listeners, like 
   ```java
     public void onPreEvent(PreEvent preEvent) {
       if (preEvent instanceof IcebergCreateTablePreEvent) {
         ObjectWrapper<CreateTableRequest> objectWrapper = 
((IcebergCreateTablePreEvent) preEvent).createTableRequestWrapper();
         CreateTableRequest originalRequest = objectWrapper.get();
         // create newRequest according to your business logic
         objectWrapper.set(newRequest);
       }
     }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to