Re: [PR] [#5873] feat(gvfs-fuse): add debug log for FuseApiHandle [gravitino]

2025-02-16 Thread via GitHub
diqiu50 commented on PR #5905: URL: https://github.com/apache/gravitino/pull/5905#issuecomment-2661837772 I hope we can control it through parameters. The log level configuration can be initialized through passed parameters. -- This is an automated message from the Apache Git Servic

Re: [PR] [#5746] improve(CLI): Support table format output for Audit command [gravitino]

2025-02-16 Thread via GitHub
tengqm commented on code in PR #6461: URL: https://github.com/apache/gravitino/pull/6461#discussion_r1957512935 ## clients/cli/src/main/java/org/apache/gravitino/cli/outputs/BaseOutputFormat.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[I] [Bug report] `HDFSFileSystemProvider` does not in the class path as filesystem-hadoop3 does not include `catalog-hadoop` [gravitino]

2025-02-16 Thread via GitHub
yuqi1129 opened a new issue, #6462: URL: https://github.com/apache/gravitino/issues/6462 ### Version main branch ### Describe what's wrong `HDFSFileSystemProvider` lies in the module `catalog-hadoop` and `filesystem-hadoop3` does not depend on the module, when users use

Re: [PR] [#6459]improve(test): Use implicit wait for time-based condition [gravitino]

2025-02-16 Thread via GitHub
tengqm commented on PR #6460: URL: https://github.com/apache/gravitino/pull/6460#issuecomment-2661845792 lgtm. Good job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] [Bug report] `HDFSFileSystemProvider` does not in the class path as filesystem-hadoop3 does not include `catalog-hadoop` [gravitino]

2025-02-16 Thread via GitHub
yuqi1129 commented on issue #6462: URL: https://github.com/apache/gravitino/issues/6462#issuecomment-2661845451 Currently, UTs and ITs seem to be unable to cover this problems and need test manually. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [#6404] feat (gvfs-fuse): Add Readme document of gvfs-fuse [gravitino]

2025-02-16 Thread via GitHub
FANNG1 commented on code in PR #6405: URL: https://github.com/apache/gravitino/pull/6405#discussion_r1957460234 ## clients/filesystem-fuse/README.md: ## @@ -0,0 +1,132 @@ + + +# Gvfs-fuse + +Gvfs-fuse is the Fuse client for Gravitino fileset. It allows users to mount Gravitino

Re: [PR] [#6404] feat (gvfs-fuse): Add Readme document of gvfs-fuse [gravitino]

2025-02-16 Thread via GitHub
FANNG1 commented on PR #6405: URL: https://github.com/apache/gravitino/pull/6405#issuecomment-2661718433 LGTM except one comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [Improvement] Enable setting of additional configuration parameters through environment variables [gravitino]

2025-02-16 Thread via GitHub
tengqm commented on PR #6458: URL: https://github.com/apache/gravitino/pull/6458#issuecomment-2661875386 I'm not sure if passing credentials via env variables is a good practice. It has some security flaws. A more secure way would be mount them via a volume. -- This is an automated messag

Re: [PR] Update Capability.java [gravitino]

2025-02-16 Thread via GitHub
tengqm commented on code in PR #6412: URL: https://github.com/apache/gravitino/pull/6412#discussion_r1957539218 ## core/src/main/java/org/apache/gravitino/connector/capability/Capability.java: ## @@ -126,18 +126,23 @@ public CapabilityResult caseSensitiveOnName(Scope scope) {

Re: [PR] Update Capability.java [gravitino]

2025-02-16 Thread via GitHub
tengqm commented on PR #6412: URL: https://github.com/apache/gravitino/pull/6412#issuecomment-2661890817 Please change the PR title to something more meaningful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [#6404] feat (gvfs-fuse): Add Readme document of gvfs-fuse [gravitino]

2025-02-16 Thread via GitHub
tengqm commented on code in PR #6405: URL: https://github.com/apache/gravitino/pull/6405#discussion_r1957541590 ## clients/filesystem-fuse/README.md: ## @@ -0,0 +1,135 @@ + + +# Gvfs-fuse + +Gvfs-fuse is the Fuse client for Gravitino fileset. It allows users to mount Gravitino

Re: [PR] [#6404] feat (gvfs-fuse): Add Readme document of gvfs-fuse [gravitino]

2025-02-16 Thread via GitHub
diqiu50 commented on code in PR #6405: URL: https://github.com/apache/gravitino/pull/6405#discussion_r1957547995 ## clients/filesystem-fuse/README.md: ## @@ -0,0 +1,135 @@ + + +# Gvfs-fuse + +Gvfs-fuse is the Fuse client for Gravitino fileset. It allows users to mount Gravitino

Re: [PR] [#6133] Improvement(core): Supports get Fileset schema location in the AuthorizationUtils [gravitino]

2025-02-16 Thread via GitHub
tengqm commented on code in PR #6211: URL: https://github.com/apache/gravitino/pull/6211#discussion_r1957549926 ## core/src/main/java/org/apache/gravitino/authorization/AuthorizationUtils.java: ## @@ -465,30 +471,72 @@ public static List getMetadataObjectLocation( }

Re: [PR] [#6330] chore: add BSD license to missing files [gravitino]

2025-02-16 Thread via GitHub
tengqm commented on code in PR #6355: URL: https://github.com/apache/gravitino/pull/6355#discussion_r1957547409 ## dev/docker/kerberos-hive/kdc.conf: ## @@ -1,4 +1,30 @@ -[kdcdefaults] +Copyright (C) 1985-2024 by the Massachusetts Institute of Technology. + +All rights reserved.

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-16 Thread via GitHub
tengqm commented on PR #6400: URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2661903201 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [#6404] feat (gvfs-fuse): Add Readme document of gvfs-fuse [gravitino]

2025-02-16 Thread via GitHub
diqiu50 commented on code in PR #6405: URL: https://github.com/apache/gravitino/pull/6405#discussion_r1957548268 ## clients/filesystem-fuse/README.md: ## @@ -0,0 +1,135 @@ + + +# Gvfs-fuse + +Gvfs-fuse is the Fuse client for Gravitino fileset. It allows users to mount Gravitino

Re: [PR] [#6330] chore: add BSD license to missing files [gravitino]

2025-02-16 Thread via GitHub
justinmclean commented on PR #6355: URL: https://github.com/apache/gravitino/pull/6355#issuecomment-2662113904 It doesn't have to be added to the file; you could, or better still, add a short comment like so "BSD licensed copyright (C) 1985-2024 by the Massachusetts Institute of Technology"

Re: [PR] [Improvement] Enable setting of additional configuration parameters through environment variables [gravitino]

2025-02-16 Thread via GitHub
jerryshao commented on PR #6458: URL: https://github.com/apache/gravitino/pull/6458#issuecomment-2662137917 @FANNG1 can you please help to review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[I] [Bug report] `gvfs-fuse` started with an error when using a configuration with a relative path. [gravitino]

2025-02-16 Thread via GitHub
diqiu50 opened a new issue, #6464: URL: https://github.com/apache/gravitino/issues/6464 ### Version main branch ### Describe what's wrong `gvfs-fuse` tools started with an error when using a configuration with a relative path. ### Error message and/or stacktrace

Re: [PR] [#6238] improvement(storage): Improve get role performance when roles is bound to many metadata. [gravitino]

2025-02-16 Thread via GitHub
yuqi1129 commented on PR #6455: URL: https://github.com/apache/gravitino/pull/6455#issuecomment-2662207063 > @yuqi1129 Do U have any other suggestion? No, it looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [#5873] feat(gvfs-fuse): add debug log for FuseApiHandle [gravitino]

2025-02-16 Thread via GitHub
unknowntpo commented on PR #5905: URL: https://github.com/apache/gravitino/pull/5905#issuecomment-2662250119 > I hope we can control it through parameters. The log level configuration can be initialized through passed parameters. Indeed, and I think we can use `-d` to set debug level:

[PR] [#6464] fix (gvfs-fuse): Fix the bug of using a relative path to configure gvfs-fuse. [gravitino]

2025-02-16 Thread via GitHub
diqiu50 opened a new pull request, #6465: URL: https://github.com/apache/gravitino/pull/6465 ### What changes were proposed in this pull request? Fix the bug of using a relative path to configure gvfs-fuse. ### Why are the changes needed? Fix: #6464 ### Does this P

Re: [PR] [#6238] improvement(storage): Improve get role performance when roles is bound to many metadata. [gravitino]

2025-02-16 Thread via GitHub
jerqi commented on PR #6455: URL: https://github.com/apache/gravitino/pull/6455#issuecomment-2662198117 @yuqi1129 Do U have any other suggestion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [#6404] feat (gvfs-fuse): Add Readme document of gvfs-fuse [gravitino]

2025-02-16 Thread via GitHub
diqiu50 commented on code in PR #6405: URL: https://github.com/apache/gravitino/pull/6405#discussion_r1957710926 ## clients/filesystem-fuse/conf/gvfs_fuse.toml: ## @@ -20,7 +20,7 @@ file_mask = 0o600 dir_mask = 0o700 fs_type = "memory" -data_path = "target/gvfs-fuse" +data_di

Re: [PR] [#6404] feat (gvfs-fuse): Add Readme document of gvfs-fuse [gravitino]

2025-02-16 Thread via GitHub
diqiu50 commented on code in PR #6405: URL: https://github.com/apache/gravitino/pull/6405#discussion_r1957717003 ## clients/filesystem-fuse/README.md: ## @@ -0,0 +1,135 @@ + + +# Gvfs-fuse + +Gvfs-fuse is the Fuse client for Gravitino fileset. It allows users to mount Gravitino

Re: [PR] [#6459]improve(test): Use implicit wait for time-based condition [gravitino]

2025-02-16 Thread via GitHub
jerryshao commented on PR #6460: URL: https://github.com/apache/gravitino/pull/6460#issuecomment-2662298791 @zzzk1 can you please fix the CI issue here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [#6462] fix(filesystem-hadoop3): Fix GVFS client can't find `HDFSFileSystemProvider` problem [gravitino]

2025-02-16 Thread via GitHub
yuqi1129 opened a new pull request, #6463: URL: https://github.com/apache/gravitino/pull/6463 ### What changes were proposed in this pull request? In the current code base, we need to add `catalog-hadoop` to make GVFS client works or class `HDFSFileSystemProvider` or `LocalFileSystemP