tengqm commented on code in PR #6412:
URL: https://github.com/apache/gravitino/pull/6412#discussion_r1957539218
##########
core/src/main/java/org/apache/gravitino/connector/capability/Capability.java:
##########
@@ -126,18 +126,23 @@ public CapabilityResult caseSensitiveOnName(Scope scope) {
}
@Override
- public CapabilityResult specificationOnName(Scope scope, String name) {
- if (RESERVED_WORDS.contains(name.toLowerCase())) {
- return CapabilityResult.unsupported(
- String.format("The %s name '%s' is reserved.", scope, name));
- }
-
- if (!name.matches(DEFAULT_NAME_PATTERN)) {
- return CapabilityResult.unsupported(
- String.format("The %s name '%s' is illegal.", scope, name));
- }
- return CapabilityResult.SUPPORTED;
- }
+public CapabilityResult specificationOnName(Scope scope, String name) {
+ if (RESERVED_WORDS.contains(name.toLowerCase())) {
+ return CapabilityResult.unsupported(
+ String.format("The %s name '%s' is reserved.", scope, name));
+ }
+
+ if (!name.matches(DEFAULT_NAME_PATTERN)) {
+ return CapabilityResult.unsupported(
+ String.format(
+ "The %s name '%s' is illegal. It must start with a letter, digit,
or underscore, "
+ + "and may contain letters, digits, underscores, slashes, hyphens,
or equals signs, "
+ + "with a maximum length of 64 characters.",
+ scope, name));
+ }
+ return CapabilityResult.SUPPORTED;
+}
Review Comment:
Please indent this method as we do for others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
