Re: [PR] [#6361] feat(paimon):Support specifying primary keys during create paimon table by flink [gravitino]

2025-02-12 Thread via GitHub
tengqm commented on PR #6362: URL: https://github.com/apache/gravitino/pull/6362#issuecomment-2653082160 No objections from me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [I] [Improvement] Refactor to add a command context to CLI [gravitino]

2025-02-12 Thread via GitHub
Abyss-lord commented on issue #6413: URL: https://github.com/apache/gravitino/issues/6413#issuecomment-2653067942 @justinmclean Should we go ahead and add Table format implementations for the details and list commands? -- This is an automated message from the Apache Git Service. To respon

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-12 Thread via GitHub
Pranaykarvi commented on PR #6400: URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2653646102 > @Pranaykarvi Hi, can you run prettier to fix formatting? @LauraXia123 done please could you check now? -- This is an automated message from the Apache Git Service. To resp

Re: [I] Refactor getURL in CLI [gravitino]

2025-02-12 Thread via GitHub
justinmclean closed issue #6424: Refactor getURL in CLI URL: https://github.com/apache/gravitino/issues/6424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

(gravitino) branch main updated: [#6424] improve(CLI): Refactor getURL in CLI and add context to simple commands. (#6440)

2025-02-12 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 4b5d6a5b0c [#6424] improve(CLI): Refactor getURL

Re: [I] Refactor getURL in CLI [gravitino]

2025-02-12 Thread via GitHub
justinmclean closed issue #6424: Refactor getURL in CLI URL: https://github.com/apache/gravitino/issues/6424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-12 Thread via GitHub
LauraXia123 commented on PR #6400: URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2653099665 @Pranaykarvi Hi, can you run prettier to fix formatting? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [#6424] improve(CLI): Refactor getURL in CLI and add context to simple commands. [gravitino]

2025-02-12 Thread via GitHub
justinmclean merged PR #6440: URL: https://github.com/apache/gravitino/pull/6440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

Re: [PR] [#5901] feat(core): support tag event to Gravitino server [gravitino]

2025-02-12 Thread via GitHub
TungYuChiang commented on code in PR #5998: URL: https://github.com/apache/gravitino/pull/5998#discussion_r1953681255 ## core/src/main/java/org/apache/gravitino/listener/api/event/AlterTagEvent.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

(gravitino) branch cherry-pick-branch-0.8-43480899938002406de04259b3e6ea8190dff1db created (now 678894a940)

2025-02-12 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch cherry-pick-branch-0.8-43480899938002406de04259b3e6ea8190dff1db in repository https://gitbox.apache.org/repos/asf/gravitino.git at 678894a940 [#6429] Fixed Wrong log format codes (#643

(gravitino) branch branch-0.8 updated: [#6429] Fixed Wrong log format codes (#6445)

2025-02-12 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch branch-0.8 in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/branch-0.8 by this push: new c4b3285d89 [#6429] Fixed Wrong log for

Re: [PR] [MINOR] docs: polish Iceberg REST server document [gravitino]

2025-02-12 Thread via GitHub
jerryshao merged PR #6444: URL: https://github.com/apache/gravitino/pull/6444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

(gravitino) branch main updated: [MINOR] docs: polish Iceberg REST server document (#6444)

2025-02-12 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new d1ec005064 [MINOR] docs: polish Iceberg REST serve

[PR] [MINOR] docs: polish Iceberg REST server document [gravitino]

2025-02-12 Thread via GitHub
github-actions[bot] opened a new pull request, #6446: URL: https://github.com/apache/gravitino/pull/6446 ### What changes were proposed in this pull request? multi catalog and view operation should shown in document side bars. ### Why are the changes needed? User could find m

(gravitino) branch main updated (d1ec005064 -> 794703f49f)

2025-02-12 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git from d1ec005064 [MINOR] docs: polish Iceberg REST server document (#6444) add 794703f49f [MINOR] improve(CLI): Remov

Re: [PR] [MINOR] improve(CLI): Remove redundant code in CLI [gravitino]

2025-02-12 Thread via GitHub
justinmclean merged PR #6443: URL: https://github.com/apache/gravitino/pull/6443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-12 Thread via GitHub
LauraXia123 commented on code in PR #6400: URL: https://github.com/apache/gravitino/pull/6400#discussion_r1953885797 ## web/web/src/lib/utils/regex.js: ## @@ -17,9 +17,9 @@ * under the License. */ -export const nameRegex = /^\w[\w]{0,63}$/ +export const nameRegex = /^[a-zA

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-12 Thread via GitHub
LauraXia123 commented on code in PR #6400: URL: https://github.com/apache/gravitino/pull/6400#discussion_r1953886369 ## web/web/src/lib/utils/regex.js: ## @@ -17,9 +17,9 @@ * under the License. */ -export const nameRegex = /^\w[\w]{0,63}$/ +export const nameRegex = /^[a-zA

Re: [I] [Improvement] Document of Hive on GCS isn't complete [gravitino]

2025-02-12 Thread via GitHub
jerqi closed issue #6373: [Improvement] Document of Hive on GCS isn't complete URL: https://github.com/apache/gravitino/issues/6373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [I] [Improvement] Document of Hive on GCS isn't complete [gravitino]

2025-02-12 Thread via GitHub
jerqi commented on issue #6373: URL: https://github.com/apache/gravitino/issues/6373#issuecomment-265562 Ok, we can close this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [#5901] feat(core): support tag event to Gravitino server [gravitino]

2025-02-12 Thread via GitHub
TungYuChiang commented on code in PR #5998: URL: https://github.com/apache/gravitino/pull/5998#discussion_r1953688276 ## core/src/main/java/org/apache/gravitino/listener/TagEventDispatcher.java: ## @@ -152,8 +186,11 @@ public MetadataObject[] listMetadataObjectsForTag(String me

Re: [PR] [#5901] feat(core): support tag event to Gravitino server [gravitino]

2025-02-12 Thread via GitHub
TungYuChiang commented on code in PR #5998: URL: https://github.com/apache/gravitino/pull/5998#discussion_r1953688276 ## core/src/main/java/org/apache/gravitino/listener/TagEventDispatcher.java: ## @@ -152,8 +186,11 @@ public MetadataObject[] listMetadataObjectsForTag(String me

Re: [PR] [#5901] feat(core): support tag event to Gravitino server [gravitino]

2025-02-12 Thread via GitHub
TungYuChiang commented on code in PR #5998: URL: https://github.com/apache/gravitino/pull/5998#discussion_r1953688276 ## core/src/main/java/org/apache/gravitino/listener/TagEventDispatcher.java: ## @@ -152,8 +186,11 @@ public MetadataObject[] listMetadataObjectsForTag(String me

Re: [PR] [#5901] feat(core): support tag event to Gravitino server [gravitino]

2025-02-12 Thread via GitHub
TungYuChiang commented on code in PR #5998: URL: https://github.com/apache/gravitino/pull/5998#discussion_r1953688276 ## core/src/main/java/org/apache/gravitino/listener/TagEventDispatcher.java: ## @@ -152,8 +186,11 @@ public MetadataObject[] listMetadataObjectsForTag(String me

Re: [PR] [#6429] Fixed Wrong log format codes [gravitino]

2025-02-12 Thread via GitHub
jerryshao merged PR #6445: URL: https://github.com/apache/gravitino/pull/6445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#6097] improve(CLI): Add --quiet option to the Gravitino CLI [gravitino]

2025-02-12 Thread via GitHub
Abyss-lord commented on PR #6447: URL: https://github.com/apache/gravitino/pull/6447#issuecomment-2655675690 @justinmclean could you please review this PR when you have time? I’d really appreciate your feedback. -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-12 Thread via GitHub
Pranaykarvi commented on PR #6400: URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2655699954 > @Pranaykarvi @LauraXia123 can you please check build error here? @jerryshao passed can u check now? -- This is an automated message from the Apache Git

Re: [PR] [#6078] feat(core): Support model event to Gravitino server [gravitino]

2025-02-12 Thread via GitHub
Abyss-lord commented on code in PR #6129: URL: https://github.com/apache/gravitino/pull/6129#discussion_r1953980508 ## core/src/main/java/org/apache/gravitino/listener/ModelEventDispatcher.java: ## @@ -0,0 +1,400 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [MINOR] docs: polish Iceberg REST server document [gravitino]

2025-02-12 Thread via GitHub
jerryshao closed pull request #6446: [MINOR] docs: polish Iceberg REST server document URL: https://github.com/apache/gravitino/pull/6446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(gravitino) branch cherry-pick-branch-0.8-d1ec00506448500f25382cbd92430c02f0369ab3 created (now 00ad8dda28)

2025-02-12 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch cherry-pick-branch-0.8-d1ec00506448500f25382cbd92430c02f0369ab3 in repository https://gitbox.apache.org/repos/asf/gravitino.git at 00ad8dda28 [MINOR] docs: polish Iceberg REST server d

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-12 Thread via GitHub
Pranaykarvi commented on PR #6400: URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2655452495 @jerryshao please could you check now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(gravitino) branch cherry-pick-branch-0.8-d1ec00506448500f25382cbd92430c02f0369ab3 deleted (was 00ad8dda28)

2025-02-12 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch cherry-pick-branch-0.8-d1ec00506448500f25382cbd92430c02f0369ab3 in repository https://gitbox.apache.org/repos/asf/gravitino.git was 00ad8dda28 [MINOR] docs: polish Iceberg REST server docume

Re: [PR] [MINOR] docs: polish Iceberg REST server document [gravitino]

2025-02-12 Thread via GitHub
jerryshao merged PR #6446: URL: https://github.com/apache/gravitino/pull/6446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

(gravitino) branch branch-0.8 updated: [MINOR] docs: polish Iceberg REST server document (#6446)

2025-02-12 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch branch-0.8 in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/branch-0.8 by this push: new e94f42954a [MINOR] docs: polish Iceber

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-12 Thread via GitHub
Pranaykarvi commented on code in PR #6400: URL: https://github.com/apache/gravitino/pull/6400#discussion_r1953846016 ## web/web/src/lib/utils/regex.js: ## @@ -17,9 +17,9 @@ * under the License. */ -export const nameRegex = /^\w[\w]{0,63}$/ +export const nameRegex = /^[a-zA

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-12 Thread via GitHub
jerryshao commented on PR #6400: URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2655254012 @Pranaykarvi @LauraXia123 can you please check build error here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[PR] [MINOR] improve(CLI): Remove redundant code in CLI [gravitino]

2025-02-12 Thread via GitHub
Abyss-lord opened a new pull request, #6443: URL: https://github.com/apache/gravitino/pull/6443 ### What changes were proposed in this pull request? Remove redundant code in CLI, and make context argument final in Command class. ### Why are the changes needed? The const

Re: [PR] [MINOR] improve(CLI): Remove redundant code in CLI [gravitino]

2025-02-12 Thread via GitHub
Abyss-lord commented on PR #6443: URL: https://github.com/apache/gravitino/pull/6443#issuecomment-2655262380 @justinmclean could you please review this PR when you have time? I’d really appreciate your feedback. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [HOTFIX] fix compile paimon error by broken maven version for net.minidev:json-smart [gravitino]

2025-02-12 Thread via GitHub
jerryshao commented on PR #6442: URL: https://github.com/apache/gravitino/pull/6442#issuecomment-2655255352 Do we still need this PR? @FANNG1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [#6429] Fixed Wrong log format codes [gravitino]

2025-02-12 Thread via GitHub
jerryshao merged PR #6433: URL: https://github.com/apache/gravitino/pull/6433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

[PR] [#6429] Fixed Wrong log format codes [gravitino]

2025-02-12 Thread via GitHub
github-actions[bot] opened a new pull request, #6445: URL: https://github.com/apache/gravitino/pull/6445 ### What changes were proposed in this pull request? The PR updates incorrect log format codes from `%s` to `{}` in the following lines: - Line 420 - Line 483 - Line 5

(gravitino) branch main updated: [#6429] Fixed Wrong log format codes (#6433)

2025-02-12 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 4348089993 [#6429] Fixed Wrong log format codes (#

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-12 Thread via GitHub
FANNG1 closed pull request #6400: [#6399] Added validation to fileset dialog URL: https://github.com/apache/gravitino/pull/6400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] [Bug report] Wrong log format codes [gravitino]

2025-02-12 Thread via GitHub
jerryshao commented on issue #6429: URL: https://github.com/apache/gravitino/issues/6429#issuecomment-2655271807 @aryanmahawar205 can you please leave a message here, so I can assign this issue to you. -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] [MINOR] docs: polish Iceberg REST server document [gravitino]

2025-02-12 Thread via GitHub
FANNG1 opened a new pull request, #6444: URL: https://github.com/apache/gravitino/pull/6444 ### What changes were proposed in this pull request? multi catalog and view operation should shown in document side bars. ### Why are the changes needed? User could find multi catalog

Re: [I] [Bug report] Wrong log format codes [gravitino]

2025-02-12 Thread via GitHub
jerryshao closed issue #6429: [Bug report] Wrong log format codes URL: https://github.com/apache/gravitino/issues/6429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [#6429] Fixed Wrong log format codes [gravitino]

2025-02-12 Thread via GitHub
jerryshao closed pull request #6445: [#6429] Fixed Wrong log format codes URL: https://github.com/apache/gravitino/pull/6445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [#6361] feat(paimon):Support specifying primary keys during create paimon table by flink [gravitino]

2025-02-12 Thread via GitHub
FANNG1 merged PR #6362: URL: https://github.com/apache/gravitino/pull/6362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

(gravitino) branch main updated (4348089993 -> 650232cf28)

2025-02-12 Thread fanng
This is an automated email from the ASF dual-hosted git repository. fanng pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git from 4348089993 [#6429] Fixed Wrong log format codes (#6433) add 650232cf28 [#6361] feat(paimon):Support specifying pr

Re: [PR] [#6361] feat(paimon):Support specifying primary keys during create paimon table by flink [gravitino]

2025-02-12 Thread via GitHub
FANNG1 commented on PR #6362: URL: https://github.com/apache/gravitino/pull/6362#issuecomment-2655284596 merged to main, thanks @hdygxsj for the PR and @tengqm for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [I] [Subtask] Support specifying primary keys during create paimon table by flink [gravitino]

2025-02-12 Thread via GitHub
FANNG1 closed issue #6361: [Subtask] Support specifying primary keys during create paimon table by flink URL: https://github.com/apache/gravitino/issues/6361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-12 Thread via GitHub
LauraXia123 commented on PR #6400: URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2655284844 @Pranaykarvi can you run `pnpm lint` to check the lint issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] [HOTFIX] fix compile paimon error by broken maven version for net.minidev:json-smart [gravitino]

2025-02-12 Thread via GitHub
FANNG1 commented on PR #6442: URL: https://github.com/apache/gravitino/pull/6442#issuecomment-2655286053 > Do we still need this PR? @FANNG1 The upstream has fixed the broken maven state and Gravitino works normally now, close this PR. -- This is an automated message from the Apach

Re: [PR] [HOTFIX] fix compile paimon error by broken maven version for net.minidev:json-smart [gravitino]

2025-02-12 Thread via GitHub
FANNG1 closed pull request #6442: [HOTFIX] fix compile paimon error by broken maven version for net.minidev:json-smart URL: https://github.com/apache/gravitino/pull/6442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the