TungYuChiang commented on code in PR #5998: URL: https://github.com/apache/gravitino/pull/5998#discussion_r1953688276
########## core/src/main/java/org/apache/gravitino/listener/TagEventDispatcher.java: ########## @@ -152,8 +186,11 @@ public MetadataObject[] listMetadataObjectsForTag(String metalake, String name) public String[] listTagsForMetadataObject(String metalake, MetadataObject metadataObject) { // TODO: listTagsForMetadataObjectPreEvent try { - // TODO: listTagsForMetadataObjectEvent - return dispatcher.listTagsForMetadataObject(metalake, metadataObject); + String[] tags = dispatcher.listTagsForMetadataObject(metalake, metadataObject); + eventBus.dispatchEvent( Review Comment: I appreciate the guidance! I see that we are getting multiple tags from listMetadataObjectsForTag. Should we instantiate a new TagInfo for each tag, like this? ` TagInfo[] tagInfos = new TagInfo[tags.length]; for (int i = 0; i < tags.length; i++) { tagInfos[i] = new TagInfo(tags[i], comment, properties); } ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org