Re: [PR] [#5900] feat(tag): support tag pre-event to Gravitino server [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on code in PR #5980: URL: https://github.com/apache/gravitino/pull/5980#discussion_r1944308748 ## core/src/main/java/org/apache/gravitino/listener/api/event/AssociateTagsForMetadataObjectPreEvent.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software

Re: [PR] [#5900] feat(tag): support tag pre-event to Gravitino server [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on code in PR #5980: URL: https://github.com/apache/gravitino/pull/5980#discussion_r1944307961 ## core/src/main/java/org/apache/gravitino/listener/api/event/AssociateTagsForMetadataObjectPreEvent.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software

Re: [PR] [#5900] feat(tag): support tag pre-event to Gravitino server [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on code in PR #5980: URL: https://github.com/apache/gravitino/pull/5980#discussion_r1944308748 ## core/src/main/java/org/apache/gravitino/listener/api/event/AssociateTagsForMetadataObjectPreEvent.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software

Re: [PR] [#5900] feat(tag): support tag pre-event to Gravitino server [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on PR #5980: URL: https://github.com/apache/gravitino/pull/5980#issuecomment-2639160962 sorry for the delay, LGTM except minor comments, could you fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

(gravitino) branch branch-0.8 updated: [#6375] improvement(catalog-hadoop): Remove `protobuf-java` to avoid conflict with authorization module (#6401)

2025-02-06 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch branch-0.8 in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/branch-0.8 by this push: new 52d250edd7 [#6375] improvement(catalog

Re: [PR] [#6382] feat(iceberg): Make Gravitino Iceberg REST server keep compatibility with Trino [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on code in PR #6396: URL: https://github.com/apache/gravitino/pull/6396#discussion_r1944590990 ## iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java: ## @@ -215,6 +216,11 @@ public LoadViewResponse updateView(

(gravitino) branch main updated: [#6375] improvment(catalog-hadoop): Remove `protobuf-java` to avoid conflict with authorization module (#6376)

2025-02-06 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 4534985262 [#6375] improvment(catalog-hadoop): Rem

Re: [PR] [#6375] improvment(catalog-hadoop): Remove `protobuf-java` to avoid conflict with authorization module [gravitino]

2025-02-06 Thread via GitHub
jerryshao merged PR #6376: URL: https://github.com/apache/gravitino/pull/6376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Improvement] protobuf-java in module `catalog-hadoop` is useless and will conflict with a new version in authorization module [gravitino]

2025-02-06 Thread via GitHub
jerryshao closed issue #6375: [Improvement] protobuf-java in module `catalog-hadoop` is useless and will conflict with a new version in authorization module URL: https://github.com/apache/gravitino/issues/6375 -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] [#6375] improvment(catalog-hadoop): Remove `protobuf-java` to avoid conflict with authorization module [gravitino]

2025-02-06 Thread via GitHub
github-actions[bot] opened a new pull request, #6401: URL: https://github.com/apache/gravitino/pull/6401 ### What changes were proposed in this pull request? Remove jar `protobuf-java.jar` from the distribution package to avoid conflicts ### Why are the changes needed?

Re: [I] [Improvement] protobuf-java in module `catalog-hadoop` is useless and will conflict with a new version in authorization module [gravitino]

2025-02-06 Thread via GitHub
jerryshao closed issue #6375: [Improvement] protobuf-java in module `catalog-hadoop` is useless and will conflict with a new version in authorization module URL: https://github.com/apache/gravitino/issues/6375 -- This is an automated message from the Apache Git Service. To respond to the mes

(gravitino) branch cherry-pick-branch-0.8-45349852629d00eb38eff531af1a0f2bd1dab852 created (now 64bb67d8df)

2025-02-06 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch cherry-pick-branch-0.8-45349852629d00eb38eff531af1a0f2bd1dab852 in repository https://gitbox.apache.org/repos/asf/gravitino.git at 64bb67d8df [#6375] improvment(catalog-hadoop): Remove

Re: [PR] [#6375] improvment(catalog-hadoop): Remove `protobuf-java` to avoid conflict with authorization module [gravitino]

2025-02-06 Thread via GitHub
jerryshao closed pull request #6401: [#6375] improvment(catalog-hadoop): Remove `protobuf-java` to avoid conflict with authorization module URL: https://github.com/apache/gravitino/pull/6401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [#6382] feat(iceberg): Make Gravitino Iceberg REST server keep compatibility with Trino [gravitino]

2025-02-06 Thread via GitHub
jerryshao commented on code in PR #6396: URL: https://github.com/apache/gravitino/pull/6396#discussion_r1944425607 ## iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java: ## @@ -215,6 +216,11 @@ public LoadViewResponse updateVi

(gravitino) branch cherry-pick-branch-0.8-45349852629d00eb38eff531af1a0f2bd1dab852 deleted (was 64bb67d8df)

2025-02-06 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch cherry-pick-branch-0.8-45349852629d00eb38eff531af1a0f2bd1dab852 in repository https://gitbox.apache.org/repos/asf/gravitino.git was 64bb67d8df [#6375] improvment(catalog-hadoop): Remove `pro

Re: [PR] [#6375] improvment(catalog-hadoop): Remove `protobuf-java` to avoid conflict with authorization module [gravitino]

2025-02-06 Thread via GitHub
jerryshao merged PR #6401: URL: https://github.com/apache/gravitino/pull/6401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Bug report] SparkJdbcMysqlCatalogIT33 failed [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on issue #6392: URL: https://github.com/apache/gravitino/issues/6392#issuecomment-2639170721 ok, seems this IT failed in some specific environment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [#6394] feat(iceberg): upgrade Iceberg version from 1.5.2 to 1.6.1 [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on code in PR #6374: URL: https://github.com/apache/gravitino/pull/6374#discussion_r1944265030 ## catalogs/catalog-common/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergConstants.java: ## @@ -84,4 +84,6 @@ public class IcebergConstants {

Re: [PR] [#5900] feat(tag): support tag pre-event to Gravitino server [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on code in PR #5980: URL: https://github.com/apache/gravitino/pull/5980#discussion_r1944293241 ## core/src/main/java/org/apache/gravitino/listener/api/event/GetTagForMetadataObjectPreEvent.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] [#5900] feat(tag): support tag pre-event to Gravitino server [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on code in PR #5980: URL: https://github.com/apache/gravitino/pull/5980#discussion_r1944293015 ## core/src/main/java/org/apache/gravitino/listener/api/event/GetTagForMetadataObjectPreEvent.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] [#5900] feat(tag): support tag pre-event to Gravitino server [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on code in PR #5980: URL: https://github.com/apache/gravitino/pull/5980#discussion_r1944296316 ## core/src/main/java/org/apache/gravitino/listener/api/event/TagPreEvent.java: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#5900] feat(tag): support tag pre-event to Gravitino server [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on code in PR #5980: URL: https://github.com/apache/gravitino/pull/5980#discussion_r1944295964 ## core/src/main/java/org/apache/gravitino/listener/api/event/ListTagsInfoPreEvent.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-06 Thread via GitHub
mchades commented on PR #6400: URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2639420677 plz make the CI pass. see: https://github.com/apache/gravitino/actions/runs/13173847662/job/36768887540?pr=6400 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [#6382] feat(iceberg): Make Gravitino Iceberg REST server keep compatibility with Trino [gravitino]

2025-02-06 Thread via GitHub
jerryshao commented on code in PR #6396: URL: https://github.com/apache/gravitino/pull/6396#discussion_r1944430131 ## iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java: ## @@ -228,10 +234,18 @@ public void renameView(RenameTa

Re: [PR] [#6326] Refactor to add a command context to CLI [gravitino]

2025-02-06 Thread via GitHub
shaofengshi commented on code in PR #6343: URL: https://github.com/apache/gravitino/pull/6343#discussion_r1944389104 ## clients/cli/src/main/java/org/apache/gravitino/cli/MetalakeCommandHandler.java: ## @@ -40,15 +39,18 @@ public class MetalakeCommandHandler extends CommandHandl

Re: [PR] [#5932] improve(CLI): Fix the CLI delete the anonymous user [gravitino]

2025-02-06 Thread via GitHub
Abyss-lord commented on PR #6359: URL: https://github.com/apache/gravitino/pull/6359#issuecomment-2639666848 > I agree with Justin that, anonymous user is a system reserved user, should not be deleted, instead of reminding user. @Abyss-lord could you please update the logic here? @sh

[I] [Bug report] Update table using trino no supported [gravitino]

2025-02-06 Thread via GitHub
gesaleh opened a new issue, #6403: URL: https://github.com/apache/gravitino/issues/6403 ### Version main branch ### Describe what's wrong according to the documents update fro mysql connector is supported if we give constant values ``` trino> UPDATE catalog_mysql.

Re: [PR] [#6382] feat(iceberg): Make Gravitino Iceberg REST server keep compatibility with Trino [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on code in PR #6396: URL: https://github.com/apache/gravitino/pull/6396#discussion_r1944594847 ## iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java: ## @@ -228,10 +234,18 @@ public void renameView(RenameTable

Re: [PR] [#6394] feat(iceberg): upgrade Iceberg version from 1.5.2 to 1.6.1 [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on code in PR #6374: URL: https://github.com/apache/gravitino/pull/6374#discussion_r1944975577 ## dev/docker/iceberg-rest-server/iceberg-rest-server-dependency.sh: ## @@ -49,19 +49,19 @@ cp ${gravitino_home}/bundles/aws/build/libs/gravitino-aws-*.jar bundles/

Re: [PR] [#6394] feat(iceberg): upgrade Iceberg version from 1.5.2 to 1.6.1 [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on code in PR #6374: URL: https://github.com/apache/gravitino/pull/6374#discussion_r1944974354 ## iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/integration/test/IcebergRESTGCSIT.java: ## @@ -92,10 +93,10 @@ private void copyGCSBundleJar(

Re: [PR] [#5900] feat(tag): support tag pre-event to Gravitino server [gravitino]

2025-02-06 Thread via GitHub
amazingLychee commented on PR #5980: URL: https://github.com/apache/gravitino/pull/5980#issuecomment-2640059201 @FANNG1, thanks for reviewing. I just fixed it, could you help me review it again? Thank you! -- This is an automated message from the Apache Git Service. To respond to the mess

(gravitino) branch main updated: [#6394] feat(iceberg): upgrade Iceberg version from 1.5.2 to 1.6.1 (#6374)

2025-02-06 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new b1e5931b27 [#6394] feat(iceberg): upgrade Iceberg

Re: [I] [Improvement] Upgrade Iceberg library version from 1.5 to 1.6 [gravitino]

2025-02-06 Thread via GitHub
jerryshao closed issue #6394: [Improvement] Upgrade Iceberg library version from 1.5 to 1.6 URL: https://github.com/apache/gravitino/issues/6394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [#6394] feat(iceberg): upgrade Iceberg version from 1.5.2 to 1.6.1 [gravitino]

2025-02-06 Thread via GitHub
jerqi commented on PR #6374: URL: https://github.com/apache/gravitino/pull/6374#issuecomment-2642048193 After reading the release notes of 1.6.0, I want to make sure that these changes won't affect the upgrade. https://github.com/apache/iceberg/pull/9885 -- This is an automated

Re: [I] [Subtask] Gvfs Fuse command line Tools: support mount and umount command [gravitino]

2025-02-06 Thread via GitHub
jerryshao closed issue #6320: [Subtask] Gvfs Fuse command line Tools: support mount and umount command URL: https://github.com/apache/gravitino/issues/6320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(gravitino) branch main updated: [#6320] feat (gvfs-fuse): Support mount and umount command for gvfs-fuse command line tools (#6321)

2025-02-06 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new e85e47dcd8 [#6320] feat (gvfs-fuse): Support mount

Re: [PR] [#6320] feat (gvfs-fuse): Support mount and umount command for gvfs-fuse command line tools [gravitino]

2025-02-06 Thread via GitHub
jerryshao merged PR #6321: URL: https://github.com/apache/gravitino/pull/6321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Subtask] Gvfs Fuse command line Tools: support mount and umount command [gravitino]

2025-02-06 Thread via GitHub
jerryshao closed issue #6320: [Subtask] Gvfs Fuse command line Tools: support mount and umount command URL: https://github.com/apache/gravitino/issues/6320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [#6404] feat (gvfs-fuse): Add Readme document of gvfs-fuse [gravitino]

2025-02-06 Thread via GitHub
diqiu50 opened a new pull request, #6405: URL: https://github.com/apache/gravitino/pull/6405 ### What changes were proposed in this pull request? Add Readme document of gvfs-fuse ### Why are the changes needed? Fix: #6404 ### Does this PR introduce _any_ user-

[I] [Bug report] CI: Cron Integration Test execute failed for task ':authorizations:authorization-ranger:test'. [gravitino]

2025-02-06 Thread via GitHub
danhuawang opened a new issue, #6406: URL: https://github.com/apache/gravitino/issues/6406 ### Version main branch ### Describe what's wrong Cron Integration Test execute failed: https://github.com/apache/gravitino/actions/runs/13164696252/job/36741893632 Error

Re: [I] [Improvement] Upgrade Iceberg library version from 1.5 to 1.6 [gravitino]

2025-02-06 Thread via GitHub
jerryshao closed issue #6394: [Improvement] Upgrade Iceberg library version from 1.5 to 1.6 URL: https://github.com/apache/gravitino/issues/6394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [#6394] feat(iceberg): upgrade Iceberg version from 1.5.2 to 1.6.1 [gravitino]

2025-02-06 Thread via GitHub
jerqi commented on PR #6374: URL: https://github.com/apache/gravitino/pull/6374#issuecomment-2642041141 Is it ok if we use 1.5 client to access our new server? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [#6394] feat(iceberg): upgrade Iceberg version from 1.5.2 to 1.6.1 [gravitino]

2025-02-06 Thread via GitHub
jerqi commented on code in PR #6374: URL: https://github.com/apache/gravitino/pull/6374#discussion_r1946010080 ## gradle/libs.versions.toml: ## @@ -55,7 +55,7 @@ commons-collections3 = "3.2.2" commons-configuration1 = "1.6" commons-dbcp2 = "2.11.0" caffeine = "2.9.3" -iceberg

Re: [PR] [#6394] feat(iceberg): upgrade Iceberg version from 1.5.2 to 1.6.1 [gravitino]

2025-02-06 Thread via GitHub
jerqi commented on code in PR #6374: URL: https://github.com/apache/gravitino/pull/6374#discussion_r1946009586 ## docs/iceberg-rest-service.md: ## @@ -13,7 +13,6 @@ The Apache Gravitino Iceberg REST Server follows the [Apache Iceberg REST API sp ### Capabilities - Supports

Re: [PR] [#6394] feat(iceberg): upgrade Iceberg version from 1.5.2 to 1.6.1 [gravitino]

2025-02-06 Thread via GitHub
jerryshao merged PR #6374: URL: https://github.com/apache/gravitino/pull/6374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#6394] feat(iceberg): upgrade Iceberg version from 1.5.2 to 1.6.1 [gravitino]

2025-02-06 Thread via GitHub
jerryshao commented on PR #6374: URL: https://github.com/apache/gravitino/pull/6374#issuecomment-2642047601 I think it is out of the question of Gravitino, this should be guaranteed by Iceberg REST spec. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [I] [info-request] change the default example oauth client and secret [gravitino]

2025-02-06 Thread via GitHub
jerqi commented on issue #6402: URL: https://github.com/apache/gravitino/issues/6402#issuecomment-2642070972 This authorization server is only used for examples. It's not for the production environment. You can see the authorization-server Docker https://github.com/apache/gravitino/commit/

Re: [PR] [#5900] feat(tag): support tag pre-event to Gravitino server [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on code in PR #5980: URL: https://github.com/apache/gravitino/pull/5980#discussion_r1945721571 ## core/src/main/java/org/apache/gravitino/listener/api/event/AlterTagPreEvent.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [#5900] feat(tag): support tag pre-event to Gravitino server [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on PR #5980: URL: https://github.com/apache/gravitino/pull/5980#issuecomment-2641521645 > @FANNG1, thanks for reviewing. I just fixed it, could you help me review it again? Thank you! one little comment. -- This is an automated message from the Apache Git Service.

Re: [I] [Bug report] CI: Cron Integration Test execute failed for task ':authorizations:authorization-ranger:test'. [gravitino]

2025-02-06 Thread via GitHub
danhuawang commented on issue #6406: URL: https://github.com/apache/gravitino/issues/6406#issuecomment-2641744697 @jerqi @xunliu Can you help check this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [#6382] feat(iceberg): Make Gravitino Iceberg REST server keep compatibility with Trino [gravitino]

2025-02-06 Thread via GitHub
jerryshao commented on code in PR #6396: URL: https://github.com/apache/gravitino/pull/6396#discussion_r1945862159 ## iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java: ## @@ -215,6 +216,11 @@ public LoadViewResponse updateVi

Re: [PR] [#6382] feat(iceberg): Make Gravitino Iceberg REST server keep compatibility with Trino [gravitino]

2025-02-06 Thread via GitHub
jerryshao commented on PR #6396: URL: https://github.com/apache/gravitino/pull/6396#issuecomment-2641837578 Hi @jackye1995 , what is your opinion on this? I think this is a Trino problem, doing a such workaround on the REST server side seems a little awkward to me -- This is an automated

Re: [PR] [#6320] feat (gvfs-fuse): Support mount and umount command for gvfs-fuse command line tools [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on code in PR #6321: URL: https://github.com/apache/gravitino/pull/6321#discussion_r1945906753 ## clients/filesystem-fuse/src/command_args.rs: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

Re: [PR] [#6394] feat(iceberg): upgrade Iceberg version from 1.5.2 to 1.6.1 [gravitino]

2025-02-06 Thread via GitHub
jerryshao commented on PR #6374: URL: https://github.com/apache/gravitino/pull/6374#issuecomment-2641852574 @jerqi Can you please take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [#6320] feat (gvfs-fuse): Support mount and umount command for gvfs-fuse command line tools [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on code in PR #6321: URL: https://github.com/apache/gravitino/pull/6321#discussion_r1945882932 ## clients/filesystem-fuse/src/command_args.rs: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

Re: [PR] [#6320] feat (gvfs-fuse): Support mount and umount command for gvfs-fuse command line tools [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on code in PR #6321: URL: https://github.com/apache/gravitino/pull/6321#discussion_r1945884458 ## clients/filesystem-fuse/src/command_args.rs: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

Re: [PR] [#6320] feat (gvfs-fuse): Support mount and umount command for gvfs-fuse command line tools [gravitino]

2025-02-06 Thread via GitHub
diqiu50 commented on code in PR #6321: URL: https://github.com/apache/gravitino/pull/6321#discussion_r1945887279 ## clients/filesystem-fuse/src/command_args.rs: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

Re: [PR] [#6326] Refactor to add a command context to CLI [gravitino]

2025-02-06 Thread via GitHub
justinmclean commented on code in PR #6343: URL: https://github.com/apache/gravitino/pull/6343#discussion_r1945581200 ## clients/cli/src/main/java/org/apache/gravitino/cli/MetalakeCommandHandler.java: ## @@ -40,15 +39,18 @@ public class MetalakeCommandHandler extends CommandHand

Re: [PR] [#6382] feat(iceberg): Make Gravitino Iceberg REST server keep compatibility with Trino [gravitino]

2025-02-06 Thread via GitHub
FANNG1 commented on code in PR #6396: URL: https://github.com/apache/gravitino/pull/6396#discussion_r1945889037 ## iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java: ## @@ -215,6 +216,11 @@ public LoadViewResponse updateView(

Re: [PR] [#6320] feat (gvfs-fuse): Support mount and umount command for gvfs-fuse command line tools [gravitino]

2025-02-06 Thread via GitHub
diqiu50 commented on code in PR #6321: URL: https://github.com/apache/gravitino/pull/6321#discussion_r1945892421 ## clients/filesystem-fuse/src/command_args.rs: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

Re: [PR] [#5932] improve(CLI): Fix the CLI delete the anonymous user [gravitino]

2025-02-06 Thread via GitHub
shaofengshi commented on code in PR #6359: URL: https://github.com/apache/gravitino/pull/6359#discussion_r1945892600 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/DeleteUser.java: ## @@ -53,6 +53,10 @@ public DeleteUser( public void handle() { boolean de

Re: [PR] [#6320] feat (gvfs-fuse): Support mount and umount command for gvfs-fuse command line tools [gravitino]

2025-02-06 Thread via GitHub
diqiu50 commented on code in PR #6321: URL: https://github.com/apache/gravitino/pull/6321#discussion_r1945893537 ## clients/filesystem-fuse/src/command_args.rs: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

Re: [PR] [#6320] feat (gvfs-fuse): Support mount and umount command for gvfs-fuse command line tools [gravitino]

2025-02-06 Thread via GitHub
diqiu50 commented on code in PR #6321: URL: https://github.com/apache/gravitino/pull/6321#discussion_r1945893537 ## clients/filesystem-fuse/src/command_args.rs: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[I] change the default example oauth client and secret [gravitino]

2025-02-06 Thread via GitHub
metalshanked opened a new issue, #6402: URL: https://github.com/apache/gravitino/issues/6402 ### Version main branch ### Describe what's wrong Hi, is there a simple way to change the default client id and secret for gravitino example mentioned here https://gravitino.

Re: [PR] [#6394] feat(iceberg): upgrade Iceberg version from 1.5.2 to 1.6.1 [gravitino]

2025-02-06 Thread via GitHub
jerryshao commented on code in PR #6374: URL: https://github.com/apache/gravitino/pull/6374#discussion_r1944815380 ## dev/docker/iceberg-rest-server/iceberg-rest-server-dependency.sh: ## @@ -49,19 +49,19 @@ cp ${gravitino_home}/bundles/aws/build/libs/gravitino-aws-*.jar bundles

Re: [PR] [#6394] feat(iceberg): upgrade Iceberg version from 1.5.2 to 1.6.1 [gravitino]

2025-02-06 Thread via GitHub
jerryshao commented on code in PR #6374: URL: https://github.com/apache/gravitino/pull/6374#discussion_r1944817175 ## iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/integration/test/IcebergRESTGCSIT.java: ## @@ -92,10 +93,10 @@ private void copyGCSBundleJ