FANNG1 commented on code in PR #6396:
URL: https://github.com/apache/gravitino/pull/6396#discussion_r1944594847
##########
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java:
##########
@@ -228,10 +234,18 @@ public void renameView(RenameTableRequest request) {
}
public boolean viewExists(TableIdentifier viewIdentifier) {
+ if (!(catalog instanceof ViewCatalog)) {
+ return false;
Review Comment:
The purpose of the change is to keep consistent with `loadView`, if the
catalog doesn't support the view operation, loadView will throw
`NoSuchViewException` which means view not exists. Yes, this is something odd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
