Re: [PR] [#6070][#5649] docs(core): add credential vending document [gravitino]

2025-01-02 Thread via GitHub
FANNG1 commented on code in PR #6071: URL: https://github.com/apache/gravitino/pull/6071#discussion_r1901402186 ## docs/security/credential-vending.md: ## @@ -0,0 +1,175 @@ +--- +title: "Gravitino credential vending" +slug: /security/credential-vending +keyword: security credent

Re: [PR] [#6070][#5649] docs(core): add credential vending document [gravitino]

2025-01-02 Thread via GitHub
FANNG1 commented on code in PR #6071: URL: https://github.com/apache/gravitino/pull/6071#discussion_r1901402060 ## docs/security/credential-vending.md: ## @@ -0,0 +1,175 @@ +--- +title: "Gravitino credential vending" +slug: /security/credential-vending +keyword: security credent

Re: [PR] [#6070][#5649] docs(core): add credential vending document [gravitino]

2025-01-02 Thread via GitHub
orenccl commented on code in PR #6071: URL: https://github.com/apache/gravitino/pull/6071#discussion_r1901403063 ## docs/security/credential-vending.md: ## @@ -0,0 +1,175 @@ +--- +title: "Gravitino credential vending" +slug: /security/credential-vending +keyword: security creden

[I] [Bug report] The OpenAPI spec is inaccurate [gravitino]

2025-01-02 Thread via GitHub
tengqm opened a new issue, #6072: URL: https://github.com/apache/gravitino/issues/6072 ### Version main branch ### Describe what's wrong The OpenAPI spec (`/docs/open-api/*.yaml`) is not accurate. This inaccuracy may lead to incomplete/insufficient parameter validation o

Re: [PR] [#6070][#5649] docs(core): add credential vending document [gravitino]

2025-01-02 Thread via GitHub
orenccl commented on code in PR #6071: URL: https://github.com/apache/gravitino/pull/6071#discussion_r1901403063 ## docs/security/credential-vending.md: ## @@ -0,0 +1,175 @@ +--- +title: "Gravitino credential vending" +slug: /security/credential-vending +keyword: security creden

Re: [PR] [#6070][#5649] docs(core): add credential vending document [gravitino]

2025-01-02 Thread via GitHub
orenccl commented on code in PR #6071: URL: https://github.com/apache/gravitino/pull/6071#discussion_r1901403063 ## docs/security/credential-vending.md: ## @@ -0,0 +1,175 @@ +--- +title: "Gravitino credential vending" +slug: /security/credential-vending +keyword: security creden

Re: [PR] [#6070][#5649] docs(core): add credential vending document [gravitino]

2025-01-02 Thread via GitHub
tengqm commented on PR #6071: URL: https://github.com/apache/gravitino/pull/6071#issuecomment-2568578677 > > By "vending", I think we mean "vendoring" ... > > `credential vending` is a specific word, please refer to https://docs.aws.amazon.com/lake-formation/latest/dg/aws-lake-formati

Re: [PR] [#6044] improve(lock): optimization tree lock when drop and load Table/Schema [gravitino]

2025-01-02 Thread via GitHub
xunliu commented on code in PR #6063: URL: https://github.com/apache/gravitino/pull/6063#discussion_r1901428872 ## core/src/main/java/org/apache/gravitino/utils/NameIdentifierUtil.java: ## @@ -265,6 +265,33 @@ public static NameIdentifier getCatalogIdentifier(NameIdentifier ide

Re: [PR] [#6044] improve(lock): optimization tree lock when drop and load Table/Schema [gravitino]

2025-01-02 Thread via GitHub
jerqi commented on code in PR #6063: URL: https://github.com/apache/gravitino/pull/6063#discussion_r1901432415 ## core/src/main/java/org/apache/gravitino/utils/NameIdentifierUtil.java: ## @@ -265,6 +265,33 @@ public static NameIdentifier getCatalogIdentifier(NameIdentifier iden

[PR] [#5937] Add spotlessCheck to iceberg-common module on compileIcebergRESTServer [gravitino]

2025-01-02 Thread via GitHub
cool9850311 opened a new pull request, #6073: URL: https://github.com/apache/gravitino/pull/6073 What changes were proposed in this pull request? Add spotlessCheck to iceberg-common module on compileIcebergRESTServer Why are the changes needed? Fix: https://github.com/apache/grav

Re: [PR] [#5937] Add spotlessCheck to iceberg-common module on compileIcebergRESTServer [gravitino]

2025-01-02 Thread via GitHub
cool9850311 closed pull request #6073: [#5937] Add spotlessCheck to iceberg-common module on compileIcebergRESTServer URL: https://github.com/apache/gravitino/pull/6073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [#6070][#5649] docs(core): add credential vending document [gravitino]

2025-01-02 Thread via GitHub
orenccl commented on code in PR #6071: URL: https://github.com/apache/gravitino/pull/6071#discussion_r1901403063 ## docs/security/credential-vending.md: ## @@ -0,0 +1,175 @@ +--- +title: "Gravitino credential vending" +slug: /security/credential-vending +keyword: security creden

Re: [PR] [#6070][#5649] docs(core): add credential vending document [gravitino]

2025-01-02 Thread via GitHub
orenccl commented on code in PR #6071: URL: https://github.com/apache/gravitino/pull/6071#discussion_r1900957074 ## docs/security/credential-vending.md: ## @@ -0,0 +1,175 @@ +--- +title: "Gravitino credential vending" +slug: /security/credential-vending +keyword: security creden

Re: [PR] [#6044] improve(lock): optimization tree lock when drop and load Table/Schema [gravitino]

2025-01-02 Thread via GitHub
xunliu commented on code in PR #6063: URL: https://github.com/apache/gravitino/pull/6063#discussion_r1901411297 ## api/src/main/java/org/apache/gravitino/authorization/MetadataObjectChange.java: ## @@ -44,10 +45,11 @@ static MetadataObjectChange rename( * Remove a metadata e

Re: [PR] [#6044] improve(lock): optimization tree lock when drop and load Table/Schema [gravitino]

2025-01-02 Thread via GitHub
xunliu commented on PR #6063: URL: https://github.com/apache/gravitino/pull/6063#issuecomment-2568598578 > Too big to review, giving up ... hi @tengqm I resubmit this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [#5960] fix(CLI): Add register and link commands to CLI for model [gravitino]

2025-01-02 Thread via GitHub
Abyss-lord commented on code in PR #6066: URL: https://github.com/apache/gravitino/pull/6066#discussion_r1901415715 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -1175,6 +1175,8 @@ private void handleModelCommand() { } String

Re: [PR] [#6004] fix: use fullName instead of names.get(0) when get role [gravitino]

2025-01-02 Thread via GitHub
cool9850311 commented on code in PR #6057: URL: https://github.com/apache/gravitino/pull/6057#discussion_r1901483985 ## core/src/test/java/org/apache/gravitino/storage/relational/TestJDBCBackend.java: ## @@ -952,6 +953,56 @@ public void testMetaLifeCycleFromCreationToDeletion()

Re: [I] [Improvement] API doc: Set owner , the type in request body is mandatory , "required" tag is needed [gravitino]

2025-01-02 Thread via GitHub
TungYuChiang commented on issue #6081: URL: https://github.com/apache/gravitino/issues/6081#issuecomment-2568719427 May I take this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [#5960] fix(CLI): Add register and link commands to CLI for model [gravitino]

2025-01-02 Thread via GitHub
justinmclean commented on code in PR #6066: URL: https://github.com/apache/gravitino/pull/6066#discussion_r1901487198 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/RegisterModel.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [#5960] fix(CLI): Add register and link commands to CLI for model [gravitino]

2025-01-02 Thread via GitHub
justinmclean commented on code in PR #6066: URL: https://github.com/apache/gravitino/pull/6066#discussion_r1901488391 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -1175,6 +1175,8 @@ private void handleModelCommand() { } Strin

[PR] [#6080] fix(docs): Fix the wrong possible values. [gravitino]

2025-01-02 Thread via GitHub
cool9850311 opened a new pull request, #6084: URL: https://github.com/apache/gravitino/pull/6084 What changes were proposed in this pull request? List role names for metadata object, "COLUMN" and "ROLE" value for "metadataObjectType" are meaningless currently. Remove it. Why are th

Re: [PR] [#5973] feat(hadoop-catalog): Support using dynamic credential when using fileset with cloud storage [gravitino]

2025-01-02 Thread via GitHub
yuqi1129 commented on code in PR #5974: URL: https://github.com/apache/gravitino/pull/5974#discussion_r1901495040 ## bundles/aliyun/src/main/java/org/apache/gravitino/oss/fs/GravitinoOSSCredentialProvider.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] [#5973] feat(hadoop-catalog): Support using dynamic credential when using fileset with cloud storage [gravitino]

2025-01-02 Thread via GitHub
yuqi1129 commented on code in PR #5974: URL: https://github.com/apache/gravitino/pull/5974#discussion_r1901496891 ## bundles/aliyun/src/main/java/org/apache/gravitino/oss/fs/GravitinoOSSCredentialProvider.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] [#5973] feat(hadoop-catalog): Support using dynamic credential when using fileset with cloud storage [gravitino]

2025-01-02 Thread via GitHub
yuqi1129 commented on code in PR #5974: URL: https://github.com/apache/gravitino/pull/5974#discussion_r1901497053 ## clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystem.java: ## @@ -79,7 +88,7 @@ public class GravitinoVirtua

Re: [I] [Improvement] API doc: Set owner , the type in request body is mandatory , "required" tag is needed [gravitino]

2025-01-02 Thread via GitHub
TungYuChiang commented on issue #6081: URL: https://github.com/apache/gravitino/issues/6081#issuecomment-2568708629 May I take this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [#5960] fix(CLI): Add register and link commands to CLI for model [gravitino]

2025-01-02 Thread via GitHub
justinmclean commented on code in PR #6066: URL: https://github.com/apache/gravitino/pull/6066#discussion_r1901482170 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -1183,6 +1185,38 @@ private void handleModelCommand() { newModelD

Re: [PR] [#5960] fix(CLI): Add register and link commands to CLI for model [gravitino]

2025-01-02 Thread via GitHub
justinmclean commented on code in PR #6066: URL: https://github.com/apache/gravitino/pull/6066#discussion_r1901482361 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -1183,6 +1185,38 @@ private void handleModelCommand() { newModelD

Re: [I] [Improvement] API doc: List role names for metadata object, "COLUMN" and "ROLE" value for "metadataObjectType" are meaningless currently [gravitino]

2025-01-02 Thread via GitHub
cool9850311 commented on issue #6080: URL: https://github.com/apache/gravitino/issues/6080#issuecomment-2568720688 Working on this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [#5973] feat(hadoop-catalog): Support using dynamic credential when using fileset with cloud storage [gravitino]

2025-01-02 Thread via GitHub
yuqi1129 commented on code in PR #5974: URL: https://github.com/apache/gravitino/pull/5974#discussion_r1901490550 ## bundles/aliyun/src/main/java/org/apache/gravitino/oss/fs/OSSCredentialProvider.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] [#6080] fix(docs): Fix the wrong possible values. [gravitino]

2025-01-02 Thread via GitHub
cool9850311 commented on PR #6084: URL: https://github.com/apache/gravitino/pull/6084#issuecomment-2568730222 https://github.com/user-attachments/assets/92d1f19f-db7b-4690-a13f-6c99ca810816"; /> -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] [#6004] fix: use fullName instead of names.get(0) when get role [gravitino]

2025-01-02 Thread via GitHub
jerqi commented on code in PR #6057: URL: https://github.com/apache/gravitino/pull/6057#discussion_r1901490656 ## api/src/test/java/org/apache/gravitino/TestMetadataObjects.java: ## @@ -84,4 +84,17 @@ public void testColumnObject() { MetadataObjects.of(

Re: [PR] [#6080] fix(docs): Fix the wrong possible values. [gravitino]

2025-01-02 Thread via GitHub
cool9850311 commented on PR #6084: URL: https://github.com/apache/gravitino/pull/6084#issuecomment-2568729905 ![Uploading 截圖 2025-01-03 下午1.57.47.png…]() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] [#5973] feat(hadoop-catalog): Support using dynamic credential when using fileset with cloud storage [gravitino]

2025-01-02 Thread via GitHub
yuqi1129 commented on code in PR #5974: URL: https://github.com/apache/gravitino/pull/5974#discussion_r1901492357 ## clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystem.java: ## @@ -91,6 +100,14 @@ public class GravitinoVirt

Re: [PR] [#5960] fix(CLI): Add register and link commands to CLI for model [gravitino]

2025-01-02 Thread via GitHub
Abyss-lord commented on code in PR #6066: URL: https://github.com/apache/gravitino/pull/6066#discussion_r1901493486 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/RegisterModel.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] [#5960] fix(CLI): Add register and link commands to CLI for model [gravitino]

2025-01-02 Thread via GitHub
Abyss-lord commented on code in PR #6066: URL: https://github.com/apache/gravitino/pull/6066#discussion_r1901493198 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -1175,6 +1175,8 @@ private void handleModelCommand() { } String

Re: [PR] [#5960] fix(CLI): Add register and link commands to CLI for model [gravitino]

2025-01-02 Thread via GitHub
Abyss-lord commented on code in PR #6066: URL: https://github.com/apache/gravitino/pull/6066#discussion_r1901416502 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/RegisterModel.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] [#5960] fix(CLI): Add register and link commands to CLI for model [gravitino]

2025-01-02 Thread via GitHub
Abyss-lord commented on code in PR #6066: URL: https://github.com/apache/gravitino/pull/6066#discussion_r1901417484 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/RegisterModel.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] [#5960] fix(CLI): Add register and link commands to CLI for model [gravitino]

2025-01-02 Thread via GitHub
Abyss-lord commented on code in PR #6066: URL: https://github.com/apache/gravitino/pull/6066#discussion_r1901418156 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/RegisterModel.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] [#6049] fix(bundles): Fix scheme gs not found problem [gravitino]

2025-01-02 Thread via GitHub
FANNG1 commented on PR #6050: URL: https://github.com/apache/gravitino/pull/6050#issuecomment-2568609606 LGTM, @yuqi1129 , please add more context to the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [#5960] fix(CLI): Add register and link commands to CLI for model [gravitino]

2025-01-02 Thread via GitHub
Abyss-lord commented on code in PR #6066: URL: https://github.com/apache/gravitino/pull/6066#discussion_r1901416831 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -1183,6 +1185,38 @@ private void handleModelCommand() { newModelDet

Re: [PR] [#6042] refactor: Delete the privilege of catalog after dropping the catalogs [gravitino]

2025-01-02 Thread via GitHub
jerqi commented on code in PR #6045: URL: https://github.com/apache/gravitino/pull/6045#discussion_r1901419461 ## core/src/main/java/org/apache/gravitino/hook/CatalogHookDispatcher.java: ## @@ -126,8 +126,19 @@ public boolean dropCatalog(NameIdentifier ident) { @Override p

Re: [PR] [#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2025-01-02 Thread via GitHub
diqiu50 commented on code in PR #6013: URL: https://github.com/apache/gravitino/pull/6013#discussion_r1901419449 ## clients/filesystem-fuse/src/gravitino_fileset_filesystem.rs: ## @@ -30,32 +30,41 @@ use std::path::{Path, PathBuf}; pub(crate) struct GravitinoFilesetFileSystem {

Re: [I] [Improvement] Creating a role in the Gravitino CLI with a missing role name gives an unexpected error [gravitino]

2025-01-02 Thread via GitHub
Abyss-lord commented on issue #5832: URL: https://github.com/apache/gravitino/issues/5832#issuecomment-2568612020 ![image](https://github.com/user-attachments/assets/6f0ae387-316b-40ca-bd24-d27c30ef2ef6) Main branch, This problem has been solved. -- This is an automated message from th

Re: [I] [Improvement] Refactor the validation logic in the handle methods [gravitino]

2025-01-02 Thread via GitHub
Abyss-lord commented on issue #5861: URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2568613973 > Still need to add a validate() method to commands. @justinmclean , Hi Justin, Should we create a new issue to elaborate on the design, this is already quite lengthy,

(gravitino) branch main updated: [#5966] improvment(authorization): Add path based securable object and user group mapping interface (#5967)

2025-01-02 Thread liuxun
This is an automated email from the ASF dual-hosted git repository. liuxun pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 6f54874e4 [#5966] improvment(authorization): Add

Re: [PR] [#5966] improvment(authorization): Add path based securable object and user group mapping interface [gravitino]

2025-01-02 Thread via GitHub
xunliu merged PR #5967: URL: https://github.com/apache/gravitino/pull/5967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

Re: [I] [Improvement] Add path-based authorization securable object and user-group mapping interface [gravitino]

2025-01-02 Thread via GitHub
xunliu closed issue #5966: [Improvement] Add path-based authorization securable object and user-group mapping interface URL: https://github.com/apache/gravitino/issues/5966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [#6044] improve(lock): optimization tree lock when drop and load Table/Schema [gravitino]

2025-01-02 Thread via GitHub
jerqi commented on code in PR #6063: URL: https://github.com/apache/gravitino/pull/6063#discussion_r1901423831 ## core/src/main/java/org/apache/gravitino/utils/NameIdentifierUtil.java: ## @@ -265,6 +265,33 @@ public static NameIdentifier getCatalogIdentifier(NameIdentifier iden

Re: [PR] [#5973] feat(hadoop-catalog): Support using dynamic credential when using fileset with cloud storage [gravitino]

2025-01-02 Thread via GitHub
FANNG1 commented on code in PR #5974: URL: https://github.com/apache/gravitino/pull/5974#discussion_r1901505443 ## bundles/aliyun/src/main/java/org/apache/gravitino/oss/fs/GravitinoOSSCredentialProvider.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [#6080] fix(docs): Fix the wrong possible values. [gravitino]

2025-01-02 Thread via GitHub
jerryshao commented on code in PR #6084: URL: https://github.com/apache/gravitino/pull/6084#discussion_r1901506925 ## docs/open-api/roles.yaml: ## @@ -386,4 +386,20 @@ components: value: { "code": 0, "names": [ "user1", "user2" ] - } \ No newline at

Re: [PR] [#5973] feat(hadoop-catalog): Support using dynamic credential when using fileset with cloud storage [gravitino]

2025-01-02 Thread via GitHub
FANNG1 commented on code in PR #5974: URL: https://github.com/apache/gravitino/pull/5974#discussion_r1901507052 ## bundles/aliyun/src/main/java/org/apache/gravitino/oss/fs/OSSCredentialProvider.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [#5960] fix(CLI): Add register and link commands to CLI for model [gravitino]

2025-01-02 Thread via GitHub
tengqm commented on code in PR #6066: URL: https://github.com/apache/gravitino/pull/6066#discussion_r1901386461 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -1183,6 +1185,38 @@ private void handleModelCommand() { newModelDetails

Re: [PR] [#6070][#5649] docs(core): add credential vending document [gravitino]

2025-01-02 Thread via GitHub
tengqm commented on PR #6071: URL: https://github.com/apache/gravitino/pull/6071#issuecomment-2568550129 By "vending", I think we mean "vendoring" ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [#5960] fix(CLI): Add register and link commands to CLI for model [gravitino]

2025-01-02 Thread via GitHub
justinmclean commented on code in PR #6066: URL: https://github.com/apache/gravitino/pull/6066#discussion_r1901292682 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -1175,6 +1175,8 @@ private void handleModelCommand() { } Strin

Re: [PR] [#5960] fix(CLI): Add register and link commands to CLI for model [gravitino]

2025-01-02 Thread via GitHub
justinmclean commented on code in PR #6066: URL: https://github.com/apache/gravitino/pull/6066#discussion_r1901294916 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -1183,6 +1185,38 @@ private void handleModelCommand() { newModelD

Re: [PR] [#6070][#5649] docs(core): add credential vending document [gravitino]

2025-01-02 Thread via GitHub
FANNG1 commented on code in PR #6071: URL: https://github.com/apache/gravitino/pull/6071#discussion_r1901477441 ## docs/hadoop-catalog.md: ## @@ -166,6 +178,9 @@ Refer to [Schema operation](./manage-fileset-metadata-using-gravitino.md#schema- | `authentication.type`

Re: [PR] [#5933] doc(catalog-model): Add docs for model management [gravitino]

2025-01-02 Thread via GitHub
jerryshao commented on code in PR #6052: URL: https://github.com/apache/gravitino/pull/6052#discussion_r1900639661 ## docs/manage-model-metadata-using-gravitino.md: ## @@ -0,0 +1,637 @@ +--- +title: Manage model metadata using Gravitino +slug: /manage-model-metadata-using-gravit

Re: [I] [Bug report] Revoke the last role from a user, then the user is removed from users list details [gravitino]

2025-01-02 Thread via GitHub
danhuawang commented on issue #6061: URL: https://github.com/apache/gravitino/issues/6061#issuecomment-2567432085 @jerqi Can you help check this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[I] [Bug report] Revoke the last role from a user, then the user is removed from users list details [gravitino]

2025-01-02 Thread via GitHub
danhuawang opened a new issue, #6061: URL: https://github.com/apache/gravitino/issues/6061 ### Version main branch ### Describe what's wrong 1. Revoke the last role from a user, https://github.com/user-attachments/assets/ae1236e5-9c6f-4517-8a3a-dbe819dad489"; /> 2.

(gravitino) branch main updated: [#5950] feat(catalog-model): Add integration tests for model API (#6051)

2025-01-02 Thread yuqi4733
This is an automated email from the ASF dual-hosted git repository. yuqi4733 pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new ece06fada [#5950] feat(catalog-model): Add inte

Re: [PR] [#5950] feat(catalog-model): Add integration tests for model API [gravitino]

2025-01-02 Thread via GitHub
yuqi1129 merged PR #6051: URL: https://github.com/apache/gravitino/pull/6051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graviti

Re: [I] [Subtask]Add integration test for both Python and Java APIs [gravitino]

2025-01-02 Thread via GitHub
yuqi1129 closed issue #5950: [Subtask]Add integration test for both Python and Java APIs URL: https://github.com/apache/gravitino/issues/5950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] [Bug report] Revoke the last role from a user, then the user is removed from users list details [gravitino]

2025-01-02 Thread via GitHub
jerqi commented on issue #6061: URL: https://github.com/apache/gravitino/issues/6061#issuecomment-2567439809 I will fix this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [#5203] feat(client-python): porting partitions from java client [gravitino]

2025-01-02 Thread via GitHub
unknowntpo commented on PR #5964: URL: https://github.com/apache/gravitino/pull/5964#issuecomment-2567403233 @xunliu please have a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [#6042] refactor: Delete the privilege of catalog after dropping the catalogs [gravitino]

2025-01-02 Thread via GitHub
tengqm commented on code in PR #6045: URL: https://github.com/apache/gravitino/pull/6045#discussion_r1900614870 ## authorizations/authorization-ranger/src/test/java/org/apache/gravitino/authorization/ranger/integration/test/RangerBaseE2EIT.java: ## @@ -142,6 +142,8 @@ protected

Re: [PR] [#5933] doc(catalog-model): Add docs for model management [gravitino]

2025-01-02 Thread via GitHub
jerryshao commented on code in PR #6052: URL: https://github.com/apache/gravitino/pull/6052#discussion_r1900638388 ## docs/manage-model-metadata-using-gravitino.md: ## @@ -0,0 +1,637 @@ +--- +title: Manage model metadata using Gravitino +slug: /manage-model-metadata-using-gravit

[PR] [#6044] improve(lock): optimization tree lock when drop and load Table/Schema [gravitino]

2025-01-02 Thread via GitHub
xunliu opened a new pull request, #6063: URL: https://github.com/apache/gravitino/pull/6063 ### What changes were proposed in this pull request? Modify Schema and Table RESTful interface lock operations. ### Why are the changes needed? Fix: #6044 ### Does this PR i

Re: [I] Playground fails to start with error dependency failed to start: container playground-ranger is unhealthy [gravitino-playground]

2025-01-02 Thread via GitHub
truth1024 commented on issue #112: URL: https://github.com/apache/gravitino-playground/issues/112#issuecomment-2567463675 I also encountered the same problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [#6070][#5649] docs(core): add credential vending document [gravitino]

2025-01-02 Thread via GitHub
FANNG1 commented on PR #6071: URL: https://github.com/apache/gravitino/pull/6071#issuecomment-2568562956 > By "vending", I think we mean "vendoring" ... `credential vending` is a specific word, please refer to https://docs.aws.amazon.com/lake-formation/latest/dg/aws-lake-formation-api

Re: [PR] [#5472] improvement(docs): Add example to use cloud stroage fileset and polish hadoop-catalog document. [gravitino]

2025-01-02 Thread via GitHub
tengqm commented on code in PR #6059: URL: https://github.com/apache/gravitino/pull/6059#discussion_r1901392704 ## docs/cloud-storage-fileset-example.md: ## @@ -0,0 +1,678 @@ +--- +title: "How to use cloud storage fileset" +slug: /how-to-use-cloud-storage-fileset +keyword: files

Re: [PR] [#6044] improve(lock): optimization tree lock when drop and load Table/Schema [gravitino]

2025-01-02 Thread via GitHub
tengqm commented on code in PR #6063: URL: https://github.com/apache/gravitino/pull/6063#discussion_r1901390767 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHDFSPlugin.java: ## @@ -118,27 +127,461 @@ public Lis

Re: [PR] [#5991] feat(gcs): unify the GCS server acount path configuration for fileset and GCSCredentialProvider [gravitino]

2025-01-02 Thread via GitHub
FANNG1 merged PR #5992: URL: https://github.com/apache/gravitino/pull/5992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

Re: [I] [Improvement] unify the GCS server acount file configuration for fileset and GCSCredentialProvider [gravitino]

2025-01-02 Thread via GitHub
FANNG1 closed issue #5991: [Improvement] unify the GCS server acount file configuration for fileset and GCSCredentialProvider URL: https://github.com/apache/gravitino/issues/5991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

(gravitino) branch main updated: [#5991] feat(gcs): unify the GCS server acount path configuration for fileset and GCSCredentialProvider (#5992)

2025-01-02 Thread fanng
This is an automated email from the ASF dual-hosted git repository. fanng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 936d0452a [#5991] feat(gcs): unify the GCS server

Re: [I] [Improvement] Setting the same tags multiple times in the Gravitino CLi gives unexpected output [gravitino]

2025-01-02 Thread via GitHub
justinmclean closed issue #6030: [Improvement] Setting the same tags multiple times in the Gravitino CLi gives unexpected output URL: https://github.com/apache/gravitino/issues/6030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [#6030] fix(CLI): Fix Setting the same tags multiple times in the Gravitino CLi gives unexpected output [gravitino]

2025-01-02 Thread via GitHub
justinmclean merged PR #6037: URL: https://github.com/apache/gravitino/pull/6037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

(gravitino) branch main updated: [#6030] fix(CLI): Fix Setting the same tags multiple times in the Gravitino CLi gives unexpected output (#6037)

2025-01-02 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new fb7561698 [#6030] fix(CLI): Fix Setting the same

Re: [I] [Improvement] Setting the same tags multiple times in the Gravitino CLi gives unexpected output [gravitino]

2025-01-02 Thread via GitHub
justinmclean closed issue #6030: [Improvement] Setting the same tags multiple times in the Gravitino CLi gives unexpected output URL: https://github.com/apache/gravitino/issues/6030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [#5962] feat(client): added audit cli command model [gravitino]

2025-01-02 Thread via GitHub
justinmclean merged PR #6047: URL: https://github.com/apache/gravitino/pull/6047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

(gravitino) branch main updated: [#5962] feat(client): added audit cli command model (#6047)

2025-01-02 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new c9d124b20 [#5962] feat(client): added audit cli

Re: [PR] [#6070][#5649] docs(core): add credential vending document [gravitino]

2025-01-02 Thread via GitHub
tengqm commented on code in PR #6071: URL: https://github.com/apache/gravitino/pull/6071#discussion_r1901382792 ## docs/security/credential-vending.md: ## @@ -0,0 +1,175 @@ +--- +title: "Gravitino credential vending" +slug: /security/credential-vending +keyword: security credent

Re: [PR] [#5979] fix(docs): Fix incorrect description in document how-to-use-gvfs.md [gravitino]

2025-01-02 Thread via GitHub
tengqm commented on PR #6068: URL: https://github.com/apache/gravitino/pull/6068#issuecomment-2568539169 lgtm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] [#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2025-01-02 Thread via GitHub
FANNG1 commented on code in PR #6013: URL: https://github.com/apache/gravitino/pull/6013#discussion_r1901404986 ## clients/filesystem-fuse/src/gravitino_fileset_filesystem.rs: ## @@ -30,32 +30,41 @@ use std::path::{Path, PathBuf}; pub(crate) struct GravitinoFilesetFileSystem {

Re: [PR] [#5973] feat(hadoop-catalog): Support using dynamic credential when using fileset with cloud storage [gravitino]

2025-01-02 Thread via GitHub
yuqi1129 commented on code in PR #5974: URL: https://github.com/apache/gravitino/pull/5974#discussion_r1900705030 ## bundles/aliyun/src/main/java/org/apache/gravitino/oss/fs/OSSCredentialProvider.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] [#5973] feat(hadoop-catalog): Support using dynamic credential when using fileset with cloud storage [gravitino]

2025-01-02 Thread via GitHub
yuqi1129 commented on code in PR #5974: URL: https://github.com/apache/gravitino/pull/5974#discussion_r1900709168 ## bundles/aliyun/src/main/java/org/apache/gravitino/oss/fs/OSSCredentialProvider.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] [#6060] fix(core): Add the check of requests related to authorization [gravitino]

2025-01-02 Thread via GitHub
yuqi1129 commented on code in PR #6065: URL: https://github.com/apache/gravitino/pull/6065#discussion_r1900790847 ## common/src/main/java/org/apache/gravitino/dto/requests/RoleCreateRequest.java: ## @@ -79,5 +79,14 @@ public void validate() throws IllegalArgumentException {

Re: [PR] [#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2025-01-02 Thread via GitHub
diqiu50 commented on code in PR #6013: URL: https://github.com/apache/gravitino/pull/6013#discussion_r1901511681 ## clients/filesystem-fuse/src/filesystem.rs: ## @@ -35,6 +35,9 @@ pub(crate) const ROOT_DIR_FILE_ID: u64 = 1; pub(crate) const ROOT_DIR_NAME: &str = ""; pub(crate)

Re: [PR] [#5960] fix(CLI): Add register and link commands to CLI for model [gravitino]

2025-01-02 Thread via GitHub
justinmclean commented on code in PR #6066: URL: https://github.com/apache/gravitino/pull/6066#discussion_r1901518914 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -1175,6 +1175,8 @@ private void handleModelCommand() { } Strin

Re: [PR] [#5960] fix(CLI): Add register and link commands to CLI for model [gravitino]

2025-01-02 Thread via GitHub
justinmclean commented on code in PR #6066: URL: https://github.com/apache/gravitino/pull/6066#discussion_r1901519854 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/RegisterModel.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2025-01-02 Thread via GitHub
FANNG1 commented on PR #6013: URL: https://github.com/apache/gravitino/pull/6013#issuecomment-2568788863 LGTM except minor comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2025-01-02 Thread via GitHub
FANNG1 commented on code in PR #6013: URL: https://github.com/apache/gravitino/pull/6013#discussion_r1901525814 ## clients/filesystem-fuse/src/filesystem.rs: ## @@ -35,6 +35,9 @@ pub(crate) const ROOT_DIR_FILE_ID: u64 = 1; pub(crate) const ROOT_DIR_NAME: &str = ""; pub(crate)

Re: [PR] [#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2025-01-02 Thread via GitHub
FANNG1 commented on code in PR #6013: URL: https://github.com/apache/gravitino/pull/6013#discussion_r1901525444 ## clients/filesystem-fuse/src/s3_filesystem.rs: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor licens

Re: [I] [Improvement] Refactor the validation logic in the handle methods [gravitino]

2025-01-02 Thread via GitHub
justinmclean closed issue #5861: [Improvement] Refactor the validation logic in the handle methods URL: https://github.com/apache/gravitino/issues/5861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [I] [Improvement] Refactor the validation logic in the handle methods [gravitino]

2025-01-02 Thread via GitHub
justinmclean commented on issue #5861: URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2568792355 Sure I see you have and will close this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [Improvement] Creating a role in the Gravitino CLI with a missing role name gives an unexpected error [gravitino]

2025-01-02 Thread via GitHub
justinmclean commented on issue #5832: URL: https://github.com/apache/gravitino/issues/5832#issuecomment-2568793105 Closing as already fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] [Improvement] Creating a role in the Gravitino CLI with a missing role name gives an unexpected error [gravitino]

2025-01-02 Thread via GitHub
justinmclean closed issue #5832: [Improvement] Creating a role in the Gravitino CLI with a missing role name gives an unexpected error URL: https://github.com/apache/gravitino/issues/5832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [#6082] fix: Fix error code of creating role operation [gravitino]

2025-01-02 Thread via GitHub
jerqi opened a new pull request, #6085: URL: https://github.com/apache/gravitino/pull/6085 ### What changes were proposed in this pull request? We should return 400, if the role contains an error metalake metadata object. We should return 400, if the catalog doesn't exist. ##

Re: [PR] [#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2025-01-02 Thread via GitHub
diqiu50 commented on code in PR #6013: URL: https://github.com/apache/gravitino/pull/6013#discussion_r1901516329 ## clients/filesystem-fuse/src/default_raw_filesystem.rs: ## @@ -168,15 +184,22 @@ impl RawFileSystem for DefaultRawFileSystem { } async fn stat(&self, f

Re: [I] [Improvement] confused description about python GVFS [gravitino]

2025-01-02 Thread via GitHub
jerryshao closed issue #5979: [Improvement] confused description about python GVFS URL: https://github.com/apache/gravitino/issues/5979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

(gravitino) branch main updated: [#5979] fix(docs): Fix incorrect description in document how-to-use-gvfs.md (#6068)

2025-01-02 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 933772f7e [#5979] fix(docs): Fix incorrect descrip

  1   2   >