cool9850311 commented on code in PR #6057:
URL: https://github.com/apache/gravitino/pull/6057#discussion_r1901483985
##########
core/src/test/java/org/apache/gravitino/storage/relational/TestJDBCBackend.java:
##########
@@ -952,6 +953,56 @@ public void testMetaLifeCycleFromCreationToDeletion()
throws IOException {
assertEquals(1, listFilesetVersions(anotherFileset.id()).size());
}
+ @Test
+ public void testGetRoleIdByMetalakeIdAndName() throws IOException {
+ AuditInfo auditInfo =
+
AuditInfo.builder().withCreator("creator").withCreateTime(Instant.now()).build();
+ String metalakeName = "testMetalake";
+ String catalogName = "catalog";
+ String roleNameWithDot = "role.with.dot";
+ String roleNameWithoutDot = "roleWithoutDot";
+
+ BaseMetalake metalake =
+ createBaseMakeLake(RandomIdGenerator.INSTANCE.nextId(), metalakeName,
auditInfo);
+ backend.insert(metalake, false);
+
+ CatalogEntity catalog =
+ createCatalog(
+ RandomIdGenerator.INSTANCE.nextId(),
+ NamespaceUtil.ofCatalog(metalakeName),
+ catalogName,
+ auditInfo);
+ backend.insert(catalog, false);
+
+ RoleEntity roleWithDot =
+ createRoleEntity(
+ RandomIdGenerator.INSTANCE.nextId(),
+ AuthorizationUtils.ofRoleNamespace(metalakeName),
+ roleNameWithDot,
+ auditInfo,
+ catalogName);
+ backend.insert(roleWithDot, false);
+
+ RoleEntity roleWithoutDot =
+ createRoleEntity(
+ RandomIdGenerator.INSTANCE.nextId(),
+ AuthorizationUtils.ofRoleNamespace(metalakeName),
+ roleNameWithoutDot,
+ auditInfo,
+ catalogName);
+ backend.insert(roleWithoutDot, false);
+
+ Long metalakeId =
MetalakeMetaService.getInstance().getMetalakeIdByName(metalakeName);
+
+ Long roleIdWithDot =
+ RoleMetaService.getInstance().getRoleIdByMetalakeIdAndName(metalakeId,
roleNameWithDot);
+ assertEquals(roleWithDot.id(), roleIdWithDot);
+
+ Long roleIdWithoutDot =
+ RoleMetaService.getInstance().getRoleIdByMetalakeIdAndName(metalakeId,
roleNameWithoutDot);
+ assertEquals(roleWithoutDot.id(), roleIdWithoutDot);
+ }
Review Comment:
@jerqi
Is this correct?
just test the method with and without dot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
