jerqi commented on code in PR #5791:
URL: https://github.com/apache/gravitino/pull/5791#discussion_r1888055125
##
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/ChainAuthorizationProperties.java:
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed
diqiu50 opened a new issue, #5885:
URL: https://github.com/apache/gravitino/issues/5885
### Describe the subtask
Optimize the pipeline for modules unrelated to gvfs-fuse, such as
non-fileset catalogs, Spark connectors, and Trino connectors ...
### Parent issue
#5504
--
xunliu commented on code in PR #5791:
URL: https://github.com/apache/gravitino/pull/5791#discussion_r1888061668
##
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/ChainAuthorizationProperties.java:
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed
diqiu50 commented on issue #5873:
URL: https://github.com/apache/gravitino/issues/5873#issuecomment-2547750863
Here is an example of go-fuse debug log:
```
2024/12/17 16:05:15 rx 4: GETATTR n1 {Fh 0 } p10929
2024/12/17 16:05:15 tx 4: OK, {tA=0s {M040644 SZ=4096 L=1 1000:1000 B0*0
xunliu commented on code in PR #5791:
URL: https://github.com/apache/gravitino/pull/5791#discussion_r1888061668
##
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/ChainAuthorizationProperties.java:
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed
jerqi commented on code in PR #5882:
URL: https://github.com/apache/gravitino/pull/5882#discussion_r1888018543
##
integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/HiveContainer.java:
##
@@ -49,6 +49,7 @@ public class HiveContainer extends Bas
jerqi commented on code in PR #5882:
URL: https://github.com/apache/gravitino/pull/5882#discussion_r1888072004
##
integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/HiveContainer.java:
##
@@ -49,6 +49,7 @@ public class HiveContainer extends Bas
shaofengshi opened a new pull request, #5887:
URL: https://github.com/apache/gravitino/pull/5887
### What changes were proposed in this pull request?
(Please outline the changes and how this PR fixes the issue.)
### Why are the changes needed?
(Please clarify why
xunliu closed issue #5790: [Subtask] Wildcard properties meta
URL: https://github.com/apache/gravitino/issues/5790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
xunliu merged PR #5791:
URL: https://github.com/apache/gravitino/pull/5791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino
xunliu commented on PR #5791:
URL: https://github.com/apache/gravitino/pull/5791#issuecomment-2547772489
We can strictly check user properties configurations in the chain by using
regular.
Checking with strings is less elegant.
Can I reference in `TestChainAuthorizationProperties.java`
This is an automated email from the ASF dual-hosted git repository.
liuxun pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 983ce4be0 [#5790] auth(chain): Chain authorizatio
shaofengshi closed pull request #5883: Revert "[Minor] Add column audit command
to CLI (#5792)"
URL: https://github.com/apache/gravitino/pull/5883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jerqi opened a new pull request, #5888:
URL: https://github.com/apache/gravitino/pull/5888
### What changes were proposed in this pull request?
Change the environment variable from `ENABLE_JDBC_AUTHORIZATION` to
`ENABLE_SQL_BASE_AUTHORIATION`
### Why are the changes needed?
Abyss-lord commented on issue #5861:
URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2547873689
> We would need to throw an exception so that no code in handle is called.
The exception message can give the reason why.
hi, @justinmclean Adding the `verify` to Command
This is an automated email from the ASF dual-hosted git repository.
roryqi pushed a change to annotated tag hive-ci-v0.1.17
in repository https://gitbox.apache.org/repos/asf/gravitino.git
*** WARNING: tag hive-ci-v0.1.17 was modified! ***
from 75d818781 (tag)
to 126a254ae (tag)
taggi
This is an automated email from the ASF dual-hosted git repository.
roryqi pushed a change to annotated tag hive-ci-v0.1.17
in repository https://gitbox.apache.org/repos/asf/gravitino.git
*** WARNING: tag hive-ci-v0.1.17 was modified! ***
from 126a254ae (tag)
to 0da26a4b3 (tag)
taggi
jerryshao commented on PR #5841:
URL: https://github.com/apache/gravitino/pull/5841#issuecomment-2547901923
My feeling is that this XXXOperationDispatcher is being obsessively used
everywhere, I don't see a strong reason to use it, I would suggest to avoid
this dispatcher pattern if unneces
orenccl commented on PR #5737:
URL: https://github.com/apache/gravitino/pull/5737#issuecomment-2548120363
I think before we implement `AzureSecretKeyCredential`, we need to open
another issue to upgrade the Iceberg version.
We should upgrade to at least version 1.6.0, as it supports
Azur
This is an automated email from the ASF dual-hosted git repository.
fanng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 4daf9d103 [#5880] feat(python): support OSSSecretK
FANNG1 merged PR #5890:
URL: https://github.com/apache/gravitino/pull/5890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino
FANNG1 closed issue #5880: [Improvement] support OSSSecretKeyCredential for
python client
URL: https://github.com/apache/gravitino/issues/5880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
FANNG1 closed issue #5880: [Improvement] support OSSSecretKeyCredential for
python client
URL: https://github.com/apache/gravitino/issues/5880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
FANNG1 commented on PR #5890:
URL: https://github.com/apache/gravitino/pull/5890#issuecomment-2548411219
@deeshantk , merged to main, thanks for your contribution and welcome to the
Gravitino community, hope you enjoy the journey.
--
This is an automated message from the Apache Git Servic
FANNG1 commented on code in PR #5847:
URL: https://github.com/apache/gravitino/pull/5847#discussion_r1888493314
##
core/src/main/java/org/apache/gravitino/listener/TagEventDispatcher.java:
##
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
FANNG1 commented on PR #5841:
URL: https://github.com/apache/gravitino/pull/5841#issuecomment-2547987322
> If you want to use the method in `OperationDispatcher`, you can choose to
let `CredentialManager` to inherit this class, or mixin into this
`CredentialManager`.
updated
--
Th
jerryshao commented on PR #5868:
URL: https://github.com/apache/gravitino/pull/5868#issuecomment-2548024156
@coolderli would you please help to review this PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
jerqi closed pull request #5888: [#5846][FOLLOWUP] dev(build): Change the
environment variable from `ENABLE_JDBC_AUTHORIZATION` to
`ENABLE_SQL_BASE_AUTHORIATION`
URL: https://github.com/apache/gravitino/pull/5888
--
This is an automated message from the Apache Git Service.
To respond to the
jerqi commented on code in PR #5882:
URL: https://github.com/apache/gravitino/pull/5882#discussion_r1888215257
##
integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/ContainerSuite.java:
##
@@ -509,6 +538,10 @@ public HiveContainer getKerberosHi
deeshantk opened a new pull request, #5890:
URL: https://github.com/apache/gravitino/pull/5890
### What changes were proposed in this pull request?
It adds support for OSSSecretKeyCredential for the Python client by
implementing it, updating CredentialFactory to create instanc
Abyss-lord opened a new pull request, #5893:
URL: https://github.com/apache/gravitino/pull/5893
When using the column list command, the CLI should provide a hint rather
than throwing an exception if the table does not exist.
### What changes were proposed in this pull request?
FANNG1 commented on PR #5841:
URL: https://github.com/apache/gravitino/pull/5841#issuecomment-2547811312
@jerryshao any other comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
This is an automated email from the ASF dual-hosted git repository.
jshao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 94c6a724d [#5842] feat(core): supports credential
jerryshao closed issue #5842: [Subtask] supports credential REST endpoint in
Gravitino server side
URL: https://github.com/apache/gravitino/issues/5842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
jerryshao merged PR #5841:
URL: https://github.com/apache/gravitino/pull/5841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravit
FANNG1 commented on PR #5737:
URL: https://github.com/apache/gravitino/pull/5737#issuecomment-2548184096
> I think when we implement `AzureSecretKeyCredential`, we need to upgrade
the Iceberg version. We should upgrade to at least version 1.6.0, as it
supports AzureSecretKeyCredential.
>
danhuawang opened a new issue, #5891:
URL: https://github.com/apache/gravitino/issues/5891
### Version
main branch
### Describe what's wrong
The creator of the schema is not the current user.
https://github.com/user-attachments/assets/585f5546-32c5-4012-97a3-12a266
danhuawang commented on issue #5891:
URL: https://github.com/apache/gravitino/issues/5891#issuecomment-2548184676
@jerqi Can you help check this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
This is an automated email from the ASF dual-hosted git repository.
liuxun pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new cb66b9be3 [#5846][FOLLOWUP] dev(build): Change th
xunliu merged PR #5888:
URL: https://github.com/apache/gravitino/pull/5888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino
TungYuChiang commented on PR #5847:
URL: https://github.com/apache/gravitino/pull/5847#issuecomment-2548313152
@FANNG1 All comments have been addressed, and changes have been pushed.
Please take another look when convenient. Thanks for the thorough review!
--
This is an automated mess
jerqi opened a new issue, #5892:
URL: https://github.com/apache/gravitino/issues/5892
### Version
main branch
### Describe what's wrong
Grant a metalake level privilege won't take effect
### Error message and/or stacktrace
Grant a metalake level privilege wo
jerqi commented on code in PR #5882:
URL: https://github.com/apache/gravitino/pull/5882#discussion_r1888212614
##
integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/ContainerSuite.java:
##
@@ -65,6 +65,7 @@ public class ContainerSuite implement
jerqi commented on code in PR #5882:
URL: https://github.com/apache/gravitino/pull/5882#discussion_r1888216110
##
integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/ContainerSuite.java:
##
@@ -231,6 +232,34 @@ public void startKerberosHiveConta
sunxiaojian commented on code in PR #5868:
URL: https://github.com/apache/gravitino/pull/5868#discussion_r1888447753
##
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/store/GravitinoCatalogStore.java:
##
@@ -96,43 +102,37 @@ public boolean contains(Stri
jerryshao commented on PR #5841:
URL: https://github.com/apache/gravitino/pull/5841#issuecomment-2547907623
If you want to use the method in `OperationDispatcher`, you can choose to
let `CredentialManager` to inherit this class, or mixin into this
`CredentialManager`.
--
This is an autom
sunxiaojian commented on code in PR #5868:
URL: https://github.com/apache/gravitino/pull/5868#discussion_r1888671177
##
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/store/GravitinoCatalogStore.java:
##
@@ -96,43 +102,37 @@ public boolean contains(Stri
shaofengshi closed issue #5884: [Bug report] Main branch compile error, due to
PR merge issue
URL: https://github.com/apache/gravitino/issues/5884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
shaofengshi closed issue #5884: [Bug report] Main branch compile error, due to
PR merge issue
URL: https://github.com/apache/gravitino/issues/5884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
shaofengshi pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 1c3949a03 fix compilation error in cli (#588
shaofengshi merged PR #5887:
URL: https://github.com/apache/gravitino/pull/5887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@grav
jerryshao commented on code in PR #5848:
URL: https://github.com/apache/gravitino/pull/5848#discussion_r1888155923
##
catalogs/catalog-model/build.gradle.kts:
##
@@ -40,11 +40,17 @@ dependencies {
exclude(group = "*")
}
- compileOnly(libs.guava)
-
+ implementation(li
jerqi closed pull request #5888: [#5846][FOLLOWUP] dev(build): Change the
environment variable from `ENABLE_JDBC_AUTHORIZATION` to
`ENABLE_SQL_BASE_AUTHORIATION`
URL: https://github.com/apache/gravitino/pull/5888
--
This is an automated message from the Apache Git Service.
To respond to the
jerryshao commented on PR #5848:
URL: https://github.com/apache/gravitino/pull/5848#issuecomment-2547890860
> I noticed that we have the listModelVersions operation, but why don't we
have a listModelAlias method?
There's no specific reason why this "listModelAliases" API is not added,
sunxiaojian commented on code in PR #5868:
URL: https://github.com/apache/gravitino/pull/5868#discussion_r1888446380
##
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/hive/GravitinoHiveCatalogFactory.java:
##
@@ -81,4 +86,39 @@ public Set> requiredOptio
sunxiaojian commented on code in PR #5868:
URL: https://github.com/apache/gravitino/pull/5868#discussion_r1888447753
##
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/store/GravitinoCatalogStore.java:
##
@@ -96,43 +102,37 @@ public boolean contains(Stri
sunxiaojian commented on code in PR #5868:
URL: https://github.com/apache/gravitino/pull/5868#discussion_r1888447088
##
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/store/GravitinoCatalogStore.java:
##
@@ -96,43 +102,37 @@ public boolean contains(Stri
sunxiaojian commented on PR #5868:
URL: https://github.com/apache/gravitino/pull/5868#issuecomment-2548363807
> Overall LGTM, @sunxiaojian could you add more information in the issue
description about what and why you are changing? @coolderli do you have time to
review this PR?
1. Re
FANNG1 commented on PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#issuecomment-2550112163
There are two many filesystems, could you provide a clear description of
what filesystems represent in your design? How do you plan to split the PRs?
--
This is an automated message f
justinmclean commented on code in PR #5897:
URL: https://github.com/apache/gravitino/pull/5897#discussion_r1889670928
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -811,6 +826,16 @@ private void handleFilesetCommand() {
}
}
+ p
justinmclean commented on code in PR #5897:
URL: https://github.com/apache/gravitino/pull/5897#discussion_r1889671792
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -811,6 +826,16 @@ private void handleFilesetCommand() {
}
}
+ p
justinmclean commented on code in PR #5897:
URL: https://github.com/apache/gravitino/pull/5897#discussion_r1889669976
##
clients/cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java:
##
@@ -30,6 +30,8 @@ public class ErrorMessages {
public static final String UNKNOWN
TungYuChiang commented on issue #5901:
URL: https://github.com/apache/gravitino/issues/5901#issuecomment-2550434040
Working on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
justinmclean commented on code in PR #5897:
URL: https://github.com/apache/gravitino/pull/5897#discussion_r1889670928
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -811,6 +826,16 @@ private void handleFilesetCommand() {
}
}
+ p
justinmclean commented on code in PR #5898:
URL: https://github.com/apache/gravitino/pull/5898#discussion_r1889675299
##
clients/cli/src/main/java/org/apache/gravitino/cli/Main.java:
##
@@ -72,7 +73,7 @@ protected static String resolveCommand(CommandLine line) {
if (args.le
justinmclean commented on code in PR #5898:
URL: https://github.com/apache/gravitino/pull/5898#discussion_r1889677028
##
clients/cli/src/main/java/org/apache/gravitino/cli/Main.java:
##
@@ -72,7 +73,7 @@ protected static String resolveCommand(CommandLine line) {
if (args.le
Abyss-lord commented on code in PR #5897:
URL: https://github.com/apache/gravitino/pull/5897#discussion_r1889680965
##
clients/cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java:
##
@@ -30,6 +30,8 @@ public class ErrorMessages {
public static final String UNKNOWN_T
justinmclean commented on issue #5861:
URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2549827556
You do not have to modify all subclasses. Remember, the CLI library does a
lot of the work for you before you get to this point, and there is no need to
check for things that
TungYuChiang opened a new issue, #5899:
URL: https://github.com/apache/gravitino/issues/5899
### Describe the proposal
Add tag relative event to event system.
### Task list
- [ ]
--
This is an automated message from the Apache Git Service.
To respond to the message, p
TungYuChiang opened a new issue, #5901:
URL: https://github.com/apache/gravitino/issues/5901
### Describe the subtask
1. add corresponding TagEvent
2. generate event in TagEventDispatcher
### Parent issue
#
--
This is an automated message from the Apache Git Service
xunliu merged PR #5847:
URL: https://github.com/apache/gravitino/pull/5847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino
xunliu closed issue #4309: [Subtask] Add event listener support for Tag system.
URL: https://github.com/apache/gravitino/issues/4309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
xunliu closed issue #4309: [Subtask] Add event listener support for Tag system.
URL: https://github.com/apache/gravitino/issues/4309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
This is an automated email from the ASF dual-hosted git repository.
liuxun pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new c727df5fe [#4309] feat(core): support tag events
xunliu closed issue #5881: [Subtask] Support Hive with SQL based auhtorization
test container
URL: https://github.com/apache/gravitino/issues/5881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
liuxun pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 92cf3c578 [#5881] test(authorization): Support Hi
xunliu closed issue #5881: [Subtask] Support Hive with SQL based auhtorization
test container
URL: https://github.com/apache/gravitino/issues/5881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
justinmclean merged PR #5893:
URL: https://github.com/apache/gravitino/pull/5893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gra
justinmclean closed issue #5824: [Improvement] Don't thow execption when table
name is unknown in Gravitino CLI command
URL: https://github.com/apache/gravitino/issues/5824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
justinmclean closed issue #5824: [Improvement] Don't thow execption when table
name is unknown in Gravitino CLI command
URL: https://github.com/apache/gravitino/issues/5824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
This is an automated email from the ASF dual-hosted git repository.
jmclean pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new e088c5574 [#5824] fix(CLI): Fix CLi throws an in
Abyss-lord commented on issue #5861:
URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2550067463
hi, @justinmclean Has the modification of the Command been completed?
Specifically, has the verify method been added, or is someone else currently
working on it? If not, could
xunliu merged PR #5882:
URL: https://github.com/apache/gravitino/pull/5882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino
justinmclean commented on PR #5783:
URL: https://github.com/apache/gravitino/pull/5783#issuecomment-2549992298
I've changed the command to use the role entity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
FANNG1 commented on code in PR #5868:
URL: https://github.com/apache/gravitino/pull/5868#discussion_r1889524277
##
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/store/GravitinoCatalogStore.java:
##
@@ -96,43 +105,56 @@ public boolean contains(String ca
FANNG1 commented on PR #5847:
URL: https://github.com/apache/gravitino/pull/5847#issuecomment-2550192471
LGTM, @TungYuChiang do you like to add tag event in this PR or create a new
PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
FANNG1 commented on code in PR #5868:
URL: https://github.com/apache/gravitino/pull/5868#discussion_r1889533431
##
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/catalog/BaseCatalogFactory.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Softwar
justinmclean commented on issue #5861:
URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2550242330
It needs to be reviewed before it can be merged, I can't review or merge it
as I wrote the code.
--
This is an automated message from the Apache Git Service.
To respond to t
Abyss-lord commented on issue #5861:
URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2550255024
> It needs to be reviewed before it can be merged, I can't review or merge
it as I wrote the code.
Got it. The modification of Command depends on #5793. This PR is highly
Abyss-lord commented on PR #5897:
URL: https://github.com/apache/gravitino/pull/5897#issuecomment-2550267626
hi @justinmclean @xunliu , Could you please take a look when you have time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Abyss-lord opened a new pull request, #5897:
URL: https://github.com/apache/gravitino/pull/5897
### What changes were proposed in this pull request?
Running the command gcli tag set --metalake metalake_demo or gcli tag remove
--metalake metalake_demo gives unexpected output.it
sunxiaojian commented on code in PR #5868:
URL: https://github.com/apache/gravitino/pull/5868#discussion_r1889570480
##
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/store/GravitinoCatalogStore.java:
##
@@ -96,43 +105,56 @@ public boolean contains(Stri
sunxiaojian commented on code in PR #5868:
URL: https://github.com/apache/gravitino/pull/5868#discussion_r1889572342
##
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/catalog/BaseCatalogFactory.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache So
Abyss-lord commented on issue #5853:
URL: https://github.com/apache/gravitino/issues/5853#issuecomment-2550272226
II would like to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Abyss-lord opened a new pull request, #5898:
URL: https://github.com/apache/gravitino/pull/5898
### What changes were proposed in this pull request?
Make the entity and arguments case-insensitive.
### Why are the changes needed?
Fix: #5853
### Does this PR
Abyss-lord commented on PR #5898:
URL: https://github.com/apache/gravitino/pull/5898#issuecomment-2550287682
hi @justinmclean @xunliu , Could you please take a look when you have time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
TungYuChiang commented on PR #5847:
URL: https://github.com/apache/gravitino/pull/5847#issuecomment-2550289706
@FANNG1 I prefer create a new PR, I will open a new issue and create a few
subtasks so that others can participate
--
This is an automated message from the Apache Git Servic
justinmclean commented on code in PR #5897:
URL: https://github.com/apache/gravitino/pull/5897#discussion_r1889692752
##
clients/cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java:
##
@@ -30,6 +30,8 @@ public class ErrorMessages {
public static final String UNKNOWN
FANNG1 commented on code in PR #5868:
URL: https://github.com/apache/gravitino/pull/5868#discussion_r1889691964
##
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/store/GravitinoCatalogStore.java:
##
@@ -96,43 +105,56 @@ public boolean contains(String ca
FANNG1 commented on code in PR #5868:
URL: https://github.com/apache/gravitino/pull/5868#discussion_r1889695868
##
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/store/GravitinoCatalogStore.java:
##
@@ -96,43 +105,60 @@ public boolean contains(String ca
1 - 100 of 120 matches
Mail list logo
