Re: [I] [Improvement] The Gravitino CLI shoudl show help if no arguments are passed [gravitino]

2024-12-10 Thread via GitHub
justinmclean commented on issue #5807: URL: https://github.com/apache/gravitino/issues/5807#issuecomment-2533468972 I'd go with the first one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] [Bug report] Gravitino trino-connector drop catalog will cause Trino Coordinator OOM [gravitino]

2024-12-10 Thread via GitHub
diqiu50 commented on issue #5804: URL: https://github.com/apache/gravitino/issues/5804#issuecomment-2533470563 This issue is caused by the resource release triggered by the Trino `DROP CATALOG` command. For more information, refer tohttps://trino.io/docs/current/admin/properties-catalog.htm

Re: [I] [Bug report] Gravitino trino-connector drop catalog will cause Trino Coordinator OOM [gravitino]

2024-12-10 Thread via GitHub
maomaodev commented on issue #5804: URL: https://github.com/apache/gravitino/issues/5804#issuecomment-2533471056 您好,我是毛立夫。 您的邮件已收到。 祝您生活愉快,身体健康! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] [Improvement] The Gravitino CLI shoudl show help if no arguments are passed [gravitino]

2024-12-10 Thread via GitHub
Abyss-lord commented on issue #5807: URL: https://github.com/apache/gravitino/issues/5807#issuecomment-2533480986 > I'd go with the first one Thank you Justin, I have submitted a PR,Could you please take a look when you have time? #5821 -- This is an automated message from the Apa

[PR] [#5807] improvement(CLI): Add functionality to display help information when no args are passed [gravitino]

2024-12-10 Thread via GitHub
Abyss-lord opened a new pull request, #5821: URL: https://github.com/apache/gravitino/pull/5821 ### What changes were proposed in this pull request? Add functionality to display help information when no arguments are passed. ### Why are the changes needed? Fix: #5

Re: [PR] [#5734] feat (gvfs-fuse): Gvfs-fuse basic FUSE-level implementation and code structure layout [gravitino]

2024-12-10 Thread via GitHub
mchades commented on code in PR #5738: URL: https://github.com/apache/gravitino/pull/5738#discussion_r1879218669 ## .github/workflows/gvfs-fuse-build-test.yml: ## @@ -0,0 +1,93 @@ +name: Build gvfs-fuse and testing + +# Controls when the workflow will run +on: + push: +bran

Re: [PR] [#5623] feat(python): supports credential API in python client [gravitino]

2024-12-10 Thread via GitHub
FANNG1 commented on PR #5777: URL: https://github.com/apache/gravitino/pull/5777#issuecomment-2533469002 @jerryshao @xloya , all comments are addressed, please help to review again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [I] [Subtask] Add e2e test case for creating schema [gravitino]

2024-12-10 Thread via GitHub
xunliu closed issue #5796: [Subtask] Add e2e test case for creating schema URL: https://github.com/apache/gravitino/issues/5796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] [Subtask] Add e2e test case for creating schema [gravitino]

2024-12-10 Thread via GitHub
xunliu closed issue #5796: [Subtask] Add e2e test case for creating schema URL: https://github.com/apache/gravitino/issues/5796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [#5796][#5798] Add e2e test case for creating schema/fileset/topic/table [gravitino]

2024-12-10 Thread via GitHub
xunliu merged PR #5805: URL: https://github.com/apache/gravitino/pull/5805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

(gravitino) branch main updated: [#5796][#5798] Add e2e test case for creating schema/fileset/topic/table (#5805)

2024-12-10 Thread liuxun
This is an automated email from the ASF dual-hosted git repository. liuxun pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 692dfb409 [#5796][#5798] Add e2e test case for cr

Re: [PR] [#5778] feat(aliyun-bundles)support OSS secret key credential [gravitino]

2024-12-10 Thread via GitHub
FANNG1 commented on code in PR #5814: URL: https://github.com/apache/gravitino/pull/5814#discussion_r1879221330 ## api/src/main/java/org/apache/gravitino/credential/OSSSecretKeyCredential.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [#3888] Metadata Support ClickHouse [gravitino]

2024-12-10 Thread via GitHub
flaming-archer commented on PR #5819: URL: https://github.com/apache/gravitino/pull/5819#issuecomment-2533506440 > Can we split this to a few smaller PRs? One PR with 5000+ lines changes in 38 files is too big to review. Among the 5000 lines, most of them are ck code, and most of them

Re: [PR] [#3888] Metadata Support ClickHouse [gravitino]

2024-12-10 Thread via GitHub
flaming-archer commented on code in PR #5819: URL: https://github.com/apache/gravitino/pull/5819#discussion_r1879251194 ## catalogs/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/converter/ClickHouseTypeConverter.java: ## @@ -0,0 +1,193 @@ +/* + *

Re: [PR] [#3888] Metadata Support ClickHouse [gravitino]

2024-12-10 Thread via GitHub
flaming-archer commented on code in PR #5819: URL: https://github.com/apache/gravitino/pull/5819#discussion_r1879253856 ## catalogs/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/converter/ClickHouseTypeConverter.java: ## @@ -0,0 +1,193 @@ +/* + *

Re: [PR] [#5602] feat(core): Add model storage schema layout (part-2) [gravitino]

2024-12-10 Thread via GitHub
jerryshao commented on code in PR #5728: URL: https://github.com/apache/gravitino/pull/5728#discussion_r1879260947 ## core/src/main/java/org/apache/gravitino/storage/relational/mapper/provider/base/ModelMetaBaseSQLProvider.java: ## @@ -134,4 +134,11 @@ public String deleteModelM

Re: [PR] [#5624] feat(bundles): support ADLS credential provider [gravitino]

2024-12-10 Thread via GitHub
FANNG1 commented on code in PR #5737: URL: https://github.com/apache/gravitino/pull/5737#discussion_r1879283913 ## common/src/main/java/org/apache/gravitino/credential/CredentialPropertyUtils.java: ## @@ -53,7 +54,9 @@ public class CredentialPropertyUtils { OSSTokenCr

Re: [PR] [#3888] Metadata Support ClickHouse [gravitino]

2024-12-10 Thread via GitHub
mchades commented on PR #5819: URL: https://github.com/apache/gravitino/pull/5819#issuecomment-2533563155 Hi @flaming-archer thanks a lot for your contribution. Since this is a big feature, would you please create a epic issue and break down things into small tasks, also it would be nice t

Re: [I] [Improvement] When a malformed name is passed to the CLI command to list columns in a table an exception occurs [gravitino]

2024-12-10 Thread via GitHub
justinmclean commented on issue #5808: URL: https://github.com/apache/gravitino/issues/5808#issuecomment-2533565969 Done. Feel free to add a comment saying you are working on an issue without me assigning it to you. I can assign it to you after you have started working on it. -- This is

Re: [PR] [#3888] Metadata Support ClickHouse [gravitino]

2024-12-10 Thread via GitHub
jerryshao commented on PR #5819: URL: https://github.com/apache/gravitino/pull/5819#issuecomment-2533566188 Hi @flaming-archer thanks a lot for your contribution, can we just break down into small subtasks, and start with a design doc? @mchades from the community will help you to get everyt

Re: [PR] [#5624] feat(bundles): support ADLS credential provider [gravitino]

2024-12-10 Thread via GitHub
FANNG1 commented on code in PR #5737: URL: https://github.com/apache/gravitino/pull/5737#discussion_r1879286069 ## iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java: ## @@ -78,7 +78,9 @@ public class IcebergCatalogWrapper imp

Re: [I] [Improvement] When a malformed name is passed to the CLI command to list columns in a table an exception occurs [gravitino]

2024-12-10 Thread via GitHub
Abyss-lord commented on issue #5808: URL: https://github.com/apache/gravitino/issues/5808#issuecomment-2533559910 Hi Justin, Could you please assign this issue to me? I would like to work on it. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [#5624] feat(bundles): support ADLS credential provider [gravitino]

2024-12-10 Thread via GitHub
FANNG1 commented on PR #5737: URL: https://github.com/apache/gravitino/pull/5737#issuecomment-2533569286 The main problem of the current implementation is passing Azure secret key not the token(token name is not correct) to the client side, The `StorageSharedKeyCredential` key problems exi

Re: [PR] [#5778] feat(aliyun-bundles)support OSS secret key credential [gravitino]

2024-12-10 Thread via GitHub
sunxiaojian commented on code in PR #5814: URL: https://github.com/apache/gravitino/pull/5814#discussion_r1879293167 ## api/src/main/java/org/apache/gravitino/credential/OSSSecretKeyCredential.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[PR] [Minor] Improve misisng name error message [gravitino]

2024-12-10 Thread via GitHub
justinmclean opened a new pull request, #5823: URL: https://github.com/apache/gravitino/pull/5823 ### What changes were proposed in this pull request? Explain to the user what is missing and how to fix it. ### Why are the changes needed? See above. Fix: # N/A

[I] [Improvement] Dropping a metalake via the Gravitino CLI gives an "in use" exception. [gravitino]

2024-12-10 Thread via GitHub
justinmclean opened a new issue, #5826: URL: https://github.com/apache/gravitino/issues/5826 ### What would you like to be improved? Looks like there has been some code changes around metalake being in use that make it difficult to drop a metalake. If you create a metalake called `my

(gravitino) branch main updated (692dfb409 -> 31d3b4a6c)

2024-12-10 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git from 692dfb409 [#5796][#5798] Add e2e test case for creating schema/fileset/topic/table (#5805) add 31d3b4a6c [#580

Re: [I] [Improvement] The Gravitino CLI shoudl show help if no arguments are passed [gravitino]

2024-12-10 Thread via GitHub
justinmclean closed issue #5807: [Improvement] The Gravitino CLI shoudl show help if no arguments are passed URL: https://github.com/apache/gravitino/issues/5807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [#5807] improvement(CLI): Add functionality to display help information when no args are passed [gravitino]

2024-12-10 Thread via GitHub
justinmclean merged PR #5821: URL: https://github.com/apache/gravitino/pull/5821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

Re: [I] [Improvement] The Gravitino CLI shoudl show help if no arguments are passed [gravitino]

2024-12-10 Thread via GitHub
justinmclean closed issue #5807: [Improvement] The Gravitino CLI shoudl show help if no arguments are passed URL: https://github.com/apache/gravitino/issues/5807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] [Improvement] Dropping a metalake via the Gravitino CLI gives an "in use" exception. [gravitino]

2024-12-10 Thread via GitHub
justinmclean commented on issue #5826: URL: https://github.com/apache/gravitino/issues/5826#issuecomment-2533608170 A similar error occurs when deleting catalogs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [Subtask] Support distributions expression [gravitino]

2024-12-10 Thread via GitHub
SophieTech88 commented on issue #5729: URL: https://github.com/apache/gravitino/issues/5729#issuecomment-2533622965 Can I work on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] [Subtask] Support sorts expression [gravitino]

2024-12-10 Thread via GitHub
SophieTech88 commented on issue #5730: URL: https://github.com/apache/gravitino/issues/5730#issuecomment-2533623035 Can I work on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] [Subtask] Support transforms expression [gravitino]

2024-12-10 Thread via GitHub
SophieTech88 commented on issue #5732: URL: https://github.com/apache/gravitino/issues/5732#issuecomment-2533623113 Can I work on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [#5745] feat(CLI): Table format output for ListCatalogs command [gravitino]

2024-12-10 Thread via GitHub
waukin commented on code in PR #5759: URL: https://github.com/apache/gravitino/pull/5759#discussion_r1879329596 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -159,17 +159,18 @@ private void handleMetalakeCommand() { FullName name = n

[I] [Improvement] Missing tag name in creating Gravitino CLI command gives an excpetion. [gravitino]

2024-12-10 Thread via GitHub
justinmclean opened a new issue, #5830: URL: https://github.com/apache/gravitino/issues/5830 ### What would you like to be improved? Running the command `gcli tag create --metalake metalake_demo` gives an exception. The same happens for `gcli tag details --metalake metalake_demo` and

Re: [I] [Improvement] Creating a role in the Gravitino CLi with a missing role name give an unexpected error [gravitino]

2024-12-10 Thread via GitHub
justinmclean commented on issue #5832: URL: https://github.com/apache/gravitino/issues/5832#issuecomment-2533649447 Note the error is saying that the name of the of the role is empty so it not incorrect it's just not user-friendly. -- This is an automated message from the Apache Git Servi

Re: [I] [Improvement] Slightly missing leading error message when user is not specified in Gravitino CLI [gravitino]

2024-12-10 Thread via GitHub
justinmclean commented on issue #5828: URL: https://github.com/apache/gravitino/issues/5828#issuecomment-2533652492 Note the error is saying that the name of the of the user is empty so it not incorrect it's just not user-friendly. -- This is an automated message from the Apache Git Servi

Re: [PR] [#5745] feat(CLI): Table format output for ListCatalogs command [gravitino]

2024-12-10 Thread via GitHub
justinmclean commented on code in PR #5759: URL: https://github.com/apache/gravitino/pull/5759#discussion_r1879358547 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -159,17 +159,18 @@ private void handleMetalakeCommand() { FullName na

Re: [PR] [#5602] feat(core): Add model storage schema layout (part-2) [gravitino]

2024-12-10 Thread via GitHub
yuqi1129 commented on code in PR #5728: URL: https://github.com/apache/gravitino/pull/5728#discussion_r1878121178 ## core/src/main/java/org/apache/gravitino/storage/relational/service/ModelVersionMetaService.java: ## @@ -0,0 +1,288 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] [#5745] feat(CLI): Table format output for ListCatalogs command [gravitino]

2024-12-10 Thread via GitHub
justinmclean commented on code in PR #5759: URL: https://github.com/apache/gravitino/pull/5759#discussion_r1878824511 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/CatalogDetails.java: ## @@ -35,14 +36,17 @@ public class CatalogDetails extends Command { *

Re: [PR] [#5745] feat(CLI): Table format output for ListCatalogs command [gravitino]

2024-12-10 Thread via GitHub
justinmclean commented on code in PR #5759: URL: https://github.com/apache/gravitino/pull/5759#discussion_r1878833785 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListCatalogs.java: ## @@ -35,29 +36,26 @@ public class ListCatalogs extends Command { * @param

Re: [PR] [#5569] improvement(CLI): Add ability to grant or revoke multiple roles or groups at once in the Gravitino CLI [gravitino]

2024-12-10 Thread via GitHub
justinmclean merged PR #5811: URL: https://github.com/apache/gravitino/pull/5811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

(gravitino) branch main updated: [#5569] improvement(CLI): Add ability to grant or revoke multiple roles or groups at once in the Gravitino CLI (#5811)

2024-12-10 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 5bc8fefe3 [#5569] improvement(CLI): Add ability

Re: [PR] feat(helm-chart): remove helm-chart support [gravitino-playground]

2024-12-10 Thread via GitHub
unknowntpo commented on code in PR #110: URL: https://github.com/apache/gravitino-playground/pull/110#discussion_r1871447104 ## healthcheck/gravitino-healthcheck.sh: ## @@ -23,10 +23,8 @@ max_attempts=3 attempt=0 success=false -HOST_IP=${GRAVITINO_HOST_IP:-localhost} - whi

Re: [PR] feat(helm-chart): remove helm-chart support [gravitino-playground]

2024-12-10 Thread via GitHub
unknowntpo commented on code in PR #110: URL: https://github.com/apache/gravitino-playground/pull/110#discussion_r1879147916 ## init/hive/init.sh: ## @@ -21,7 +21,6 @@ sed -i '$d' /usr/local/sbin/start.sh sed -i '$d' /usr/local/sbin/start.sh cp /tmp/hive/core-site.xml /tmp/h

Re: [PR] feat(helm-chart): remove helm-chart support [gravitino-playground]

2024-12-10 Thread via GitHub
unknowntpo commented on code in PR #110: URL: https://github.com/apache/gravitino-playground/pull/110#discussion_r1879147916 ## init/hive/init.sh: ## @@ -21,7 +21,6 @@ sed -i '$d' /usr/local/sbin/start.sh sed -i '$d' /usr/local/sbin/start.sh cp /tmp/hive/core-site.xml /tmp/h

Re: [PR] feat(helm-chart): remove helm-chart support [gravitino-playground]

2024-12-10 Thread via GitHub
unknowntpo commented on code in PR #110: URL: https://github.com/apache/gravitino-playground/pull/110#discussion_r1879148347 ## init/hive/init.sh: ## @@ -21,7 +21,6 @@ sed -i '$d' /usr/local/sbin/start.sh sed -i '$d' /usr/local/sbin/start.sh Review Comment: I changed it t

Re: [PR] feat(helm-chart): remove helm-chart support [gravitino-playground]

2024-12-10 Thread via GitHub
unknowntpo commented on code in PR #110: URL: https://github.com/apache/gravitino-playground/pull/110#discussion_r1871447898 ## healthcheck/trino-healthcheck.sh: ## @@ -20,7 +20,7 @@ set -ex # Because trino-connector must first synchronize a default metalake from the Gravi

Re: [PR] [#3888] Metadata Support ClickHouse [gravitino]

2024-12-10 Thread via GitHub
flaming-archer commented on code in PR #5819: URL: https://github.com/apache/gravitino/pull/5819#discussion_r1879258818 ## catalogs/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/operation/ClickHouseDatabaseOperations.java: ## @@ -0,0 +1,95 @@ +/*

Re: [PR] [#5685] Change main command section of Gravitino CLI to use switch statements [gravitino]

2024-12-10 Thread via GitHub
tengqm commented on code in PR #5793: URL: https://github.com/apache/gravitino/pull/5793#discussion_r1879129401 ## api/src/main/java/org/apache/gravitino/SupportsCatalogs.java: ## @@ -98,6 +101,23 @@ Catalog createCatalog( Map properties) throws NoSuchMetalakeExcep

Re: [PR] [#5745] feat(CLI): Table format output for ListCatalogs command [gravitino]

2024-12-10 Thread via GitHub
justinmclean commented on code in PR #5759: URL: https://github.com/apache/gravitino/pull/5759#discussion_r1878816436 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -208,11 +209,12 @@ private void handleCatalogCommand() { FullName nam

Re: [PR] [#5602] feat(core): Add model storage schema layout (part-2) [gravitino]

2024-12-10 Thread via GitHub
jerryshao commented on code in PR #5728: URL: https://github.com/apache/gravitino/pull/5728#discussion_r1879217367 ## core/src/main/java/org/apache/gravitino/storage/relational/service/ModelVersionMetaService.java: ## @@ -0,0 +1,288 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] [#5734] feat (gvfs-fuse): Gvfs-fuse basic FUSE-level implementation and code structure layout [gravitino]

2024-12-10 Thread via GitHub
mchades commented on code in PR #5738: URL: https://github.com/apache/gravitino/pull/5738#discussion_r1879218669 ## .github/workflows/gvfs-fuse-build-test.yml: ## @@ -0,0 +1,93 @@ +name: Build gvfs-fuse and testing + +# Controls when the workflow will run +on: + push: +bran

Re: [PR] [#5623] feat(python): supports credential API in python client [gravitino]

2024-12-10 Thread via GitHub
FANNG1 commented on code in PR #5777: URL: https://github.com/apache/gravitino/pull/5777#discussion_r1879219353 ## clients/client-python/gravitino/dto/responses/credential_response.py: ## @@ -0,0 +1,44 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more c

Re: [PR] [#5623] feat(python): supports credential API in python client [gravitino]

2024-12-10 Thread via GitHub
FANNG1 commented on code in PR #5777: URL: https://github.com/apache/gravitino/pull/5777#discussion_r1879218498 ## clients/client-python/gravitino/client/metadata_object_credential_operations.py: ## @@ -0,0 +1,67 @@ +# Licensed to the Apache Software Foundation (ASF) under one +

[I] [Improvement] Improve error message for missing role name in the "gcli role create" command. [gravitino]

2024-12-10 Thread via GitHub
Gurleen12star opened a new issue, #5834: URL: https://github.com/apache/gravitino/issues/5834 ### What would you like to be improved? Currently, when the gcli role create command is run without specifying a role name, the error message shown is vague and does not directly indicate the

Re: [PR] [#5729]feat(client-python): Update the distribution expression in python [gravitino]

2024-12-10 Thread via GitHub
tengqm commented on code in PR #5833: URL: https://github.com/apache/gravitino/pull/5833#discussion_r1879474574 ## clients/client-python/gravitino/api/expressions/distributions/distribution.py: ## @@ -0,0 +1,58 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

Re: [PR] [#3888] Metadata Support ClickHouse [gravitino]

2024-12-10 Thread via GitHub
tengqm commented on code in PR #5819: URL: https://github.com/apache/gravitino/pull/5819#discussion_r1879481898 ## catalogs/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/converter/ClickHouseTypeConverter.java: ## @@ -0,0 +1,193 @@ +/* + * Licensed

Re: [PR] [#5602] feat(core): Add model storage schema layout (part-2) [gravitino]

2024-12-10 Thread via GitHub
jerryshao commented on code in PR #5728: URL: https://github.com/apache/gravitino/pull/5728#discussion_r1879486425 ## core/src/main/java/org/apache/gravitino/storage/relational/service/ModelVersionMetaService.java: ## @@ -0,0 +1,278 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] [#5790] feat(core): Wildcard properties meta [gravitino]

2024-12-10 Thread via GitHub
mchades commented on code in PR #5791: URL: https://github.com/apache/gravitino/pull/5791#discussion_r1879492612 ## core/src/main/java/org/apache/gravitino/connector/WildcardPropertiesMetadata.java: ## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] [#5790] feat(core): Wildcard properties meta [gravitino]

2024-12-10 Thread via GitHub
mchades commented on code in PR #5791: URL: https://github.com/apache/gravitino/pull/5791#discussion_r1879506799 ## core/src/main/java/org/apache/gravitino/connector/WildcardPropertiesMetadata.java: ## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] [#5602] feat(core): Add model storage schema layout (part-2) [gravitino]

2024-12-10 Thread via GitHub
jerryshao commented on code in PR #5728: URL: https://github.com/apache/gravitino/pull/5728#discussion_r1879506711 ## core/src/main/java/org/apache/gravitino/storage/relational/mapper/provider/base/ModelMetaBaseSQLProvider.java: ## @@ -134,4 +134,11 @@ public String deleteModelM

[PR] Clickhouse 0.7 forpr [gravitino]

2024-12-10 Thread via GitHub
flaming-archer opened a new pull request, #5819: URL: https://github.com/apache/gravitino/pull/5819 ### Title 1. [#3888] feat(operator): support clickhouse" ### What changes were proposed in this pull request? Support clickhouse as a metadata. ### Why are the chan

Re: [PR] [#3888] Metadata Support ClickHouse [gravitino]

2024-12-10 Thread via GitHub
flaming-archer commented on PR #5819: URL: https://github.com/apache/gravitino/pull/5819#issuecomment-2532581924 @shaofengshi @xunliu Pls help to review this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [Bug report] The API for creating an Iceberg catalog has a deprecated parameter "warehouse" that is required in the HTTP payload [gravitino]

2024-12-10 Thread via GitHub
liuchunhao commented on issue #5756: URL: https://github.com/apache/gravitino/issues/5756#issuecomment-2531673638 Sure, I'd be happy to handle it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] [Improvement] Update Hadoop version from 3.1 to 3.3 to make fileset catalog up-to-date [gravitino]

2024-12-10 Thread via GitHub
yuqi1129 closed issue #5532: [Improvement] Update Hadoop version from 3.1 to 3.3 to make fileset catalog up-to-date URL: https://github.com/apache/gravitino/issues/5532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] [Improvement] Update Hadoop version from 3.1 to 3.3 to make fileset catalog up-to-date [gravitino]

2024-12-10 Thread via GitHub
yuqi1129 commented on issue #5532: URL: https://github.com/apache/gravitino/issues/5532#issuecomment-2531698064 Close it as it has been fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

2024-12-10 Thread via GitHub
yuqi1129 commented on PR #5645: URL: https://github.com/apache/gravitino/pull/5645#issuecomment-2531560854 Merge it into main, @pithecuse527 Thanks for your hard work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [#5790] feat(core): Wildcard properties meta [gravitino]

2024-12-10 Thread via GitHub
xunliu commented on code in PR #5791: URL: https://github.com/apache/gravitino/pull/5791#discussion_r1877586827 ## core/src/main/java/org/apache/gravitino/authorization/AuthorizationPropertiesMetadata.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [#5569] improvement(CLI): Add ability to grant or revoke multiple roles or groups at once in the Gravitino CLI [gravitino]

2024-12-10 Thread via GitHub
justinmclean commented on code in PR #5811: URL: https://github.com/apache/gravitino/pull/5811#discussion_r1877588930 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java: ## @@ -100,12 +100,12 @@ public Options options() { options.addOption(createArg

Re: [PR] [#5569] improvement(CLI): Add ability to grant or revoke multiple roles or groups at once in the Gravitino CLI [gravitino]

2024-12-10 Thread via GitHub
justinmclean commented on code in PR #5811: URL: https://github.com/apache/gravitino/pull/5811#discussion_r1877671578 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java: ## @@ -100,12 +100,12 @@ public Options options() { options.addOption(createArg

Re: [PR] [#5569] improvement(CLI): Add ability to grant or revoke multiple roles or groups at once in the Gravitino CLI [gravitino]

2024-12-10 Thread via GitHub
Abyss-lord commented on code in PR #5811: URL: https://github.com/apache/gravitino/pull/5811#discussion_r1877702909 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java: ## @@ -100,12 +100,12 @@ public Options options() { options.addOption(createArgOp

Re: [PR] [#5734] feat (gvfs-fuse): Gvfs-fuse basic FUSE-level implementation and code structure layout [gravitino]

2024-12-10 Thread via GitHub
diqiu50 commented on code in PR #5738: URL: https://github.com/apache/gravitino/pull/5738#discussion_r1877717481 ## .github/workflows/gvfs-fuse-build-test.yml: ## @@ -0,0 +1,93 @@ +name: Build gvfs-fuse and testing + +# Controls when the workflow will run +on: + push: +bran

[PR] [#5778] feat(aliyun-bundles)support OSS secret key credential [gravitino]

2024-12-10 Thread via GitHub
sunxiaojian opened a new pull request, #5814: URL: https://github.com/apache/gravitino/pull/5814 ### What changes were proposed in this pull request? Support OSS secret key credential ### Why are the changes needed? Fix: [# (5778)](https://github.com/apache/gravitino/

Re: [I] [Improvement] OB-Catalog(WebUI): missing column data types [gravitino]

2024-12-10 Thread via GitHub
mchades commented on issue #5815: URL: https://github.com/apache/gravitino/issues/5815#issuecomment-2531243720 @LauraXia123 cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[I] [Improvement] OB-Catalog(WebUI): missing column data types [gravitino]

2024-12-10 Thread via GitHub
mchades opened a new issue, #5815: URL: https://github.com/apache/gravitino/issues/5815 ### What would you like to be improved? cannot create a ob table through web UI since: https://github.com/user-attachments/assets/e3d80946-7291-41ec-af78-7db50c221d08";> ### How should

Re: [PR] [#5790] feat(core): Wildcard properties meta [gravitino]

2024-12-10 Thread via GitHub
xunliu commented on PR #5791: URL: https://github.com/apache/gravitino/pull/5791#issuecomment-2531121435 @mchades I fixed all the problems, please help me review it again. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] [Bug report] http client out of time [gravitino]

2024-12-10 Thread via GitHub
an-shi-chi-fan commented on issue #5765: URL: https://github.com/apache/gravitino/issues/5765#issuecomment-2530876699 > may yes, it is. i found error log in hms -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] [#5815] fix(web): config oceanbase column types [gravitino]

2024-12-10 Thread via GitHub
LauraXia123 opened a new pull request, #5816: URL: https://github.com/apache/gravitino/pull/5816 ### What changes were proposed in this pull request? config oceanbase column types ### Why are the changes needed? N/A Fix: #5815 ### Does this PR introduce _any

Re: [PR] [MINOR] docs: fix typo in catalog.management exception message [gravitino]

2024-12-10 Thread via GitHub
diqiu50 merged PR #5812: URL: https://github.com/apache/gravitino/pull/5812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitin

(gravitino) branch main updated: [MINOR] docs: fix typo in catalog.management exception message (#5812)

2024-12-10 Thread diqiu50
This is an automated email from the ASF dual-hosted git repository. diqiu50 pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 53500a637 [MINOR] docs: fix typo in catalog.mana

Re: [PR] [#5569] improvement(CLI): Add ability to grant or revoke multiple roles or groups at once in the Gravitino CLI [gravitino]

2024-12-10 Thread via GitHub
Abyss-lord commented on code in PR #5811: URL: https://github.com/apache/gravitino/pull/5811#discussion_r1877626347 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java: ## @@ -100,12 +100,12 @@ public Options options() { options.addOption(createArgOp

Re: [PR] [#5815] fix(web): config oceanbase column types [gravitino]

2024-12-10 Thread via GitHub
mchades merged PR #5816: URL: https://github.com/apache/gravitino/pull/5816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitin

Re: [PR] [#5602] feat(core): Add model storage schema layout (part-2) [gravitino]

2024-12-10 Thread via GitHub
xloya commented on code in PR #5728: URL: https://github.com/apache/gravitino/pull/5728#discussion_r1877941961 ## core/src/main/java/org/apache/gravitino/storage/relational/service/ModelVersionMetaService.java: ## @@ -0,0 +1,288 @@ +/* + * Licensed to the Apache Software Foundat

Re: [I] [Improvement] OB-Catalog(WebUI): missing column data types [gravitino]

2024-12-10 Thread via GitHub
mchades closed issue #5815: [Improvement] OB-Catalog(WebUI): missing column data types URL: https://github.com/apache/gravitino/issues/5815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] [Improvement] OB-Catalog(WebUI): missing column data types [gravitino]

2024-12-10 Thread via GitHub
mchades closed issue #5815: [Improvement] OB-Catalog(WebUI): missing column data types URL: https://github.com/apache/gravitino/issues/5815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

(gravitino) branch main updated: [#5815] fix(web): config oceanbase column types (#5816)

2024-12-10 Thread mchades
This is an automated email from the ASF dual-hosted git repository. mchades pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 8fa24a475 [#5815] fix(web): config oceanbase col

Re: [I] [Subtask] [flink-connector] Support iceberg catalog [gravitino]

2024-12-10 Thread via GitHub
sunxiaojian commented on issue #3515: URL: https://github.com/apache/gravitino/issues/3515#issuecomment-2531311183 @coolderli @xunliu please assign it to me, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[PR] [MINOR] docs: fix typo in catalog.management exception message [gravitino]

2024-12-10 Thread via GitHub
predator4ann opened a new pull request, #5812: URL: https://github.com/apache/gravitino/pull/5812 ### What changes were proposed in this pull request? The exception message should be `catalog.management = dynamic` when the trino configuration is incorrect. ### Why are the changes n

Re: [PR] [#5760][#5780] fix(catalog): fix drop catalog error [gravitino]

2024-12-10 Thread via GitHub
mchades commented on code in PR #5761: URL: https://github.com/apache/gravitino/pull/5761#discussion_r1877646142 ## core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java: ## @@ -677,11 +678,70 @@ public boolean dropCatalog(NameIdentifier ident, boolean force)

Re: [I] [Bug report] http client out of time [gravitino]

2024-12-10 Thread via GitHub
an-shi-chi-fan commented on issue #5765: URL: https://github.com/apache/gravitino/issues/5765#issuecomment-2530879552 thanks @mchades @FANNG1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] [Bug report] http client out of time [gravitino]

2024-12-10 Thread via GitHub
an-shi-chi-fan commented on issue #5765: URL: https://github.com/apache/gravitino/issues/5765#issuecomment-2530882791 hive metastore service time out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] [Bug report] http client out of time [gravitino]

2024-12-10 Thread via GitHub
an-shi-chi-fan closed issue #5765: [Bug report] http client out of time URL: https://github.com/apache/gravitino/issues/5765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [#5623] feat(python): supports credential API in python client [gravitino]

2024-12-10 Thread via GitHub
xloya commented on code in PR #5777: URL: https://github.com/apache/gravitino/pull/5777#discussion_r1877973226 ## clients/client-python/gravitino/dto/responses/credential_response.py: ## @@ -0,0 +1,44 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more co

Re: [PR] [#5734] feat (gvfs-fuse): Gvfs-fuse basic FUSE-level implementation and code structure layout [gravitino]

2024-12-10 Thread via GitHub
xunliu commented on code in PR #5738: URL: https://github.com/apache/gravitino/pull/5738#discussion_r1878030592 ## clients/filesystem-fuse/src/fuse_api_handle.rs: ## @@ -0,0 +1,437 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor lice

[PR] [#5192] [Feature] Support Catalog Operation DDL for paimon-catalog [gravitino]

2024-12-10 Thread via GitHub
hdygxsj opened a new pull request, #5818: URL: https://github.com/apache/gravitino/pull/5818 ### What changes were proposed in this pull request? Support Catalog Operation DDL for paimon-catalog ### Why are the changes needed? close #5192 ### Does this PR i

Re: [I] [Improvement] Remove `RocksDBKvBackend` and related code & dependencies from code base. [gravitino]

2024-12-10 Thread via GitHub
yuqi1129 closed issue #5633: [Improvement] Remove `RocksDBKvBackend` and related code & dependencies from code base. URL: https://github.com/apache/gravitino/issues/5633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

2024-12-10 Thread via GitHub
yuqi1129 merged PR #5645: URL: https://github.com/apache/gravitino/pull/5645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graviti

Re: [PR] [#5734] feat (gvfs-fuse): Gvfs-fuse basic FUSE-level implementation and code structure layout [gravitino]

2024-12-10 Thread via GitHub
diqiu50 commented on code in PR #5738: URL: https://github.com/apache/gravitino/pull/5738#discussion_r1878050265 ## clients/filesystem-fuse/src/fuse_api_handle.rs: ## @@ -0,0 +1,437 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor lic

  1   2   >