FANNG1 commented on code in PR #5737:
URL: https://github.com/apache/gravitino/pull/5737#discussion_r1879286069


##########
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java:
##########
@@ -78,7 +78,9 @@ public class IcebergCatalogWrapper implements AutoCloseable {
           IcebergConstants.ICEBERG_S3_ENDPOINT,
           IcebergConstants.ICEBERG_OSS_ENDPOINT,
           IcebergConstants.ICEBERG_OSS_ACCESS_KEY_ID,
-          IcebergConstants.ICEBERG_OSS_ACCESS_KEY_SECRET);
+          IcebergConstants.ICEBERG_OSS_ACCESS_KEY_SECRET,

Review Comment:
   please remove `ICEBERG_ADLS_STORAGE_ACCOUNT_NAME ` and 
`ICEBERG_ADLS_STORAGE_ACCOUNT_KEY ` , or the client Iceberg will use the above 
static secret keys.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to