FANNG1 commented on code in PR #4563:
URL: https://github.com/apache/gravitino/pull/4563#discussion_r1721300638
##
iceberg/iceberg-common/src/test/java/org/apache/gravitino/iceberg/common/utils/TestIcebergCatalogUtil.java:
##
@@ -78,4 +78,52 @@ void testLoadCatalog() {
FANNG1 commented on PR #4563:
URL: https://github.com/apache/gravitino/pull/4563#issuecomment-2295814583
Do you think is it necessary to support a custom catalog for the Gravitino
Iceberg catalog not only for the Iceberg REST service?
--
This is an automated message from the Apache Git Se
featherchen opened a new pull request, #4577:
URL: https://github.com/apache/gravitino/pull/4577
### What changes were proposed in this pull request?
Hide jdbc-password value in details page.
### Why are the changes needed?
Fix: #4506
### Does this PR intr
featherchen commented on PR #4561:
URL: https://github.com/apache/gravitino/pull/4561#issuecomment-2295824010
> @featherchen the auto cherry-pick action is failed for this PR
(https://github.com/apache/gravitino/actions/runs/10446609068). Would you
please cherry-pick the commit to "branch-0
theoryxu commented on code in PR #4563:
URL: https://github.com/apache/gravitino/pull/4563#discussion_r1721309322
##
iceberg/iceberg-common/src/test/java/org/apache/gravitino/iceberg/common/utils/TestIcebergCatalogUtil.java:
##
@@ -78,4 +78,52 @@ void testLoadCatalog() {
yuqi1129 commented on code in PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#discussion_r1721304932
##
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationPlugin.java:
##
@@ -0,0 +1,1023 @@
+/*
+ * Licensed
jerqi opened a new pull request, #4578:
URL: https://github.com/apache/gravitino/pull/4578
### What changes were proposed in this pull request?
Add the document for 0.6.0
### Why are the changes needed?
(Please clarify why the changes are needed. For instance,
1. If
justinmclean commented on issue #2738:
URL: https://github.com/apache/gravitino/issues/2738#issuecomment-2295835915
0.6.0 should be released in the next couple of weeks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
yuqi1129 commented on PR #4578:
URL: https://github.com/apache/gravitino/pull/4578#issuecomment-2295836284
This PR seems to be duplicated with #4523.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jerryshao opened a new pull request, #4579:
URL: https://github.com/apache/gravitino/pull/4579
### What changes were proposed in this pull request?
This PR proposes to add a missing tag openapi to list all the metadata
objects for a tag.
### Why are the changes needed?
T
theoryxu commented on PR #4563:
URL: https://github.com/apache/gravitino/pull/4563#issuecomment-2295839733
> Do you think is it necessary to support a custom catalog for the Gravitino
Iceberg catalog not only for the Iceberg REST service?
I want to keep a PR as simple as possible. May
jerqi commented on code in PR #4579:
URL: https://github.com/apache/gravitino/pull/4579#discussion_r1721318596
##
docs/open-api/catalogs.yaml:
##
@@ -256,8 +256,10 @@ components:
enum:
- hive
- lakehouse-iceberg
+- lakehouse-paimo
jerqi commented on PR #4578:
URL: https://github.com/apache/gravitino/pull/4578#issuecomment-2295846733
> This PR seems to be duplicated with #4523.
If you add the document about 0.6.0, I can close this.
--
This is an automated message from the Apache Git Service.
To respond to the
jerqi closed pull request #4578: [#4573] docs(docker): Add the document for
0.6.0
URL: https://github.com/apache/gravitino/pull/4578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
jerqi commented on code in PR #4523:
URL: https://github.com/apache/gravitino/pull/4523#discussion_r1721337994
##
docs/docker-image-details.md:
##
@@ -82,23 +83,22 @@ Changelog
Changelog
-- trino:435-gravitino-0.5.1
- - Based on Gravitino 0.5.1, you can know more informati
jerqi commented on code in PR #4523:
URL: https://github.com/apache/gravitino/pull/4523#discussion_r1721342532
##
docs/docker-image-details.md:
##
@@ -112,28 +112,32 @@ You can use these kinds of Docker images to facilitate
integration testing of al
You can use this kind of im
jerqi commented on PR #4523:
URL: https://github.com/apache/gravitino/pull/4523#issuecomment-2295885090
After you release the images, you should update the playground, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
mchades commented on code in PR #4579:
URL: https://github.com/apache/gravitino/pull/4579#discussion_r1721349531
##
docs/open-api/tags.yaml:
##
@@ -284,6 +284,41 @@ paths:
"5xx":
$ref: "./openapi.yaml#/components/responses/ServerErrorResponse"
+
+ /metalak
FANNG1 commented on code in PR #65:
URL:
https://github.com/apache/gravitino-playground/pull/65#discussion_r1721351128
##
docker-compose.yaml:
##
@@ -22,9 +22,9 @@ services:
image: datastrato/hive:2.7.3-no-yarn
ports:
- "3307:3306"
- - "9000:9000"
- -
jerryshao merged PR #65:
URL: https://github.com/apache/gravitino-playground/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
This is an automated email from the ASF dual-hosted git repository.
jshao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino-playground.git
The following commit(s) were added to refs/heads/main by this push:
new fd68dd2 [Enhancement] Change exposed p
jerryshao commented on code in PR #65:
URL:
https://github.com/apache/gravitino-playground/pull/65#discussion_r1721354332
##
docker-compose.yaml:
##
@@ -22,9 +22,9 @@ services:
image: datastrato/hive:2.7.3-no-yarn
ports:
- "3307:3306"
- - "9000:9000"
-
This is an automated email from the ASF dual-hosted git repository.
yuqi4733 pushed a change to branch branch-0.5
in repository https://gitbox.apache.org/repos/asf/gravitino-playground.git
at fd68dd2 [Enhancement] Change exposed ports to avoid possible
conflicts (#65)
No new revisions w
yuqi1129 commented on code in PR #4523:
URL: https://github.com/apache/gravitino/pull/4523#discussion_r1721359537
##
docs/docker-image-details.md:
##
@@ -112,28 +112,32 @@ You can use these kinds of Docker images to facilitate
integration testing of al
You can use this kind of
yuqi1129 commented on code in PR #4523:
URL: https://github.com/apache/gravitino/pull/4523#discussion_r1721360446
##
docs/docker-image-details.md:
##
@@ -82,23 +83,22 @@ Changelog
Changelog
-- trino:435-gravitino-0.5.1
- - Based on Gravitino 0.5.1, you can know more inform
shaofengshi commented on code in PR #65:
URL:
https://github.com/apache/gravitino-playground/pull/65#discussion_r1721362662
##
docker-compose.yaml:
##
@@ -22,9 +22,9 @@ services:
image: datastrato/hive:2.7.3-no-yarn
ports:
- "3307:3306"
- - "9000:9000"
-
xunliu closed pull request #4461: [#4460] feat(core): Add the method call of
the authorizationPlugin
URL: https://github.com/apache/gravitino/pull/4461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
coolderli commented on issue #4558:
URL: https://github.com/apache/gravitino/issues/4558#issuecomment-2296027918
@jerryshao @shaofengshi @xunliu Can you share your thoughts？Thanks. cc
@xloya @YxAc @zhoukangcn
--
This is an automated message from the Apache Git Service.
To respond to the
theoryxu commented on PR #4563:
URL: https://github.com/apache/gravitino/pull/4563#issuecomment-2296045350
> Do you think is it necessary to support a custom catalog for the Gravitino
Iceberg catalog not only for the Iceberg REST service?
I planned to do it in a separate PR to keep th
theoryxu commented on issue #4581:
URL: https://github.com/apache/gravitino/issues/4581#issuecomment-2296070846
I can take it; please assign it to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
jshao pushed a commit to branch branch-0.6
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/branch-0.6 by this push:
new 7875ba629 [#4506] fix(UI): Hide jdbc-p
jerryshao merged PR #4579:
URL: https://github.com/apache/gravitino/pull/4579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravit
This is an automated email from the ASF dual-hosted git repository.
jshao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new ab20382ff [MINOR] fix(doc): Add missing tag api in
jerryshao merged PR #4577:
URL: https://github.com/apache/gravitino/pull/4577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravit
jerqi commented on issue #60:
URL:
https://github.com/apache/gravitino-playground/issues/60#issuecomment-2296074137
You should close this issue because the pull request is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
shaofengshi opened a new issue, #4582:
URL: https://github.com/apache/gravitino/issues/4582
### Version
main branch
### Describe what's wrong
Firstly, create a hadoop catalog, for example:
`curl -X POST -H "Accept: application/vnd.gravitino.v1+json" \
-H "Conten
FANNG1 commented on issue #4581:
URL: https://github.com/apache/gravitino/issues/4581#issuecomment-2296087436
> I can take it; please assign it to me.
Thanks @theoryxu for taking this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
FANNG1 commented on PR #4563:
URL: https://github.com/apache/gravitino/pull/4563#issuecomment-2296091808
> > Do you think is it necessary to support a custom catalog for the
Gravitino Iceberg catalog not only for the Iceberg REST service?
>
> I planned to do it in a separate PR to kee
FANNG1 commented on code in PR #4563:
URL: https://github.com/apache/gravitino/pull/4563#discussion_r1721479495
##
docs/iceberg-rest-service.md:
##
@@ -162,6 +162,14 @@ If you have a JDBC Iceberg catalog prior, you must set
`catalog-backend-name` to
You must download the corre
FANNG1 commented on PR #4563:
URL: https://github.com/apache/gravitino/pull/4563#issuecomment-2296098394
LGTM, except one comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
jerqi commented on PR #45:
URL:
https://github.com/apache/gravitino-playground/pull/45#issuecomment-2296099930
You should submit the document to the main repo, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jerqi commented on PR #52:
URL:
https://github.com/apache/gravitino-playground/pull/52#issuecomment-2296103111
Do you need to update the version of python client?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
theoryxu commented on PR #4563:
URL: https://github.com/apache/gravitino/pull/4563#issuecomment-2296111724
> > > Do you think is it necessary to support a custom catalog for the
Gravitino Iceberg catalog not only for the Iceberg REST service?
> >
> >
> > I planned to do it in a se
mchades commented on issue #4583:
URL: https://github.com/apache/gravitino/issues/4583#issuecomment-2296115518
@yuqi1129 @xunliu @jerryshao @FANNG1 WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
theoryxu commented on code in PR #4563:
URL: https://github.com/apache/gravitino/pull/4563#discussion_r1721494030
##
docs/iceberg-rest-service.md:
##
@@ -162,6 +162,14 @@ If you have a JDBC Iceberg catalog prior, you must set
`catalog-backend-name` to
You must download the cor
jerryshao opened a new pull request, #4585:
URL: https://github.com/apache/gravitino/pull/4585
### What changes were proposed in this pull request?
This PR proposes to add a missing tag openapi to list all the metadata
objects for a tag.
### Why are the changes needed?
T
heziyi399 opened a new issue, #4586:
URL: https://github.com/apache/gravitino/issues/4586
### Version
main branch
### Describe what's wrong
now I want to use hadoop catalog,i hava create
metalake,catalog,schema,fileset,the localtion is:
https://github.com/user-attachm
jerryshao commented on issue #4583:
URL: https://github.com/apache/gravitino/issues/4583#issuecomment-2296165997
Yeah, we can take a try to reduce the task number, there're too many tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
FANNG1 commented on code in PR #65:
URL:
https://github.com/apache/gravitino-playground/pull/65#discussion_r1721540676
##
docker-compose.yaml:
##
@@ -22,9 +22,9 @@ services:
image: datastrato/hive:2.7.3-no-yarn
ports:
- "3307:3306"
- - "9000:9000"
- -
FANNG1 commented on PR #45:
URL:
https://github.com/apache/gravitino-playground/pull/45#issuecomment-2296214111
> Will it influence the demo of Iceberg REST catalog? Is it clear for user
to use Spark connector and REST service catalog. It is a confusing for user.
The original documen
jerryshao commented on issue #4586:
URL: https://github.com/apache/gravitino/issues/4586#issuecomment-2296218052
@xloya would you please take a look at this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
xunliu closed issue #4460: [FEATURE] Add the method call of authorization plugin
URL: https://github.com/apache/gravitino/issues/4460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
xunliu merged PR #4461:
URL: https://github.com/apache/gravitino/pull/4461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino
This is an automated email from the ASF dual-hosted git repository.
liuxun pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 79fda5fe3 [#4460] feat(core): Add the method call
xunliu closed issue #4460: [FEATURE] Add the method call of authorization plugin
URL: https://github.com/apache/gravitino/issues/4460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
xunliu commented on PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#issuecomment-2296236058
@yuqi1129 I fixed all problems based on your comments, Please help me review
again. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
LauraXia123 opened a new issue, #4588:
URL: https://github.com/apache/gravitino/issues/4588
### Describe the feature
We can associate tags with a existing metadata object right now.
Need to support associating tags when creating a metadata object
### Motivation
_No res
jerryshao commented on issue #4558:
URL: https://github.com/apache/gravitino/issues/4558#issuecomment-2296282629
Thanks @coolderli to bring this out. I think HCFS API is not Posix compliant
API, so using HCFS API with fuse has many limitations. I don't know how well
fsspec support Posix, we
yuqi1129 commented on code in PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#discussion_r1721492852
##
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerClientExt.java:
##
@@ -0,0 +1,184 @@
+/*
+ * Licensed to the Apa
jerqi commented on code in PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#discussion_r1721648253
##
api/src/main/java/org/apache/gravitino/authorization/RoleChange.java:
##
@@ -149,7 +189,101 @@ public int hashCode() {
*/
@Override
public String toS
jerqi commented on PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#issuecomment-2296375571
If we set a schema the privilege `read table`, will it present schema.* in
the Ranger?
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
yuqi1129 closed pull request #4469: [#4089] fix(hive catalog): the problem of
slow acquisition of hive table list
URL: https://github.com/apache/gravitino/pull/4469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jerqi commented on code in PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#discussion_r1721662285
##
core/src/main/java/org/apache/gravitino/connector/authorization/UserGroupAuthorizationPlugin.java:
##
@@ -98,46 +98,15 @@ interface UserGroupAuthorizationPlugin {
jerqi commented on code in PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#discussion_r1721675565
##
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHiveAuthorizationPlugin.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed
danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1721676175
##
helm-chart/values.yaml:
##
@@ -0,0 +1,150 @@
+# Global settings
+global:
+ storageClass: ""
+ namespace: gravitino-playground
+
+# Hive settings
+hive
danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1721680582
##
helm-chart/values.yaml:
##
@@ -0,0 +1,150 @@
+# Global settings
+global:
+ storageClass: ""
+ namespace: gravitino-playground
+
+# Hive settings
+hive
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2296416879
I didn't see the dependency logic in docker-compose.yaml that is implemented
in helm chart yaml. I think these dependencies are important for pod launch.
--
This is an auto
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2296442320
After I try to access gravitino ui , gravitino pod is restarting. I think
the resources for the pod of gravitino is not enough . After I changed to the
following configurati
xunliu commented on PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#issuecomment-2296473673
> If we set a schema the privilege read table, will it present schema.* in
the Ranger?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the
lw-yang commented on code in PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#discussion_r1721691630
##
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationPlugin.java:
##
@@ -0,0 +1,1015 @@
+/*
+ * Licensed
FANNG1 merged PR #4563:
URL: https://github.com/apache/gravitino/pull/4563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino
This is an automated email from the ASF dual-hosted git repository.
fanng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 837b53b1c [#4508]feat(iceberg-rest-server): suppor
FANNG1 commented on PR #4563:
URL: https://github.com/apache/gravitino/pull/4563#issuecomment-2296531124
@theoryxu , merged to main, thanks for your contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
xloya commented on issue #4586:
URL: https://github.com/apache/gravitino/issues/4586#issuecomment-2296532624
Have reproduced the issue, will fix this tomorrow. @heziyi399 Thanks for
reporting this.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
FANNG1 closed issue #4508: [Improvement] Support loading custom catalog as
backend In Iceberg rest catalog server
URL: https://github.com/apache/gravitino/issues/4508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
jerryshao merged PR #4585:
URL: https://github.com/apache/gravitino/pull/4585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravit
This is an automated email from the ASF dual-hosted git repository.
jshao pushed a commit to branch branch-0.6
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/branch-0.6 by this push:
new d440eed33 [MINOR] fix(doc): Add missin
xunliu commented on code in PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#discussion_r1721863651
##
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationPlugin.java:
##
@@ -0,0 +1,1015 @@
+/*
+ * Licensed t
xunliu commented on code in PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#discussion_r1721883659
##
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHiveAuthorizationPlugin.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed
xunliu commented on code in PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#discussion_r1721883659
##
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHiveAuthorizationPlugin.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed
jerryshao commented on PR #4518:
URL: https://github.com/apache/gravitino/pull/4518#issuecomment-2296768095
@yuqi1129 @jerqi please help to review, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jerryshao commented on PR #4589:
URL: https://github.com/apache/gravitino/pull/4589#issuecomment-2296776509
I think we can also add some component level fine-grained control. For
example, if the code change only happens in one independent component, then we
can only run the related componen
jerryshao commented on PR #4281:
URL: https://github.com/apache/gravitino/pull/4281#issuecomment-2296783231
@xloya is it ready for review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
xunliu commented on code in PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#discussion_r1721845748
##
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationPlugin.java:
##
@@ -0,0 +1,1015 @@
+/*
+ * Licensed t
xunliu commented on code in PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#discussion_r1721943510
##
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationPlugin.java:
##
@@ -0,0 +1,1015 @@
+/*
+ * Licensed t
noidname01 opened a new pull request, #4590:
URL: https://github.com/apache/gravitino/pull/4590
### What changes were proposed in this pull request?
NOTE: This is draft PR
Remove reload action and fix the following logic of ITs
### Why are the changes needed?
noidname01 commented on issue #3729:
URL: https://github.com/apache/gravitino/issues/3729#issuecomment-2297415717
@mchades Sorry for the inactiveness in this PR.
I've created a draft PR, I have done the main logic modification, the
remaining to-do works is modifying the logic of ITs, whic
LiuQhahah opened a new issue, #4591:
URL: https://github.com/apache/gravitino/issues/4591
### Version
main branch
### Describe what's wrong
When checking the input value of the jdbc-url, the current logic is checked
if the value is not blank.
Can you add more rest
jerqi commented on code in PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#discussion_r1722592797
##
core/src/main/java/org/apache/gravitino/connector/authorization/UserGroupAuthorizationPlugin.java:
##
@@ -98,46 +98,15 @@ interface UserGroupAuthorizationPlugin {
jerqi commented on PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#issuecomment-2297824047
Do you have e2e tests for this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
jerqi commented on code in PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#discussion_r1722596783
##
authorizations/authorization-ranger/src/main/resources/META-INF/services/org.apache.gravitino.authorization.ranger.RangerAuthorization:
##
@@ -0,0 +1,19 @@
+#
+# Lic
lw-yang commented on code in PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#discussion_r1722591836
##
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationPlugin.java:
##
@@ -0,0 +1,1015 @@
+/*
+ * Licensed
jerqi commented on PR #4518:
URL: https://github.com/apache/gravitino/pull/4518#issuecomment-2297842903
Should we check the requirement of executing the scripts? For example, we
should check whether users have installed git, svn.
--
This is an automated message from the Apache Git Service
jerryshao commented on PR #4518:
URL: https://github.com/apache/gravitino/pull/4518#issuecomment-2297845510
OK, I will add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jerryshao commented on PR #4523:
URL: https://github.com/apache/gravitino/pull/4523#issuecomment-2297853476
@jerqi do you have any more feedbacks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
xloya commented on PR #4281:
URL: https://github.com/apache/gravitino/pull/4281#issuecomment-2297855158
> @xloya is it ready for review?
Yeah, the code have been changed according to the discussion.
--
This is an automated message from the Apache Git Service.
To respond to the messa
mchades commented on PR #4589:
URL: https://github.com/apache/gravitino/pull/4589#issuecomment-2297861153
> I think we can also add some component level fine-grained control. For
example, if the code change only happens in one independent component, then we
can only run the related componen
yuqi1129 commented on PR #4589:
URL: https://github.com/apache/gravitino/pull/4589#issuecomment-2297888908
I suggest we merge several JDK versions and use JDK17 to run the GitHub CI
pipeline. If we want to test all JDK versions, I think a nightly test is okay.
It's more probable that the st
xunliu commented on PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#issuecomment-2297911224
hi @jerqi
> Do you have e2e tests for this pull request?
Sure, IT in the `RangerHiveIT.java`
--
This is an automated message from the Apache Git Service.
To respond to the me
xunliu commented on code in PR #4515:
URL: https://github.com/apache/gravitino/pull/4515#discussion_r1722651057
##
authorizations/authorization-ranger/src/main/resources/META-INF/services/org.apache.gravitino.authorization.ranger.RangerAuthorization:
##
@@ -0,0 +1,19 @@
+#
+# Li
1 - 100 of 128 matches
Mail list logo
