This is an automated email from the ASF dual-hosted git repository.

jshao pushed a commit to branch branch-0.6
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/branch-0.6 by this push:
     new 7875ba629 [#4506] fix(UI): Hide jdbc-password value in details page 
(#4577)
7875ba629 is described below

commit 7875ba629157e60735d7d95554ff9ff9374d6c55
Author: Liang Chun <garychen0975321...@gmail.com>
AuthorDate: Mon Aug 19 18:13:31 2024 +0900

    [#4506] fix(UI): Hide jdbc-password value in details page (#4577)
    
    ### What changes were proposed in this pull request?
    
    Hide jdbc-password value in details page.
    
    ### Why are the changes needed?
    
    Fix: #4506
    
    ### Does this PR introduce _any_ user-facing change?
    
    Jdbc-password value is not palintext now.
    
    ### How was this patch tested?
    
    ![Screenshot from 2024-08-16
    
15-31-53](https://github.com/user-attachments/assets/75cb2a83-8145-41be-9be5-19a7a4add336)
    ![Screenshot from 2024-08-16
    
15-21-04](https://github.com/user-attachments/assets/63e34fee-fef1-4fa6-a93c-ac028b2d04b3)
---
 .../metalake/rightContent/tabsContent/detailsView/DetailsView.js        | 2 +-
 web/src/components/DetailsDrawer.js                                     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/web/src/app/metalakes/metalake/rightContent/tabsContent/detailsView/DetailsView.js
 
b/web/src/app/metalakes/metalake/rightContent/tabsContent/detailsView/DetailsView.js
index 41313c121..6e21eabdb 100644
--- 
a/web/src/app/metalakes/metalake/rightContent/tabsContent/detailsView/DetailsView.js
+++ 
b/web/src/app/metalakes/metalake/rightContent/tabsContent/detailsView/DetailsView.js
@@ -196,7 +196,7 @@ const DetailsView = () => {
                                 : `props-value-${item.key}`
                             }
                           >
-                            {item.value}
+                            {item.key === 'jdbc-password' ? '[HIDDEN]' : 
item.value}
                           </div>
                         </Typography>
                       </TableCell>
diff --git a/web/src/components/DetailsDrawer.js 
b/web/src/components/DetailsDrawer.js
index 9479e3067..553f0e6fd 100644
--- a/web/src/components/DetailsDrawer.js
+++ b/web/src/components/DetailsDrawer.js
@@ -206,7 +206,7 @@ const DetailsDrawer = props => {
                         data-refer={`details-props-value-${item.value}`}
                         data-prev-refer={`details-props-key-${item.key}`}
                       >
-                        {item.value}
+                        {item.key === 'jdbc-password' ? '[HIDDEN]' : 
item.value}
                       </TableCell>
                     </TableRow>
                   )

Reply via email to