jerryshao merged PR #5944:
URL: https://github.com/apache/gravitino/pull/5944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravit
FANNG1 commented on PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#issuecomment-2574487181
LGTM, @jerryshao do you have time to review again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
FANNG1 commented on PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#issuecomment-2574267922
@cool9850311 , LGTM except for minor comments, could you fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
FANNG1 commented on code in PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#discussion_r1904819488
##
core/src/main/java/org/apache/gravitino/listener/api/event/ListMetadataObjectsForTagFailureEvent.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software F
FANNG1 commented on PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#issuecomment-2564572784
> @FANNG1 I run the Frontend IT test successfully in local, but it does not
pass here 2 times, and it says connection timeout, do I need to change anything?
no, it's network failur
cool9850311 commented on PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#issuecomment-2564371371
@FANNG1 I run the Frontend IT test successfully in local, do I need to
change anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
cool9850311 commented on PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#issuecomment-2564159266
@FANNG1 Done, pls review thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
cool9850311 commented on PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#issuecomment-2563464709
> Could you fix the comments and could you add related document in
`gravitino-server-config.md`?
OK
--
This is an automated message from the Apache Git Service.
To respond
FANNG1 commented on PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#issuecomment-2563431271
Could you add related document in `gravitino-server-config.md`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
FANNG1 commented on code in PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#discussion_r1898338425
##
core/src/main/java/org/apache/gravitino/listener/api/event/AlterTagFailureEvent.java:
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
xunliu commented on PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#issuecomment-2562645309
hi @FANNG1 Please help review this PR, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
FANNG1 commented on code in PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#discussion_r1897174816
##
core/src/main/java/org/apache/gravitino/listener/api/event/AlterTagFailureEvent.java:
##
@@ -0,0 +1,33 @@
+package org.apache.gravitino.listener.api.event;
+
+impor
FANNG1 commented on code in PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#discussion_r1897174971
##
core/src/main/java/org/apache/gravitino/listener/api/event/AssociateTagsForMetadataObjectFailureEvent.java:
##
@@ -0,0 +1,38 @@
+package org.apache.gravitino.listen
FANNG1 commented on PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#issuecomment-2561680979
event describes what happened to a resource identified by a nameIdentifier,
1. for most tag event(create/get/delete), the identifier is the
`metalakeName`.`tagName` which could be gen
cool9850311 commented on code in PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#discussion_r1896461209
##
core/src/main/java/org/apache/gravitino/listener/api/event/AlterTagFailureEvent.java:
##
@@ -7,7 +7,7 @@ public class AlterTagFailureEvent extends TagFailureEv
FANNG1 commented on code in PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#discussion_r1896439734
##
core/src/main/java/org/apache/gravitino/listener/api/event/AlterTagFailureEvent.java:
##
@@ -7,7 +7,7 @@ public class AlterTagFailureEvent extends TagFailureEvent {
cool9850311 commented on code in PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#discussion_r1896365535
##
core/src/main/java/org/apache/gravitino/listener/api/event/AlterTagFailureEvent.java:
##
@@ -7,7 +7,7 @@ public class AlterTagFailureEvent extends TagFailureEv
FANNG1 commented on code in PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#discussion_r1896291754
##
core/src/main/java/org/apache/gravitino/listener/api/event/AlterTagFailureEvent.java:
##
@@ -7,7 +7,7 @@ public class AlterTagFailureEvent extends TagFailureEvent {
cool9850311 commented on code in PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#discussion_r1896250583
##
core/src/main/java/org/apache/gravitino/listener/api/event/AlterTagFailureEvent.java:
##
@@ -7,7 +7,7 @@ public class AlterTagFailureEvent extends TagFailureEv
cool9850311 commented on code in PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#discussion_r1895749129
##
core/src/main/java/org/apache/gravitino/listener/api/event/AlterTagFailureEvent.java:
##
@@ -7,7 +7,7 @@ public class AlterTagFailureEvent extends TagFailureEv
FANNG1 commented on code in PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#discussion_r1895619541
##
core/src/main/java/org/apache/gravitino/listener/api/event/AlterTagFailureEvent.java:
##
@@ -7,7 +7,7 @@ public class AlterTagFailureEvent extends TagFailureEvent {
cool9850311 commented on code in PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#discussion_r1895371248
##
core/src/main/java/org/apache/gravitino/listener/api/event/TagFailureEvent.java:
##
@@ -0,0 +1,7 @@
+package org.apache.gravitino.listener.api.event;
+
+public
FANNG1 commented on code in PR #5944:
URL: https://github.com/apache/gravitino/pull/5944#discussion_r1895209349
##
core/src/main/java/org/apache/gravitino/listener/TagEventDispatcher.java:
##
@@ -19,11 +19,25 @@
package org.apache.gravitino.listener;
import java.util.Map;
+
cool9850311 opened a new pull request, #5944:
URL: https://github.com/apache/gravitino/pull/5944
### What changes were proposed in this pull request?
Add tag failure event to Gravitino server
### Why are the changes needed?
Subtask: apache#5902
### Does this PR int
24 matches
Mail list logo
