FANNG1 merged PR #5878:
URL: https://github.com/apache/gravitino/pull/5878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1896300941
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,393 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1896282772
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,393 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1896282665
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,393 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
FANNG1 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1895759278
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,393 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribut
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1895497886
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -239,3 +352,406 @@ pub trait FileWriter: Sync + Send {
Ok(())
}
}
+
+/// SimpleFileSystem is a simp
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1895497061
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -201,6 +246,74 @@ pub(crate) struct OpenedFile {
pub writer: Option>,
}
+impl OpenedFile {
+pub fn new
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1895440325
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1895408130
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1895397439
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
FANNG1 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1895303055
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribut
FANNG1 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1895302378
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribut
FANNG1 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1895301983
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribut
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893617339
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893644880
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893639779
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893639250
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893632540
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893627716
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893624530
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893621157
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893617339
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893613372
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
FANNG1 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893585343
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribut
FANNG1 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893364137
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -201,6 +246,74 @@ pub(crate) struct OpenedFile {
pub writer: Option>,
}
+impl OpenedFile {
+pub fn new(
diqiu50 commented on PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#issuecomment-2553506584
> > @FANNG1 @jerryshao @yuqi1129 @xunliu @mchades Do you think we must
rename 'parent' , 'name' and 'path' in the function or struct names of this
interface to `file_path` `parent_file_
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1891673360
##
clients/filesystem-fuse/build.gradle.kts:
##
@@ -32,34 +32,34 @@ val buildRustProject by tasks.registering(Exec::class) {
dependsOn(checkRustEnvironment)
des
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1891672219
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -239,3 +364,414 @@ pub trait FileWriter: Sync + Send {
Ok(())
}
}
+
+/// DefaultRawFileSystem is a
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1891667537
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -239,3 +364,412 @@ pub trait FileWriter: Sync + Send {
Ok(())
}
}
+
+/// SimpleFileSystem is a simp
FANNG1 commented on PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#issuecomment-2553451032
> @FANNG1 @jerryshao @yuqi1129 @xunliu @mchades Do you think we must rename
'parent' , 'name' and 'path' in the function or struct names of this interface
to `file_path` `parent_file_pat
jerryshao commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1891433780
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -88,19 +94,19 @@ pub(crate) trait PathFileSystem: Send + Sync {
async fn init(&self) -> Result<()>;
xunliu commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1891428865
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -239,3 +364,412 @@ pub trait FileWriter: Sync + Send {
Ok(())
}
}
+
+/// SimpleFileSystem is a simpl
xunliu commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1891414750
##
clients/filesystem-fuse/src/utils.rs:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreeme
mchades commented on PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#issuecomment-2552721809
> Do you think we must rename 'parent' , 'name' and 'path' in the function
or struct names of this interface to `file_path` `parent_file_path` and
`file_name` respectively? Is it hard t
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1891090015
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -201,6 +246,86 @@ pub(crate) struct OpenedFile {
pub writer: Option>,
}
+impl OpenedFile {
+pub fn new
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1891089763
##
clients/filesystem-fuse/src/utils.rs:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreem
diqiu50 commented on PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#issuecomment-2552692596
@FANNG1 @jerryshao @yuqi1129 @xunliu @mchades
Do you think we must rename 'parent' , 'name' and 'path' in the function or
struct names of this interface to 'parent_file_path' and
FANNG1 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1891063401
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -201,6 +246,86 @@ pub(crate) struct OpenedFile {
pub writer: Option>,
}
+impl OpenedFile {
+pub fn new(
FANNG1 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1891063401
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -201,6 +246,86 @@ pub(crate) struct OpenedFile {
pub writer: Option>,
}
+impl OpenedFile {
+pub fn new(
FANNG1 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1891049129
##
clients/filesystem-fuse/src/utils.rs:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreeme
FANNG1 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1891048215
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -239,3 +352,406 @@ pub trait FileWriter: Sync + Send {
Ok(())
}
}
+
+/// SimpleFileSystem is a simpl
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1890260561
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -201,6 +246,86 @@ pub(crate) struct OpenedFile {
pub writer: Option>,
}
+impl OpenedFile {
+pub fn new
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1890267602
##
clients/filesystem-fuse/src/utils.rs:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreem
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1890267254
##
clients/filesystem-fuse/src/utils.rs:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreem
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1890263624
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -239,3 +364,412 @@ pub trait FileWriter: Sync + Send {
Ok(())
}
}
+
+/// SimpleFileSystem is a simp
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1890263624
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -239,3 +364,412 @@ pub trait FileWriter: Sync + Send {
Ok(())
}
}
+
+/// SimpleFileSystem is a simp
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1890260561
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -201,6 +246,86 @@ pub(crate) struct OpenedFile {
pub writer: Option>,
}
+impl OpenedFile {
+pub fn new
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1890249797
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -239,3 +352,406 @@ pub trait FileWriter: Sync + Send {
Ok(())
}
}
+
+/// SimpleFileSystem is a simp
FANNG1 commented on PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#issuecomment-2551339394
please try avoid using the general names like `file` `name`, in filesystem
there are two many similar conceptions, it's hard to distinguish
--
This is an automated message from the Apa
FANNG1 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1890215836
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -239,3 +364,412 @@ pub trait FileWriter: Sync + Send {
Ok(())
}
}
+
+/// SimpleFileSystem is a simpl
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1890244951
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -239,3 +352,406 @@ pub trait FileWriter: Sync + Send {
Ok(())
}
}
+
+/// SimpleFileSystem is a simp
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1890242379
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -239,3 +364,412 @@ pub trait FileWriter: Sync + Send {
Ok(())
}
}
+
+/// SimpleFileSystem is a simp
FANNG1 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1890207945
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -239,3 +352,406 @@ pub trait FileWriter: Sync + Send {
Ok(())
}
}
+
+/// SimpleFileSystem is a simpl
FANNG1 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1890203373
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -239,3 +364,412 @@ pub trait FileWriter: Sync + Send {
Ok(())
}
}
+
+/// SimpleFileSystem is a simpl
FANNG1 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1890203373
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -239,3 +364,412 @@ pub trait FileWriter: Sync + Send {
Ok(())
}
}
+
+/// SimpleFileSystem is a simpl
FANNG1 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1890198790
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -239,3 +352,406 @@ pub trait FileWriter: Sync + Send {
Ok(())
}
}
+
+/// SimpleFileSystem is a simpl
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1890089665
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -201,6 +246,74 @@ pub(crate) struct OpenedFile {
pub writer: Option>,
}
+impl OpenedFile {
+pub fn new
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1890084707
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -239,3 +352,406 @@ pub trait FileWriter: Sync + Send {
Ok(())
}
}
+
+/// SimpleFileSystem is a simp
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1890082961
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -239,3 +352,406 @@ pub trait FileWriter: Sync + Send {
Ok(())
}
}
+
+/// SimpleFileSystem is a simp
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1890081796
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -239,3 +352,406 @@ pub trait FileWriter: Sync + Send {
Ok(())
}
}
+
+/// SimpleFileSystem is a simp
FANNG1 commented on PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#issuecomment-2550667524
It's hard to understand the code for the naming, suggest using meaningful
name for variables and functions, avoid to use the general `file` to represent
`filestat` and `openedFile` in d
FANNG1 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1889720461
##
clients/filesystem-fuse/src/filesystem.rs:
##
@@ -201,6 +246,74 @@ pub(crate) struct OpenedFile {
pub writer: Option>,
}
+impl OpenedFile {
+pub fn new(
FANNG1 commented on PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#issuecomment-2550112163
There are two many filesystems, could you provide a clear description of
what filesystems represent in your design? How do you plan to split the PRs?
--
This is an automated message f
diqiu50 opened a new pull request, #5878:
URL: https://github.com/apache/gravitino/pull/5878
### What changes were proposed in this pull request?
Implement a common filesystem layer to handle manage file ids, file name
mappings, and file relationships. and delegate filesystem APIs to
64 matches
Mail list logo
