diqiu50 commented on PR #5878: URL: https://github.com/apache/gravitino/pull/5878#issuecomment-2552692596
@FANNG1 @jerryshao @yuqi1129 @xunliu @mchades Do you think we must rename 'parent' , 'name' and 'path' in the function or struct names of this interface to 'parent_file_path' and 'file_name' respectively? ``` /// Create the file by parent file id and file name and flags, if successful, return the file handle async fn create_file(&self, parent_file_id: u64, name: &str, flags: u32) -> Result<FileHandle>; async fn create_file( &self, parent: &str, name: &str, flags: OpenFileFlags, ) -> Result<OpenedFile>; #[derive(Clone, Debug)] pub struct FileStat { // file id for the file system. pub(crate) file_id: u64, // parent file id pub(crate) parent_file_id: u64, // file name pub(crate) name: String, // file path of the fuse file system root pub(crate) path: String, ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org