FANNG1 merged PR #5879:
URL: https://github.com/apache/gravitino/pull/5879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino
jasonmar310 commented on PR #5879:
URL: https://github.com/apache/gravitino/pull/5879#issuecomment-2563224650
overall LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jasonmar310 commented on PR #5879:
URL: https://github.com/apache/gravitino/pull/5879#issuecomment-2563224080
overall LTGM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
xunliu commented on code in PR #5879:
URL: https://github.com/apache/gravitino/pull/5879#discussion_r1895594620
##
clients/client-python/gravitino/api/expressions/sorts/sort_orders.py:
##
@@ -0,0 +1,97 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more c
tengqm commented on code in PR #5879:
URL: https://github.com/apache/gravitino/pull/5879#discussion_r1895195084
##
clients/client-python/gravitino/api/expressions/sorts/sort_orders.py:
##
@@ -0,0 +1,97 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more c
xunliu commented on code in PR #5879:
URL: https://github.com/apache/gravitino/pull/5879#discussion_r1895180868
##
clients/client-python/gravitino/api/expressions/sorts/sort_orders.py:
##
@@ -0,0 +1,97 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more c
xunliu commented on code in PR #5879:
URL: https://github.com/apache/gravitino/pull/5879#discussion_r1895180632
##
clients/client-python/gravitino/api/expressions/sorts/sort_direction.py:
##
@@ -0,0 +1,76 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or mor
tengqm commented on code in PR #5879:
URL: https://github.com/apache/gravitino/pull/5879#discussion_r1894827422
##
clients/client-python/gravitino/api/expressions/sorts/sort_direction.py:
##
@@ -0,0 +1,76 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or mor
tengqm commented on code in PR #5879:
URL: https://github.com/apache/gravitino/pull/5879#discussion_r1894828073
##
clients/client-python/gravitino/api/expressions/sorts/sort_orders.py:
##
@@ -0,0 +1,97 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more c
tengqm commented on code in PR #5879:
URL: https://github.com/apache/gravitino/pull/5879#discussion_r1894827422
##
clients/client-python/gravitino/api/expressions/sorts/sort_direction.py:
##
@@ -0,0 +1,76 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or mor
tengqm commented on code in PR #5879:
URL: https://github.com/apache/gravitino/pull/5879#discussion_r1894827177
##
clients/client-python/gravitino/api/expressions/sorts/sort_direction.py:
##
@@ -0,0 +1,76 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or mor
unknowntpo commented on PR #5879:
URL: https://github.com/apache/gravitino/pull/5879#issuecomment-2556418901
overall, LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
unknowntpo commented on code in PR #5879:
URL: https://github.com/apache/gravitino/pull/5879#discussion_r1893554026
##
clients/client-python/gravitino/api/expressions/sorts/sort_orders.py:
##
@@ -0,0 +1,97 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or mo
xunliu commented on PR #5879:
URL: https://github.com/apache/gravitino/pull/5879#issuecomment-2547653613
hi @SophieTech88 I help you improve this PR, Please review it, Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
SophieTech88 opened a new pull request, #5879:
URL: https://github.com/apache/gravitino/pull/5879
### What changes were proposed in this pull request?
Implement sorts expression in python client, add unit test.
### Why are the changes needed?
We need to support the sorts expressi
15 matches
Mail list logo