tengqm commented on code in PR #5879: URL: https://github.com/apache/gravitino/pull/5879#discussion_r1894827177
########## clients/client-python/gravitino/api/expressions/sorts/sort_direction.py: ########## @@ -0,0 +1,76 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from enum import Enum +from gravitino.api.expressions.sorts.null_ordering import NullOrdering + + +class SortDirection(Enum): + """A sort direction used in sorting expressions. + Each direction has a default null ordering that is implied if no null ordering is specified explicitly. + """ + + ASCENDING = ("asc", NullOrdering.NULLS_FIRST) + """Ascending sort direction. Nulls appear first. For ascending order, this means nulls appear at the beginning.""" + + DESCENDING = ("desc", NullOrdering.NULLS_LAST) + """Descending sort direction. Nulls appear last. For ascending order, this means nulls appear at the end.""" + + _direction: str + _default_null_ordering: NullOrdering Review Comment: These lines should be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
