FANNG1 commented on PR #5938:
URL: https://github.com/apache/gravitino/pull/5938#issuecomment-2558041063
LGTM, just one naming issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
FANNG1 commented on code in PR #5938:
URL: https://github.com/apache/gravitino/pull/5938#discussion_r1894581077
##
api/src/main/java/org/apache/gravitino/credential/ADLSAccountKeyCredential.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Abyss-lord commented on issue #5926:
URL: https://github.com/apache/gravitino/issues/5926#issuecomment-2558025550
I would like to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
Abyss-lord commented on issue #5929:
URL: https://github.com/apache/gravitino/issues/5929#issuecomment-2558025427
I would like to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
justinmclean commented on code in PR #5906:
URL: https://github.com/apache/gravitino/pull/5906#discussion_r1893870704
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -381,27 +381,33 @@ private void handleTableCommand() {
String schema
orenccl opened a new pull request, #5938:
URL: https://github.com/apache/gravitino/pull/5938
### What changes were proposed in this pull request?
Support ADLS account key credential
### Why are the changes needed?
Fix: #5894
### Does this PR introduce _any_ user-fa
This is an automated email from the ASF dual-hosted git repository.
liuxun pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 2a5838fd6 [#5934] fix(auth): Avoid other catalogs
xunliu closed issue #5934: [Bug report] Other catalog privileges will be
pushed down this catalog
URL: https://github.com/apache/gravitino/issues/5934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
xunliu merged PR #5935:
URL: https://github.com/apache/gravitino/pull/5935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino
This is an automated email from the ASF dual-hosted git repository.
jmclean pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 908e994e6 [#5829] improvement(CLI): Slightly mis
justinmclean closed issue #5829: [Improvement] Slightly missing leading error
message when group is not specified in Gravitino CLI
URL: https://github.com/apache/gravitino/issues/5829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
justinmclean closed issue #5829: [Improvement] Slightly missing leading error
message when group is not specified in Gravitino CLI
URL: https://github.com/apache/gravitino/issues/5829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
justinmclean merged PR #5920:
URL: https://github.com/apache/gravitino/pull/5920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gra
justinmclean commented on code in PR #5906:
URL: https://github.com/apache/gravitino/pull/5906#discussion_r1893870704
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -381,27 +381,33 @@ private void handleTableCommand() {
String schema
jerryshao commented on code in PR #5908:
URL: https://github.com/apache/gravitino/pull/5908#discussion_r1893851205
##
core/src/main/java/org/apache/gravitino/catalog/ModelOperationDispatcher.java:
##
@@ -40,40 +49,114 @@ public ModelOperationDispatcher(
@Override
public
cool9850311 commented on code in PR #5922:
URL: https://github.com/apache/gravitino/pull/5922#discussion_r1893826899
##
docs/open-api/openapi.yaml:
##
@@ -133,6 +133,23 @@ paths:
$ref: "./roles.yaml#/paths/~1metalakes~1%7Bmetalake%7D~1roles~1%7Brole%7D"
/metalakes/{met
jerqi commented on code in PR #5935:
URL: https://github.com/apache/gravitino/pull/5935#discussion_r1893791850
##
core/src/main/java/org/apache/gravitino/authorization/PermissionManager.java:
##
@@ -116,16 +117,23 @@ User grantRolesToUser(String metalake, List
roles, String use
an-shi-chi-fan commented on issue #5912:
URL: https://github.com/apache/gravitino/issues/5912#issuecomment-2556739802
@jerryshao @yujiantao CC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
an-shi-chi-fan commented on issue #5912:
URL: https://github.com/apache/gravitino/issues/5912#issuecomment-2556729366
## Hive 3 support draft
Regarding this feature, we had a brief discussion, and here are the results
of the discussion.ยท
### For catalog
![image](https://git
fsalhi2 commented on code in PR #5923:
URL: https://github.com/apache/gravitino/pull/5923#discussion_r1893761346
##
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java:
##
@@ -82,9 +82,12 @@ public IcebergCatalogWrapper(Iceberg
fsalhi2 commented on code in PR #5923:
URL: https://github.com/apache/gravitino/pull/5923#discussion_r1893759702
##
gradle.properties:
##
@@ -20,18 +20,18 @@
org.gradle.parallel=true
Review Comment:
Yes the changes in gradle.properties aren't related , i've forgot to disabl
xunliu commented on code in PR #5935:
URL: https://github.com/apache/gravitino/pull/5935#discussion_r1893757453
##
core/src/main/java/org/apache/gravitino/authorization/PermissionManager.java:
##
@@ -116,16 +117,23 @@ User grantRolesToUser(String metalake, List
roles, String us
liangyouze opened a new issue, #5936:
URL: https://github.com/apache/gravitino/issues/5936
### What would you like to be improved?
Currently, IRCS can automatically proxy a Gravitino Iceberg catalog under a
metalake, but the metalake config is static, which means that every time a new
xloya commented on code in PR #5908:
URL: https://github.com/apache/gravitino/pull/5908#discussion_r1893653482
##
core/src/main/java/org/apache/gravitino/catalog/ModelOperationDispatcher.java:
##
@@ -40,40 +49,114 @@ public ModelOperationDispatcher(
@Override
public Name
xloya commented on code in PR #5908:
URL: https://github.com/apache/gravitino/pull/5908#discussion_r1893653482
##
core/src/main/java/org/apache/gravitino/catalog/ModelOperationDispatcher.java:
##
@@ -40,40 +49,114 @@ public ModelOperationDispatcher(
@Override
public Name
jerqi opened a new pull request, #5935:
URL: https://github.com/apache/gravitino/pull/5935
### What changes were proposed in this pull request?
Avoid other catalogs' privileges are pushed down
### Why are the changes needed?
Fix: #5934
### Does this PR introduce _any_
Abyss-lord commented on PR #5907:
URL: https://github.com/apache/gravitino/pull/5907#issuecomment-2556548810
> Up to you, but I would probably do it in one PR as they are related.
ok, I'll do it in a PR.
--
This is an automated message from the Apache Git Service.
To respond to the
justinmclean commented on PR #5907:
URL: https://github.com/apache/gravitino/pull/5907#issuecomment-2556547046
Up to you, but I would probably do it in one PR as they are related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893617339
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893644880
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893639779
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893639250
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
Abyss-lord commented on PR #5907:
URL: https://github.com/apache/gravitino/pull/5907#issuecomment-2556528343
> As I mentioned above we don't want to tell the user to use the REST (not
rest btw) server. We want them to be able to fix this with the CLI. So either
we have the delete command ta
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893632540
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
justinmclean commented on PR #5907:
URL: https://github.com/apache/gravitino/pull/5907#issuecomment-2556522489
As I mentioned above we don't want to tell the user to use the REST (not
rest btw) server. We want them to be able to fix this with the CLI. So either
we have the delete command ta
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893627716
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893624530
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893621157
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
mchades commented on code in PR #5922:
URL: https://github.com/apache/gravitino/pull/5922#discussion_r1893618682
##
docs/open-api/openapi.yaml:
##
@@ -133,6 +133,23 @@ paths:
$ref: "./roles.yaml#/paths/~1metalakes~1%7Bmetalake%7D~1roles~1%7Brole%7D"
/metalakes/{metalak
mchades commented on code in PR #5922:
URL: https://github.com/apache/gravitino/pull/5922#discussion_r1893616982
##
docs/open-api/openapi.yaml:
##
@@ -133,6 +133,23 @@ paths:
$ref: "./roles.yaml#/paths/~1metalakes~1%7Bmetalake%7D~1roles~1%7Brole%7D"
/metalakes/{metalak
mchades commented on code in PR #5922:
URL: https://github.com/apache/gravitino/pull/5922#discussion_r1893616982
##
docs/open-api/openapi.yaml:
##
@@ -133,6 +133,23 @@ paths:
$ref: "./roles.yaml#/paths/~1metalakes~1%7Bmetalake%7D~1roles~1%7Brole%7D"
/metalakes/{metalak
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893617339
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
diqiu50 commented on code in PR #5878:
URL: https://github.com/apache/gravitino/pull/5878#discussion_r1893613372
##
clients/filesystem-fuse/src/default_raw_filesystem.rs:
##
@@ -0,0 +1,398 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contribu
cool9850311 commented on code in PR #5922:
URL: https://github.com/apache/gravitino/pull/5922#discussion_r1893608116
##
docs/open-api/openapi.yaml:
##
@@ -133,6 +133,23 @@ paths:
$ref: "./roles.yaml#/paths/~1metalakes~1%7Bmetalake%7D~1roles~1%7Brole%7D"
/metalakes/{met
tengqm commented on PR #5920:
URL: https://github.com/apache/gravitino/pull/5920#issuecomment-2556477846
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
45 matches
Mail list logo