(gravitino) branch main updated: [#5829] improvement(CLI): Slightly misleading error message when group is not specified (#5920)

[jmclean]

This is an automated email from the ASF dual-hosted git repository.

jmclean pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new 908e994e6 [#5829] improvement(CLI): Slightly misleading error message 
when group is not specified (#5920)
908e994e6 is described below

commit 908e994e63e57b70e00c3a6e2b990a6c63ae0b00
Author: Lord of Abyss <103809695+abyss-l...@users.noreply.github.com>
AuthorDate: Fri Dec 20 20:18:52 2024 +0800

    [#5829] improvement(CLI): Slightly misleading error message when group is 
not specified (#5920)
    
    ### What changes were proposed in this pull request?
    
    Slightly missing leading error message when group is not specified, it
    should give some hints to user.
    
    ### Why are the changes needed?
    
    Fix: #5829
    
    ### Does this PR introduce _any_ user-facing change?
    
    NO
    
    ### How was this patch tested?
    
    ```bash
    bin/gcli.sh group create --metalake demo_metalake
    # Missing --group option.
    
    bin/gcli.sh group details --metalake demo_metalake
    # Missing --group option.
    
    bin/gcli.sh group delete --metalake demo_metalake
    # Missing --group option.
    ```
---
 .../cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java    | 1 +
 .../src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java | 5 +++++
 2 files changed, 6 insertions(+)

diff --git 
a/clients/cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java 
b/clients/cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java
index 3af83b32a..3423cee07 100644
--- a/clients/cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java
+++ b/clients/cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java
@@ -30,6 +30,7 @@ public class ErrorMessages {
   public static final String UNKNOWN_TABLE = "Unknown table name.";
   public static final String MALFORMED_NAME = "Malformed entity name.";
   public static final String MISSING_NAME = "Missing --name option.";
+  public static final String MISSING_GROUP = "Missing --group option.";
   public static final String MISSING_USER = "Missing --user option.";
   public static final String METALAKE_EXISTS = "Metalake already exists.";
   public static final String CATALOG_EXISTS = "Catalog already exists.";
diff --git 
a/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java 
b/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
index d651572e3..f18600985 100644
--- 
a/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
+++ 
b/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
@@ -540,6 +540,11 @@ public class GravitinoCommandLine extends 
TestableCommandLine {
 
     Command.setAuthenticationMode(auth, userName);
 
+    if (group == null && !CommandActions.LIST.equals(command)) {
+      System.err.println(ErrorMessages.MISSING_GROUP);
+      return;
+    }
+
     switch (command) {
       case CommandActions.DETAILS:
         if (line.hasOption(GravitinoOptions.AUDIT)) {