theoryxu commented on code in PR #5629:
URL: https://github.com/apache/gravitino/pull/5629#discussion_r1856005651
##
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java:
##
@@ -86,6 +86,9 @@ public RangerHelper(
*/
orenccl commented on code in PR #5651:
URL: https://github.com/apache/gravitino/pull/5651#discussion_r1855985194
##
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/listener/api/event/IcebergRegisterTableEvent.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apac
orenccl commented on code in PR #5651:
URL: https://github.com/apache/gravitino/pull/5651#discussion_r1855985194
##
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/listener/api/event/IcebergRegisterTableEvent.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apac
LiuQhahah commented on PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#issuecomment-2497085704
HI @jerryshao @FANNG1
I have updated it.
please help to review it again.
sorry.
Thanks,
Qiang
--
This is an automated message from the Apache Git Service.
To res
sunxiaojian commented on PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#issuecomment-2497072213
> I have those tests failing locally one this branch as well. The issue is
that not all tag commands use the --tag option and it failing on this line:
>
> ```
> String[
LauraXia123 commented on PR #5643:
URL: https://github.com/apache/gravitino/pull/5643#issuecomment-2497042718
> Hi @LauraXia123,
>
> I’ve updated the properties field width and the reserved/immutable column
settings.
>
> However, I noticed that some properties appear to be immu
sunxiaojian closed pull request #5641: [#5528]Improvement[cli] Add and delete
multiple tags at once in the Gravitino CLI
URL: https://github.com/apache/gravitino/pull/5641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
sunxiaojian opened a new pull request, #5641:
URL: https://github.com/apache/gravitino/pull/5641
### What changes were proposed in this pull request?
Add and delete multiple tags at once in the Gravitino CLI
### Why are the changes needed?
Close: [(#5528)](https:
sunxiaojian commented on PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#issuecomment-2497025984
> There are still a couple of things to fix:
>
> * There are unnecessary checks if tags are null that are not needed, as
the CLI library will detect if you pass no tags and gi
danhuawang commented on code in PR #5632:
URL: https://github.com/apache/gravitino/pull/5632#discussion_r1855882858
##
trino-connector/integration-test/src/test/resources/trino-ci-testset/trino-cascading-testsets/hive/catalog_hive_prepare.sql:
##
@@ -0,0 +1,74 @@
+call gravitino
danhuawang commented on code in PR #5632:
URL: https://github.com/apache/gravitino/pull/5632#discussion_r1855882858
##
trino-connector/integration-test/src/test/resources/trino-ci-testset/trino-cascading-testsets/hive/catalog_hive_prepare.sql:
##
@@ -0,0 +1,74 @@
+call gravitino
danhuawang commented on code in PR #5632:
URL: https://github.com/apache/gravitino/pull/5632#discussion_r1855745116
##
trino-connector/integration-test/src/test/resources/trino-ci-testset/trino-cascading-testsets/lakehouse-iceberg-hive/catalog_iceberg_prepare.sql:
##
@@ -0,0 +1,
danhuawang commented on code in PR #5632:
URL: https://github.com/apache/gravitino/pull/5632#discussion_r1855871623
##
trino-connector/integration-test/trino-test-tools/trino-cascading-env/init/hive/init.sh:
##
@@ -0,0 +1,24 @@
+#
+# Licensed to the Apache Software Foundation (A
danhuawang commented on code in PR #5632:
URL: https://github.com/apache/gravitino/pull/5632#discussion_r1855729593
##
trino-connector/integration-test/trino-test-tools/trino-cascading-env/docker-compose.yaml:
##
@@ -59,6 +88,7 @@ services:
- ./init/trino-remote:/tmp/trin
justinmclean commented on PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#issuecomment-2497002514
Easy fix would to be only set tags if line.hasOption(GravitinoOptions.TAG)
is true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
orenccl commented on PR #5643:
URL: https://github.com/apache/gravitino/pull/5643#issuecomment-2496999884
Hi @LauraXia123,
I’ve updated the properties field width and the reserved/immutable column
settings.
However, I noticed that some properties appear to be immutable but are
justinmclean commented on PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#issuecomment-2496998863
I have those tests failing locally one this branch as well. The issue is
that not all tag commands use the --tag option and it failing on this line:
```
String[] tags =
LauraXia123 commented on PR #5653:
URL: https://github.com/apache/gravitino/pull/5653#issuecomment-2496983434
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
FANNG1 commented on PR #5627:
URL: https://github.com/apache/gravitino/pull/5627#issuecomment-2496982535
LGTM, except minor comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
justinmclean commented on code in PR #5606:
URL: https://github.com/apache/gravitino/pull/5606#discussion_r1855909668
##
clients/cli/src/main/java/org/apache/gravitino/cli/outputs/TableFormats.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
FANNG1 commented on code in PR #5627:
URL: https://github.com/apache/gravitino/pull/5627#discussion_r1855896904
##
clients/filesystem-fuse/Cargo.toml:
##
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. Se
jerryshao opened a new pull request, #5662:
URL: https://github.com/apache/gravitino/pull/5662
### What changes were proposed in this pull request?
1. Define and add the model namespace, name identifier, entity definition in
Gravitino.
2. Add the basic dispatcher framework in Gravi
justinmclean commented on code in PR #5606:
URL: https://github.com/apache/gravitino/pull/5606#discussion_r1855905530
##
clients/cli/src/main/java/org/apache/gravitino/cli/outputs/CommaSeparatorFormats.java:
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation
justinmclean commented on code in PR #5606:
URL: https://github.com/apache/gravitino/pull/5606#discussion_r1855892542
##
clients/cli/src/test/java/org/apache/gravitino/cli/TestMetalakeCommands.java:
##
@@ -59,7 +59,9 @@ void testListMetalakesCommand() {
spy(
justinmclean commented on code in PR #5606:
URL: https://github.com/apache/gravitino/pull/5606#discussion_r1855895395
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java:
##
@@ -89,6 +89,7 @@ public Options options() {
// Force delete entity and rena
FANNG1 commented on PR #5651:
URL: https://github.com/apache/gravitino/pull/5651#issuecomment-2496970499
LGTM, except minor comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
FANNG1 commented on code in PR #5651:
URL: https://github.com/apache/gravitino/pull/5651#discussion_r1855893402
##
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/listener/api/event/IcebergRegisterTableEvent.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apach
justinmclean commented on code in PR #5606:
URL: https://github.com/apache/gravitino/pull/5606#discussion_r1855892542
##
clients/cli/src/test/java/org/apache/gravitino/cli/TestMetalakeCommands.java:
##
@@ -59,7 +59,9 @@ void testListMetalakesCommand() {
spy(
justinmclean commented on code in PR #5606:
URL: https://github.com/apache/gravitino/pull/5606#discussion_r1855889032
##
clients/cli/src/main/java/org/apache/gravitino/cli/commands/MetalakeDetails.java:
##
@@ -33,27 +34,24 @@ public class MetalakeDetails extends Command {
*
justinmclean commented on code in PR #5606:
URL: https://github.com/apache/gravitino/pull/5606#discussion_r1855887054
##
clients/cli/src/main/java/org/apache/gravitino/cli/commands/MetalakeDetails.java:
##
@@ -33,27 +34,24 @@ public class MetalakeDetails extends Command {
*
FANNG1 commented on issue #1686:
URL: https://github.com/apache/gravitino/issues/1686#issuecomment-2496950833
> @FANNG1
>
> > you could only drop columns with compatibility types for the limitation
of the Hive metastore, like drop column a from table with schema(a int, b int)
>
danhuawang commented on code in PR #5632:
URL: https://github.com/apache/gravitino/pull/5632#discussion_r1855882858
##
trino-connector/integration-test/src/test/resources/trino-ci-testset/trino-cascading-testsets/hive/catalog_hive_prepare.sql:
##
@@ -0,0 +1,74 @@
+call gravitino
danhuawang commented on code in PR #5632:
URL: https://github.com/apache/gravitino/pull/5632#discussion_r1855871623
##
trino-connector/integration-test/trino-test-tools/trino-cascading-env/init/hive/init.sh:
##
@@ -0,0 +1,24 @@
+#
+# Licensed to the Apache Software Foundation (A
SophieTech88 commented on code in PR #5646:
URL: https://github.com/apache/gravitino/pull/5646#discussion_r1855831796
##
clients/client-python/gravitino/api/expressions/named_reference.py:
##
@@ -0,0 +1,76 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review
orenccl commented on code in PR #5643:
URL: https://github.com/apache/gravitino/pull/5643#discussion_r1855768647
##
web/web/src/lib/utils/initial.js:
##
@@ -570,10 +566,64 @@ const relationalColumnTypeMap = {
]
}
-export const getRelationalColumnTypeMap = catalog => {
- i
orenccl commented on code in PR #5643:
URL: https://github.com/apache/gravitino/pull/5643#discussion_r1855768647
##
web/web/src/lib/utils/initial.js:
##
@@ -570,10 +566,64 @@ const relationalColumnTypeMap = {
]
}
-export const getRelationalColumnTypeMap = catalog => {
- i
sunxiaojian commented on PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#issuecomment-2496721816
> You have changed createArgOption, which changes the behaviour of all CLI
options. Please change the behaviour only for the --tag option
Okay, thanks for your guidance
--
justinmclean commented on PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#issuecomment-2496703203
For 2. You have changed createArgOption, which changes the behaviour of all
CLI options. Please change the behaviour only for the --tag option. For 3
please keep the handle methods
LauraXia123 commented on code in PR #5643:
URL: https://github.com/apache/gravitino/pull/5643#discussion_r1855752008
##
web/web/src/lib/utils/initial.js:
##
@@ -570,10 +566,64 @@ const relationalColumnTypeMap = {
]
}
-export const getRelationalColumnTypeMap = catalog => {
LauraXia123 commented on PR #5643:
URL: https://github.com/apache/gravitino/pull/5643#issuecomment-2496701147
https://github.com/user-attachments/assets/190f0f63-92e4-40b6-9d2f-137a72b896fd";>
Would you mind optimizing the length of the input by the way?
And disabled the immutable prope
sunxiaojian commented on PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#issuecomment-2496690375
> * When removing tags there an extra comma in the output - "xxx removed tag
tagA,tagB, now tagged with nothing"
> There are still a couple of things to fix:
>
danhuawang commented on code in PR #5632:
URL: https://github.com/apache/gravitino/pull/5632#discussion_r1855745116
##
trino-connector/integration-test/src/test/resources/trino-ci-testset/trino-cascading-testsets/lakehouse-iceberg-hive/catalog_iceberg_prepare.sql:
##
@@ -0,0 +1,
diqiu50 commented on PR #5627:
URL: https://github.com/apache/gravitino/pull/5627#issuecomment-2496669374
@FANNG1
I have made modifications. The `-Penable_gvfs_fuse` parameter needs to be
added to build `gvfs_fuse`, and it will not automatically install Rust."
--
This is an automated
diqiu50 commented on code in PR #5627:
URL: https://github.com/apache/gravitino/pull/5627#discussion_r1855740133
##
clients/filesystem-fuse/Cargo.toml:
##
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. S
danhuawang commented on code in PR #5632:
URL: https://github.com/apache/gravitino/pull/5632#discussion_r1855729593
##
trino-connector/integration-test/trino-test-tools/trino-cascading-env/docker-compose.yaml:
##
@@ -59,6 +88,7 @@ services:
- ./init/trino-remote:/tmp/trin
orenccl commented on code in PR #5654:
URL: https://github.com/apache/gravitino/pull/5654#discussion_r1855727168
##
api/build.gradle.kts:
##
@@ -35,3 +37,15 @@ dependencies {
tasks.build {
dependsOn("javadoc")
}
+
+tasks.jar {
+ archiveBaseName.set(artifactName)
+}
+
+publ
jerryshao commented on code in PR #5654:
URL: https://github.com/apache/gravitino/pull/5654#discussion_r1855725365
##
api/build.gradle.kts:
##
@@ -35,3 +37,15 @@ dependencies {
tasks.build {
dependsOn("javadoc")
}
+
+tasks.jar {
+ archiveBaseName.set(artifactName)
+}
+
+pu
jerryshao commented on code in PR #5654:
URL: https://github.com/apache/gravitino/pull/5654#discussion_r1855724832
##
api/build.gradle.kts:
##
@@ -35,3 +37,15 @@ dependencies {
tasks.build {
dependsOn("javadoc")
}
+
+tasks.jar {
+ archiveBaseName.set(artifactName)
+}
+
+pu
suisenkotoba commented on issue #1686:
URL: https://github.com/apache/gravitino/issues/1686#issuecomment-2496605236
@FANNG1
> you could only drop columns with compatibility types for the limitation of
the Hive metastore, like drop column a from table with schema(a int, b int)
coul
jerryshao commented on PR #5654:
URL: https://github.com/apache/gravitino/pull/5654#issuecomment-2496603539
It is occasional, maybe you can configuration that gradle plugin to increase
the timeout or add retry times (but it depends on if that plugin has such
configurations).
--
This is a
FANNG1 merged PR #5612:
URL: https://github.com/apache/gravitino/pull/5612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino
This is an automated email from the ASF dual-hosted git repository.
fanng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new dd87cdd45 [#5600] feat(API): Add Java API definiti
FANNG1 closed issue #5600: [Subtask]Design and implement the Java API for model
and model operation
URL: https://github.com/apache/gravitino/issues/5600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jerryshao commented on PR #5646:
URL: https://github.com/apache/gravitino/pull/5646#issuecomment-2496601874
@mchades @xunliu would you please also help to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jerryshao commented on PR #5645:
URL: https://github.com/apache/gravitino/pull/5645#issuecomment-2496598552
@yuqi1129 please spend time on this PR, to help @pithecuse527 to get this
done, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
FANNG1 commented on issue #5648:
URL: https://github.com/apache/gravitino/issues/5648#issuecomment-2496595110
> I want to try testing it myself and will update you on the progress.
>
> Thanks for your help!
please contact me if encounter any problems, credential vending is somet
jerryshao commented on PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#issuecomment-2496591926
There're some UT failures that need to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
orenccl commented on PR #5654:
URL: https://github.com/apache/gravitino/pull/5654#issuecomment-2496587676
I also encountered this network error on other pull requests. Is there a way
to improve this?
```
> Task :clients:client-python:downloadHadoopPack FAILED
* What went wrong:
FANNG1 commented on issue #5648:
URL: https://github.com/apache/gravitino/issues/5648#issuecomment-2496587806
Yes, it should be worked if you are passing the specific locations. Do you
have a AWS or GCS account ? If yes, you cloud create to create a Iceberg table
with specific metadata or
xunliu commented on PR #5606:
URL: https://github.com/apache/gravitino/pull/5606#issuecomment-2496580672
hi @waukin I will help you improve your this PR, Please wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
danhuawang commented on issue #5660:
URL: https://github.com/apache/gravitino/issues/5660#issuecomment-2496567599
@diqiu50 Can you help check this issue? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
diqiu50 commented on code in PR #5632:
URL: https://github.com/apache/gravitino/pull/5632#discussion_r1855703929
##
trino-connector/integration-test/trino-test-tools/trino-cascading-env/init/hive/init.sh:
##
@@ -0,0 +1,24 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
diqiu50 commented on code in PR #5632:
URL: https://github.com/apache/gravitino/pull/5632#discussion_r1855703929
##
trino-connector/integration-test/trino-test-tools/trino-cascading-env/init/hive/init.sh:
##
@@ -0,0 +1,24 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
danhuawang opened a new issue, #5660:
URL: https://github.com/apache/gravitino/issues/5660
### Version
main branch
### Describe what's wrong
Load the PG table including Array data encounter unknown field error. But
gravitino doc says we support Array data type in PG cat
danhuawang commented on issue #5658:
URL: https://github.com/apache/gravitino/issues/5658#issuecomment-2496550257
@diqiu50 Can you help check this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
tengqm commented on code in PR #5629:
URL: https://github.com/apache/gravitino/pull/5629#discussion_r1855702455
##
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java:
##
@@ -86,6 +86,9 @@ public RangerHelper(
*/
v
diqiu50 commented on code in PR #5632:
URL: https://github.com/apache/gravitino/pull/5632#discussion_r1855702248
##
trino-connector/integration-test/trino-test-tools/trino-cascading-env/docker-compose.yaml:
##
@@ -59,6 +88,7 @@ services:
- ./init/trino-remote:/tmp/trino
danhuawang commented on issue #5659:
URL: https://github.com/apache/gravitino/issues/5659#issuecomment-2496558306
@diqiu50 Can you take a look at this issue? Do we have plan to support
this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
danhuawang opened a new issue, #5659:
URL: https://github.com/apache/gravitino/issues/5659
### What would you like to be improved?
If the table in MySQL data source including the data type 'BOOLEAN', Trino
can't load the original data in MySQL table.
This block the data load proce
danhuawang opened a new issue, #5658:
URL: https://github.com/apache/gravitino/issues/5658
### Version
main branch
### Describe what's wrong
In MySQL data source:
```
create table my_tb05 (col_timestamp TIMESTAMP);
insert into my_tb05 values (CURRENT_TIMESTAM
danhuawang commented on issue #5657:
URL: https://github.com/apache/gravitino/issues/5657#issuecomment-2496543451
@diqiu50 Can you take a look at this issue ? Do we have plan to support
this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
danhuawang opened a new issue, #5657:
URL: https://github.com/apache/gravitino/issues/5657
### What would you like to be improved?
When the data source MySQL has the data including JSON type data as
following. Then I configure the MySQL catalog in Trino and try to load the
original d
theoryxu commented on code in PR #5629:
URL: https://github.com/apache/gravitino/pull/5629#discussion_r1855678616
##
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java:
##
@@ -86,6 +86,9 @@ public RangerHelper(
*/
danhuawang commented on issue #5656:
URL: https://github.com/apache/gravitino/issues/5656#issuecomment-2496530534
@diqiu50 Can you help check this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
danhuawang opened a new issue, #5656:
URL: https://github.com/apache/gravitino/issues/5656
### Version
main branch
### Describe what's wrong
I can't create table including ARRAY data type in Trino when I use the PG
catalog.
```
trino:db3> CREATE TABLE tb02 (i
danhuawang commented on issue #5655:
URL: https://github.com/apache/gravitino/issues/5655#issuecomment-2496522377
@diqiu50 Can you help check this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
danhuawang opened a new issue, #5655:
URL: https://github.com/apache/gravitino/issues/5655
### Version
main branch
### Describe what's wrong
ADD COLUMN NOT NULL as following, it failed.
I think the NULL value of the name column shouldn't impact add the column
"gende
xloya commented on PR #5612:
URL: https://github.com/apache/gravitino/pull/5612#issuecomment-2496517235
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
charliecheng630 commented on issue #5098:
URL: https://github.com/apache/gravitino/issues/5098#issuecomment-2496505587
@mchades Due to a busy work schedule, I’m afraid I won’t have time to fix
this bug. I recommend seeking help from other contributors to complete this
issue.
--
This is a
unknowntpo opened a new pull request, #110:
URL: https://github.com/apache/gravitino-playground/pull/110
Resolve #108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
justinmclean commented on PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#issuecomment-2496445689
There are still a couple of things to fix:
- There are unnecessary checks if tags are null that are not needed, as the
CLI library will detect if you pass no tags and give an err
orenccl commented on issue #5648:
URL: https://github.com/apache/gravitino/issues/5648#issuecomment-2496110660
Currently, the only solution I can think of is to pass `WRITE_DATA_LOCATION`
and `WRITE_METADATA_LOCATION` when injecting CredentialConfig.
```diff
CredentialUtils.vendCr
orenccl opened a new pull request, #5654:
URL: https://github.com/apache/gravitino/pull/5654
### What changes were proposed in this pull request?
As title
### Why are the changes needed?
Fix: # (issue)
### Does this PR introduce _any_ user-facing change?
Ma
LiuQhahah commented on PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#issuecomment-2495929374
> @LiuQhahah ,LGTM except minor comments, could you fix it ?
Hi @FANNG1
I have fixed the issue.
Please review it again.
Thanks,
Qiang
--
This is an automa
sunxiaojian commented on code in PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#discussion_r1855404233
##
clients/cli/src/main/java/org/apache/gravitino/cli/commands/DeleteTag.java:
##
@@ -28,52 +31,55 @@
public class DeleteTag extends Command {
protected fin
sunxiaojian commented on code in PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#discussion_r1855404172
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -444,44 +449,66 @@ protected void handleTagCommand() {
}
} else
sunxiaojian commented on code in PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#discussion_r1855404091
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -432,10 +433,14 @@ protected void handleTagCommand() {
String url = ge
sunxiaojian commented on code in PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#discussion_r1855404045
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -444,44 +449,66 @@ protected void handleTagCommand() {
}
} else
orenccl opened a new pull request, #5653:
URL: https://github.com/apache/gravitino/pull/5653
### What changes were proposed in this pull request?
- Capitalized display type values.
- Sorted the provider list alphabetically.
### Why are these changes needed?
Fix: #5650
sunxiaojian commented on code in PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#discussion_r1855401472
##
clients/cli/src/main/java/org/apache/gravitino/cli/commands/DeleteTag.java:
##
@@ -28,52 +31,55 @@
public class DeleteTag extends Command {
protected fin
sunxiaojian commented on code in PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#discussion_r1853728705
##
docs/cli.md:
##
@@ -456,10 +457,10 @@ gcli group delete --group new_group
gcli tag details --tag tagA
```
- Create a tag
+ Create tags
```bash
-
sunxiaojian commented on code in PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#discussion_r1853683208
##
docs/cli.md:
##
@@ -468,22 +469,22 @@ gcli tag details --tag tagA
gcli tag list
```
- Delete a tag
+ Delete tags
```bash
-gcli tag delete --tag
sunxiaojian commented on code in PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#discussion_r1853683208
##
docs/cli.md:
##
@@ -468,22 +469,22 @@ gcli tag details --tag tagA
gcli tag list
```
- Delete a tag
+ Delete tags
```bash
-gcli tag delete --tag
sunxiaojian commented on code in PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#discussion_r1853683208
##
docs/cli.md:
##
@@ -468,22 +469,22 @@ gcli tag details --tag tagA
gcli tag list
```
- Delete a tag
+ Delete tags
```bash
-gcli tag delete --tag
sunxiaojian commented on PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#issuecomment-2495880243
> Hi I don't mean comments in the code, I mean comments on this PR that have
not been addressed.
I also mean this PR comment， Can you point out which one has not been
resolve
FANNG1 commented on PR #5652:
URL: https://github.com/apache/gravitino/pull/5652#issuecomment-2495876072
LGTM except one minor comment, @TungYuChiang could you fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
FANNG1 commented on code in PR #5652:
URL: https://github.com/apache/gravitino/pull/5652#discussion_r1855397012
##
core/src/main/java/org/apache/gravitino/listener/api/event/AlterFilesetPreEvent.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
justinmclean commented on PR #5641:
URL: https://github.com/apache/gravitino/pull/5641#issuecomment-2495867454
Hi I don't mean comments in the code, I mean comments on this PR that have
not been addressed.
--
This is an automated message from the Apache Git Service.
To respond to the mess
98 matches
Mail list logo
