orenccl commented on code in PR #5643:
URL: https://github.com/apache/gravitino/pull/5643#discussion_r1855768647
##########
web/web/src/lib/utils/initial.js:
##########
@@ -570,10 +566,64 @@ const relationalColumnTypeMap = {
]
}
-export const getRelationalColumnTypeMap = catalog => {
- if (Object.keys(relationalColumnTypeMap).includes(catalog)) {
+export const getRelationalColumnType = catalog => {
+ if (Object.hasOwn(relationalColumnTypeMap, catalog)) {
return relationalColumnTypeMap[catalog]
}
return []
}
+
+const relationalTablePropInfoMap = {
+ 'lakehouse-iceberg': {
+ reserved: ['location'],
Review Comment:
Sorry, I missed that. Will update it.
Some properties, like `serde-name`, are not in the documentation, but are
they also immutable?
##########
web/web/src/lib/utils/initial.js:
##########
@@ -570,10 +566,64 @@ const relationalColumnTypeMap = {
]
}
-export const getRelationalColumnTypeMap = catalog => {
- if (Object.keys(relationalColumnTypeMap).includes(catalog)) {
+export const getRelationalColumnType = catalog => {
+ if (Object.hasOwn(relationalColumnTypeMap, catalog)) {
return relationalColumnTypeMap[catalog]
}
return []
}
+
+const relationalTablePropInfoMap = {
+ 'lakehouse-iceberg': {
+ reserved: ['location'],
Review Comment:
Sorry, I missed that. Will update it.
Some properties, like `serde-name`, are not in the documentation, but they
also immutable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
