Re: [PR] [5201]Implement expressions in python client [gravitino]

2024-11-22 Thread via GitHub
SophieTech88 commented on code in PR #5646: URL: https://github.com/apache/gravitino/pull/5646#discussion_r1855126932 ## clients/client-python/gravitino/api/expressions/named_reference.py: ## @@ -0,0 +1,76 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or mo

Re: [PR] [5201]Implement expressions in python client [gravitino]

2024-11-22 Thread via GitHub
SophieTech88 commented on code in PR #5646: URL: https://github.com/apache/gravitino/pull/5646#discussion_r1855126556 ## clients/client-python/gravitino/api/expressions/named_reference.py: ## @@ -0,0 +1,76 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or mo

Re: [PR] [5201]Implement expressions in python client [gravitino]

2024-11-22 Thread via GitHub
SophieTech88 commented on code in PR #5646: URL: https://github.com/apache/gravitino/pull/5646#discussion_r1855125964 ## clients/client-python/gravitino/api/expressions/function_expression.py: ## @@ -0,0 +1,90 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# o

Re: [I] [Improvement] Web UI create catalog page minor issues [gravitino]

2024-11-22 Thread via GitHub
orenccl commented on issue #5650: URL: https://github.com/apache/gravitino/issues/5650#issuecomment-2494338025 Hi, I’d like to work on this issue. Please assign it to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [#5437] feat(core): add schema event for Iceberg REST server [gravitino]

2024-11-22 Thread via GitHub
orenccl commented on code in PR #5651: URL: https://github.com/apache/gravitino/pull/5651#discussion_r1854279212 ## iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/dispatcher/IcebergNamespaceEventDispatcher.java: ## @@ -0,0 +1,238 @@ +/* + * Licen

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

2024-11-22 Thread via GitHub
pithecuse527 commented on PR #5645: URL: https://github.com/apache/gravitino/pull/5645#issuecomment-2493966408 @jerryshao Hello, I have removed the module `meta` and its related implementations. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [#5437] feat(core): add schema event for Iceberg REST server [gravitino]

2024-11-22 Thread via GitHub
orenccl commented on PR #5651: URL: https://github.com/apache/gravitino/pull/5651#issuecomment-2493779302 I’m also having difficulty properly setting up MockNamespaceOperation for table and view unit tests. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [I] [Subtask] [flink-connector] Support database operation DDL for paimon-catalog [gravitino]

2024-11-22 Thread via GitHub
hdygxsj commented on issue #5193: URL: https://github.com/apache/gravitino/issues/5193#issuecomment-2493776624 Can it be assigned to me? Our company is in need of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] [Subtask] [flink-connector] Support basic table DDL Operation for paimon-catalog [gravitino]

2024-11-22 Thread via GitHub
hdygxsj commented on issue #5194: URL: https://github.com/apache/gravitino/issues/5194#issuecomment-2493776920 Can it be assigned to me? Our company is in need of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] [Subtask] [flink-connector] Support Catalog Operation DDL for paimon-catalog [gravitino]

2024-11-22 Thread via GitHub
hdygxsj commented on issue #5192: URL: https://github.com/apache/gravitino/issues/5192#issuecomment-2493776223 Can it be assigned to me? Our company is in need of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse [gravitino]

2024-11-22 Thread via GitHub
jerryshao commented on PR #5627: URL: https://github.com/apache/gravitino/pull/5627#issuecomment-2493605083 @FANNG1 can you please help to review again? If there's no blocking issue, I think we can improve the building command in the following PRs, what do you think? -- This is an automa

Re: [I] [Bug report] Drop iceberg table column failed [gravitino]

2024-11-22 Thread via GitHub
suisenkotoba commented on issue #1686: URL: https://github.com/apache/gravitino/issues/1686#issuecomment-2493587015 @yuqi1129 if this is not a bug, how should we drop a column from an iceberg table then? -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] [Improvement] Remove gravitino-docs-*.jar from Gravitino release files [gravitino]

2024-11-22 Thread via GitHub
jerryshao merged PR #5615: URL: https://github.com/apache/gravitino/pull/5615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#5336] feat(auth-ranger): Remove MANAGED_BY_GRAVITINO limit and compatible for existing ranger policy [gravitino]

2024-11-22 Thread via GitHub
tengqm commented on code in PR #5629: URL: https://github.com/apache/gravitino/pull/5629#discussion_r1853759002 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java: ## @@ -86,6 +86,9 @@ public RangerHelper( */ v

Re: [PR] [#5528]Improvement[cli] Add and delete multiple tags at once in the Gravitino CLI [gravitino]

2024-11-22 Thread via GitHub
sunxiaojian commented on PR #5641: URL: https://github.com/apache/gravitino/pull/5641#issuecomment-2493522923 @justinmclean @tengqm PTAL, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [5201]Implement expressions in python client [gravitino]

2024-11-22 Thread via GitHub
tengqm commented on code in PR #5646: URL: https://github.com/apache/gravitino/pull/5646#discussion_r1853747579 ## clients/client-python/gravitino/api/expressions/named_reference.py: ## @@ -0,0 +1,76 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Commen

Re: [I] [Improvement] Remove `gravitino-docs-0.7.0-incubating.jar` from Gravitino release files as it's a useless and empty files. [gravitino]

2024-11-22 Thread via GitHub
jerryshao closed issue #5490: [Improvement] Remove `gravitino-docs-0.7.0-incubating.jar` from Gravitino release files as it's a useless and empty files. URL: https://github.com/apache/gravitino/issues/5490 -- This is an automated message from the Apache Git Service. To respond to the message

(gravitino) branch main updated: [Improvement] Remove gravitino-docs-*.jar from Gravitino release files (#5615)

2024-11-22 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new e89d80fa8 [Improvement] Remove gravitino-docs-*.ja

Re: [I] [Improvement] Remove `gravitino-docs-0.7.0-incubating.jar` from Gravitino release files as it's a useless and empty files. [gravitino]

2024-11-22 Thread via GitHub
jerryshao closed issue #5490: [Improvement] Remove `gravitino-docs-0.7.0-incubating.jar` from Gravitino release files as it's a useless and empty files. URL: https://github.com/apache/gravitino/issues/5490 -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] [#5437] feat(core): add schema event for Iceberg REST server [gravitino]

2024-11-22 Thread via GitHub
tengqm commented on code in PR #5651: URL: https://github.com/apache/gravitino/pull/5651#discussion_r1853725507 ## iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/dispatcher/IcebergNamespaceEventDispatcher.java: ## @@ -0,0 +1,238 @@ +/* + * Licens

Re: [PR] [#5528]Improvement[cli] Add and delete multiple tags at once in the Gravitino CLI [gravitino]

2024-11-22 Thread via GitHub
sunxiaojian commented on code in PR #5641: URL: https://github.com/apache/gravitino/pull/5641#discussion_r1853683208 ## docs/cli.md: ## @@ -468,22 +469,22 @@ gcli tag details --tag tagA gcli tag list ``` - Delete a tag + Delete tags ```bash -gcli tag delete --tag

Re: [PR] [#5528]Improvement[cli] Add and delete multiple tags at once in the Gravitino CLI [gravitino]

2024-11-22 Thread via GitHub
sunxiaojian commented on code in PR #5641: URL: https://github.com/apache/gravitino/pull/5641#discussion_r1853728705 ## docs/cli.md: ## @@ -456,10 +457,10 @@ gcli group delete --group new_group gcli tag details --tag tagA ``` - Create a tag + Create tags ```bash -

Re: [PR] [#5384] Added OAuth support to Gravitino CLI [gravitino]

2024-11-22 Thread via GitHub
tengqm commented on code in PR #5618: URL: https://github.com/apache/gravitino/pull/5618#discussion_r1853720738 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java: ## @@ -42,10 +42,12 @@ public class GravitinoOptions { public static final String TAG =

Re: [PR] [#5437] feat(core): add schema event for Iceberg REST server [gravitino]

2024-11-22 Thread via GitHub
orenccl commented on PR #5651: URL: https://github.com/apache/gravitino/pull/5651#issuecomment-2493431218 Hi, @FANNG1 ### Couple of Questions 1. Should I use `OperationType.*_SCHEMA`, or should I create a new type called `OperationType.*_NAMESPACE`? 2. Currently, there

[PR] [#5437] feat(core): add schema event for Iceberg REST server [gravitino]

2024-11-22 Thread via GitHub
orenccl opened a new pull request, #5651: URL: https://github.com/apache/gravitino/pull/5651 ### What changes were proposed in this pull request? add schema event for Iceberg REST server ### Why are the changes needed? Fix: #5437 ### Does this PR introduce _any_ us

Re: [PR] [#5528]Improvement[cli] Add and delete multiple tags at once in the Gravitino CLI [gravitino]

2024-11-22 Thread via GitHub
sunxiaojian commented on code in PR #5641: URL: https://github.com/apache/gravitino/pull/5641#discussion_r1853683208 ## docs/cli.md: ## @@ -468,22 +469,22 @@ gcli tag details --tag tagA gcli tag list ``` - Delete a tag + Delete tags ```bash -gcli tag delete --tag

Re: [PR] [#5528]Improvement[cli] Add and delete multiple tags at once in the Gravitino CLI [gravitino]

2024-11-22 Thread via GitHub
sunxiaojian commented on code in PR #5641: URL: https://github.com/apache/gravitino/pull/5641#discussion_r1853674390 ## docs/cli.md: ## @@ -44,6 +44,7 @@ The general structure for running commands with the Gravitino CLI is `gcli entit --renamenew entity name -s,-

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-22 Thread via GitHub
jerryshao commented on PR #5612: URL: https://github.com/apache/gravitino/pull/5612#issuecomment-2493370665 @xloya @FANNG1 can you please take another review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[I] [Improvement] Web UI create catalog page minor issues [gravitino]

2024-11-22 Thread via GitHub
shaofengshi opened a new issue, #5650: URL: https://github.com/apache/gravitino/issues/5650 ### What would you like to be improved? 1. the "Type" filed, the displayed values, the first character should be capitalized 2. the provider list, should be sorted in alphabet https://gi

(gravitino) branch main updated: [#5452] Improvement(web): add REST catalog backend for Iceberg catalog (#5635)

2024-11-22 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 7c2c0f0ae [#5452] Improvement(web): add REST catal

Re: [PR] [#5452] Improvement(web): add REST catalog backend for Iceberg catalog [gravitino]

2024-11-22 Thread via GitHub
jerryshao merged PR #5635: URL: https://github.com/apache/gravitino/pull/5635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit