Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
justinmclean commented on PR #5058: URL: https://github.com/apache/gravitino/pull/5058#issuecomment-2430980192 All requested changes have been done, @jerryshao if you could please review, that would be appreciated. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
justinmclean commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1811911157 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/TableDetails.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [I] [FEATURE] Support query the unified Fileset Data Source in Spark [gravitino]

2024-10-22 Thread via GitHub
coolderli commented on issue #5226: URL: https://github.com/apache/gravitino/issues/5226#issuecomment-2430807111 I think this is a very meaningful feature. We can better analyze the fileset while preserving its file semantics. By binding the schema, we can skip the inference stage of the sc

Re: [PR] [#5172]fix bug:Iceberg catalog audit user is not correct [gravitino]

2024-10-22 Thread via GitHub
FANNG1 commented on PR #5208: URL: https://github.com/apache/gravitino/pull/5208#issuecomment-2430751384 @lsyulong thanks for your work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [I] [FEATURE] Support query the unified Fileset Data Source in Spark [gravitino]

2024-10-22 Thread via GitHub
xloya commented on issue #5226: URL: https://github.com/apache/gravitino/issues/5226#issuecomment-2430694320 @jerryshao @shaofengshi @FANNG1 @coolderli What do you think? Please share your opinion when you have time, thanks. -- This is an automated message from the Apache Git Service. To

[I] [FEATURE] Support query the unified Fileset Data Source in Spark [gravitino]

2024-10-22 Thread via GitHub
: ``` // Dataframe API val df = sparkSession .read .parquet("gvfs://fileset/fileset_catalog/tmp/test_fileset/date=20241021") df.write .mode("overwrite") .parquet("gvfs://fileset/fileset_catalog/tmp/test_fileset/date=20241022") // SQL

Re: [PR] [#5206] improvement(web): Web UI add delete metalake/catalog reminder [gravitino]

2024-10-22 Thread via GitHub
mchades commented on PR #5216: URL: https://github.com/apache/gravitino/pull/5216#issuecomment-2430664514 Can you help review the content of this reminder? @shaofengshi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] [Bug report] Iceberg catalog audit user is not correct [gravitino]

2024-10-22 Thread via GitHub
FANNG1 closed issue #5172: [Bug report] Iceberg catalog audit user is not correct URL: https://github.com/apache/gravitino/issues/5172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

(gravitino) branch main updated: [#5172]fix bug:Iceberg catalog audit user is not correct (#5208)

2024-10-22 Thread fanng
This is an automated email from the ASF dual-hosted git repository. fanng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 44a47d088 [#5172]fix bug:Iceberg catalog audit use

Re: [I] [Bug report] Iceberg catalog audit user is not correct [gravitino]

2024-10-22 Thread via GitHub
FANNG1 closed issue #5172: [Bug report] Iceberg catalog audit user is not correct URL: https://github.com/apache/gravitino/issues/5172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [#5172]fix bug:Iceberg catalog audit user is not correct [gravitino]

2024-10-22 Thread via GitHub
FANNG1 merged PR #5208: URL: https://github.com/apache/gravitino/pull/5208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

Re: [PR] [#5188] feat(python-client): Support s3 fileset in python client [gravitino]

2024-10-22 Thread via GitHub
yuqi1129 commented on code in PR #5209: URL: https://github.com/apache/gravitino/pull/5209#discussion_r1811654523 ## clients/client-python/gravitino/filesystem/gvfs.py: ## @@ -819,5 +840,40 @@ def _get_gcs_filesystem(self): return importlib.import_module("pyarrow.fs")

[PR] [#5211] feat(python-client): Support OSS for fileset python client [gravitino]

2024-10-22 Thread via GitHub
yuqi1129 opened a new pull request, #5225: URL: https://github.com/apache/gravitino/pull/5225 ### What changes were proposed in this pull request? Add support for Aliyun OSS python client. ### Why are the changes needed? It's a need Fix: #5211 ### Does this

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
justinmclean commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1811651174 ## clients/cli/docs/README.md: ## @@ -0,0 +1,149 @@ + + +# Apache Gravitino Command Line Interface + +Apache Gravitino CLI is a command-line tool that interacts

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
justinmclean commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1811650289 ## clients/cli/docs/README.md: ## @@ -0,0 +1,149 @@ + + +# Apache Gravitino Command Line Interface + +Apache Gravitino CLI is a command-line tool that interacts

Re: [PR] [#5211] feat(python-client): Support OSS for fileset python client [gravitino]

2024-10-22 Thread via GitHub
yuqi1129 commented on PR #5225: URL: https://github.com/apache/gravitino/pull/5225#issuecomment-2430629656 This PR is not ready for review until #5209 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [#5188] feat(python-client): Support s3 fileset in python client [gravitino]

2024-10-22 Thread via GitHub
xloya commented on code in PR #5209: URL: https://github.com/apache/gravitino/pull/5209#discussion_r1811644341 ## clients/client-python/gravitino/filesystem/gvfs.py: ## @@ -819,5 +840,40 @@ def _get_gcs_filesystem(self): return importlib.import_module("pyarrow.fs").Gc

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1811621551 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/TableDetails.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
justinmclean commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1811614810 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/TableDetails.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1811614926 ## clients/cli/docs/README.md: ## @@ -0,0 +1,149 @@ + + +# Apache Gravitino Command Line Interface + +Apache Gravitino CLI is a command-line tool that interacts wit

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
justinmclean commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1811614810 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/TableDetails.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
justinmclean commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1811607667 ## clients/cli/docs/README.md: ## @@ -0,0 +1,149 @@ + + +# Apache Gravitino Command Line Interface + +Apache Gravitino CLI is a command-line tool that interacts

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
justinmclean commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1811607667 ## clients/cli/docs/README.md: ## @@ -0,0 +1,149 @@ + + +# Apache Gravitino Command Line Interface + +Apache Gravitino CLI is a command-line tool that interacts

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
justinmclean commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1811606901 ## clients/cli/docs/README.md: ## @@ -0,0 +1,149 @@ + + +# Apache Gravitino Command Line Interface + +Apache Gravitino CLI is a command-line tool that interacts

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1811606848 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/Command.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1811605666 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/TableDetails.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1811592564 ## clients/cli/docs/README.md: ## @@ -0,0 +1,149 @@ + + +# Apache Gravitino Command Line Interface + +Apache Gravitino CLI is a command-line tool that interacts wit

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
justinmclean commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1811578915 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/TableDetails.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] [#5068] feat(core): support GCS token provider [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on PR #5224: URL: https://github.com/apache/gravitino/pull/5224#issuecomment-2430506437 You'd better ping @jerqi and @yuqi1129 review first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
justinmclean commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1811552929 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/Command.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
justinmclean commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1811547416 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
justinmclean commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1811537635 ## clients/cli/docs/README.md: ## @@ -0,0 +1,149 @@ + + +# Apache Gravitino Command Line Interface + +Apache Gravitino CLI is a command-line tool that interacts

Re: [PR] [#4984] improvement(core, doris): Add the random distribution strategy [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on PR #4985: URL: https://github.com/apache/gravitino/pull/4985#issuecomment-2429447945 @yuqi1129 this should be merged before 0.7.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1810753663 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [#5196] improve(auth-ranger): Refactor RangerSecurableObject class [gravitino]

2024-10-22 Thread via GitHub
xunliu commented on code in PR #5222: URL: https://github.com/apache/gravitino/pull/5222#discussion_r1810793039 ## api/src/main/java/org/apache/gravitino/MetadataObjects.java: ## @@ -159,7 +160,7 @@ public static MetadataObject parse(String fullName, MetadataObject.Type type) {

Re: [PR] [SIP] support GCS token provider [gravitino]

2024-10-22 Thread via GitHub
FANNG1 commented on PR #5224: URL: https://github.com/apache/gravitino/pull/5224#issuecomment-2429329523 @jerryshao please help to review when you have time, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on PR #5058: URL: https://github.com/apache/gravitino/pull/5058#issuecomment-2429297198 > Hi Justin, my comments are all resolved now, thank you! > > I see you have replied Jerry's comments; I think he suggests to move the document to gravitino project's "docs" fol

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1810725014 ## clients/cli/docs/README.md: ## @@ -0,0 +1,149 @@ + + +# Apache Gravitino Command Line Interface + +Apache Gravitino CLI is a command-line tool that interacts wit

Re: [PR] [#5114] Improvement:use incubating version in docs [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on PR #5207: URL: https://github.com/apache/gravitino/pull/5207#issuecomment-2429273462 Seems like you still need to fix the conflicts before it can be merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [#5114] Improvement:use incubating version in docs [gravitino]

2024-10-22 Thread via GitHub
lsyulong commented on PR #5207: URL: https://github.com/apache/gravitino/pull/5207#issuecomment-2429243426 > Just rebase your branch against main branch, then solve the conflicts, that should be enough. Sorry, due to network issues, I submitted multiple revisions during the process,

Re: [I] [Improvement] README.md should refer the link to our doc website but not doc's source directory [gravitino]

2024-10-22 Thread via GitHub
jerryshao closed issue #5109: [Improvement] README.md should refer the link to our doc website but not doc's source directory URL: https://github.com/apache/gravitino/issues/5109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

(gravitino) branch main updated (6a9a77b8f -> 3f2456efb)

2024-10-22 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git from 6a9a77b8f [#5204] feat(iceberg): support more table event for Iceberg REST server (#5156) add 3f2456efb [#5109

Re: [PR] [#5109] fix(doc): fix link to documentation website in README [gravitino]

2024-10-22 Thread via GitHub
jerryshao merged PR #5149: URL: https://github.com/apache/gravitino/pull/5149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#5196] improve(auth-ranger): Refactor RangerSecurableObject class [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on code in PR #5222: URL: https://github.com/apache/gravitino/pull/5222#discussion_r1810676453 ## api/src/main/java/org/apache/gravitino/MetadataObjects.java: ## @@ -159,7 +160,7 @@ public static MetadataObject parse(String fullName, MetadataObject.Type type

Re: [PR] [#5196] improve(auth-ranger): Refactor RangerSecurableObject class [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on code in PR #5222: URL: https://github.com/apache/gravitino/pull/5222#discussion_r1810673549 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerMetadataObjects.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to

(gravitino) branch main updated: [#5204] feat(iceberg): support more table event for Iceberg REST server (#5156)

2024-10-22 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 6a9a77b8f [#5204] feat(iceberg): support more ta

Re: [I] [EPIC] event listener for IcebergRESTServer [gravitino]

2024-10-22 Thread via GitHub
jerryshao closed issue #5204: [EPIC] event listener for IcebergRESTServer URL: https://github.com/apache/gravitino/issues/5204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [#5204] feat(iceberg): support more table event for Iceberg REST server [gravitino]

2024-10-22 Thread via GitHub
jerryshao merged PR #5156: URL: https://github.com/apache/gravitino/pull/5156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#5114] Improvement:use incubating version in docs [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on PR #5207: URL: https://github.com/apache/gravitino/pull/5207#issuecomment-2429192300 Just rebase your branch against main branch, then solve the conflicts, that should be enough. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] [#5172]fix bug:Iceberg catalog audit user is not correct [gravitino]

2024-10-22 Thread via GitHub
lsyulong commented on PR #5208: URL: https://github.com/apache/gravitino/pull/5208#issuecomment-2429179888 > @lsyulong, thanks for your PR. There are similar problems in `JdbcCatalog`. Would you like to fix them together in this PR? https://github.com/apache/gravitino/blob/main/catalogs/cat

[PR] [SIP] support GCS token provider [gravitino]

2024-10-22 Thread via GitHub
FANNG1 opened a new pull request, #5224: URL: https://github.com/apache/gravitino/pull/5224 ### What changes were proposed in this pull request? (Please outline the changes and how this PR fixes the issue.) ### Why are the changes needed? (Please clarify why the c

Re: [PR] support GCS credentail provider [gravitino]

2024-10-22 Thread via GitHub
FANNG1 closed pull request #5179: support GCS credentail provider URL: https://github.com/apache/gravitino/pull/5179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] [MINOR] Fix iceberg catalog backend name [gravitino-playground]

2024-10-22 Thread via GitHub
FANNG1 commented on PR #80: URL: https://github.com/apache/gravitino-playground/pull/80#issuecomment-2428982912 included in another PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [MINOR] Fix iceberg catalog backend name [gravitino-playground]

2024-10-22 Thread via GitHub
FANNG1 closed pull request #80: [MINOR] Fix iceberg catalog backend name URL: https://github.com/apache/gravitino-playground/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [#4014] feat(catalog-lakehouse-paimon): Support kerberos auth for Paimon HiveCatalog [gravitino]

2024-10-22 Thread via GitHub
FANNG1 commented on PR #5136: URL: https://github.com/apache/gravitino/pull/5136#issuecomment-242898 @jerqi @yuqi1129 do you have time to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] [#5204] feat(iceberg): support more table event for Iceberg REST server [gravitino]

2024-10-22 Thread via GitHub
FANNG1 commented on code in PR #5156: URL: https://github.com/apache/gravitino/pull/5156#discussion_r1810508730 ## iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergTableOperations.java: ## @@ -101,8 +102,12 @@ public IcebergTableOperatio

[PR] [#5268][#5269][#5270] Feature(web): Add ui support for creating, editing, viewing, … [gravitino]

2024-10-22 Thread via GitHub
LauraXia123 opened a new pull request, #5223: URL: https://github.com/apache/gravitino/pull/5223 …and deleting fileset ### What changes were proposed in this pull request? Add ui support for creating, editing, viewing, and deleting fileset https://github.com/user-attachme

Re: [I] [Subtask] Add support for creating schema UI [gravitino]

2024-10-22 Thread via GitHub
jerryshao closed issue #5141: [Subtask] Add support for creating schema UI URL: https://github.com/apache/gravitino/issues/5141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] [Subtask] Add support for editing schema UI [gravitino]

2024-10-22 Thread via GitHub
jerryshao closed issue #5142: [Subtask] Add support for editing schema UI URL: https://github.com/apache/gravitino/issues/5142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [I] [Subtask] Add support for deleting schema UI [gravitino]

2024-10-22 Thread via GitHub
jerryshao closed issue #5143: [Subtask] Add support for deleting schema UI URL: https://github.com/apache/gravitino/issues/5143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [#5141][#5142][#5143] web(ui): Add support for creating, editing, and deleting schema [gravitino]

2024-10-22 Thread via GitHub
jerryshao merged PR #5164: URL: https://github.com/apache/gravitino/pull/5164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Subtask] Add support for creating schema UI [gravitino]

2024-10-22 Thread via GitHub
jerryshao closed issue #5141: [Subtask] Add support for creating schema UI URL: https://github.com/apache/gravitino/issues/5141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] [EPIC] Add ui support for creating, editing, viewing and deleting schema [gravitino]

2024-10-22 Thread via GitHub
jerryshao closed issue #5140: [EPIC] Add ui support for creating, editing, viewing and deleting schema URL: https://github.com/apache/gravitino/issues/5140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(gravitino) branch main updated: [#5141][#5142][#5143] web(ui): Add support for creating, editing, and deleting schema (#5164)

2024-10-22 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new ab3e7cd32 [#5141][#5142][#5143] web(ui): Add suppo

Re: [PR] [#5204] feat(iceberg): support more table event for Iceberg REST server [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on PR #5156: URL: https://github.com/apache/gravitino/pull/5156#issuecomment-2428904918 Just two minor issues, others LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [#5204] feat(iceberg): support more table event for Iceberg REST server [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on code in PR #5156: URL: https://github.com/apache/gravitino/pull/5156#discussion_r1810453783 ## iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergTableOperations.java: ## @@ -195,21 +199,23 @@ public Response loadTab

Re: [PR] [#5204] feat(iceberg): support more table event for Iceberg REST server [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on code in PR #5156: URL: https://github.com/apache/gravitino/pull/5156#discussion_r1810451154 ## iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergTableOperations.java: ## @@ -101,8 +102,12 @@ public IcebergTableOpera

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
shaofengshi commented on PR #5058: URL: https://github.com/apache/gravitino/pull/5058#issuecomment-2428874558 Hi Justin, my comments are all resolved now, thank you! I see you have replied Jerry's comments; I think he suggests to move the document to gravitino project's "docs" folder

Re: [PR] [#5114] Improvement:use incubating version in docs [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on code in PR #5207: URL: https://github.com/apache/gravitino/pull/5207#discussion_r1810375903 ## docs/how-to-use-gvfs.md: ## @@ -335,18 +335,17 @@ to recompile the native libraries like `libhdfs` and others, and completely repl ### Configuration -| Con

Re: [I] [Improvement] add jdbc-driver to Paimon JDBC catalog backend configuration [gravitino]

2024-10-22 Thread via GitHub
caican00 commented on issue #5214: URL: https://github.com/apache/gravitino/issues/5214#issuecomment-2428823725 > cc @caican00 please help to check this when you have time, thanks @FANNG1 ok, thanks for pointing out this issue -- This is an automated message from the Apache Git Serv

[PR] [#5196] improve(auth-ranger): Refactor RangerSecurableObject class [gravitino]

2024-10-22 Thread via GitHub
xunliu opened a new pull request, #5222: URL: https://github.com/apache/gravitino/pull/5222 ### What changes were proposed in this pull request? 1. Add `RangerMetadataObject` class. ### Why are the changes needed? Currently, RangerSecurableObject extends MetadataObject, b

(gravitino) branch main updated: [#5181] feat(oceanbase-catalog): Add implementation for converter package (#5182)

2024-10-22 Thread mchades
This is an automated email from the ASF dual-hosted git repository. mchades pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 51e42ea79 [#5181] feat(oceanbase-catalog): Add i

Re: [I] [Subtask] Add implementations for converter package. [gravitino]

2024-10-22 Thread via GitHub
mchades closed issue #5181: [Subtask] Add implementations for converter package. URL: https://github.com/apache/gravitino/issues/5181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [#5181] feat(oceanbase-catalog): Add implementation for converter package [gravitino]

2024-10-22 Thread via GitHub
mchades merged PR #5182: URL: https://github.com/apache/gravitino/pull/5182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitin

(gravitino) branch main updated (832bffb7f -> 18b0606b3)

2024-10-22 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git from 832bffb7f [#5212] improvement(web): Opt out of Next.js usage telemetry (#5219) add 18b0606b3 [MINOR] fix(doc): A

Re: [PR] [MINOR] fix(doc): Add blank line and remove redundant [gravitino]

2024-10-22 Thread via GitHub
jerryshao merged PR #5177: URL: https://github.com/apache/gravitino/pull/5177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

(gravitino) branch main updated: [#5212] improvement(web): Opt out of Next.js usage telemetry (#5219)

2024-10-22 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 832bffb7f [#5212] improvement(web): Opt out of Nex

Re: [I] [Improvement] Opt out of Next.js usage telemetry [gravitino]

2024-10-22 Thread via GitHub
jerryshao closed issue #5212: [Improvement] Opt out of Next.js usage telemetry URL: https://github.com/apache/gravitino/issues/5212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [#5212] improvement(web): Opt out of Next.js usage telemetry [gravitino]

2024-10-22 Thread via GitHub
jerryshao merged PR #5219: URL: https://github.com/apache/gravitino/pull/5219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#5071] Improvement (test): Add integration tests for Trino cascading queries [gravitino]

2024-10-22 Thread via GitHub
diqiu50 commented on code in PR #5073: URL: https://github.com/apache/gravitino/pull/5073#discussion_r1810318050 ## .github/workflows/trino-integration-test.yml: ## @@ -76,7 +76,7 @@ jobs: - name: Package Gravitino run: | - ./gradlew compileDistributio

Re: [PR] [#5172]fix bug:Iceberg catalog audit user is not correct [gravitino]

2024-10-22 Thread via GitHub
FANNG1 commented on PR #5208: URL: https://github.com/apache/gravitino/pull/5208#issuecomment-2428699400 @lsyulong, thanks for your PR. There are similar problems in `JdbcCatalog`. Would you like to fix them together in this PR? https://github.com/apache/gravitino/blob/main/catalogs/cata

Re: [I] [FEATURE] trino connector support more Iceberg partitions [gravitino]

2024-10-22 Thread via GitHub
diqiu50 closed issue #4757: [FEATURE] trino connector support more Iceberg partitions URL: https://github.com/apache/gravitino/issues/4757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [#4757]feat(trino-connector): Support more partition and sort order features of the Iceberg catalog [gravitino]

2024-10-22 Thread via GitHub
diqiu50 merged PR #4925: URL: https://github.com/apache/gravitino/pull/4925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitin

(gravitino) branch main updated: [#4757]feat(trino-connector): Support more partition and sort order features of the Iceberg catalog (#4925)

2024-10-22 Thread diqiu50
This is an automated email from the ASF dual-hosted git repository. diqiu50 pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new eded01901 [#4757]feat(trino-connector): Support

[I] [FEATURE] Support OSS fileset python client [gravitino]

2024-10-22 Thread via GitHub
yuqi1129 opened a new issue, #5221: URL: https://github.com/apache/gravitino/issues/5221 ### Describe the feature After https://github.com/apache/gravitino/issues/5174, we have supported the OSS fileset in the Gravitno server, however, the corresponding Python client has not been fin

Re: [PR] [#5188] feat(python-client): Support s3 fileset in python client [gravitino]

2024-10-22 Thread via GitHub
yuqi1129 commented on code in PR #5209: URL: https://github.com/apache/gravitino/pull/5209#discussion_r1810266085 ## clients/client-python/tests/integration/test_gvfs_with_s3.py: ## @@ -0,0 +1,166 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contri

Re: [PR] [#5188] feat(python-client): Support s3 fileset in python client [gravitino]

2024-10-22 Thread via GitHub
yuqi1129 commented on code in PR #5209: URL: https://github.com/apache/gravitino/pull/5209#discussion_r1810268386 ## clients/client-python/gravitino/filesystem/gvfs_config.py: ## @@ -35,3 +35,8 @@ class GVFSConfig: GVFS_FILESYSTEM_BY_PASS = "gravitino.bypass" GVFS_FILE

[I] [Improvement] Optimize cloud storage property keys when creating Hadoop catalog [gravitino]

2024-10-22 Thread via GitHub
yuqi1129 opened a new issue, #5220: URL: https://github.com/apache/gravitino/issues/5220 ### What would you like to be improved? Currently, we use `gravitino.bypass.` to pass cloud storage `xxx` to gravitino, for example, key `gravitino.bypass.fs.s3a.access.key` will convert to `

Re: [PR] [#5181] feat(oceanbase-catalog): Add implementation for converter package [gravitino]

2024-10-22 Thread via GitHub
yuanoOo commented on code in PR #5182: URL: https://github.com/apache/gravitino/pull/5182#discussion_r1810263776 ## catalogs/catalog-jdbc-oceanbase/src/test/java/org/apache/gravitino/catalog/oceanbase/converter/TestOceanBaseTypeConverter.java: ## @@ -0,0 +1,111 @@ +/* + * Licens

Re: [PR] [#5181] feat(oceanbase-catalog): Add implementation for converter package [gravitino]

2024-10-22 Thread via GitHub
mchades commented on code in PR #5182: URL: https://github.com/apache/gravitino/pull/5182#discussion_r1810239326 ## catalogs/catalog-jdbc-oceanbase/src/test/java/org/apache/gravitino/catalog/oceanbase/converter/TestOceanBaseTypeConverter.java: ## @@ -0,0 +1,111 @@ +/* + * Licens

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-22 Thread via GitHub
yuqi1129 commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1810235289 ## clients/cli/build.gradle.kts: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

[PR] [#5212] improvement(web): Opt out of Next.js usage telemetry [gravitino]

2024-10-22 Thread via GitHub
LauraXia123 opened a new pull request, #5219: URL: https://github.com/apache/gravitino/pull/5219 ### What changes were proposed in this pull request? Opt out of Next.js usage telemetry ### Why are the changes needed? this is not in line with the ASF privacy policy

Re: [PR] [#5188] feat(python-client): Support s3 fileset in python client [gravitino]

2024-10-22 Thread via GitHub
yuqi1129 commented on code in PR #5209: URL: https://github.com/apache/gravitino/pull/5209#discussion_r1810184103 ## clients/client-python/gravitino/filesystem/gvfs.py: ## @@ -819,5 +840,40 @@ def _get_gcs_filesystem(self): return importlib.import_module("pyarrow.fs")

[PR] [#5217] docs(metalake-catalog): refine docs for deleting metalake and catalog [gravitino]

2024-10-22 Thread via GitHub
mchades opened a new pull request, #5218: URL: https://github.com/apache/gravitino/pull/5218 ### What changes were proposed in this pull request? refine docs for deleting metalake and catalog ### Why are the changes needed? Fix: #5217 ### Does this PR introduce _a

Re: [PR] [#5181] feat(oceanbase-catalog): Add implementation for converter package [gravitino]

2024-10-22 Thread via GitHub
yuanoOo commented on code in PR #5182: URL: https://github.com/apache/gravitino/pull/5182#discussion_r1810199848 ## catalogs/catalog-jdbc-oceanbase/src/main/java/org/apache/gravitino/catalog/oceanbase/converter/OceanBaseTypeConverter.java: ## @@ -19,22 +19,132 @@ package org.ap

Re: [PR] [#5181] feat(oceanbase-catalog): Add implementation for converter package [gravitino]

2024-10-22 Thread via GitHub
yuanoOo commented on code in PR #5182: URL: https://github.com/apache/gravitino/pull/5182#discussion_r1810199039 ## catalogs/catalog-jdbc-oceanbase/src/main/java/org/apache/gravitino/catalog/oceanbase/converter/OceanBaseColumnDefaultValueConverter.java: ## Review Comment: T

Re: [PR] [#5141][#5142][#5143] web(ui): Add support for creating, editing, and deleting schema [gravitino]

2024-10-22 Thread via GitHub
jerryshao commented on code in PR #5164: URL: https://github.com/apache/gravitino/pull/5164#discussion_r1810176909 ## web/web/src/app/metalakes/metalake/rightContent/RightContent.js: ## @@ -25,23 +25,38 @@ import { Box, Button, IconButton } from '@mui/material' import Icon from

Re: [PR] [#5141][#5142][#5143] web(ui): Add support for creating, editing, and deleting schema [gravitino]

2024-10-22 Thread via GitHub
LauraXia123 commented on code in PR #5164: URL: https://github.com/apache/gravitino/pull/5164#discussion_r1810191637 ## web/web/src/app/metalakes/metalake/rightContent/RightContent.js: ## @@ -25,23 +25,38 @@ import { Box, Button, IconButton } from '@mui/material' import Icon fr

[PR] [#5206] improvement(web): Web UI add delete metalake/catalog reminder [gravitino]

2024-10-22 Thread via GitHub
LauraXia123 opened a new pull request, #5216: URL: https://github.com/apache/gravitino/pull/5216 ### What changes were proposed in this pull request? Web UI add delete metalake/catalog reminder https://github.com/user-attachments/assets/b943e3a6-3794-4f3e-b07f-2b6ebe54f9b1";>

Re: [PR] [#5114] Improvement:use incubating version in docs [gravitino]

2024-10-22 Thread via GitHub
lsyulong commented on code in PR #5207: URL: https://github.com/apache/gravitino/pull/5207#discussion_r1810164695 ## docs/how-to-use-gvfs.md: ## @@ -335,18 +335,17 @@ to recompile the native libraries like `libhdfs` and others, and completely repl ### Configuration -| Conf

  1   2   >