justinmclean commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1811552929
########## clients/cli/src/main/java/org/apache/gravitino/cli/commands/Command.java: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.cli.commands; + +import org.apache.gravitino.client.GravitinoAdminClient; +import org.apache.gravitino.client.GravitinoClient; +import org.apache.gravitino.exceptions.NoSuchMetalakeException; + +/* The base for all commands. */ +public abstract class Command { + private final String url; + + /** + * Command constructor. + * + * @param url The URL of the Gravitino server. + */ + protected Command(String url) { + this.url = url; + } + /** All commands have a handle method to handle and run the required command. */ + public abstract void handle(); + + /** + * Builds a {@link GravitinoClient} instance with the provided server URL and metalake. + * + * @param metalake The name of the metalake. + * @return A configured {@link GravitinoClient} instance. + * @throws NoSuchMetalakeException if the specified metalake does not exist. + */ + protected GravitinoClient buildClient(String metalake) throws NoSuchMetalakeException { + return GravitinoClient.builder(url).withMetalake(metalake).withVersionCheckDisabled().build(); Review Comment: It was added so it works with the playground, removing that check means it fails to work with the playground as you get this error: The client version is 0.7.0-incubating-SNAPSHOT, and the server version 0.6.0-incubating While that is correct and may cause may cause some issues, it makes it difficult for a user to use the CLI with the playground. Even if the playground was updated to the latest release the version check would still fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
