Re: [PR] [#4236] feat(core): Supports the post-hook for the managers or dispatcher [gravitino]

2024-07-29 Thread via GitHub
jerqi commented on code in PR #4239: URL: https://github.com/apache/gravitino/pull/4239#discussion_r1696413803 ## core/src/main/java/org/apache/gravitino/GravitinoEnv.java: ## @@ -375,4 +385,23 @@ private void initGravitinoServerComponents() { // Tag manager this.tagMa

Re: [PR] [#4185] improvement(core, catalogs): Change the @VisibleForTesting in production code to change usability [gravitino]

2024-07-29 Thread via GitHub
khmgobe commented on PR #4304: URL: https://github.com/apache/gravitino/pull/4304#issuecomment-2257605562 @yuqi1129 Here are the changes to the code you asked about. When asked why you deleted the call book, the original code of the call book is read-only. -- This is an automated mess

Re: [I] [Improvement] switch statements missing default [gravitino]

2024-07-29 Thread via GitHub
khmgobe commented on issue #4305: URL: https://github.com/apache/gravitino/issues/4305#issuecomment-2257602650 > Note that the check topic call does check that the level length is 3 @justinmclean What should I assign as the default? -- This is an automated message from the Apach

Re: [PR] [#4236] feat(core): Supports the post-hook for the managers or dispatcher [gravitino]

2024-07-29 Thread via GitHub
xunliu commented on code in PR #4239: URL: https://github.com/apache/gravitino/pull/4239#discussion_r1696407423 ## core/src/main/java/org/apache/gravitino/GravitinoEnv.java: ## @@ -317,27 +321,29 @@ private void initGravitinoServerComponents() { this.idGenerator = new Rando

Re: [PR] [#4303] improvement(core): Improved removed loop code and readability [gravitino]

2024-07-29 Thread via GitHub
khmgobe commented on code in PR #4307: URL: https://github.com/apache/gravitino/pull/4307#discussion_r1696406910 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/authentication/kerberos/KerberosClient.java: ## @@ -66,7 +65,6 @@ public String login(Str

Re: [PR] [#4236] feat(core): Supports the post-hook for the managers or dispatcher [gravitino]

2024-07-29 Thread via GitHub
xunliu commented on code in PR #4239: URL: https://github.com/apache/gravitino/pull/4239#discussion_r1696209844 ## core/src/main/java/org/apache/gravitino/authorization/AuthorizationUtils.java: ## @@ -116,4 +123,65 @@ public static void checkRoleNamespace(Namespace namespace) {

Re: [PR] [#4298]fix(flink-connector): fix scala version in flink connector [gravitino]

2024-07-29 Thread via GitHub
yuqi1129 commented on PR #4302: URL: https://github.com/apache/gravitino/pull/4302#issuecomment-2257595818 > @yuqi1129 do you have time to review this PR? I have reviewed it and I'm okay with the change. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [#4303] improvement(core): Improved removed loop code and readability [gravitino]

2024-07-29 Thread via GitHub
yuqi1129 commented on code in PR #4307: URL: https://github.com/apache/gravitino/pull/4307#discussion_r1696401596 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/authentication/kerberos/KerberosClient.java: ## @@ -66,7 +65,6 @@ public String login(St

Re: [PR] [#4237] test: Add integration tests for tag system [gravitino]

2024-07-29 Thread via GitHub
yuqi1129 commented on code in PR #4257: URL: https://github.com/apache/gravitino/pull/4257#discussion_r1696394714 ## api/src/main/java/org/apache/gravitino/tag/SupportsTags.java: ## @@ -58,6 +59,8 @@ public interface SupportsTags { * @param tagsToAdd The arrays of tag name t

Re: [PR] [#4298]fix(flink-connector): fix scala version in flink connector [gravitino]

2024-07-29 Thread via GitHub
FANNG1 commented on PR #4302: URL: https://github.com/apache/gravitino/pull/4302#issuecomment-2257586677 @yuqi1129 do you have time to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [#4298]fix(flink-connector): fix scala version in flink connector [gravitino]

2024-07-29 Thread via GitHub
FANNG1 commented on code in PR #4302: URL: https://github.com/apache/gravitino/pull/4302#discussion_r1696395822 ## flink-connector/build.gradle.kts: ## @@ -27,7 +27,13 @@ repositories { } val flinkVersion: String = libs.versions.flink.get() -val scalaVersion: String = projec

Re: [PR] [#4056] improvement(server-common): Support multiple authentication at the same time on the server side [gravitino]

2024-07-29 Thread via GitHub
jerqi commented on PR #4160: URL: https://github.com/apache/gravitino/pull/4160#issuecomment-2257585566 > Yes, `add a new config option` is also a solution. I think if we can maintain backward compatibility, we can reuse the previous configuration, so I didn't introduce a new configuration

Re: [PR] [#4056] improvement(server-common): Support multiple authentication at the same time on the server side [gravitino]

2024-07-29 Thread via GitHub
jerqi commented on code in PR #4160: URL: https://github.com/apache/gravitino/pull/4160#discussion_r1696391669 ## server/src/main/java/org/apache/gravitino/server/web/ConfigServlet.java: ## @@ -51,7 +55,9 @@ public ConfigServlet(ServerConfig serverConfig) { String config

Re: [I] [Improvement] In CommonMetaService.java getParentEntityIdByNamespace method code can be improved [gravitino]

2024-07-29 Thread via GitHub
khmgobe commented on issue #4303: URL: https://github.com/apache/gravitino/issues/4303#issuecomment-2257579690 I want to improve it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] [Improvement] switch statements missing default [gravitino]

2024-07-29 Thread via GitHub
justinmclean commented on issue #4305: URL: https://github.com/apache/gravitino/issues/4305#issuecomment-2257572250 Note that the check topic call does check that the level length is 3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] [Improvement] switch statements missing default [gravitino]

2024-07-29 Thread via GitHub
khmgobe commented on issue #4305: URL: https://github.com/apache/gravitino/issues/4305#issuecomment-2257571366 Let me do it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [#4185] improvement(core, catalogs): Change the @VisibleForTesting in production code to change usability [gravitino]

2024-07-29 Thread via GitHub
khmgobe commented on PR #4304: URL: https://github.com/apache/gravitino/pull/4304#issuecomment-2257570208 @justinmclean Always Have a Goot Time .. ! Among some pager codes that I tried to remove the annotation, I removed the pager because it was in read-only mode where the annotation

[PR] [#4185] improvement(core, catalogs): Change the @VisibleForTesting in production code to change usability [gravitino]

2024-07-29 Thread via GitHub
khmgobe opened a new pull request, #4304: URL: https://github.com/apache/gravitino/pull/4304 What changes were proposed in this pull request? Modifying declaration parts, removing calls that do not need to be used Why are the changes needed? It shouldn't be used, but it's declare

Re: [PR] [#4056] improvement(server-common): Support multiple authentication at the same time on the server side [gravitino]

2024-07-29 Thread via GitHub
jerqi commented on PR #4160: URL: https://github.com/apache/gravitino/pull/4160#issuecomment-2257551301 > Why can't we guarantee compatibility, if upgrade to 0.6.0, the previous config can also work Config interface provides different results. Before 0.6.0, it's a string. After 0.

Re: [PR] [#4237] test: Add integration tests for tag system [gravitino]

2024-07-29 Thread via GitHub
jerryshao commented on PR #4257: URL: https://github.com/apache/gravitino/pull/4257#issuecomment-2257546985 @yuqi1129 @jerqi would you please help to review when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [I] [Improvement] The hint message for the Kafka catalog should be more readable. [gravitino]

2024-07-29 Thread via GitHub
jenish-thapa commented on issue #4148: URL: https://github.com/apache/gravitino/issues/4148#issuecomment-2257470628 Hey @danhuawang, I would like to work on this issue. Can you please assign this to me? -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] [#4298]fix(flink-connector): fix scala version in flink connector [gravitino]

2024-07-29 Thread via GitHub
coolderli commented on code in PR #4302: URL: https://github.com/apache/gravitino/pull/4302#discussion_r1696304708 ## flink-connector/build.gradle.kts: ## @@ -27,7 +27,13 @@ repositories { } val flinkVersion: String = libs.versions.flink.get() -val scalaVersion: String = pro

Re: [I] [Improvement] Change `HADOOP_USER_NAME` for all containers from `datastrato` or `anonymous` to `gravitino` [gravitino]

2024-07-29 Thread via GitHub
kohantikanath commented on issue #4270: URL: https://github.com/apache/gravitino/issues/4270#issuecomment-2257458319 Hi @yuqi1129, I would love to work on this issue, can you assume this issue? -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] [#4056] improvement(server-common): Support multiple authentication at the same time on the server side [gravitino]

2024-07-29 Thread via GitHub
lw-yang commented on PR #4160: URL: https://github.com/apache/gravitino/pull/4160#issuecomment-2257409543 Why can't we guarantee compatibility, if upgrade to 0.6.0, the previous config can also work -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [I] [Improvement] Use of regex on error messages can be fragile in DorisExceptionConverter.java [gravitino]

2024-07-29 Thread via GitHub
justinmclean commented on issue #3027: URL: https://github.com/apache/gravitino/issues/3027#issuecomment-2257408714 The issue is that the regex used like this can cause issues. Can you find a simpler regex or another way of doing it? -- This is an automated message from the Apache Git Ser

Re: [PR] [#4291] feat(catalog-lakehouse-paimon): Support Paimon table with primary keys in Gravitino [gravitino]

2024-07-29 Thread via GitHub
caican00 commented on code in PR #4292: URL: https://github.com/apache/gravitino/pull/4292#discussion_r1696234494 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/GravitinoPaimonTable.java: ## @@ -51,7 +64,25 @@ protected TableOper

Re: [PR] [#4291] feat(catalog-lakehouse-paimon): Support Paimon table with primary keys in Gravitino [gravitino]

2024-07-29 Thread via GitHub
caican00 commented on code in PR #4292: URL: https://github.com/apache/gravitino/pull/4292#discussion_r1696234494 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/GravitinoPaimonTable.java: ## @@ -51,7 +64,25 @@ protected TableOper

Re: [PR] [#4056] improvement(server-common): Support multiple authentication at the same time on the server side [gravitino]

2024-07-29 Thread via GitHub
jerqi commented on PR #4160: URL: https://github.com/apache/gravitino/pull/4160#issuecomment-2257404495 > Yes, `add a new config option` is also a solution. I think if we can maintain backward compatibility, we can reuse the previous configuration, so I didn't introduce a new configuration

Re: [PR] [#4291] feat(catalog-lakehouse-paimon): Support Paimon table with primary keys in Gravitino [gravitino]

2024-07-29 Thread via GitHub
caican00 commented on code in PR #4292: URL: https://github.com/apache/gravitino/pull/4292#discussion_r1696234494 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/GravitinoPaimonTable.java: ## @@ -51,7 +64,25 @@ protected TableOper

Re: [PR] [#4291] feat(catalog-lakehouse-paimon): Support Paimon table with primary keys in Gravitino [gravitino]

2024-07-29 Thread via GitHub
caican00 commented on code in PR #4292: URL: https://github.com/apache/gravitino/pull/4292#discussion_r1696234494 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/GravitinoPaimonTable.java: ## @@ -51,7 +64,25 @@ protected TableOper

Re: [PR] [#4056] improvement(server-common): Support multiple authentication at the same time on the server side [gravitino]

2024-07-29 Thread via GitHub
lw-yang commented on PR #4160: URL: https://github.com/apache/gravitino/pull/4160#issuecomment-2257398933 Yes, `add a new config option` is also a solution. I think if we can maintain backward compatibility, we can reuse the previous configuration, so I didn't introduce a new configuration

Re: [I] [Improvement] Git ignore file `version.ini` [gravitino]

2024-07-29 Thread via GitHub
justinmclean commented on issue #4023: URL: https://github.com/apache/gravitino/issues/4023#issuecomment-2257397355 fixed by #3953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [I] [Improvement] Git ignore file `version.ini` [gravitino]

2024-07-29 Thread via GitHub
justinmclean closed issue #4023: [Improvement] Git ignore file `version.ini` URL: https://github.com/apache/gravitino/issues/4023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [#4236] feat(core): Supports the post-hook for the managers or dispatcher [gravitino]

2024-07-29 Thread via GitHub
jerqi commented on code in PR #4239: URL: https://github.com/apache/gravitino/pull/4239#discussion_r1696226992 ## core/src/main/java/org/apache/gravitino/GravitinoEnv.java: ## @@ -317,27 +321,29 @@ private void initGravitinoServerComponents() { this.idGenerator = new Random

Re: [PR] [#4236] feat(core): Supports the post-hook for the managers or dispatcher [gravitino]

2024-07-29 Thread via GitHub
jerqi commented on code in PR #4239: URL: https://github.com/apache/gravitino/pull/4239#discussion_r1696226992 ## core/src/main/java/org/apache/gravitino/GravitinoEnv.java: ## @@ -317,27 +321,29 @@ private void initGravitinoServerComponents() { this.idGenerator = new Random

Re: [PR] [#4298]fix(flink-connector): fix scala version in flink connector [gravitino]

2024-07-29 Thread via GitHub
FANNG1 commented on PR #4302: URL: https://github.com/apache/gravitino/pull/4302#issuecomment-2257394835 we could exclude the Flink connector from Gravitino if the scala version is 2.13, like spark-connector in `setting.gradle.kts` ``` if (scalaVersion == "2.12") { include("spark-

Re: [PR] [#4056] improvement(server-common): Support multiple authentication at the same time on the server side [gravitino]

2024-07-29 Thread via GitHub
jerqi commented on PR #4160: URL: https://github.com/apache/gravitino/pull/4160#issuecomment-2257390314 > If the `list` is used, the `/config` interface will return `['xx']`, which includes an additional square bracket, instead of just a string. it require additional processing for the prev

Re: [PR] [#4298]fix(flink-connector): fix scala version in flink connector [gravitino]

2024-07-29 Thread via GitHub
coolderli commented on PR #4302: URL: https://github.com/apache/gravitino/pull/4302#issuecomment-2257388122 @FANNG1 Please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [#4298]fix(flink-connector): fix scala version in flink connector [gravitino]

2024-07-29 Thread via GitHub
coolderli opened a new pull request, #4302: URL: https://github.com/apache/gravitino/pull/4302 ### What changes were proposed in this pull request? Flink only supports Scala 2.12. All scala API will removed in the future version. https://issues.apache.org/jira/browse/FL

Re: [PR] [#4287] feat(catalog-lakehouse-paimon): Support Paimon table with partitions in Gravitino [gravitino]

2024-07-29 Thread via GitHub
caican00 commented on PR #4288: URL: https://github.com/apache/gravitino/pull/4288#issuecomment-2257387439 comments have been addressed, and could you help review again? @FANNG1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [#4287] feat(catalog-lakehouse-paimon): Support Paimon table with partitions in Gravitino [gravitino]

2024-07-29 Thread via GitHub
caican00 commented on code in PR #4288: URL: https://github.com/apache/gravitino/pull/4288#discussion_r1696217505 ## catalogs/catalog-lakehouse-paimon/src/test/java/org/apache/gravitino/catalog/lakehouse/paimon/TestGravitinoPaimonTable.java: ## @@ -201,6 +204,80 @@ void testCrea

Re: [PR] [#4287] feat(catalog-lakehouse-paimon): Support Paimon table with partitions in Gravitino [gravitino]

2024-07-29 Thread via GitHub
caican00 commented on code in PR #4288: URL: https://github.com/apache/gravitino/pull/4288#discussion_r1696217394 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/GravitinoPaimonTable.java: ## @@ -71,12 +82,17 @@ public static Grav

Re: [PR] [#4287] feat(catalog-lakehouse-paimon): Support Paimon table with partitions in Gravitino [gravitino]

2024-07-29 Thread via GitHub
caican00 commented on code in PR #4288: URL: https://github.com/apache/gravitino/pull/4288#discussion_r1696217613 ## catalogs/catalog-lakehouse-paimon/src/test/java/org/apache/gravitino/catalog/lakehouse/paimon/integration/test/CatalogPaimonBaseIT.java: ## @@ -283,6 +286,109 @@

Re: [PR] [#4287] feat(catalog-lakehouse-paimon): Support Paimon table with partitions in Gravitino [gravitino]

2024-07-29 Thread via GitHub
caican00 commented on code in PR #4288: URL: https://github.com/apache/gravitino/pull/4288#discussion_r1696216953 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/GravitinoPaimonTable.java: ## @@ -52,6 +57,12 @@ protected TableOper

Re: [PR] [#4056] improvement(server-common): Support multiple authentication at the same time on the server side [gravitino]

2024-07-29 Thread via GitHub
lw-yang commented on PR #4160: URL: https://github.com/apache/gravitino/pull/4160#issuecomment-2257386067 If the `list` is used, the `/config` interface will return `['xx']`, which includes an additional square bracket, instead of just a string. it require additional processing for the prev

Re: [I] [Improvement] Accelerate compileDistribution task for Gravitino [gravitino]

2024-07-29 Thread via GitHub
khmgobe commented on issue #4174: URL: https://github.com/apache/gravitino/issues/4174#issuecomment-2257383497 > > @yuqi1129 > > BUILD SUCCESSFUL in 1m 18s 125 actionable tasks: 83 executed, 42 up-to-date > > It takes about a minute for me, is it based on the time when I just hit that

Re: [PR] [#4056] improvement(server-common): Support multiple authentication at the same time on the server side [gravitino]

2024-07-29 Thread via GitHub
jerqi commented on PR #4160: URL: https://github.com/apache/gravitino/pull/4160#issuecomment-2257379824 > We should maintain backward compatibility, so revert the changes to keep `string` type First, It won't break backward compatiblity using sequeuece. Second, how to handle the st

Re: [PR] [#4056] improvement(server-common): Support multiple authentication at the same time on the server side [gravitino]

2024-07-29 Thread via GitHub
lw-yang commented on PR #4160: URL: https://github.com/apache/gravitino/pull/4160#issuecomment-2257377248 We should maintain backward compatibility, so revert the changes to keep `string` type -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [I] [Subtask] enable pre-assign partition for Doris catalog [gravitino]

2024-07-29 Thread via GitHub
mchades closed issue #3368: [Subtask] enable pre-assign partition for Doris catalog URL: https://github.com/apache/gravitino/issues/3368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(gravitino) branch main updated: [#3368] feat(jdbc-doris): support pre-assign partition for Doris table (#3887)

2024-07-29 Thread mchades
This is an automated email from the ASF dual-hosted git repository. mchades pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 4acdc498c [#3368] feat(jdbc-doris): support pre-

Re: [PR] Issue 4169 [gravitino]

2024-07-29 Thread via GitHub
jerqi closed pull request #4283: Issue 4169 URL: https://github.com/apache/gravitino/pull/4283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

Re: [PR] [#3368] feat(jdbc-doris): support pre-assign partition for Doris table [gravitino]

2024-07-29 Thread via GitHub
mchades merged PR #3887: URL: https://github.com/apache/gravitino/pull/3887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitin

Re: [PR] [#4056] improvement(server-common): Support multiple authentication at the same time on the server side [gravitino]

2024-07-29 Thread via GitHub
jerqi commented on PR #4160: URL: https://github.com/apache/gravitino/pull/4160#issuecomment-2257374838 > @jerqi @lw-yang has reverted the changes about the type of authenticator from `List` to `String`, Is it okay for you? Not ok for me. It's weird. -- This is an automated messag

Re: [PR] [TEST]Test CI [gravitino]

2024-07-29 Thread via GitHub
yuqi1129 closed pull request #4260: [TEST]Test CI URL: https://github.com/apache/gravitino/pull/4260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: com

Re: [I] [Improvement] Accelerate compileDistribution task for Gravitino [gravitino]

2024-07-29 Thread via GitHub
yuqi1129 commented on issue #4174: URL: https://github.com/apache/gravitino/issues/4174#issuecomment-2257368700 > @yuqi1129 > > BUILD SUCCESSFUL in 1m 18s 125 actionable tasks: 83 executed, 42 up-to-date > > It takes about a minute for me, is it based on the time when I just hit

Re: [I] [Improvement] Accelerate compileDistribution task for Gravitino [gravitino]

2024-07-29 Thread via GitHub
khmgobe commented on issue #4174: URL: https://github.com/apache/gravitino/issues/4174#issuecomment-2257365799 @yuqi1129 BUILD SUCCESSFUL in 1m 18s 125 actionable tasks: 83 executed, 42 up-to-date It takes about a minute for me, is it based on the time when I just hit that

Re: [I] [Improvement] Use of methods marked @VisibleForTesting in production code [gravitino]

2024-07-29 Thread via GitHub
khmgobe commented on issue #4185: URL: https://github.com/apache/gravitino/issues/4185#issuecomment-2257360936 @justinmclean Do you mind if I try it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [#4056] improvement(server-common): Support multiple authentication at the same time on the server side [gravitino]

2024-07-29 Thread via GitHub
yuqi1129 commented on PR #4160: URL: https://github.com/apache/gravitino/pull/4160#issuecomment-2257360487 @jerqi @lw-yang has reverted the changes about the type of authenticator from `List` to `String`, Is it okay for you? -- This is an automated message from the Apache Git Serv

Re: [PR] [#4293] improvement(catalogs): add deleted flag and Error Log [gravitino]

2024-07-29 Thread via GitHub
yuqi1129 closed pull request #4296: [#4293] improvement(catalogs): add deleted flag and Error Log URL: https://github.com/apache/gravitino/pull/4296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] [Improvement] In SecureHadoopCatalogOperations.java checkif file is deleted [gravitino]

2024-07-29 Thread via GitHub
yuqi1129 closed issue #4293: [Improvement] In SecureHadoopCatalogOperations.java checkif file is deleted URL: https://github.com/apache/gravitino/issues/4293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] [Improvement] In SecureHadoopCatalogOperations.java checkif file is deleted [gravitino]

2024-07-29 Thread via GitHub
yuqi1129 commented on issue #4293: URL: https://github.com/apache/gravitino/issues/4293#issuecomment-2257356359 This issue was resolved in #4297. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] [Improvement] In SecureHadoopCatalogOperations.java checkif file is deleted [gravitino]

2024-07-29 Thread via GitHub
khmgobe commented on issue #4293: URL: https://github.com/apache/gravitino/issues/4293#issuecomment-2257355084 > This issue was resolved by #4297 by the way, perhaps the PR can be closed? sure ! closed please, Have a Good Time ! -- This is an automated message from the Apache Git S

Re: [I] [Improvement] In SecureHadoopCatalogOperations.java checkif file is deleted [gravitino]

2024-07-29 Thread via GitHub
yuqi1129 commented on issue #4293: URL: https://github.com/apache/gravitino/issues/4293#issuecomment-2257353998 This issue was resolved by #4297 by the way, perhaps the PR can be closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

(gravitino) annotated tag kerberos-hive-ci-v0.1.5 updated (1b6a1556b -> a1726a19f)

2024-07-29 Thread yuqi4733
This is an automated email from the ASF dual-hosted git repository. yuqi4733 pushed a change to annotated tag kerberos-hive-ci-v0.1.5 in repository https://gitbox.apache.org/repos/asf/gravitino.git *** WARNING: tag kerberos-hive-ci-v0.1.5 was modified! *** from 1b6a1556b (commit) to a

(gravitino) branch main updated (a8e9a31a0 -> a9e503da9)

2024-07-29 Thread fanng
This is an automated email from the ASF dual-hosted git repository. fanng pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git from a8e9a31a0 [#4294] improvement(catalogs): Improved readability of trinomial operator usage code (#4297) add a9e50

Re: [I] [Subtask] Add flink-connector doc for 0.6 release [gravitino]

2024-07-29 Thread via GitHub
FANNG1 closed issue #4269: [Subtask] Add flink-connector doc for 0.6 release URL: https://github.com/apache/gravitino/issues/4269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] [Subtask] Add flink-connector doc for 0.6 release [gravitino]

2024-07-29 Thread via GitHub
FANNG1 closed issue #4269: [Subtask] Add flink-connector doc for 0.6 release URL: https://github.com/apache/gravitino/issues/4269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [#4269] doc(flink-connector): add flink connector doc [gravitino]

2024-07-29 Thread via GitHub
FANNG1 merged PR #4284: URL: https://github.com/apache/gravitino/pull/4284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

Re: [PR] [#3368] feat(jdbc-doris): support pre-assign partition for Doris table [gravitino]

2024-07-29 Thread via GitHub
yuqi1129 commented on PR #3887: URL: https://github.com/apache/gravitino/pull/3887#issuecomment-2257341934 > Overall LGTM. @yuqi1129 Do you want to take another look? I'm okay with the current changes. -- This is an automated message from the Apache Git Service. To respond to the me

[PR] [#4300] improvement(Mysql&PG catalog): use UnparsedExpression to represent unparsed column default value [gravitino]

2024-07-29 Thread via GitHub
mchades opened a new pull request, #4301: URL: https://github.com/apache/gravitino/pull/4301 ### What changes were proposed in this pull request? use UnparsedExpression to represent unpared column default value ### Why are the changes needed? Fix: #4300 ### Does t

Re: [I] [Bug report] Can find pom file `flink-connector-hive_2.13-1.18.0.pom` when setting scala version to 2.13 [gravitino]

2024-07-29 Thread via GitHub
FANNG1 commented on issue #4298: URL: https://github.com/apache/gravitino/issues/4298#issuecomment-2257338510 @coolderli do you have time to check this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [Improvement] In SecureHadoopCatalogOperations.java checkif file is deleted [gravitino]

2024-07-29 Thread via GitHub
khmgobe commented on issue #4293: URL: https://github.com/apache/gravitino/issues/4293#issuecomment-2257333027 > https://private-user-images.githubusercontent.com/15794564/353289057-9ccf44e7-db19-40e6-bb10-880b23fb95f2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiY

Re: [I] [Improvement] In SecureHadoopCatalogOperations.java checkif file is deleted [gravitino]

2024-07-29 Thread via GitHub
yuqi1129 commented on issue #4293: URL: https://github.com/apache/gravitino/issues/4293#issuecomment-2257330045 https://github.com/user-attachments/assets/9ccf44e7-db19-40e6-bb10-880b23fb95f2";> Please take a look at at the code change. -- This is an automated message from the Apach

Re: [I] [Improvement] In SecureHadoopCatalogOperations.java checkif file is deleted [gravitino]

2024-07-29 Thread via GitHub
khmgobe commented on issue #4293: URL: https://github.com/apache/gravitino/issues/4293#issuecomment-2257325585 @yuqi1129 > @yuqi1129 I hope you have a good day today. Please review it. > >Please look at the promotion and I'm confused about the actual change. Existing cha

Re: [I] [Improvement] In SecureHadoopCatalogOperations.java checkif file is deleted [gravitino]

2024-07-29 Thread via GitHub
yuqi1129 commented on issue #4293: URL: https://github.com/apache/gravitino/issues/4293#issuecomment-2257322648 > @yuqi1129 I hope you have a good day today. Please review it. Please look at your PR and I'm confused about the actual change you made. -- This is an automated message f

Re: [PR] [#4247] improvement(docs, catalog-hadoop): Add docs about multiple-level authentication for Hadoop catalog. [gravitino]

2024-07-29 Thread via GitHub
jerqi commented on PR #4248: URL: https://github.com/apache/gravitino/pull/4248#issuecomment-2257321907 > > It's the best to have the abstraction like > > ``` > > class UserContext { > > UserGroupInformation getUGI(); > > doAs(); > > } > > > > class SimpleUserC

Re: [I] [Improvement] In SecureHadoopCatalogOperations.java checkif file is deleted [gravitino]

2024-07-29 Thread via GitHub
khmgobe commented on issue #4293: URL: https://github.com/apache/gravitino/issues/4293#issuecomment-2257320564 @yuqi1129 I hope you have a good day today. Please review it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] [#4269]feat(flink-connector): add flink connector doc [gravitino]

2024-07-29 Thread via GitHub
coolderli commented on code in PR #4284: URL: https://github.com/apache/gravitino/pull/4284#discussion_r1696170076 ## docs/flink-connector/flink-connector.md: ## @@ -0,0 +1,93 @@ +--- +title: "Apache Gravitino Flink connector" +slug: /flink-connector/flink-connector +keyword: fl

Re: [PR] [#4269]feat(flink-connector): add flink connector doc [gravitino]

2024-07-29 Thread via GitHub
coolderli commented on PR #4284: URL: https://github.com/apache/gravitino/pull/4284#issuecomment-2257313172 @FANNG1 I have fixed. Please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [#4269]feat(flink-connector): add flink connector doc [gravitino]

2024-07-29 Thread via GitHub
coolderli commented on code in PR #4284: URL: https://github.com/apache/gravitino/pull/4284#discussion_r1696168591 ## docs/flink-connector/flink-connector.md: ## @@ -0,0 +1,93 @@ +--- +title: "Apache Gravitino Flink connector" +slug: /flink-connector/flink-connector +keyword: fl

Re: [PR] [#4269]feat(flink-connector): add flink connector doc [gravitino]

2024-07-29 Thread via GitHub
coolderli commented on code in PR #4284: URL: https://github.com/apache/gravitino/pull/4284#discussion_r1696165538 ## docs/flink-connector/flink-connector.md: ## @@ -0,0 +1,93 @@ +--- +title: "Apache Gravitino Flink connector" +slug: /flink-connector/flink-connector +keyword: fl

Re: [I] [Improvement] Use of nested ternary operation is a little confusing [gravitino]

2024-07-29 Thread via GitHub
yuqi1129 closed issue #4294: [Improvement] Use of nested ternary operation is a little confusing URL: https://github.com/apache/gravitino/issues/4294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] [Improvement] Use of nested ternary operation is a little confusing [gravitino]

2024-07-29 Thread via GitHub
yuqi1129 closed issue #4294: [Improvement] Use of nested ternary operation is a little confusing URL: https://github.com/apache/gravitino/issues/4294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

(gravitino) branch main updated: [#4294] improvement(catalogs): Improved readability of trinomial operator usage code (#4297)

2024-07-29 Thread yuqi4733
This is an automated email from the ASF dual-hosted git repository. yuqi4733 pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new a8e9a31a0 [#4294] improvement(catalogs): Improv

Re: [PR] [#4294] improvement(catalogs): Improved readability of trinomial operator usage code [gravitino]

2024-07-29 Thread via GitHub
yuqi1129 merged PR #4297: URL: https://github.com/apache/gravitino/pull/4297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graviti

Re: [I] [Bug report] Missing description of support type uuid [gravitino]

2024-07-29 Thread via GitHub
mchades closed issue #4258: [Bug report] Missing description of support type uuid URL: https://github.com/apache/gravitino/issues/4258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] [Bug report] Missing description of support type uuid [gravitino]

2024-07-29 Thread via GitHub
mchades closed issue #4258: [Bug report] Missing description of support type uuid URL: https://github.com/apache/gravitino/issues/4258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

(gravitino) branch main updated (8c4a32590 -> 023488888)

2024-07-29 Thread mchades
This is an automated email from the ASF dual-hosted git repository. mchades pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git from 8c4a32590 [#3785] Throw a clear exception for unsupported Trino versions when Trino starts (#4268) add 0234888

Re: [PR] [#4258] fix(doc): Added description of support type uuid [gravitino]

2024-07-29 Thread via GitHub
mchades merged PR #4299: URL: https://github.com/apache/gravitino/pull/4299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitin

Re: [I] [Improvement] Use of regex on error messages can be fragile in DorisExceptionConverter.java [gravitino]

2024-07-29 Thread via GitHub
ashwin1596 commented on issue #3027: URL: https://github.com/apache/gravitino/issues/3027#issuecomment-2257220976 I am a bit confused about the issue. We are using the error code for "Database already exists" defined as: `@VisibleForTesting static final int CODE_DATABASE_EXISTS = 1007

Re: [PR] [#4226] Improvement(python-client): Add Metalake Error Handler and related exceptions, test cases in client-python [gravitino]

2024-07-29 Thread via GitHub
jingjia88 commented on PR #4271: URL: https://github.com/apache/gravitino/pull/4271#issuecomment-2256209205 @noidname01 Done! Please help to take a look again, Thank you~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] [#4226] Improvement(python-client): Add Metalake Error Handler and related exceptions, test cases in client-python [gravitino]

2024-07-29 Thread via GitHub
jingjia88 commented on code in PR #4271: URL: https://github.com/apache/gravitino/pull/4271#discussion_r1695399066 ## clients/client-python/gravitino/exceptions/base.py: ## @@ -54,6 +54,9 @@ class InternalError(GravitinoRuntimeException): class NotFoundException(GravitinoRuntim

Re: [PR] Vishesh paliwal patch 1 [gravitino]

2024-07-29 Thread via GitHub
Vishesh-Paliwal commented on PR #4299: URL: https://github.com/apache/gravitino/pull/4299#issuecomment-2256148817 Hi @mchades , sorry about that , I'm new to open source . Kindly review now . -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] [#4293] improvement(catalogs): add deleted flag and Error Log [gravitino]

2024-07-29 Thread via GitHub
khmgobe commented on PR #4296: URL: https://github.com/apache/gravitino/pull/4296#issuecomment-2256132683 To. Reviewer Please note that the pre-PR content exclusion change code has been changed to conform to Spotless's rules. -- This is an automated message from the Apache Git Ser

Re: [PR] Vishesh paliwal patch 1 [gravitino]

2024-07-29 Thread via GitHub
mchades commented on PR #4299: URL: https://github.com/apache/gravitino/pull/4299#issuecomment-2256114596 Thanks for your PR. Please adjust the title and description to adhere to the required format. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [I] [Improvement] Simplify compilation by compiling scripts [gravitino]

2024-07-29 Thread via GitHub
yuqi1129 commented on issue #4266: URL: https://github.com/apache/gravitino/issues/4266#issuecomment-2256108679 1. It's a good idea to list some commonly used build options and combinations in the `kts` file. 2. Putting all build options in a conspicuous place like in the `build.kts` wil

Re: [I] [Improvement] Simplify compilation by compiling scripts [gravitino]

2024-07-29 Thread via GitHub
xunliu commented on issue #4266: URL: https://github.com/apache/gravitino/issues/4266#issuecomment-2256086348 @mchades @yuqi1129 What do you think about this issue, Please give some suggestions, Thanks! -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] [#4294] improvement(catalogs): Improved readability of trinomial operator usage code [gravitino]

2024-07-29 Thread via GitHub
khmgobe commented on PR #4297: URL: https://github.com/apache/gravitino/pull/4297#issuecomment-2256081600 > @khmgobe Please change your PR description according to the PR template. @yuqi1129 My mistake. I'm sorry. I've changed the description, so please check it -- This is an autom

Re: [I] [Bug report] Missing description of support type uuid [gravitino]

2024-07-29 Thread via GitHub
Vishesh-Paliwal commented on issue #4258: URL: https://github.com/apache/gravitino/issues/4258#issuecomment-2256072171 hi @justinmclean , Created a PR . kindly review . PS : sorry about earlier one , I'm new to open source -- This is an automated message from the Apache Git Service

[PR] Vishesh paliwal patch 1 [gravitino]

2024-07-29 Thread via GitHub
Vishesh-Paliwal opened a new pull request, #4299: URL: https://github.com/apache/gravitino/pull/4299 What PR does : Adds description of support type uuid ### What changes were proposed in this pull request? https://datastrato.ai/docs/0.5.1/manage-relational-metadata-usi

  1   2   >