Re: [PR] [#4236] feat(core): Supports the post-hook for the managers or dispatcher [gravitino]

[via GitHub]

xunliu commented on code in PR #4239:
URL: https://github.com/apache/gravitino/pull/4239#discussion_r1696407423


##########
core/src/main/java/org/apache/gravitino/GravitinoEnv.java:
##########
@@ -317,27 +321,29 @@ private void initGravitinoServerComponents() {
     this.idGenerator = new RandomIdGenerator();
 
     // Create and initialize metalake related modules
-    MetalakeManager metalakeManager = new MetalakeManager(entityStore, 
idGenerator);
+    MetalakeDispatcher metalakeManager = new MetalakeManager(entityStore, 
idGenerator);
     MetalakeNormalizeDispatcher metalakeNormalizeDispatcher =
-        new MetalakeNormalizeDispatcher(metalakeManager);
+        new 
MetalakeNormalizeDispatcher(installLifecycleHooks(metalakeManager));
     this.metalakeDispatcher = new MetalakeEventDispatcher(eventBus, 
metalakeNormalizeDispatcher);
 
     // Create and initialize Catalog related modules
     this.catalogManager = new CatalogManager(config, entityStore, idGenerator);
     CatalogNormalizeDispatcher catalogNormalizeDispatcher =
-        new CatalogNormalizeDispatcher(catalogManager);
+        new 
CatalogNormalizeDispatcher(installLifecycleHooks((CatalogDispatcher) 
catalogManager));
     this.catalogDispatcher = new CatalogEventDispatcher(eventBus, 
catalogNormalizeDispatcher);
 
     SchemaOperationDispatcher schemaOperationDispatcher =
         new SchemaOperationDispatcher(catalogManager, entityStore, 
idGenerator);
     SchemaNormalizeDispatcher schemaNormalizeDispatcher =
-        new SchemaNormalizeDispatcher(schemaOperationDispatcher, 
catalogManager);
+        new SchemaNormalizeDispatcher(
+            installLifecycleHooks((SchemaDispatcher) 
schemaOperationDispatcher), catalogManager);
     this.schemaDispatcher = new SchemaEventDispatcher(eventBus, 
schemaNormalizeDispatcher);
 
     TableOperationDispatcher tableOperationDispatcher =
         new TableOperationDispatcher(catalogManager, entityStore, idGenerator);
     TableNormalizeDispatcher tableNormalizeDispatcher =
-        new TableNormalizeDispatcher(tableOperationDispatcher, catalogManager);
+        new TableNormalizeDispatcher(
+            installLifecycleHooks((TableDispatcher) tableOperationDispatcher), 
catalogManager);
     this.tableDispatcher = new TableEventDispatcher(eventBus, 
tableNormalizeDispatcher);
 
     PartitionOperationDispatcher partitionOperationDispatcher =

Review Comment:
   If we didn't add the hooks for patitionDispatcher in this PR, I think you 
can add comments here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org