Re: [PR] [fix](decompress)(review) context leaked in failure path [doris]

2024-04-18 Thread via GitHub
yiguolei commented on code in PR #33622: URL: https://github.com/apache/doris/pull/33622#discussion_r1571151415 ## be/src/util/block_compression.cpp: ## @@ -116,13 +121,11 @@ class Lz4BlockCompression : public BlockCompressionCodec { input.size); }

Re: [PR] [fix](decompress)(review) context leaked in failure path [doris]

2024-04-18 Thread via GitHub
yiguolei commented on code in PR #33622: URL: https://github.com/apache/doris/pull/33622#discussion_r1571150437 ## be/src/util/block_compression.cpp: ## @@ -169,40 +172,34 @@ class Lz4BlockCompression : public BlockCompressionCodec { private: // reuse LZ4 compress stream

Re: [PR] [Fix](compile) Fix gcc compile on master [doris]

2024-04-18 Thread via GitHub
doris-robot commented on PR #33864: URL: https://github.com/apache/doris/pull/33864#issuecomment-2064732860 ClickBench: Total hot run time: 30.35 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Fix](compile) Fix gcc compile on master [doris]

2024-04-18 Thread via GitHub
doris-robot commented on PR #33864: URL: https://github.com/apache/doris/pull/33864#issuecomment-2064743177 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 680a46f252a16a43a3f236a82f342f652c18e641 with default session variables Stream

Re: [PR] [fix](decompress)(review) context leaked in failure path [doris]

2024-04-18 Thread via GitHub
Vallishp commented on PR #33622: URL: https://github.com/apache/doris/pull/33622#issuecomment-2064791539 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](decompress)(review) context leaked in failure path [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on code in PR #33622: URL: https://github.com/apache/doris/pull/33622#discussion_r1571178049 ## be/src/util/block_compression.cpp: ## @@ -169,40 +172,34 @@ class Lz4BlockCompression : public BlockCompressionCodec { private: // reuse LZ4 comp

Re: [PR] (cloud-merge) Support more multi case strategies about cache [doris]

2024-04-18 Thread via GitHub
gavinchou commented on code in PR #32804: URL: https://github.com/apache/doris/pull/32804#discussion_r1570412055 ## be/src/cloud/config.h: ## @@ -88,4 +88,6 @@ DECLARE_mInt32(schedule_sync_tablets_interval_s); // Cloud mow DECLARE_mInt32(mow_stream_load_commit_retry_times);

Re: [PR] [fix](schema change) fix schema change check does not calculate reader merged rows [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33825: URL: https://github.com/apache/doris/pull/33825#issuecomment-2064856993 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](move-memtable) fix commit may fail due to duplicated reports [doris]

2024-04-18 Thread via GitHub
kaijchen commented on PR #32403: URL: https://github.com/apache/doris/pull/32403#issuecomment-2064906691 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](move-memtable) fix commit may fail due to duplicated reports [doris]

2024-04-18 Thread via GitHub
doris-robot commented on PR #32403: URL: https://github.com/apache/doris/pull/32403#issuecomment-2065004231 TeamCity be ut coverage result: Function Coverage: 35.45% (8919/25161) Line Coverage: 27.15% (73306/270001) Region Coverage: 26.26% (37847/144113) Branch Coverage: 23.0

Re: [PR] [refine](node) Remove the cse DCHECK from the constructor. [doris]

2024-04-18 Thread via GitHub
Mryange commented on PR #33856: URL: https://github.com/apache/doris/pull/33856#issuecomment-2065478894 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [refine](node) Remove the cse DCHECK from the constructor. [doris]

2024-04-18 Thread via GitHub
doris-robot commented on PR #33856: URL: https://github.com/apache/doris/pull/33856#issuecomment-2065508040 TeamCity be ut coverage result: Function Coverage: 35.43% (8913/25157) Line Coverage: 27.13% (73238/269987) Region Coverage: 26.26% (37843/144112) Branch Coverage: 23.0

[PR] [opt](auto bucket) add fe config autobucket_max_buckets #33842 [doris]

2024-04-18 Thread via GitHub
xiaokang opened a new pull request, #33866: URL: https://github.com/apache/doris/pull/33866 ## Proposed changes Issue Number: close #xxx pick from master #33842 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@d

Re: [PR] [opt](auto bucket) add fe config autobucket_max_buckets #33842 [doris]

2024-04-18 Thread via GitHub
doris-robot commented on PR #33866: URL: https://github.com/apache/doris/pull/33866#issuecomment-2065517236 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [opt](auto bucket) add fe config autobucket_max_buckets #33842 [doris]

2024-04-18 Thread via GitHub
xiaokang commented on PR #33866: URL: https://github.com/apache/doris/pull/33866#issuecomment-2065517307 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [opt](auto bucket) add fe config autobucket_max_buckets [doris]

2024-04-18 Thread via GitHub
xiaokang commented on PR #33842: URL: https://github.com/apache/doris/pull/33842#issuecomment-2065517644 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [opt](auto bucket) add fe config autobucket_max_buckets #33842 [doris]

2024-04-18 Thread via GitHub
doris-robot commented on PR #33866: URL: https://github.com/apache/doris/pull/33866#issuecomment-2065548090 TPC-H: Total hot run time: 49502 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [opt](nereids)do not apply CSE(Common Sub Expression) upon multiDataSink [doris]

2024-04-18 Thread via GitHub
englefly merged PR #33746: URL: https://github.com/apache/doris/pull/33746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

(doris) branch master updated: [opt](nereids)do not apply CSE(Common Sub Expression) upon multiDataSink (#33746)

2024-04-18 Thread englefly
This is an automated email from the ASF dual-hosted git repository. englefly pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 3973571bf17 [opt](nereids)do not apply CSE(Comm

Re: [PR] [opt](auto bucket) add fe config autobucket_max_buckets #33842 [doris]

2024-04-18 Thread via GitHub
doris-robot commented on PR #33866: URL: https://github.com/apache/doris/pull/33866#issuecomment-2065558241 TPC-DS: Total hot run time: 202804 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](nereids) do not push RF into nested cte [doris]

2024-04-18 Thread via GitHub
englefly commented on PR #33769: URL: https://github.com/apache/doris/pull/33769#issuecomment-2065558933 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [opt](auto bucket) add fe config autobucket_max_buckets #33842 [doris]

2024-04-18 Thread via GitHub
doris-robot commented on PR #33866: URL: https://github.com/apache/doris/pull/33866#issuecomment-2065562041 ClickBench: Total hot run time: 30.82 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [opt](auto bucket) add fe config autobucket_max_buckets #33842 [doris]

2024-04-18 Thread via GitHub
doris-robot commented on PR #33866: URL: https://github.com/apache/doris/pull/33866#issuecomment-2065564376 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 6f27e1ea5fa80c83f1502e9a736884cc874ab2cc with default session variables Stream

Re: [PR] [fix](nereids) do not push RF into nested cte [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33769: URL: https://github.com/apache/doris/pull/33769#issuecomment-2065569566 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](nereids) do not push RF into nested cte [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33769: URL: https://github.com/apache/doris/pull/33769#issuecomment-2065569600 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [feature](merge-cloud) Add `BrokerLoad` and `DriverUrl` white list [doris]

2024-04-18 Thread via GitHub
dataroaring merged PR #33003: URL: https://github.com/apache/doris/pull/33003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

(doris) branch master updated: [feature](merge-cloud) Add `BrokerLoad` and `DriverUrl` white list (#33003)

2024-04-18 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 037cf12ad5e [feature](merge-cloud) Add `Brok

Re: [PR] [opt](auto bucket) add fe config autobucket_max_buckets #33842 [doris]

2024-04-18 Thread via GitHub
dataroaring merged PR #33866: URL: https://github.com/apache/doris/pull/33866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

(doris) branch branch-2.0 updated: [opt](auto bucket) add fe config autobucket_max_buckets #33842 (#33866)

2024-04-18 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.0 by this push: new 77240179bf0 [opt](auto bucket) add f

Re: [PR] [Enhancement](group commit) Add fault injection case for group commit [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33861: URL: https://github.com/apache/doris/pull/33861#issuecomment-2065589953 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Enhancement](group commit) Add fault injection case for group commit [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33861: URL: https://github.com/apache/doris/pull/33861#issuecomment-2065589967 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [feature-wip](Cloud) Show isDefault vault in show storage vault stmt [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33839: URL: https://github.com/apache/doris/pull/33839#issuecomment-2065591853 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](cloud) exclude some cases from cloud_p0 [doris]

2024-04-18 Thread via GitHub
dataroaring commented on PR #33725: URL: https://github.com/apache/doris/pull/33725#issuecomment-2065596448 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [imporve](cloud) Get key values in batch during txn commit [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33771: URL: https://github.com/apache/doris/pull/33771#issuecomment-2065597729 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

(doris) branch master updated (037cf12ad5e -> 8aa0b1c0959)

2024-04-18 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 037cf12ad5e [feature](merge-cloud) Add `BrokerLoad` and `DriverUrl` white list (#33003) add 8aa0b1c0959 [imp

Re: [PR] [fix](schema change) fix schema change check does not calculate reader merged rows [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33825: URL: https://github.com/apache/doris/pull/33825#issuecomment-2065600795 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](move-memtable) fix commit may fail due to duplicated reports [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #32403: URL: https://github.com/apache/doris/pull/32403#issuecomment-2065601385 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [pick](Nereids) cherry-pick prs to branch-2.0 [doris]

2024-04-18 Thread via GitHub
LiBinfeng-01 closed pull request #33838: [pick](Nereids) cherry-pick prs to branch-2.0 URL: https://github.com/apache/doris/pull/33838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [fix](decommission) fix cann't decommission mtmv [doris]

2024-04-18 Thread via GitHub
dataroaring commented on PR #33823: URL: https://github.com/apache/doris/pull/33823#issuecomment-2065605708 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](nereids) do not push RF into nested cte [doris]

2024-04-18 Thread via GitHub
englefly commented on PR #33769: URL: https://github.com/apache/doris/pull/33769#issuecomment-2065605759 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhencement](Nereids) string compare with empty string convert to length greater than zero [doris]

2024-04-18 Thread via GitHub
LiBinfeng-01 commented on PR #33837: URL: https://github.com/apache/doris/pull/33837#issuecomment-2065606296 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](schema change) fix schema change check does not calculate reader merged rows [doris]

2024-04-18 Thread via GitHub
dataroaring commented on PR #33825: URL: https://github.com/apache/doris/pull/33825#issuecomment-2065607100 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature-wip](Cloud) Show isDefault vault in show storage vault stmt [doris]

2024-04-18 Thread via GitHub
dataroaring merged PR #33839: URL: https://github.com/apache/doris/pull/33839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

(doris) branch master updated (8aa0b1c0959 -> 64ceab497d4)

2024-04-18 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 8aa0b1c0959 [imporve](cloud) Get key values in batch during txn commit (#33771) add 64ceab497d4 [feature-wip

Re: [PR] [feature](Cloud) Enable write into file cache for hdfs writer [doris]

2024-04-18 Thread via GitHub
ByteYue commented on code in PR #33796: URL: https://github.com/apache/doris/pull/33796#discussion_r1571629546 ## be/src/common/config.cpp: ## @@ -1028,6 +1028,7 @@ DEFINE_mInt64(s3_write_buffer_size, "5242880"); // The timeout config for S3 buffer allocation DEFINE_mInt32(s3_

Re: [PR] [fix](schema change) fix schema change check does not calculate reader merged rows [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33825: URL: https://github.com/apache/doris/pull/33825#issuecomment-2065611129 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [bugfix](hive)delete write path after hive insert [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33798: URL: https://github.com/apache/doris/pull/33798#issuecomment-2065612508 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [enhancement](Nereids) Enable parse sql from sql cache and fix some bugs [doris]

2024-04-18 Thread via GitHub
doris-robot commented on PR #33867: URL: https://github.com/apache/doris/pull/33867#issuecomment-2065618011 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [enhancement](Nereids) Enable parse sql from sql cache and fix some bugs [doris]

2024-04-18 Thread via GitHub
924060929 opened a new pull request, #33867: URL: https://github.com/apache/doris/pull/33867 cherry pick from #33262, #33722, #33799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [improve](load) limit flush thread num proportional to CPU count [doris]

2024-04-18 Thread via GitHub
kaijchen commented on code in PR #33325: URL: https://github.com/apache/doris/pull/33325#discussion_r1571640410 ## be/src/common/config.cpp: ## @@ -662,6 +662,12 @@ DEFINE_mInt64(storage_flood_stage_left_capacity_bytes, "1073741824"); // 1GB DEFINE_Int32(flush_thread_num_per_s

Re: [PR] [Improve](config)The stream_load label length is changed to a configurable [doris]

2024-04-18 Thread via GitHub
DongLiang-0 commented on PR #33745: URL: https://github.com/apache/doris/pull/33745#issuecomment-2065620292 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [improve](txn insert) txn insert support write to one table many times [doris]

2024-04-18 Thread via GitHub
mymeiyi commented on PR #32980: URL: https://github.com/apache/doris/pull/32980#issuecomment-2065621068 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] [Doc](fix):Fix typo in CN [doris-website]

2024-04-18 Thread via GitHub
Oliverwqcwrw opened a new pull request, #575: URL: https://github.com/apache/doris-website/pull/575 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] [improve](load) limit flush thread num proportional to CPU count [doris]

2024-04-18 Thread via GitHub
kaijchen commented on PR #33325: URL: https://github.com/apache/doris/pull/33325#issuecomment-2065621705 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [feature](java-udtf) support java-udtf [doris]

2024-04-18 Thread via GitHub
zhangstar333 commented on PR #33595: URL: https://github.com/apache/doris/pull/33595#issuecomment-2065623937 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [opt](auto bucket) add fe config autobucket_max_buckets [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33842: URL: https://github.com/apache/doris/pull/33842#issuecomment-2065624795 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](move-memtable) fix commit may fail due to duplicated reports [doris]

2024-04-18 Thread via GitHub
dataroaring merged PR #32403: URL: https://github.com/apache/doris/pull/32403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

(doris) branch master updated (64ceab497d4 -> 049729a3612)

2024-04-18 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 64ceab497d4 [feature-wip](Cloud) Show isDefault vault in show storage vault stmt (#33839) add 049729a3612 [f

Re: [PR] [improve](load) limit flush thread num proportional to CPU count [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33325: URL: https://github.com/apache/doris/pull/33325#issuecomment-2065627033 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](schema change) fix schema change check does not calculate reader merged rows [doris]

2024-04-18 Thread via GitHub
doris-robot commented on PR #33825: URL: https://github.com/apache/doris/pull/33825#issuecomment-2065628455 TeamCity be ut coverage result: Function Coverage: 35.43% (8913/25158) Line Coverage: 27.12% (73230/269977) Region Coverage: 26.26% (37837/144103) Branch Coverage: 23.0

Re: [PR] [enhancement](threadname) change thread name, whose length is restric… [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33792: URL: https://github.com/apache/doris/pull/33792#issuecomment-2065633370 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [feature] (partition) Dynamic partition behavior changes [doris]

2024-04-18 Thread via GitHub
wyxxxcat commented on PR #33712: URL: https://github.com/apache/doris/pull/33712#issuecomment-2065633582 run cloud_p1 5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Enhancement](group commit) Add fault injection case for group commit [doris]

2024-04-18 Thread via GitHub
mymeiyi commented on code in PR #33861: URL: https://github.com/apache/doris/pull/33861#discussion_r1571660581 ## be/src/runtime/group_commit_mgr.cpp: ## @@ -392,7 +401,7 @@ Status GroupCommitTable::_finish_group_commit_load(int64_t db_id, int64_t table_ // status: exec_pl

Re: [PR] [Feat](nereids) add rewrite rule LikeToEqualRewrite [doris]

2024-04-18 Thread via GitHub
feiniaofeiafei commented on PR #33803: URL: https://github.com/apache/doris/pull/33803#issuecomment-2065634399 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Fix](nereids) fix bind order by expression logic [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33843: URL: https://github.com/apache/doris/pull/33843#issuecomment-2065638062 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Fix](nereids) fix bind order by expression logic [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33843: URL: https://github.com/apache/doris/pull/33843#issuecomment-2065638040 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Fix](Csv-Reader)Fix the issue of BE core dump caused by improper configuration of column_seperator and line_delimiter. [doris]

2024-04-18 Thread via GitHub
BePPPower commented on PR #33693: URL: https://github.com/apache/doris/pull/33693#issuecomment-2065642356 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Fix](planner) fix create view star except and modify cast to sql [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33726: URL: https://github.com/apache/doris/pull/33726#issuecomment-2065646548 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](multi-table-load) fix single stream multi table load cannot finish [doris]

2024-04-18 Thread via GitHub
HHoflittlefish777 commented on PR #33816: URL: https://github.com/apache/doris/pull/33816#issuecomment-2065646626 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Fix](Csv-Reader)Fix the issue of BE core dump caused by improper configuration of column_seperator and line_delimiter. [doris]

2024-04-18 Thread via GitHub
BePPPower commented on PR #33693: URL: https://github.com/apache/doris/pull/33693#issuecomment-2065647155 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

(doris) branch master updated (049729a3612 -> c04416b2f8d)

2024-04-18 Thread starocean999
This is an automated email from the ASF dual-hosted git repository. starocean999 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 049729a3612 [fix](move-memtable) fix commit may fail due to duplicated reports (#32403) add c04416b2f8d [Fi

Re: [PR] [Fix](planner) fix create view star except and modify cast to sql [doris]

2024-04-18 Thread via GitHub
starocean999 merged PR #33726: URL: https://github.com/apache/doris/pull/33726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

(doris) branch master updated: [Fix](planner) fix create view star except and modify cast to sql (#33726)

2024-04-18 Thread starocean999
This is an automated email from the ASF dual-hosted git repository. starocean999 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new c6b766722be [Fix](planner) fix create view

Re: [PR] [Fix](nereids) fix bind order by expression logic [doris]

2024-04-18 Thread via GitHub
starocean999 merged PR #33843: URL: https://github.com/apache/doris/pull/33843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

[PR] [fix](DECIMAL) error DECIMAL cat to BOOLEAN [doris]

2024-04-18 Thread via GitHub
Mryange opened a new pull request, #33868: URL: https://github.com/apache/doris/pull/33868 ## Proposed changes before ``` mysql [test]>select cast(3.000 as boolean) ; ++ | cast(3.000 as BOOLEAN) | ++ | 3

Re: [PR] [fix](DECIMAL) error DECIMAL cat to BOOLEAN [doris]

2024-04-18 Thread via GitHub
doris-robot commented on PR #33868: URL: https://github.com/apache/doris/pull/33868#issuecomment-2065652762 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [feature](Cloud) Enable write into file cache for hdfs writer [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33796: URL: https://github.com/apache/doris/pull/33796#issuecomment-2065653265 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [feature](Cloud) Enable write into file cache for hdfs writer [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33796: URL: https://github.com/apache/doris/pull/33796#issuecomment-2065653295 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](DECIMAL) error DECIMAL cat to BOOLEAN [doris]

2024-04-18 Thread via GitHub
Mryange commented on PR #33868: URL: https://github.com/apache/doris/pull/33868#issuecomment-2065654421 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [feature](Cloud) Enable write into file cache for hdfs writer [doris]

2024-04-18 Thread via GitHub
platoneko merged PR #33796: URL: https://github.com/apache/doris/pull/33796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

(doris) branch master updated (c6b766722be -> 401910c017f)

2024-04-18 Thread plat1ko
This is an automated email from the ASF dual-hosted git repository. plat1ko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from c6b766722be [Fix](planner) fix create view star except and modify cast to sql (#33726) add 401910c017f [feature]

Re: [PR] [fix](decommission) fix cann't decommission mtmv [doris]

2024-04-18 Thread via GitHub
yujun777 commented on PR #33823: URL: https://github.com/apache/doris/pull/33823#issuecomment-2065654807 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](multi-table-load) fix single stream multi table load cannot finish [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33816: URL: https://github.com/apache/doris/pull/33816#issuecomment-2065655077 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](vectorization) fix gcc compile failed [doris]

2024-04-18 Thread via GitHub
caizj commented on PR #31996: URL: https://github.com/apache/doris/pull/31996#issuecomment-2065655166 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [Fix](compile) Fix gcc compile on master [doris]

2024-04-18 Thread via GitHub
zclllyybb commented on PR #33864: URL: https://github.com/apache/doris/pull/33864#issuecomment-2065655746 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Feat](nereids) add transform rule SimplifyWindowExpression [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33647: URL: https://github.com/apache/doris/pull/33647#issuecomment-2065655866 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](multi-table-load) fix single stream multi table load cannot finish [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33816: URL: https://github.com/apache/doris/pull/33816#issuecomment-2065655097 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](test)fix auto partition date file not exists [doris]

2024-04-18 Thread via GitHub
zclllyybb commented on PR #33827: URL: https://github.com/apache/doris/pull/33827#issuecomment-2065655813 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Feat](nereids) add transform rule SimplifyWindowExpression [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33647: URL: https://github.com/apache/doris/pull/33647#issuecomment-2065655893 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Feat](nereids) add rewrite rule PushCountIntoUnionAll [doris]

2024-04-18 Thread via GitHub
924060929 commented on code in PR #33530: URL: https://github.com/apache/doris/pull/33530#discussion_r1571690150 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/CheckAfterRewrite.java: ## @@ -106,7 +106,7 @@ private void checkAllSlotReferenceFromChildren(Plan

Re: [PR] [fix](DECIMAL) error DECIMAL cat to BOOLEAN [doris]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #33868: URL: https://github.com/apache/doris/pull/33868#issuecomment-2065656931 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](mow) cloud full compaction should check unique key when trying to calculate delete bitmap [doris]

2024-04-18 Thread via GitHub
zhannngchen commented on code in PR #33859: URL: https://github.com/apache/doris/pull/33859#discussion_r1571695945 ## be/src/cloud/cloud_full_compaction.cpp: ## @@ -295,7 +295,14 @@ void CloudFullCompaction::do_lease() { } } -Status CloudFullCompaction::_cloud_full_comp

Re: [PR] [Feat](nereids) add rewrite rule PushCountIntoUnionAll [doris]

2024-04-18 Thread via GitHub
feiniaofeiafei commented on PR #33530: URL: https://github.com/apache/doris/pull/33530#issuecomment-2065661914 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Fix](Csv-Reader)Fix the issue of BE core dump caused by improper configuration of column_seperator and line_delimiter. [doris]

2024-04-18 Thread via GitHub
doris-robot commented on PR #33693: URL: https://github.com/apache/doris/pull/33693#issuecomment-2065664132 TeamCity be ut coverage result: Function Coverage: 35.45% (8920/25161) Line Coverage: 27.15% (73315/270003) Region Coverage: 26.27% (37853/144115) Branch Coverage: 23.0

Re: [PR] [Feat](nereids) add rewrite rule PushCountIntoUnionAll [doris]

2024-04-18 Thread via GitHub
924060929 commented on code in PR #33530: URL: https://github.com/apache/doris/pull/33530#discussion_r1571691751 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PushCountIntoUnionAll.java: ## @@ -0,0 +1,188 @@ +// Licensed to the Apache Software Foundation (AS

Re: [PR] [Feat](nereids) add rewrite rule PushCountIntoUnionAll [doris]

2024-04-18 Thread via GitHub
924060929 commented on code in PR #33530: URL: https://github.com/apache/doris/pull/33530#discussion_r1571699692 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PushCountIntoUnionAll.java: ## @@ -0,0 +1,188 @@ +// Licensed to the Apache Software Foundation (AS

[PR] [Bug](runtime-filter) fix coredump on no null string type rf [doris]

2024-04-18 Thread via GitHub
BiteThet opened a new pull request, #33869: URL: https://github.com/apache/doris/pull/33869 ## Proposed changes fix coredump on no null string type rf ```cpp ** SIGSEGV address not mapped to object (@0x1) received by PID 9781 (TID 13516 OR 0x7f961d90c700) from PID 1; stack trace

Re: [PR] [Bug](runtime-filter) fix coredump on no null string type rf [doris]

2024-04-18 Thread via GitHub
doris-robot commented on PR #33869: URL: https://github.com/apache/doris/pull/33869#issuecomment-2065668862 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [Bug](runtime-filter) fix coredump on no null string type rf [doris]

2024-04-18 Thread via GitHub
BiteThet commented on PR #33869: URL: https://github.com/apache/doris/pull/33869#issuecomment-2065668936 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [Branch-2.1](Outfile) Fixed the problem that the concurrent Outfile wrote multiple Success files [doris]

2024-04-18 Thread via GitHub
BePPPower opened a new pull request, #33870: URL: https://github.com/apache/doris/pull/33870 ## Proposed changes Issue Number: close #xxx backport: https://github.com/apache/doris/pull/33016 ## Further comments If this is a relatively large or complex chang

<    1   2   3   4   5   6   7   >