yiguolei commented on code in PR #33622:
URL: https://github.com/apache/doris/pull/33622#discussion_r1571150437
##########
be/src/util/block_compression.cpp:
##########
@@ -169,40 +172,34 @@ class Lz4BlockCompression : public BlockCompressionCodec {
private:
// reuse LZ4 compress stream
- Status _acquire_compression_ctx(Context** out) {
+ Status _acquire_compression_ctx(std::unique_ptr<Context>& out) {
std::lock_guard<std::mutex> l(_ctx_mutex);
if (_ctx_pool.empty()) {
- Context* context = new (std::nothrow) Context();
- if (context == nullptr) {
+ std::unique_ptr<Context> localCtx = Context::create_unique();
+ if (localCtx.get() == nullptr) {
return Status::InvalidArgument("new LZ4 context error");
}
- context->ctx = LZ4_createStream();
- if (context->ctx == nullptr) {
- delete context;
+ localCtx->ctx = LZ4_createStream();
+ if (localCtx->ctx == nullptr) {
return Status::InvalidArgument("LZ4_createStream error");
}
- *out = context;
+ out = std::move(localCtx);
return Status::OK();
}
- *out = _ctx_pool.back();
+ out = std::move(_ctx_pool.back());
_ctx_pool.pop_back();
return Status::OK();
}
- void _release_compression_ctx(Context* context) {
+ void _release_compression_ctx(std::unique_ptr<Context>& context) {
Review Comment:
use std::unique_ptr<Context>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
