Re: [PR] [feature](invert index) add match_phrase_prefix and match_regexp [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28715: URL: https://github.com/apache/doris/pull/28715#issuecomment-1865817973 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 50.51 seconds stream load tsv: 569 seconds loaded 74807831229 Bytes,

[PR] [branch-2.0](publish version) publish txn fail retry do not wait 1s #28441 [doris]

2023-12-21 Thread via GitHub
yujun777 opened a new pull request, #28793: URL: https://github.com/apache/doris/pull/28793 pick: #28441 If many txns publish failed, then txns start to pile up. No need wait here, even if BE publish failed, FE will send retry tasks later (in no more than 15s). ## Propo

Re: [PR] [branch-2.0](publish version) publish txn fail retry do not wait 1s #28441 [doris]

2023-12-21 Thread via GitHub
yujun777 commented on PR #28793: URL: https://github.com/apache/doris/pull/28793#issuecomment-1865818558 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Fix](executor)Fix scan queue query hang [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28781: URL: https://github.com/apache/doris/pull/28781#issuecomment-1865820341 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit d3737225bdbc28898d441da0394cc4f2944563e5, data reload: false run tpc

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1865823211 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.11 seconds stream load tsv: 569 seconds loaded 74807831229 Bytes,

Re: [PR] [opt](query cancel) optimization for query cancel [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28778: URL: https://github.com/apache/doris/pull/28778#issuecomment-1865824270 TeamCity be ut coverage result: Function Coverage: 36.48% (8538/23406) Line Coverage: 28.60% (69425/242775) Region Coverage: 27.62% (35926/130080) Branch Coverage: 24.3

Re: [PR] [Chore](decimal) set check_overflow_for_decimal to true when alter table [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28777: URL: https://github.com/apache/doris/pull/28777#issuecomment-1865825072 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [branch-2.0](publish version) publish txn fail retry do not wait 1s #28441 [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28793: URL: https://github.com/apache/doris/pull/28793#issuecomment-1865825384 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](nereids)group by expr may be bound twice in bind agg slot [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28771: URL: https://github.com/apache/doris/pull/28771#issuecomment-1865826144 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.34 seconds stream load tsv: 569 seconds loaded 74807831229 Bytes,

Re: [PR] [opt](query cancel) optimization for query cancel [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28778: URL: https://github.com/apache/doris/pull/28778#issuecomment-1865827717 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit f60252351e66dc30109af3cd0e29a58aeed05cac, data reload: false run tpc

Re: [PR] [improvement](memory) Storage page cache use LRU-K algorithm, K=2 [doris]

2023-12-21 Thread via GitHub
xinyiZzz commented on PR #28794: URL: https://github.com/apache/doris/pull/28794#issuecomment-1865828788 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [I] [Bug] doris json类型的字段目前不支持 某个key值不能为 jsonstring [doris]

2023-12-21 Thread via GitHub
foundation1 commented on issue #28735: URL: https://github.com/apache/doris/issues/28735#issuecomment-1865828413 这个是一个合法的 只是他的值 是一个 jsonString 用工具可以解析 ![image](https://github.com/apache/doris/assets/28500506/83a5e019-11a2-429f-b1ae-7d37cacbf7da) 建议还是得支持一下 因为mysql的json 就支持 不然在进行数据迁移时 就会

[PR] [improvement](memory) Storage page cache use LRU-K algorithm, K=2 [doris]

2023-12-21 Thread via GitHub
xinyiZzz opened a new pull request, #28794: URL: https://github.com/apache/doris/pull/28794 ## Proposed changes Storage page cache uses plain LRU Cache, occasional batch operations can cause "cache pollution" in plain LRU Cache. This will cause hotspot data to be squeezed out of the

[PR] [fix](pipelineX) fix cannot runtime obtain profile on pipelineX [doris]

2023-12-21 Thread via GitHub
Mryange opened a new pull request, #28795: URL: https://github.com/apache/doris/pull/28795 ## Proposed changes ``` SET enable_profile=true; set profile_level = 1; set parallel_pipeline_task_num = 8; set ENABLE_SHARED_SCAN = true; set enable_local_exchange = true; set

Re: [I] [Bug] doris json类型的字段目前不支持 某个key值不能为 jsonstring [doris]

2023-12-21 Thread via GitHub
foundation1 commented on issue #28735: URL: https://github.com/apache/doris/issues/28735#issuecomment-1865831472 > 这不是一个合法的json,它应该是`[{"854368616680689809":[{"h": 12}]}]` 这个是一个 合法的json 用工具可以解析 只是因为他的值是一个 jsonString https://github.com/apache/doris/issues/28735#issuecomment-186539115

Re: [PR] [Enhancement](load) Limit the number of incorrect data drops [doris]

2023-12-21 Thread via GitHub
xy720 commented on PR #27727: URL: https://github.com/apache/doris/pull/27727#issuecomment-1865831495 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[PR] [Bug](mark-join) fix mark join report error when probe block have col… [doris]

2023-12-21 Thread via GitHub
BiteThet opened a new pull request, #28796: URL: https://github.com/apache/doris/pull/28796 …umn do not output (#27360) fix mark join report error when probe block have column do not output ## Proposed changes pick from #27360 ## Further comments If this is

Re: [PR] [Bug](mark-join) fix mark join report error when probe block have col… [doris]

2023-12-21 Thread via GitHub
BiteThet commented on PR #28796: URL: https://github.com/apache/doris/pull/28796#issuecomment-1865831709 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[I] [Feature]2.0.1 版本BE的8040端口和brpc的8060端口缺少鉴权,有安全风险 [doris]

2023-12-21 Thread via GitHub
cxw0619 opened a new issue, #28797: URL: https://github.com/apache/doris/issues/28797 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description (https://github

Re: [PR] [Improvement](materialized-view) forbidden mv rewriter when select stmt's from clause not have mv [doris]

2023-12-21 Thread via GitHub
BiteThet commented on PR #28798: URL: https://github.com/apache/doris/pull/28798#issuecomment-1865834144 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [bug](pipelineX) Fix pipelineX bug on multiple BE [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28792: URL: https://github.com/apache/doris/pull/28792#issuecomment-1865834590 TeamCity be ut coverage result: Function Coverage: 36.48% (8538/23405) Line Coverage: 28.59% (69417/242783) Region Coverage: 27.61% (35913/130081) Branch Coverage: 24.3

Re: [PR] [bug](pipelineX) Fix pipelineX bug on multiple BE [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28753: URL: https://github.com/apache/doris/pull/28753#issuecomment-1865835106 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit a77749049b55770bd04680eb8e5516320f41be3e, data reload: false run tpc

[PR] [Improvement](materialized-view) forbidden mv rewriter when select stmt's from clause not have mv [doris]

2023-12-21 Thread via GitHub
BiteThet opened a new pull request, #28798: URL: https://github.com/apache/doris/pull/28798 …mt's from clause not have mv (#27638) forbidden mv rewriter when select stmt's from clause not have mv ## Proposed changes pick from #27638 ## Further comments If th

Re: [PR] [fix](load) reduce lock scope in MemTableWriter active consumption [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28790: URL: https://github.com/apache/doris/pull/28790#issuecomment-1865836397 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.25 seconds stream load tsv: 580 seconds loaded 74807831229 Bytes,

Re: [PR] [opt](Nereids) improve Shape check cases [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28124: URL: https://github.com/apache/doris/pull/28124#issuecomment-1865836481 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.08 seconds stream load tsv: 568 seconds loaded 74807831229 Bytes,

[PR] [Bug](materialized-view) fix create mv failed on unique table (#27971) [doris]

2023-12-21 Thread via GitHub
BiteThet opened a new pull request, #28799: URL: https://github.com/apache/doris/pull/28799 fix create mv failed on unique table ## Proposed changes pick from #27971 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@

Re: [PR] [improvement](memory) Storage page cache use LRU-K algorithm, K=2 [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on code in PR #28794: URL: https://github.com/apache/doris/pull/28794#discussion_r1433701883 ## be/src/olap/page_cache.cpp: ## @@ -66,7 +66,7 @@ bool StoragePageCache::lookup(const CacheKey& key, PageCacheHandle* handle, return true; } -voi

Re: [PR] [Bug](materialized-view) fix create mv failed on unique table (#27971) [doris]

2023-12-21 Thread via GitHub
BiteThet commented on PR #28799: URL: https://github.com/apache/doris/pull/28799#issuecomment-1865837646 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](Nereids) Pull up join from union all [doris]

2023-12-21 Thread via GitHub
xzj7019 commented on PR #28682: URL: https://github.com/apache/doris/pull/28682#issuecomment-1865838320 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [Bug](mark-join) fix mark join report error when probe block have col… [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28796: URL: https://github.com/apache/doris/pull/28796#issuecomment-1865838721 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [branch-2.0-fix](partial update) Don't use delete bitmap to mark delete for rows with delete sign when sequence column doesn't exist [doris]

2023-12-21 Thread via GitHub
bobhan1 opened a new pull request, #28800: URL: https://github.com/apache/doris/pull/28800 ## Proposed changes pick from master: https://github.com/apache/doris/pull/26721 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d.

Re: [PR] [Enhancement](load) Limit the number of incorrect data drops [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #27727: URL: https://github.com/apache/doris/pull/27727#issuecomment-1865839832 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [improvement](external catalog)Change log level to debug for getRowCountFromExternalSource. [doris]

2023-12-21 Thread via GitHub
Jibing-Li opened a new pull request, #28801: URL: https://github.com/apache/doris/pull/28801 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailt

Re: [PR] [fix](group-commit) check if wal need recovery is not correct [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28769: URL: https://github.com/apache/doris/pull/28769#issuecomment-1865841357 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.02 seconds stream load tsv: 565 seconds loaded 74807831229 Bytes,

Re: [PR] [improvement](external catalog)Change log level to debug for getRowCountFromExternalSource. [doris]

2023-12-21 Thread via GitHub
Jibing-Li commented on PR #28801: URL: https://github.com/apache/doris/pull/28801#issuecomment-1865841808 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] [Bug] doris json类型的字段目前不支持 某个key值不能为 jsonstring [doris]

2023-12-21 Thread via GitHub
foundation1 commented on issue #28735: URL: https://github.com/apache/doris/issues/28735#issuecomment-1865842313 > This is not a legal json, it should be `[{"854368616680689809":[{"h": 12}]}]` 这个json是合法的 用解析工具可以解析 ![image](https://github.com/apache/doris/assets/28500506/e3fc5701-e

Re: [PR] [Fix](metrics) correct fe collector type for jvm_gc [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28784: URL: https://github.com/apache/doris/pull/28784#issuecomment-1865839824 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [improve](move-memtable) remove heavy work pool from load stream [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28745: URL: https://github.com/apache/doris/pull/28745#issuecomment-1865843595 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [bug](pipelineX) Fix pipelineX bug on multiple BE [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28792: URL: https://github.com/apache/doris/pull/28792#issuecomment-1865844279 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 43.87 seconds stream load tsv: 571 seconds loaded 74807831229 Bytes,

Re: [PR] [feature](invert index) add match_phrase_prefix and match_regexp [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28715: URL: https://github.com/apache/doris/pull/28715#issuecomment-1865844904 TeamCity be ut coverage result: Function Coverage: 37.75% (7991/21170) Line Coverage: 29.44% (64901/220433) Region Coverage: 28.92% (33397/115491) Branch Coverage: 24.7

Re: [PR] [improve](move-memtable) remove heavy work pool from load stream [doris]

2023-12-21 Thread via GitHub
kaijchen commented on PR #28745: URL: https://github.com/apache/doris/pull/28745#issuecomment-1865844913 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [pipelineX](fix) Fix TPCH Q2 [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28783: URL: https://github.com/apache/doris/pull/28783#issuecomment-1865845262 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 8ce113ce81549a749b73df3d15458edb82b2849a, data reload: false run tpc

Re: [PR] [Fix](metrics) correct fe collector type for jvm_gc [doris]

2023-12-21 Thread via GitHub
Gabriel39 merged PR #28784: URL: https://github.com/apache/doris/pull/28784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [I] [Bug] promethues can't collect info from fe [doris]

2023-12-21 Thread via GitHub
Gabriel39 closed issue #28789: [Bug] promethues can't collect info from fe URL: https://github.com/apache/doris/issues/28789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(doris) branch master updated (4ddef31c208 -> 6dcf79fc27a)

2023-12-21 Thread gabriellee
This is an automated email from the ASF dual-hosted git repository. gabriellee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 4ddef31c208 (fix)[meta][export] fix replay export NPE issue (#28752) add 6dcf79fc27a [Bug fix][metrics] correc

Error while running github feature from .asf.yaml in doris!

2023-12-21 Thread Apache Infrastructure
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsub

Re: [PR] [branch-2.0](publish version) publish txn fail retry do not wait 1s #28441 [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28793: URL: https://github.com/apache/doris/pull/28793#issuecomment-1865846983 TeamCity be ut coverage result: Function Coverage: 37.78% (7989/21144) Line Coverage: 29.49% (64906/220106) Region Coverage: 28.96% (33394/115320) Branch Coverage: 24.8

Re: [PR] [Chore](decimal) set check_overflow_for_decimal to true when alter table [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28777: URL: https://github.com/apache/doris/pull/28777#issuecomment-1865847444 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [improvement](external catalog)Change log level to debug for getRowCountFromExternalSource. [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28801: URL: https://github.com/apache/doris/pull/28801#issuecomment-1865847912 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [branch-2-0](http) add show_table_data http api [doris]

2023-12-21 Thread via GitHub
nextdreamblue commented on PR #28633: URL: https://github.com/apache/doris/pull/28633#issuecomment-1865847069 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [improvement](external catalog)Change log level to debug for getRowCountFromExternalSource. [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28801: URL: https://github.com/apache/doris/pull/28801#issuecomment-1865847977 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-21 Thread via GitHub
nanfeng1999 commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1865849603 run arm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [branch-2.0-fix](partial update) Don't use delete bitmap to mark delete for rows with delete sign when sequence column doesn't exist [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28800: URL: https://github.com/apache/doris/pull/28800#issuecomment-1865850302 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Feature](Variant) Implement variant new sub column access method [doris]

2023-12-21 Thread via GitHub
eldenmoon commented on PR #28484: URL: https://github.com/apache/doris/pull/28484#issuecomment-1865851422 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [feature](nereids)support decimalv2 [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28726: URL: https://github.com/apache/doris/pull/28726#issuecomment-1865851627 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[PR] [fix](paimon)fix `like` predict [doris]

2023-12-21 Thread via GitHub
wuwenchi opened a new pull request, #28803: URL: https://github.com/apache/doris/pull/28803 ## Proposed changes fix `like` predict ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@

Re: [PR] [branch-2.0-fix](partial update) Don't use delete bitmap to mark delete for rows with delete sign when sequence column doesn't exist [doris]

2023-12-21 Thread via GitHub
bobhan1 commented on PR #28800: URL: https://github.com/apache/doris/pull/28800#issuecomment-1865852400 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](paimon)fix `like` predict [doris]

2023-12-21 Thread via GitHub
wuwenchi commented on PR #28803: URL: https://github.com/apache/doris/pull/28803#issuecomment-1865852939 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Error while running github feature from .asf.yaml in doris!

2023-12-21 Thread Apache Infrastructure
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsub

Re: [PR] [Improvement](execute) optimize for ColumnNullable's serialize_vec/deserialize_vec [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28788: URL: https://github.com/apache/doris/pull/28788#issuecomment-1865854176 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 3a0f89eeca40f565d04115152206caf3b235bd69, data reload: false run tpc

Re: [PR] [branch-2.0](publish version) fix publish version failed but return ok #28425 [doris]

2023-12-21 Thread via GitHub
yujun777 commented on PR #28791: URL: https://github.com/apache/doris/pull/28791#issuecomment-1865853438 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

(doris) branch master updated: [Chore](decimal) set check_overflow_for_decimal to true when alter table(#28777)

2023-12-21 Thread panxiaolei
This is an automated email from the ASF dual-hosted git repository. panxiaolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new f3bf26c269c [Chore](decimal) set check_overfl

Re: [PR] [Chore](decimal) set check_overflow_for_decimal to true when alter table [doris]

2023-12-21 Thread via GitHub
BiteThet merged PR #28777: URL: https://github.com/apache/doris/pull/28777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

Re: [PR] [feature](Nereids): return residual expr of join [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28760: URL: https://github.com/apache/doris/pull/28760#issuecomment-1865853971 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [improve](move-memtable) remove heavy work pool from load stream [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28745: URL: https://github.com/apache/doris/pull/28745#issuecomment-1865854856 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [branch-2.0-fix](partial update) Don't use delete bitmap to mark delete for rows with delete sign when sequence column doesn't exist [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28800: URL: https://github.com/apache/doris/pull/28800#issuecomment-1865858376 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] Add high concurrency broker thrift server. [doris]

2023-12-21 Thread via GitHub
fm opened a new pull request, #28804: URL: https://github.com/apache/doris/pull/28804 ## Proposed changes This PR has added TThreadedSelectorServer as the default broker thrift server. TThreadedSelectorServer uses non blocking I/O and a multi-threaded model, which is suitable for

Re: [PR] [branch-2.0](publish version) fix publish version failed but return ok #28425 [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28791: URL: https://github.com/apache/doris/pull/28791#issuecomment-1865859482 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](memory) Add thread asynchronous purge jemalloc dirty pages [doris]

2023-12-21 Thread via GitHub
yiguolei commented on code in PR #28655: URL: https://github.com/apache/doris/pull/28655#discussion_r1433726006 ## be/src/common/daemon.cpp: ## @@ -352,6 +354,18 @@ void Daemon::block_spill_gc_thread() { } } +void Daemon::je_purge_dirty_pages_thread() const { +_je_pu

Re: [PR] [fix](memory) Add thread asynchronous purge jemalloc dirty pages [doris]

2023-12-21 Thread via GitHub
yiguolei commented on code in PR #28655: URL: https://github.com/apache/doris/pull/28655#discussion_r1433726833 ## be/src/common/daemon.h: ## @@ -36,15 +36,22 @@ class Daemon { // Stop background threads void stop(); +static void count_down_je_purge_dirty_pages_t

Re: [PR] [Bug](mark-join) fix mark join report error when probe block have col… [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28796: URL: https://github.com/apache/doris/pull/28796#issuecomment-1865861569 TeamCity be ut coverage result: Function Coverage: 37.79% (7991/21144) Line Coverage: 29.49% (64912/220105) Region Coverage: 28.97% (33402/115318) Branch Coverage: 24.8

Re: [PR] [Chore](decimal) set check_overflow_for_decimal to true when alter table [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28777: URL: https://github.com/apache/doris/pull/28777#issuecomment-1865862044 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 81bfdd295ddcdd5f76e72897e3c581a70609cb6f, data reload: false run tpc

Re: [PR] [improvement](group commit) Add an option of enable relay wal on all regression test [doris]

2023-12-21 Thread via GitHub
hust-hhb commented on PR #28757: URL: https://github.com/apache/doris/pull/28757#issuecomment-1865862411 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [optimize](count) optimize pk exact query without reading data [doris]

2023-12-21 Thread via GitHub
xiaokang commented on code in PR #28494: URL: https://github.com/apache/doris/pull/28494#discussion_r1433730282 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -2570,5 +2573,64 @@ void SegmentIterator::_calculate_pred_in_remaining_conjunct_root( } } +bool S

[I] [Bug] docker方式启动后无法重启 [doris]

2023-12-21 Thread via GitHub
seawenc opened a new issue, #28805: URL: https://github.com/apache/doris/issues/28805 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 2.0.0_alpha-fe-x86_64

Re: [PR] [imrovement](statistics)Auto analyze priority table/column first. [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28385: URL: https://github.com/apache/doris/pull/28385#issuecomment-1865864942 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](function) Fix from_second functions overflow and wrong result [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28685: URL: https://github.com/apache/doris/pull/28685#issuecomment-1865866339 TeamCity be ut coverage result: Function Coverage: 36.47% (8537/23406) Line Coverage: 28.60% (69416/242742) Region Coverage: 27.61% (35914/130056) Branch Coverage: 24.3

Re: [PR] [optimize](count) optimize pk exact query without reading data [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28494: URL: https://github.com/apache/doris/pull/28494#issuecomment-1865870287 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 703686d86e42c66438e23c8309b40ca4ae975edd, data reload: false run tpc

Re: [PR] [improve](move-memtable) remove heavy work pool from load stream [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28745: URL: https://github.com/apache/doris/pull/28745#issuecomment-1865870540 TeamCity be ut coverage result: Function Coverage: 36.46% (8532/23403) Line Coverage: 28.56% (69319/242709) Region Coverage: 27.59% (35885/130061) Branch Coverage: 24.3

[PR] [opt] support orc generated from hive 1.x for all file scan node [doris]

2023-12-21 Thread via GitHub
morningman opened a new pull request, #28806: URL: https://github.com/apache/doris/pull/28806 ## Proposed changes Previous, we only handle orc generated from hive 1.x for `HiveScanNode`. It should be for all kinds for FileScanNode. And no need to set `hive.version = 1.1.0` ex

Re: [PR] [fix](pipelineX) fix cannot runtime obtain profile on pipelineX [doris]

2023-12-21 Thread via GitHub
Mryange commented on PR #28795: URL: https://github.com/apache/doris/pull/28795#issuecomment-1865871613 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](paimon)fix type convert for paimon [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28774: URL: https://github.com/apache/doris/pull/28774#issuecomment-1865871764 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [improvement](group commit) Add an option of enable relay wal on all regression test [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on code in PR #28757: URL: https://github.com/apache/doris/pull/28757#discussion_r1433737891 ## be/src/olap/wal_manager.cpp: ## @@ -410,4 +424,80 @@ Status WalManager::get_wal_column_index(int64_t wal_id, std::vector& col return Status::OK();

Re: [PR] [fix](paimon)fix type convert for paimon [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28774: URL: https://github.com/apache/doris/pull/28774#issuecomment-1865871709 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [improvement](executor) Add tvf and regression test for Workload Scheduler [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28733: URL: https://github.com/apache/doris/pull/28733#issuecomment-1865872722 TeamCity be ut coverage result: Function Coverage: 36.48% (8538/23407) Line Coverage: 28.60% (69425/242784) Region Coverage: 27.61% (35920/130079) Branch Coverage: 24.3

Re: [PR] Add high concurrency broker thrift server. [doris]

2023-12-21 Thread via GitHub
fm commented on PR #28804: URL: https://github.com/apache/doris/pull/28804#issuecomment-1865875448 @WinkerDu @morningman @chenlinzhong Please take a review, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Add high concurrency broker thrift server. [doris]

2023-12-21 Thread via GitHub
fm commented on PR #28804: URL: https://github.com/apache/doris/pull/28804#issuecomment-1865875679 run buildall. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [test](partial update) add complex type regression cases for partial update [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28758: URL: https://github.com/apache/doris/pull/28758#issuecomment-1865875763 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1865878289 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit cfb3f1ccb0fb51b26e90075f7648568a38735da8, data reload: false run tpc

[I] [Bug] MySQL channel infinite blocking [doris]

2023-12-21 Thread via GitHub
fornaix opened a new issue, #28807: URL: https://github.com/apache/doris/issues/28807 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 2.0.2 ### What's

Re: [PR] [Feature](Variant) Implement variant new sub column access method [doris]

2023-12-21 Thread via GitHub
eldenmoon commented on PR #28484: URL: https://github.com/apache/doris/pull/28484#issuecomment-1865881174 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Bug](materialized-view) fix create mv failed on unique table (#27971) [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28799: URL: https://github.com/apache/doris/pull/28799#issuecomment-1865884301 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.57 seconds stream load tsv: 567 seconds loaded 74807831229 Bytes,

Re: [PR] [Bug](mark-join) fix mark join report error when probe block have col… [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28796: URL: https://github.com/apache/doris/pull/28796#issuecomment-1865884938 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 50.51 seconds stream load tsv: 569 seconds loaded 74807831229 Bytes,

Re: [PR] [improve](move-memtable) remove heavy work pool from load stream [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28745: URL: https://github.com/apache/doris/pull/28745#issuecomment-1865885642 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 43.99 seconds stream load tsv: 566 seconds loaded 74807831229 Bytes,

Re: [PR] [improvement](memory) Storage page cache use LRU-K cache, K=2 [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28794: URL: https://github.com/apache/doris/pull/28794#issuecomment-1865886130 TeamCity be ut coverage result: Function Coverage: 36.47% (8537/23407) Line Coverage: 28.60% (69450/242820) Region Coverage: 27.63% (35945/130105) Branch Coverage: 24.3

Re: [PR] [fix](nereids)group by expr may be bound twice in bind agg slot [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28771: URL: https://github.com/apache/doris/pull/28771#issuecomment-1865886712 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit a2f334268a94251941b1422b3cdac924e82c08c1, data reload: false run tpc

Re: [PR] [branch-2.0](publish version) fix publish version failed but return ok #28425 [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28791: URL: https://github.com/apache/doris/pull/28791#issuecomment-1865885677 TeamCity be ut coverage result: Function Coverage: 37.78% (7990/21147) Line Coverage: 29.49% (64917/220150) Region Coverage: 28.96% (33395/115332) Branch Coverage: 24.8

Re: [PR] [feature](nereids)support decimalv2 [doris]

2023-12-21 Thread via GitHub
morrySnow commented on code in PR #28726: URL: https://github.com/apache/doris/pull/28726#discussion_r1433720620 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java: ## @@ -371,6 +373,7 @@ public static Expression su

Re: [PR] [Improve][COLOCATE] improve colocate balance and colocate join [doris]

2023-12-21 Thread via GitHub
yujun777 commented on code in PR #28302: URL: https://github.com/apache/doris/pull/28302#discussion_r1433754658 ## fe/fe-core/src/main/java/org/apache/doris/catalog/Tablet.java: ## @@ -691,6 +691,23 @@ public TabletStatus getColocateHealthStatus(long visibleVersion, re

Re: [PR] [feature](Nereids) Pull up join from union all [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28682: URL: https://github.com/apache/doris/pull/28682#issuecomment-1865888478 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.71 seconds stream load tsv: 568 seconds loaded 74807831229 Bytes,

  1   2   3   4   5   6   7   8   9   10   >