morrySnow commented on code in PR #28726:
URL: https://github.com/apache/doris/pull/28726#discussion_r1433720620
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java:
##########
@@ -371,6 +373,7 @@ public static Expression subtractDoubleDouble(DoubleLiteral
first, DoubleLiteral
@ExecFunction(name = "subtract", argTypes = {"DECIMAL", "DECIMAL"},
returnType = "DECIMAL")
public static Expression subtractDecimalDecimal(DecimalLiteral first,
DecimalLiteral second) {
BigDecimal result = first.getValue().subtract(second.getValue());
+ DecimalV2Type.validateDecimalV2Type(result);
Review Comment:
check in DecimalLiteral directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
