Re: [PR] [performance](variant) support topn 2phase read for variant column [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28318: URL: https://github.com/apache/doris/pull/28318#issuecomment-1857441041 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.51 seconds stream load tsv: 606 seconds loaded 74807831229 Bytes,

Re: [PR] [ci](perf) 1. add perf check of tpcds, 2. adjust clickbench and tpch check [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28431: URL: https://github.com/apache/doris/pull/28431#issuecomment-1857442084 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/7219448671";) output. shellcheck err

Re: [PR] [refact](fe) Split `SchemaChangeHandler.process` into several function [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28366: URL: https://github.com/apache/doris/pull/28366#issuecomment-1857442974 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.25 seconds stream load tsv: 585 seconds loaded 74807831229 Bytes,

Re: [PR] [DNM](Nereids) test disable fallback [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #25344: URL: https://github.com/apache/doris/pull/25344#issuecomment-1857444875 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 43.85 seconds stream load tsv: 588 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](block) fix be core while mutable block merge may cause different row size between columns in origin block [doris]

2023-12-15 Thread via GitHub
caiconghui commented on PR #27943: URL: https://github.com/apache/doris/pull/27943#issuecomment-1857443729 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [improvement](publish) Publish task not wait when be's publish task a… [doris]

2023-12-15 Thread via GitHub
deardeng commented on code in PR #28079: URL: https://github.com/apache/doris/pull/28079#discussion_r1427673698 ## fe/fe-core/src/main/java/org/apache/doris/transaction/PublishVersionDaemon.java: ## @@ -132,27 +133,45 @@ private void publishVersion() { Map tableIdToTota

Re: [PR] [fix](Nereids) explain should fallback too if Nereids is not enable [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28475: URL: https://github.com/apache/doris/pull/28475#issuecomment-1857453817 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.36 seconds stream load tsv: 581 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](block) fix be core while mutable block merge may cause different row size between columns in origin block [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #27943: URL: https://github.com/apache/doris/pull/27943#issuecomment-1857454660 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [nereids] found rows support fe side [doris]

2023-12-15 Thread via GitHub
xzj7019 commented on PR #28372: URL: https://github.com/apache/doris/pull/28372#issuecomment-1857455471 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improvement](hint) query fail print tablet detail info [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28476: URL: https://github.com/apache/doris/pull/28476#issuecomment-1857455561 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 43.99 seconds stream load tsv: 590 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](full compaction) Full compaction should hold meta lock when modifying tablet's meta data [doris]

2023-12-15 Thread via GitHub
bobhan1 commented on PR #28449: URL: https://github.com/apache/doris/pull/28449#issuecomment-1857456250 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](session variables) Make default value of max_execution_time same to query_timeout [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28474: URL: https://github.com/apache/doris/pull/28474#issuecomment-1857457024 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.59 seconds stream load tsv: 585 seconds loaded 74807831229 Bytes,

Re: [PR] [branch-2.0] Pick "[fix](partial update) Fix missing rowsets during doing alignment when flushing memtable due to compaction #28062" [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28468: URL: https://github.com/apache/doris/pull/28468#issuecomment-1857458954 TeamCity be ut coverage result: Function Coverage: 37.81% (7988/21129) Line Coverage: 29.48% (64826/219913) Region Coverage: 28.95% (33356/115238) Branch Coverage: 24.8

Re: [PR] [feature](Load)(step2)support nereids load job schedule [doris]

2023-12-15 Thread via GitHub
wsjz commented on code in PR #26356: URL: https://github.com/apache/doris/pull/26356#discussion_r1427678062 ## fe/fe-core/src/main/java/org/apache/doris/job/extensions/insert/InsertTask.java: ## @@ -74,30 +72,70 @@ public class InsertTask extends AbstractTask { } pri

Re: [PR] [Pick-2.0](vcompound pred) Corrected evaluation for compound predicates with constant columns [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28477: URL: https://github.com/apache/doris/pull/28477#issuecomment-1857459190 TeamCity be ut coverage result: Function Coverage: 37.88% (8002/21126) Line Coverage: 29.54% (64938/219862) Region Coverage: 29.01% (33425/115215) Branch Coverage: 24.9

Re: [PR] [feature](Load)(step2)support nereids load job schedule [doris]

2023-12-15 Thread via GitHub
wsjz commented on code in PR #26356: URL: https://github.com/apache/doris/pull/26356#discussion_r1427678969 ## fe/fe-core/src/main/java/org/apache/doris/job/extensions/insert/InsertTask.java: ## @@ -74,30 +72,70 @@ public class InsertTask extends AbstractTask { } pri

[I] [Feature] 窗口分析函数支持窗口按照时间范围 [doris]

2023-12-15 Thread via GitHub
xiaolei55 opened a new issue, #28478: URL: https://github.com/apache/doris/issues/28478 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description 窗口分析函数支持按照时间窗口,类似语

Re: [PR] [fix](Planner): parse more Punctuation Date/DateTime [doris]

2023-12-15 Thread via GitHub
jackwener merged PR #28432: URL: https://github.com/apache/doris/pull/28432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

(doris) branch master updated: [fix](Planner): parse more Punctuation Date/DateTime (#28432)

2023-12-15 Thread jakevin
This is an automated email from the ASF dual-hosted git repository. jakevin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 8986bb6bb4d [fix](Planner): parse more Punctuati

Re: [PR] [fix](Nereids): TransposeSemiJoinAgg can't apply in Scalar Agg [doris]

2023-12-15 Thread via GitHub
jackwener merged PR #28434: URL: https://github.com/apache/doris/pull/28434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Error while running github feature from .asf.yaml in doris!

2023-12-15 Thread Apache Infrastructure
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsub

Re: [PR] [fix](full compaction) Full compaction should hold meta lock when modifying tablet's meta data [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28449: URL: https://github.com/apache/doris/pull/28449#issuecomment-1857463843 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Error while running github feature from .asf.yaml in doris!

2023-12-15 Thread Apache Infrastructure
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsub

(doris) branch master updated (8986bb6bb4d -> 0f93ee87936)

2023-12-15 Thread jakevin
This is an automated email from the ASF dual-hosted git repository. jakevin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 8986bb6bb4d [fix](Planner): parse more Punctuation Date/DateTime (#28432) add 0f93ee87936 [fix](Nereids): Transp

Re: [PR] [chore](user) Add user property `parallel_fragment_exec_instance_num` [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28447: URL: https://github.com/apache/doris/pull/28447#issuecomment-1857464612 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.45 seconds stream load tsv: 586 seconds loaded 74807831229 Bytes,

Re: [PR] [Pick-2.0](vcompound pred) Corrected evaluation for compound predicates with constant columns [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28477: URL: https://github.com/apache/doris/pull/28477#issuecomment-1857466212 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 51.11 seconds stream load tsv: 603 seconds loaded 74807831229 Bytes,

Re: [PR] [regression](memtable) add case for memtable flush error status handle [doris]

2023-12-15 Thread via GitHub
Ma1oneZhang commented on PR #28285: URL: https://github.com/apache/doris/pull/28285#issuecomment-1857469600 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [regression](memtable) add case for memtable flush error status handle [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28285: URL: https://github.com/apache/doris/pull/28285#issuecomment-1857472765 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [feature](Load)(step2)support nereids load job schedule [doris]

2023-12-15 Thread via GitHub
wsjz commented on code in PR #26356: URL: https://github.com/apache/doris/pull/26356#discussion_r1427690881 ## fe/fe-core/src/main/java/org/apache/doris/job/extensions/insert/InsertJob.java: ## @@ -65,58 +100,171 @@ public class InsertJob extends AbstractJob { new C

Re: [PR] [fix](Export) Fix an export error when lower_case_table_names=1 [doris]

2023-12-15 Thread via GitHub
BePPPower commented on PR #28389: URL: https://github.com/apache/doris/pull/28389#issuecomment-1857477348 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Branch2.0](fix) Fix an `export` error when lower case table names=1 [doris]

2023-12-15 Thread via GitHub
BePPPower commented on PR #28388: URL: https://github.com/apache/doris/pull/28388#issuecomment-1857477641 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [refact](fe) Split `SchemaChangeHandler.process` into several function [doris]

2023-12-15 Thread via GitHub
SWJTU-ZhangLei commented on PR #28366: URL: https://github.com/apache/doris/pull/28366#issuecomment-1857477385 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Draft](HiveCatalog) Support for querying relational databases under HMS [doris]

2023-12-15 Thread via GitHub
BePPPower closed pull request #27737: [Draft](HiveCatalog) Support for querying relational databases under HMS URL: https://github.com/apache/doris/pull/27737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

(doris-flink-connector) branch master updated: [step4][Improve]Format suppressions files and pom files (#274)

2023-12-15 Thread diwu
This is an automated email from the ASF dual-hosted git repository. diwu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-flink-connector.git The following commit(s) were added to refs/heads/master by this push: new 124879d [step4][Improve]Format sup

Re: [PR] [step4][Improve]Format suppressions files and pom files [doris-flink-connector]

2023-12-15 Thread via GitHub
JNSimba merged PR #274: URL: https://github.com/apache/doris-flink-connector/pull/274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

Re: [PR] [feature](executor)make scan task wait timeout config [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28467: URL: https://github.com/apache/doris/pull/28467#issuecomment-1857490182 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.1 seconds stream load tsv: 593 seconds loaded 74807831229 Bytes, a

Re: [PR] [feature](Load)(step2)support nereids load job schedule [doris]

2023-12-15 Thread via GitHub
wsjz commented on code in PR #26356: URL: https://github.com/apache/doris/pull/26356#discussion_r1427703299 ## fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/load/LoadMgr.java: ## @@ -0,0 +1,340 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

Re: [PR] [feature](Load)(step2)support nereids load job schedule [doris]

2023-12-15 Thread via GitHub
wsjz commented on code in PR #26356: URL: https://github.com/apache/doris/pull/26356#discussion_r1427703299 ## fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/load/LoadMgr.java: ## @@ -0,0 +1,340 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

Re: [PR] [fix](full compaction) Full compaction should hold meta lock when modifying tablet's meta data [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28449: URL: https://github.com/apache/doris/pull/28449#issuecomment-1857498338 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.82 seconds stream load tsv: 606 seconds loaded 74807831229 Bytes,

Re: [PR] [improvement](hint) query fail print tablet detail info [doris]

2023-12-15 Thread via GitHub
yujun777 commented on PR #28476: URL: https://github.com/apache/doris/pull/28476#issuecomment-1857501074 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [cherry-pick](udf) java-udf function open failed cause BE core dump #28063 [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28462: URL: https://github.com/apache/doris/pull/28462#issuecomment-1857503878 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 51.71 seconds stream load tsv: 601 seconds loaded 74807831229 Bytes,

Re: [PR] [chore] Add bvar for meta operations of BE [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28374: URL: https://github.com/apache/doris/pull/28374#issuecomment-1857504494 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](block) fix be core while mutable block merge may cause different row size between columns in origin block [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #27943: URL: https://github.com/apache/doris/pull/27943#issuecomment-1857511066 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.76 seconds stream load tsv: 590 seconds loaded 74807831229 Bytes,

Re: [PR] [chore] Add bvar for meta operations of BE [doris]

2023-12-15 Thread via GitHub
gavinchou commented on PR #28374: URL: https://github.com/apache/doris/pull/28374#issuecomment-1857511367 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] [fix](proxy) Fix getProxy frequently parse hostname to ip [doris]

2023-12-15 Thread via GitHub
xinyiZzz opened a new pull request, #28479: URL: https://github.com/apache/doris/pull/28479 ## Proposed changes Each RPC between Doris FE and BE will call getProxy. Each getProxy will parse hostname and check whether the IP has changed. When the hostname resolution server is un

Re: [PR] [regression](memtable) add case for memtable flush error status handle [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28285: URL: https://github.com/apache/doris/pull/28285#issuecomment-1857511791 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.8 seconds stream load tsv: 605 seconds loaded 74807831229 Bytes, a

Re: [PR] [feature](Nereids): put or expansion rule in rewriter [doris]

2023-12-15 Thread via GitHub
XieJiann commented on PR #28348: URL: https://github.com/apache/doris/pull/28348#issuecomment-1857516949 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](Export) Fix an export error when lower_case_table_names=1 [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28389: URL: https://github.com/apache/doris/pull/28389#issuecomment-1857520139 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 43.99 seconds stream load tsv: 582 seconds loaded 74807831229 Bytes,

Re: [PR] [chore] Add bvar for meta operations of BE [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28374: URL: https://github.com/apache/doris/pull/28374#issuecomment-1857521564 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refact](fe) Refact `SchemaChangeHandler.createJob` [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28366: URL: https://github.com/apache/doris/pull/28366#issuecomment-1857524559 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.45 seconds stream load tsv: 588 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](proxy) Fix getProxy frequently parse hostname to ip [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28479: URL: https://github.com/apache/doris/pull/28479#issuecomment-1857524013 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [fix](iterator) Fix mem leak when initial iterator failed [doris]

2023-12-15 Thread via GitHub
w41ter opened a new pull request, #28480: URL: https://github.com/apache/doris/pull/28480 ## Proposed changes Issue Number: close #xxx Memory leaks are prone to occur when using raw pointers, such as directly using the `RETURN_IF_ERROR` macro to skip error handling. This PR rep

Re: [PR] [fix](iterator) Fix mem leak when initial iterator failed [doris]

2023-12-15 Thread via GitHub
w41ter commented on PR #28480: URL: https://github.com/apache/doris/pull/28480#issuecomment-1857526960 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[PR] [Test](Job)Add test case [doris]

2023-12-15 Thread via GitHub
CalvinKirs opened a new pull request, #28481: URL: https://github.com/apache/doris/pull/28481 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mail

Re: [PR] [fix](iterator) Fix mem leak when initial iterator failed [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28480: URL: https://github.com/apache/doris/pull/28480#issuecomment-1857535385 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [feature](mtmv)mtmv support partition [doris]

2023-12-15 Thread via GitHub
zddr commented on PR #28144: URL: https://github.com/apache/doris/pull/28144#issuecomment-1857537083 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [Bug](view) fix npe on create view with comment [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28464: URL: https://github.com/apache/doris/pull/28464#issuecomment-1857537310 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Bug](view) fix npe on create view with comment [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28464: URL: https://github.com/apache/doris/pull/28464#issuecomment-1857537352 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [improvement](publish) Publish task not wait when be's publish task a… [doris]

2023-12-15 Thread via GitHub
deardeng commented on code in PR #28079: URL: https://github.com/apache/doris/pull/28079#discussion_r1427740924 ## fe/fe-core/src/main/java/org/apache/doris/transaction/PublishVersionDaemon.java: ## @@ -132,27 +133,45 @@ private void publishVersion() { Map tableIdToTota

Re: [PR] [improvement](hint) query fail print tablet detail info [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28476: URL: https://github.com/apache/doris/pull/28476#issuecomment-1857544476 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.32 seconds stream load tsv: 584 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](operation_node)Replace structure to ensure same colRef can be save [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28440: URL: https://github.com/apache/doris/pull/28440#issuecomment-1857546288 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [cherry-pick](udf) java-udf function open failed cause BE core dump #28063 [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28462: URL: https://github.com/apache/doris/pull/28462#issuecomment-1857547431 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 50.08 seconds stream load tsv: 599 seconds loaded 74807831229 Bytes,

[PR] [Bug](memory) Fix exception-unsafe in aggregation node [doris]

2023-12-15 Thread via GitHub
xy720 opened a new pull request, #28483: URL: https://github.com/apache/doris/pull/28483 ## Proposed changes Issue Number: close #xxx The alloc function may throw std::bad_alloc exception when the process memory exceed limit. be.INFO: ``` W1214 09:14:17.434849

Re: [PR] [docker][regregression]update routine load cases [doris]

2023-12-15 Thread via GitHub
XuJianxu commented on PR #28450: URL: https://github.com/apache/doris/pull/28450#issuecomment-1857552165 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Bug](memory) Fix exception-unsafe in aggregation node [doris]

2023-12-15 Thread via GitHub
xy720 commented on PR #28483: URL: https://github.com/apache/doris/pull/28483#issuecomment-1857553594 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [fix](operation_node)Replace structure to ensure same colRef can be save [doris]

2023-12-15 Thread via GitHub
zhiqiang- commented on PR #28440: URL: https://github.com/apache/doris/pull/28440#issuecomment-1857556365 @TomaYoko hello, thanks for your contribution, you can see my comment before buildall. `sh run-regression-test --run -s minus_except -getOut` will make help -- This

Re: [PR] [regression](memtable) add case for memtable flush error status handle [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28285: URL: https://github.com/apache/doris/pull/28285#issuecomment-1857558409 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.61 seconds stream load tsv: 604 seconds loaded 74807831229 Bytes,

Re: [PR] [Bug](memory) Fix exception-unsafe in aggregation node [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28483: URL: https://github.com/apache/doris/pull/28483#issuecomment-1857560157 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [Feature](Variant) Implement variant new sub column access method [doris]

2023-12-15 Thread via GitHub
eldenmoon opened a new pull request, #28484: URL: https://github.com/apache/doris/pull/28484 The query SELECT v["a"]["b"] from simple_var WHERE cast(v["a"]["b"] as int) = 1 encompasses three primary testing scenarios: ``` 1. A basic test involving the variant data type. 2. A sce

Re: [PR] [Feature](Variant) Implement variant new sub column access method [doris]

2023-12-15 Thread via GitHub
eldenmoon commented on PR #28484: URL: https://github.com/apache/doris/pull/28484#issuecomment-1857560671 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](operation_node)Replace structure to ensure same colRef can be save [doris]

2023-12-15 Thread via GitHub
zhiqiang- commented on code in PR #28440: URL: https://github.com/apache/doris/pull/28440#discussion_r1427750874 ## regression-test/data/minus_except_test/minus_except.out: ## @@ -0,0 +1,3 @@ +-- This file is automatically generated. You should know what you did if you want

[PR] [branch-1.2](memory) Fix AggFunc memory leak due to incorrect destroy [doris]

2023-12-15 Thread via GitHub
xy720 opened a new pull request, #28485: URL: https://github.com/apache/doris/pull/28485 ## Proposed changes cherry-pick #19126 into branch-1.2 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org

Re: [PR] [improvement](hint) query fail print tablet detail info [doris]

2023-12-15 Thread via GitHub
yujun777 commented on PR #28476: URL: https://github.com/apache/doris/pull/28476#issuecomment-1857563235 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Test](Job)Add test case [doris]

2023-12-15 Thread via GitHub
CalvinKirs commented on PR #28481: URL: https://github.com/apache/doris/pull/28481#issuecomment-1857561097 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [fix](operation_node)Replace structure to ensure same colRef can be save [doris]

2023-12-15 Thread via GitHub
zhiqiang- commented on code in PR #28440: URL: https://github.com/apache/doris/pull/28440#discussion_r1427750874 ## regression-test/data/minus_except_test/minus_except.out: ## @@ -0,0 +1,3 @@ +-- This file is automatically generated. You should know what you did if you want

Re: [PR] [feature](mtmv)mtmv support partition [doris]

2023-12-15 Thread via GitHub
zddr commented on PR #28144: URL: https://github.com/apache/doris/pull/28144#issuecomment-1857566431 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [fix](iterator) Fix mem leak when initial iterator failed [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28480: URL: https://github.com/apache/doris/pull/28480#issuecomment-1857566859 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](iterator) Fix mem leak when initial iterator failed [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28480: URL: https://github.com/apache/doris/pull/28480#issuecomment-1857566910 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[PR] [feature](Nereids) elimite join by foereign key [doris]

2023-12-15 Thread via GitHub
XieJiann opened a new pull request, #28486: URL: https://github.com/apache/doris/pull/28486 ## Proposed changes eliminate join by foreign key ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d.

Re: [PR] [fix](iterator) Fix mem leak when initial iterator failed [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28480: URL: https://github.com/apache/doris/pull/28480#issuecomment-1857568153 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.06 seconds stream load tsv: 587 seconds loaded 74807831229 Bytes,

[PR] [Chore](Workflow)Fix auto-reply not work [doris]

2023-12-15 Thread via GitHub
CalvinKirs opened a new pull request, #28487: URL: https://github.com/apache/doris/pull/28487 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mail

Re: [PR] [Enhancement](Wal)Support dynamic wal space limit [doris]

2023-12-15 Thread via GitHub
Yukang-Lian commented on PR #27726: URL: https://github.com/apache/doris/pull/27726#issuecomment-1857569619 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [refine](pipelineX)Make the 'set ready' logic of SenderQueue in pipelineX the same as that in the pipeline. [doris]

2023-12-15 Thread via GitHub
Mryange opened a new pull request, #28488: URL: https://github.com/apache/doris/pull/28488 ## Proposed changes core in pipelineX ``` vdata_stream_recvr.h:272] Check failed: _is_cancelled || !_block_queue.empty() || _num_remaining_senders == 0 _is_cancelled: 0, _block_queue_emp

Re: [PR] [fix](session variables) Make default value of max_execution_time same to query_timeout [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28474: URL: https://github.com/apache/doris/pull/28474#issuecomment-1857570639 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](session variables) Make default value of max_execution_time same to query_timeout [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28474: URL: https://github.com/apache/doris/pull/28474#issuecomment-1857570709 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [I] [Bug] FE 频繁打满64G内存导致宕机,集群上只有Broker Load在定时执行,过一段时间内存就满了 [doris]

2023-12-15 Thread via GitHub
ziyanTOP commented on issue #27594: URL: https://github.com/apache/doris/issues/27594#issuecomment-1857572219 一样的问题,minor gc的频率跟不上老年代增长的速度,最后三个fe节点全部查询排队超时卡死宕机,建议用prometheus+grafana监控fe的JVM,看看到底问题出在哪,顺便改下你的参数,年轻代等于老年代的1/3,并且不要用-XX:NewRatio=3这种,而是固定设置成-Xmn16G,打开CMS的并行重标记,不然minor gc那点时间这么多内存

Re: [PR] [fix](operation_node)Replace structure to ensure same colRef can be save [doris]

2023-12-15 Thread via GitHub
TomaYoko commented on code in PR #28440: URL: https://github.com/apache/doris/pull/28440#discussion_r1427768936 ## regression-test/data/minus_except_test/minus_except.out: ## @@ -0,0 +1,3 @@ +-- This file is automatically generated. You should know what you did if you want to e

Re: [PR] [Feature](Variant) Implement variant new sub column access method [doris]

2023-12-15 Thread via GitHub
eldenmoon commented on PR #28484: URL: https://github.com/apache/doris/pull/28484#issuecomment-1857574785 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Chore](Workflow)Fix auto-reply not work [doris]

2023-12-15 Thread via GitHub
CalvinKirs closed pull request #28487: [Chore](Workflow)Fix auto-reply not work URL: https://github.com/apache/doris/pull/28487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [improvement](decimalv2) support check overflow for decimalv2 arithmetics [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28456: URL: https://github.com/apache/doris/pull/28456#issuecomment-1857579154 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [refine](pipelineX)Make the 'set ready' logic of SenderQueue in pipelineX the same as that in the pipeline. [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on code in PR #28488: URL: https://github.com/apache/doris/pull/28488#discussion_r1427773381 ## be/src/vec/runtime/vdata_stream_recvr.cpp: ## @@ -122,6 +122,16 @@ Status VDataStreamRecvr::SenderQueue::_inner_get_batch_without_lock(Block* block

Re: [PR] [improvement](decimalv2) support check overflow for decimalv2 arithmetics [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28456: URL: https://github.com/apache/doris/pull/28456#issuecomment-1857579216 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](operation_node)Replace structure to ensure same colRef can be save [doris]

2023-12-15 Thread via GitHub
TomaYoko commented on code in PR #28440: URL: https://github.com/apache/doris/pull/28440#discussion_r142353 ## regression-test/suites/minus_except_test/minus_except.groovy: ## @@ -24,7 +24,6 @@ suite("minus_except") { sql "CREATE TABLE ${tableNameDate}(c2 date) DUPLICAT

[PR] [improvement](decimalv2) support check overflow for decimalv2 arithmetics (#28456) [doris]

2023-12-15 Thread via GitHub
jacktengg opened a new pull request, #28489: URL: https://github.com/apache/doris/pull/28489 ## Proposed changes Pick from #28456 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@d

Re: [PR] [improvement](decimalv2) support check overflow for decimalv2 arithmetics (#28456) [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28489: URL: https://github.com/apache/doris/pull/28489#issuecomment-1857595574 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [improvement](decimalv2) support check overflow for decimalv2 arithmetics [doris]

2023-12-15 Thread via GitHub
jacktengg commented on PR #28456: URL: https://github.com/apache/doris/pull/28456#issuecomment-1857596171 run pipelinex_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [refact](fe) Refact `SchemaChangeHandler.createJob` [doris]

2023-12-15 Thread via GitHub
SWJTU-ZhangLei commented on PR #28366: URL: https://github.com/apache/doris/pull/28366#issuecomment-1857596520 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [feature](coverage): refresh the coverage file before exiting the program [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28354: URL: https://github.com/apache/doris/pull/28354#issuecomment-1857597226 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Bug](memory) Fix exception-unsafe in aggregation node [doris]

2023-12-15 Thread via GitHub
github-actions[bot] commented on PR #28483: URL: https://github.com/apache/doris/pull/28483#issuecomment-1857598774 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [chore] Add bvar for meta operations of BE [doris]

2023-12-15 Thread via GitHub
doris-robot commented on PR #28374: URL: https://github.com/apache/doris/pull/28374#issuecomment-1857600425 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.62 seconds stream load tsv: 592 seconds loaded 74807831229 Bytes,

  1   2   3   4   5   6   >