github-actions[bot] commented on code in PR #28488: URL: https://github.com/apache/doris/pull/28488#discussion_r1427773381
########## be/src/vec/runtime/vdata_stream_recvr.cpp: ########## @@ -122,6 +122,16 @@ Status VDataStreamRecvr::SenderQueue::_inner_get_batch_without_lock(Block* block return Status::OK(); } +void VDataStreamRecvr::SenderQueue::try_set_dep_ready_without_lock() { Review Comment: warning: method 'try_set_dep_ready_without_lock' can be made static [readability-convert-member-functions-to-static] be/src/vec/runtime/vdata_stream_recvr.h:242: ```diff - void try_set_dep_ready_without_lock(); + static void try_set_dep_ready_without_lock(); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org