[GitHub] [doris] HappenLee commented on a diff in pull request #23236: [Feature-WIP](partitions) Support auto partition

2023-08-28 Thread via GitHub
HappenLee commented on code in PR #23236: URL: https://github.com/apache/doris/pull/23236#discussion_r1308142273 ## be/src/vec/runtime/vdatetime_value.cpp: ## @@ -50,6 +50,29 @@ static const char* s_ab_month_name[] = {"","Jan", "Feb", "Mar", "Apr", "May" static const cha

[GitHub] [doris] hust-hhb commented on pull request #23448: [improvement](compaction) add an option on delete stale rowset by judging _stale_rs_metas size when doing compaction

2023-08-28 Thread via GitHub
hust-hhb commented on PR #23448: URL: https://github.com/apache/doris/pull/23448#issuecomment-1696695816 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] HappenLee commented on a diff in pull request #23236: [Feature-WIP](partitions) Support auto partition

2023-08-28 Thread via GitHub
HappenLee commented on code in PR #23236: URL: https://github.com/apache/doris/pull/23236#discussion_r1308142396 ## be/src/vec/runtime/vdatetime_value.h: ## @@ -69,6 +71,8 @@ enum TimeUnit { YEAR_MONTH }; +TimeUnit parse_upper_to_timeunit(const std::string& str); Review

[GitHub] [doris] github-actions[bot] commented on pull request #23448: [improvement](compaction) add an option on delete stale rowset by judging _stale_rs_metas size when doing compaction

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23448: URL: https://github.com/apache/doris/pull/23448#issuecomment-1696696908 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #23362: [Enhancement](Load) stream Load using SQL

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23362: URL: https://github.com/apache/doris/pull/23362#issuecomment-1696697633 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Mryange commented on pull request #23564: [fix](filter) fix error id in bloomfilter

2023-08-28 Thread via GitHub
Mryange commented on PR #23564: URL: https://github.com/apache/doris/pull/23564#issuecomment-1696697674 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] bobhan1 opened a new pull request, #23599: [fix](regression) Fix test no_await

2023-08-28 Thread via GitHub
bobhan1 opened a new pull request, #23599: URL: https://github.com/apache/doris/pull/23599 ## Proposed changes ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining

[GitHub] [doris] bobhan1 commented on pull request #23599: [fix](regression) Fix test no_await

2023-08-28 Thread via GitHub
bobhan1 commented on PR #23599: URL: https://github.com/apache/doris/pull/23599#issuecomment-1696698104 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] github-actions[bot] commented on pull request #23489: [FIX](array)update array olapconvertor and support array nested other complex type

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23489: URL: https://github.com/apache/doris/pull/23489#issuecomment-1696698580 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] shuke987 commented on pull request #23565: [FIX](serde) fix handle serde error

2023-08-28 Thread via GitHub
shuke987 commented on PR #23565: URL: https://github.com/apache/doris/pull/23565#issuecomment-1696699206 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on pull request #23564: [fix](filter) fix error id in bloomfilter

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23564: URL: https://github.com/apache/doris/pull/23564#issuecomment-1696700607 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] HappenLee commented on a diff in pull request #23236: [Feature-WIP](partitions) Support auto partition

2023-08-28 Thread via GitHub
HappenLee commented on code in PR #23236: URL: https://github.com/apache/doris/pull/23236#discussion_r1308145522 ## be/src/exec/tablet_info.cpp: ## @@ -457,4 +475,54 @@ Status VOlapTablePartitionParam::_create_partition_key(const TExprNode& t_expr, return Status::OK(); }

[GitHub] [doris] github-actions[bot] commented on pull request #23448: [improvement](compaction) add an option on delete stale rowset by judging _stale_rs_metas size when doing compaction

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23448: URL: https://github.com/apache/doris/pull/23448#issuecomment-1696700691 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] BiteTheDDDDt commented on pull request #23580: [Bug](materialized-view) fix mv not match because cast and alias name

2023-08-28 Thread via GitHub
BiteThet commented on PR #23580: URL: https://github.com/apache/doris/pull/23580#issuecomment-1696701396 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] github-actions[bot] commented on pull request #23489: [FIX](array)update array olapconvertor and support array nested other complex type

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23489: URL: https://github.com/apache/doris/pull/23489#issuecomment-1696701792 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #23489: [FIX](array)update array olapconvertor and support array nested other complex type

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23489: URL: https://github.com/apache/doris/pull/23489#issuecomment-1696701821 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] ixzc commented on issue #23592: Query the time difference function from the view, and the value becomes negative

2023-08-28 Thread via GitHub
ixzc commented on issue #23592: URL: https://github.com/apache/doris/issues/23592#issuecomment-1696702717 Thanks, there is indeed this problem, I have given feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] Mryange commented on pull request #23564: [fix](filter) fix error id in bloomfilter

2023-08-28 Thread via GitHub
Mryange commented on PR #23564: URL: https://github.com/apache/doris/pull/23564#issuecomment-1696702912 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] Mryange commented on pull request #23564: [fix](filter) fix error id in bloomfilter

2023-08-28 Thread via GitHub
Mryange commented on PR #23564: URL: https://github.com/apache/doris/pull/23564#issuecomment-1696704255 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] hello-stephen commented on pull request #23594: [Enhancement](Column) Support int default value to int type column

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23594: URL: https://github.com/apache/doris/pull/23594#issuecomment-1696706282 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.86 seconds stream load tsv: 536 seconds loaded 74807831229 Bytes

[GitHub] [doris] hello-stephen commented on pull request #23434: [minor](nereids) SUPPORT COLLATE GRAMMAR

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23434: URL: https://github.com/apache/doris/pull/23434#issuecomment-1696706403 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.31 seconds stream load tsv: 538 seconds loaded 74807831229 Bytes

[GitHub] [doris] hello-stephen commented on pull request #23411: [fix](json)Fix the bug that read json file Out of bounds access

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23411: URL: https://github.com/apache/doris/pull/23411#issuecomment-1696706569 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 51.02 seconds stream load tsv: 544 seconds loaded 74807831229 Bytes

[GitHub] [doris] DongLiang-0 commented on pull request #23426: [fix](auth)fix after setting the user password to expire, changing the password again will not take effect

2023-08-28 Thread via GitHub
DongLiang-0 commented on PR #23426: URL: https://github.com/apache/doris/pull/23426#issuecomment-1696706608 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] github-actions[bot] commented on pull request #23564: [fix](filter) fix error id in bloomfilter

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23564: URL: https://github.com/apache/doris/pull/23564#issuecomment-1696708086 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] amorynan commented on pull request #23489: [FIX](array)update array olapconvertor and support array nested other complex type

2023-08-28 Thread via GitHub
amorynan commented on PR #23489: URL: https://github.com/apache/doris/pull/23489#issuecomment-1696708804 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] CodeCooker17 commented on pull request #20622: [fix](fe) Support set hive version when create hive external table

2023-08-28 Thread via GitHub
CodeCooker17 commented on PR #20622: URL: https://github.com/apache/doris/pull/20622#issuecomment-1696709605 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] dutyu commented on pull request #23555: [Fix](cache) fix query cache returns wrong result after deleting partitions.

2023-08-28 Thread via GitHub
dutyu commented on PR #23555: URL: https://github.com/apache/doris/pull/23555#issuecomment-1696711545 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [doris] hello-stephen commented on pull request #23597: [feature](Nereids) support struct type

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23597: URL: https://github.com/apache/doris/pull/23597#issuecomment-1696712699 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.27 seconds stream load tsv: 537 seconds loaded 74807831229 Bytes

[GitHub] [doris] github-actions[bot] commented on pull request #23489: [FIX](array)update array olapconvertor and support array nested other complex type

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23489: URL: https://github.com/apache/doris/pull/23489#issuecomment-1696712960 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] CodeCooker17 commented on pull request #21837: [Improvement][sparkLoad] use system env configs when user does not set env configs.

2023-08-28 Thread via GitHub
CodeCooker17 commented on PR #21837: URL: https://github.com/apache/doris/pull/21837#issuecomment-1696713422 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] github-actions[bot] commented on pull request #23555: [Fix](cache) fix query cache returns wrong result after deleting partitions.

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23555: URL: https://github.com/apache/doris/pull/23555#issuecomment-1696714133 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[doris] branch master updated: [test](fix case) fix sql user conflict in test case (#23583)

2023-08-28 Thread gabriellee
This is an automated email from the ASF dual-hosted git repository. gabriellee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 93db9b455a [test](fix case) fix sql user conf

[GitHub] [doris] Gabriel39 merged pull request #23583: [test](fix case) fix sql user conflict in test case.

2023-08-28 Thread via GitHub
Gabriel39 merged PR #23583: URL: https://github.com/apache/doris/pull/23583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[GitHub] [doris] zhiqiang-hhhh commented on pull request #23582: [Improvement](pipeline) Cancel outdated query if original fe restarts

2023-08-28 Thread via GitHub
zhiqiang- commented on PR #23582: URL: https://github.com/apache/doris/pull/23582#issuecomment-1696716827 run CheckStyle -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] Kikyou1997 closed pull request #23434: [minor](nereids) SUPPORT COLLATE GRAMMAR

2023-08-28 Thread via GitHub
Kikyou1997 closed pull request #23434: [minor](nereids) SUPPORT COLLATE GRAMMAR URL: https://github.com/apache/doris/pull/23434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [doris] hello-stephen commented on pull request #23586: [fix](Outfile) fix core dump when export data to orc file format using `outfile`

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23586: URL: https://github.com/apache/doris/pull/23586#issuecomment-1696718049 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.52 seconds stream load tsv: 535 seconds loaded 74807831229 Bytes

[GitHub] [doris] yiguolei commented on a diff in pull request #23581: [Fix](column predicate) seperate CHAR primitive type for column predicate

2023-08-28 Thread via GitHub
yiguolei commented on code in PR #23581: URL: https://github.com/apache/doris/pull/23581#discussion_r1308157764 ## be/src/vec/olap/block_reader.cpp: ## @@ -503,7 +503,7 @@ bool BlockReader::_get_next_row_same() { } } -ColumnPredicate* BlockReader::_parse_to_predicate(con

[GitHub] [doris] Kikyou1997 commented on pull request #23600: [minor](optimizer): SUPPORT COLLATE GRAMMAR

2023-08-28 Thread via GitHub
Kikyou1997 commented on PR #23600: URL: https://github.com/apache/doris/pull/23600#issuecomment-1696718613 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] airborne12 commented on a diff in pull request #23581: [Fix](column predicate) seperate CHAR primitive type for column predicate

2023-08-28 Thread via GitHub
airborne12 commented on code in PR #23581: URL: https://github.com/apache/doris/pull/23581#discussion_r1308158087 ## be/src/vec/olap/block_reader.cpp: ## @@ -503,7 +503,7 @@ bool BlockReader::_get_next_row_same() { } } -ColumnPredicate* BlockReader::_parse_to_predicate(c

[GitHub] [doris] Kikyou1997 opened a new pull request, #23600: [minor](optimizer): SUPPORT COLLATE GRAMMAR

2023-08-28 Thread via GitHub
Kikyou1997 opened a new pull request, #23600: URL: https://github.com/apache/doris/pull/23600 ## Proposed changes Support such sql grammar Just for compatibility ```sql select table_name from information_schema.tables where table_schema collate utf8_general_ci =

[GitHub] [doris] hello-stephen commented on pull request #23499: [fix](Nereids) make agg output unchanged after normalized

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23499: URL: https://github.com/apache/doris/pull/23499#issuecomment-1696719580 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.85 seconds stream load tsv: 535 seconds loaded 74807831229 Bytes

[GitHub] [doris-flink-connector] JNSimba opened a new pull request, #188: [mysql] add mysql chunk column options

2023-08-28 Thread via GitHub
JNSimba opened a new pull request, #188: URL: https://github.com/apache/doris-flink-connector/pull/188 # Proposed changes add mysql column key column: --mysql-conf scan.incremental.snapshot.chunk.key-column = db.tbl1:col1,db.tbl2:col2 mysqlcdc version must be greater than 2.

[GitHub] [doris] zy-kkk commented on pull request #23364: [fix](odbc) fix odbc insert string data to sqlserve

2023-08-28 Thread via GitHub
zy-kkk commented on PR #23364: URL: https://github.com/apache/doris/pull/23364#issuecomment-1696719820 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] shuke987 commented on pull request #23590: [regression](fix) enable fixed unstable cases

2023-08-28 Thread via GitHub
shuke987 commented on PR #23590: URL: https://github.com/apache/doris/pull/23590#issuecomment-1696719929 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] morrySnow opened a new pull request, #23601: [fix](view) The parameter positions of timestamp diff function to sql are reversed

2023-08-28 Thread via GitHub
morrySnow opened a new pull request, #23601: URL: https://github.com/apache/doris/pull/23601 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailt

[GitHub] [doris] Gabriel39 opened a new pull request, #23602: [bug](decimal) Use max value as result if overflow

2023-08-28 Thread via GitHub
Gabriel39 opened a new pull request, #23602: URL: https://github.com/apache/doris/pull/23602 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailt

[GitHub] [doris] Gabriel39 commented on pull request #23602: [bug](decimal) Use max value as result if overflow

2023-08-28 Thread via GitHub
Gabriel39 commented on PR #23602: URL: https://github.com/apache/doris/pull/23602#issuecomment-1696720835 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] bobhan1 commented on pull request #23443: [Enhancement](merge on write) Add primary keys consistency check for partial update

2023-08-28 Thread via GitHub
bobhan1 commented on PR #23443: URL: https://github.com/apache/doris/pull/23443#issuecomment-1696720841 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] shuke987 commented on pull request #23590: [regression](fix) enable fixed unstable cases

2023-08-28 Thread via GitHub
shuke987 commented on PR #23590: URL: https://github.com/apache/doris/pull/23590#issuecomment-1696721646 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] zhangstar333 opened a new pull request, #23603: [bug](function) fix explode_number function return wrong rows

2023-08-28 Thread via GitHub
zhangstar333 opened a new pull request, #23603: URL: https://github.com/apache/doris/pull/23603 ## Proposed changes before the explode_number is random with const value. because the _cur_size is reset, so it's can't insert values to column. Issue Number: close #xxx

[GitHub] [doris] github-actions[bot] commented on pull request #19312: [feature](nereids)prune runtime filter by ndv

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #19312: URL: https://github.com/apache/doris/pull/19312#issuecomment-1696722130 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #23602: [bug](decimal) Use max value as result if overflow

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23602: URL: https://github.com/apache/doris/pull/23602#issuecomment-1696722543 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] zhangstar333 commented on pull request #23603: [bug](function) fix explode_number function return wrong rows

2023-08-28 Thread via GitHub
zhangstar333 commented on PR #23603: URL: https://github.com/apache/doris/pull/23603#issuecomment-1696722603 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] jacktengg opened a new pull request, #23604: [fix](regression) add sync for loading data to avoid case failure in multi-fe test env

2023-08-28 Thread via GitHub
jacktengg opened a new pull request, #23604: URL: https://github.com/apache/doris/pull/23604 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](m

[GitHub] [doris] jacktengg commented on pull request #23604: [fix](regression) add sync for loading data to avoid case failure in multi-fe test env

2023-08-28 Thread via GitHub
jacktengg commented on PR #23604: URL: https://github.com/apache/doris/pull/23604#issuecomment-1696722709 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] hello-stephen commented on pull request #23426: [fix](auth)fix after setting the user password to expire, changing the password again will not take effect

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23426: URL: https://github.com/apache/doris/pull/23426#issuecomment-1696723064 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.15 seconds stream load tsv: 536 seconds loaded 74807831229 Bytes

[GitHub] [doris] hello-stephen commented on pull request #23564: [fix](filter) fix error id in bloomfilter

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23564: URL: https://github.com/apache/doris/pull/23564#issuecomment-1696723085 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 50.55 seconds stream load tsv: 541 seconds loaded 74807831229 Bytes

[GitHub] [doris] github-actions[bot] commented on pull request #23590: [regression](fix) enable fixed unstable cases

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23590: URL: https://github.com/apache/doris/pull/23590#issuecomment-1696723339 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #23364: [fix](odbc) fix odbc insert string data to sqlserve

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23364: URL: https://github.com/apache/doris/pull/23364#issuecomment-1696723822 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] CodeCooker17 commented on pull request #20622: [fix](fe) Support set hive version when create hive external table

2023-08-28 Thread via GitHub
CodeCooker17 commented on PR #20622: URL: https://github.com/apache/doris/pull/20622#issuecomment-1696724291 create EXTERNAL TABLE `auto_user_gender_tag_v2_external`( `case_id` bigint, `tag_id` string, `tag_value` string ) ENGINE=hive properties ( "database" = "d

[GitHub] [doris] github-actions[bot] commented on pull request #23602: [bug](decimal) Use max value as result if overflow

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23602: URL: https://github.com/apache/doris/pull/23602#issuecomment-1696724589 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #23443: [Enhancement](merge on write) Add primary keys consistency check for partial update

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23443: URL: https://github.com/apache/doris/pull/23443#issuecomment-1696724772 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #23590: [regression](fix) enable fixed unstable cases

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23590: URL: https://github.com/apache/doris/pull/23590#issuecomment-1696725306 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #23564: [fix](filter) fix error id in bloomfilter

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23564: URL: https://github.com/apache/doris/pull/23564#issuecomment-1696725572 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.48 seconds stream load tsv: 537 seconds loaded 74807831229 Bytes

[GitHub] [doris] github-actions[bot] commented on pull request #23603: [bug](function) fix explode_number function return wrong rows

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23603: URL: https://github.com/apache/doris/pull/23603#issuecomment-1696726377 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #23603: [bug](function) fix explode_number function return wrong rows

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23603: URL: https://github.com/apache/doris/pull/23603#issuecomment-1696726490 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris-flink-connector] JNSimba commented on a diff in pull request #187: [Improve]Added direct access to BE through the intranet

2023-08-28 Thread via GitHub
JNSimba commented on code in PR #187: URL: https://github.com/apache/doris-flink-connector/pull/187#discussion_r1308165258 ## flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisConnectionOptions.java: ## @@ -27,19 +27,30 @@ public class DorisConnectionOptions i

[GitHub] [doris] yiguolei commented on a diff in pull request #23582: [Improvement](pipeline) Cancel outdated query if original fe restarts

2023-08-28 Thread via GitHub
yiguolei commented on code in PR #23582: URL: https://github.com/apache/doris/pull/23582#discussion_r1308165301 ## .gitignore: ## @@ -37,6 +37,7 @@ package-lock.json !.idea/icon.svg **/.vscode/ **/.fleet/ +compile_commands.json Review Comment: why add this? -- This is

[GitHub] [doris] hello-stephen commented on pull request #20622: [fix](fe) Support set hive version when create hive external table

2023-08-28 Thread via GitHub
hello-stephen commented on PR #20622: URL: https://github.com/apache/doris/pull/20622#issuecomment-1696728014 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.96 seconds stream load tsv: 538 seconds loaded 74807831229 Bytes

[GitHub] [doris-flink-connector] JNSimba commented on pull request #187: [Improve]Added direct access to BE through the intranet

2023-08-28 Thread via GitHub
JNSimba commented on PR #187: URL: https://github.com/apache/doris-flink-connector/pull/187#issuecomment-1696728166 By the way, add the options of flink table, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [doris-flink-connector] JNSimba commented on a diff in pull request #187: [Improve]Added direct access to BE through the intranet

2023-08-28 Thread via GitHub
JNSimba commented on code in PR #187: URL: https://github.com/apache/doris-flink-connector/pull/187#discussion_r1308166380 ## flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisOptions.java: ## @@ -107,11 +130,13 @@ public Builder setJdbcUrl(String jdbcUrl) {

[GitHub] [doris] github-actions[bot] commented on pull request #20622: [fix](fe) Support set hive version when create hive external table

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #20622: URL: https://github.com/apache/doris/pull/20622#issuecomment-1696729461 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #20622: [fix](fe) Support set hive version when create hive external table

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #20622: URL: https://github.com/apache/doris/pull/20622#issuecomment-1696729482 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] hello-stephen commented on pull request #23581: [Fix](column predicate) seperate CHAR primitive type for column predicate

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23581: URL: https://github.com/apache/doris/pull/23581#issuecomment-1696729568 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.77 seconds stream load tsv: 538 seconds loaded 74807831229 Bytes

[GitHub] [doris] yiguolei commented on a diff in pull request #23582: [Improvement](pipeline) Cancel outdated query if original fe restarts

2023-08-28 Thread via GitHub
yiguolei commented on code in PR #23582: URL: https://github.com/apache/doris/pull/23582#discussion_r1308166974 ## be/src/agent/heartbeat_server.cpp: ## @@ -219,6 +222,69 @@ Status HeartbeatServer::_heartbeat(const TMasterInfo& master_info) { _master_info->__set_backen

[GitHub] [doris] hello-stephen commented on pull request #23489: [FIX](array)update array olapconvertor and support array nested other complex type

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23489: URL: https://github.com/apache/doris/pull/23489#issuecomment-1696729850 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.97 seconds stream load tsv: 549 seconds loaded 74807831229 Bytes

[GitHub] [doris] hello-stephen commented on pull request #23489: [FIX](array)update array olapconvertor and support array nested other complex type

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23489: URL: https://github.com/apache/doris/pull/23489#issuecomment-1696730494 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 48.82 seconds stream load tsv: 548 seconds loaded 74807831229 Bytes

[GitHub] [doris] hello-stephen commented on pull request #23555: [Fix](cache) fix query cache returns wrong result after deleting partitions.

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23555: URL: https://github.com/apache/doris/pull/23555#issuecomment-1696731279 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.24 seconds stream load tsv: 533 seconds loaded 74807831229 Bytes

[GitHub] [doris] hello-stephen commented on pull request #21837: [Improvement][sparkLoad] use system env configs when user does not set env configs.

2023-08-28 Thread via GitHub
hello-stephen commented on PR #21837: URL: https://github.com/apache/doris/pull/21837#issuecomment-1696731854 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.53 seconds stream load tsv: 535 seconds loaded 74807831229 Bytes

[GitHub] [doris] hello-stephen commented on pull request #23600: [minor](optimizer): SUPPORT COLLATE GRAMMAR

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23600: URL: https://github.com/apache/doris/pull/23600#issuecomment-1696734905 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.67 seconds stream load tsv: 537 seconds loaded 74807831229 Bytes

[GitHub] [doris] hello-stephen commented on pull request #23364: [fix](odbc) fix odbc insert string data to sqlserve

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23364: URL: https://github.com/apache/doris/pull/23364#issuecomment-1696735940 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.6 seconds stream load tsv: 538 seconds loaded 74807831229 Bytes,

[GitHub] [doris] hello-stephen commented on pull request #23565: [FIX](serde) fix handle serde error

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23565: URL: https://github.com/apache/doris/pull/23565#issuecomment-1696739755 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.38 seconds stream load tsv: 543 seconds loaded 74807831229 Bytes

[GitHub] [doris] zgxme commented on pull request #22883: [Enhancement] submit Baidu test cases

2023-08-28 Thread via GitHub
zgxme commented on PR #22883: URL: https://github.com/apache/doris/pull/22883#issuecomment-1696739854 Hi @zhangy5 , thanks for your contribution ! With the Baidu test cases, we found a few more serious issues: 1. be out of core. 2. test result calibration issues, we are on goin

[GitHub] [doris] zgxme commented on a diff in pull request #22883: [Enhancement] submit Baidu test cases

2023-08-28 Thread via GitHub
zgxme commented on code in PR #22883: URL: https://github.com/apache/doris/pull/22883#discussion_r1308176481 ## pytest/run_case.sh: ## @@ -0,0 +1,325 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [doris] hello-stephen commented on pull request #23448: [improvement](compaction) add an option on delete stale rowset by judging _stale_rs_metas size when doing compaction

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23448: URL: https://github.com/apache/doris/pull/23448#issuecomment-1696742882 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.44 seconds stream load tsv: 534 seconds loaded 74807831229 Bytes

[GitHub] [doris] zgxme commented on a diff in pull request #22883: [Enhancement] submit Baidu test cases

2023-08-28 Thread via GitHub
zgxme commented on code in PR #22883: URL: https://github.com/apache/doris/pull/22883#discussion_r1308176481 ## pytest/run_case.sh: ## @@ -0,0 +1,325 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [doris] zgxme commented on a diff in pull request #22883: [Enhancement] submit Baidu test cases

2023-08-28 Thread via GitHub
zgxme commented on code in PR #22883: URL: https://github.com/apache/doris/pull/22883#discussion_r1308178776 ## pytest/run_case.sh: ## @@ -0,0 +1,325 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [doris] kaijchen commented on pull request #23135: [feature](move-memtable)[0/7] support memtable on sink node

2023-08-28 Thread via GitHub
kaijchen commented on PR #23135: URL: https://github.com/apache/doris/pull/23135#issuecomment-1696748171 closed as all subtasks done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [doris] kaijchen closed pull request #23135: [feature](move-memtable)[0/7] support memtable on sink node

2023-08-28 Thread via GitHub
kaijchen closed pull request #23135: [feature](move-memtable)[0/7] support memtable on sink node URL: https://github.com/apache/doris/pull/23135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [doris] hello-stephen commented on pull request #23603: [bug](function) fix explode_number function return wrong rows

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23603: URL: https://github.com/apache/doris/pull/23603#issuecomment-1696748906 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.02 seconds stream load tsv: 536 seconds loaded 74807831229 Bytes

[GitHub] [doris] kaijchen opened a new pull request, #23605: [fix](move-memtable) wait StreamClose from remote

2023-08-28 Thread via GitHub
kaijchen opened a new pull request, #23605: URL: https://github.com/apache/doris/pull/23605 ## Proposed changes Previously, SinkV2 will count reports from remote as a signal for close_wait. It is error-prone because it's hard to predict how many reports will be generated. Th

[GitHub] [doris] kaijchen commented on pull request #23605: [fix](move-memtable) wait StreamClose from remote

2023-08-28 Thread via GitHub
kaijchen commented on PR #23605: URL: https://github.com/apache/doris/pull/23605#issuecomment-1696751639 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] github-actions[bot] commented on pull request #23605: [fix](move-memtable) wait StreamClose from remote

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23605: URL: https://github.com/apache/doris/pull/23605#issuecomment-1696756209 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #23602: [bug](decimal) Use max value as result if overflow

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23602: URL: https://github.com/apache/doris/pull/23602#issuecomment-1696758558 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.15 seconds stream load tsv: 536 seconds loaded 74807831229 Bytes

[GitHub] [doris] tarepanda1024 commented on pull request #20622: [fix](fe) Support set hive version when create hive external table

2023-08-28 Thread via GitHub
tarepanda1024 commented on PR #20622: URL: https://github.com/apache/doris/pull/20622#issuecomment-1696760723 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [doris] shawn0762 opened a new issue, #23606: [Bug]

2023-08-28 Thread via GitHub
shawn0762 opened a new issue, #23606: URL: https://github.com/apache/doris/issues/23606 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version doris-1.2.6-rc03-Unkno

[GitHub] [doris] hello-stephen commented on pull request #23443: [Enhancement](merge on write) Add primary keys consistency check for partial update

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23443: URL: https://github.com/apache/doris/pull/23443#issuecomment-1696766085 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.47 seconds stream load tsv: 548 seconds loaded 74807831229 Bytes

[GitHub] [doris] github-actions[bot] commented on pull request #23362: [Enhancement](Load) stream Load using SQL

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #23362: URL: https://github.com/apache/doris/pull/23362#issuecomment-1696771386 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #23605: [fix](move-memtable) wait StreamClose from remote

2023-08-28 Thread via GitHub
hello-stephen commented on PR #23605: URL: https://github.com/apache/doris/pull/23605#issuecomment-1696771458 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.03 seconds stream load tsv: 543 seconds loaded 74807831229 Bytes

[GitHub] [doris] BiteTheDDDDt opened a new pull request, #23607: [Bug](materialized-view) fix change base schema when create mv

2023-08-28 Thread via GitHub
BiteThet opened a new pull request, #23607: URL: https://github.com/apache/doris/pull/23607 ## Proposed changes fix change base schema when create mv ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](m

<    1   2   3   4   5   6   >