JNSimba commented on code in PR #187:
URL:
https://github.com/apache/doris-flink-connector/pull/187#discussion_r1308166380
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisOptions.java:
##########
@@ -107,11 +130,13 @@ public Builder setJdbcUrl(String jdbcUrl) {
}
public DorisOptions build() {
- checkNotNull(fenodes, "No fenodes supplied.");
Review Comment:
`fenodes` should be required, because fe-related APIs, such as /schema, will
be requested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
