[GitHub] [doris] hello-stephen commented on pull request #21511: [fix](status) Return the correct error code when clucene error occured

2023-07-05 Thread via GitHub
hello-stephen commented on PR #21511: URL: https://github.com/apache/doris/pull/21511#issuecomment-1621657127 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 48.11 seconds stream load tsv: 457 seconds loaded 74807831229 Bytes, about 156 MB/s

[GitHub] [doris] hello-stephen commented on pull request #21511: [fix](status) Return the correct error code when clucene error occured

2023-07-05 Thread via GitHub
hello-stephen commented on PR #21511: URL: https://github.com/apache/doris/pull/21511#issuecomment-1621657827 (From new mechine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 52.35 seconds stream load tsv: 507 seconds loaded 74807831229 Bytes

[GitHub] [doris] hello-stephen commented on pull request #21505: (fix)[compaction] Restarting the BE causes write amplification --- time series compaction

2023-07-05 Thread via GitHub
hello-stephen commented on PR #21505: URL: https://github.com/apache/doris/pull/21505#issuecomment-1621658781 (From new mechine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 57.34 seconds stream load tsv: 512 seconds loaded 74807831229 Bytes

[GitHub] [doris] HHoflittlefish777 opened a new pull request, #21541: [branch-1.2-lts](memtable) change memtable flush error code

2023-07-05 Thread via GitHub
HHoflittlefish777 opened a new pull request, #21541: URL: https://github.com/apache/doris/pull/21541 ## Proposed changes Currently, when the memtable flush fails, the error code is blocked and a status error code needs to be used. ## Further comments If this is a

[GitHub] [doris] HHoflittlefish777 closed pull request #21541: [branch-1.2-lts](memtable) change memtable flush error code

2023-07-05 Thread via GitHub
HHoflittlefish777 closed pull request #21541: [branch-1.2-lts](memtable) change memtable flush error code URL: https://github.com/apache/doris/pull/21541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [doris] HHoflittlefish777 opened a new pull request, #21542: [branch-1.2-lts](memtable) change memtable flush error code

2023-07-05 Thread via GitHub
HHoflittlefish777 opened a new pull request, #21542: URL: https://github.com/apache/doris/pull/21542 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.or

[GitHub] [doris] weizhengte opened a new pull request, #21543: [enchancement](stats) Inject partition statistics

2023-07-05 Thread via GitHub
weizhengte opened a new pull request, #21543: URL: https://github.com/apache/doris/pull/21543 ## Proposed changes The cost estimation can be more accurate if the statistics of partition are available. But we are running 1T such big data, can not really import. So now we want t

[GitHub] [doris] weizhengte commented on pull request #21543: [enchancement](stats) Inject partition statistics

2023-07-05 Thread via GitHub
weizhengte commented on PR #21543: URL: https://github.com/apache/doris/pull/21543#issuecomment-1621676562 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] w41ter commented on pull request #21508: [fix](rpc) shutdown removed backend client without wait

2023-07-05 Thread via GitHub
w41ter commented on PR #21508: URL: https://github.com/apache/doris/pull/21508#issuecomment-1621677283 > add description pls Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [doris] hello-stephen commented on pull request #21477: [Performance](Nereids): add withGroupExprLogicalPropChildren to reduce new Plan

2023-07-05 Thread via GitHub
hello-stephen commented on PR #21477: URL: https://github.com/apache/doris/pull/21477#issuecomment-1621687335 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.41 seconds stream load tsv: 454 seconds loaded 74807831229 Bytes, about 157 MB/s

[GitHub] [doris] hello-stephen commented on pull request #21471: [Enhancement](multi-catalog) Make meta cache batch loading concurrently.

2023-07-05 Thread via GitHub
hello-stephen commented on PR #21471: URL: https://github.com/apache/doris/pull/21471#issuecomment-1621699353 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 51.85 seconds stream load tsv: 460 seconds loaded 74807831229 Bytes, about 155 MB/s

[GitHub] [doris] song940094765 closed issue #21537: [Bug] terminate called after throwing an instance of 'orc::ParseError'.

2023-07-05 Thread via GitHub
song940094765 closed issue #21537: [Bug] terminate called after throwing an instance of 'orc::ParseError'. URL: https://github.com/apache/doris/issues/21537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [doris] song940094765 commented on issue #21537: [Bug] terminate called after throwing an instance of 'orc::ParseError'.

2023-07-05 Thread via GitHub
song940094765 commented on issue #21537: URL: https://github.com/apache/doris/issues/21537#issuecomment-1621721733 cant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] song940094765 commented on issue #21537: [Bug] terminate called after throwing an instance of 'orc::ParseError'.

2023-07-05 Thread via GitHub
song940094765 commented on issue #21537: URL: https://github.com/apache/doris/issues/21537#issuecomment-1621722406 1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] song940094765 commented on issue #21537: [Bug] terminate called after throwing an instance of 'orc::ParseError'.

2023-07-05 Thread via GitHub
song940094765 commented on issue #21537: URL: https://github.com/apache/doris/issues/21537#issuecomment-1621725199 2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] hello-stephen commented on pull request #21539: [Enhancement](Nereids)enable nereids DML by default.

2023-07-05 Thread via GitHub
hello-stephen commented on PR #21539: URL: https://github.com/apache/doris/pull/21539#issuecomment-1621727281 (From new mechine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 52.1 seconds stream load tsv: 512 seconds loaded 74807831229 Bytes,

[GitHub] [doris] song940094765 commented on issue #21537: [Bug] terminate called after throwing an instance of 'orc::ParseError'

2023-07-05 Thread via GitHub
song940094765 commented on issue #21537: URL: https://github.com/apache/doris/issues/21537#issuecomment-1621737994 please help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [doris] JackDrogon opened a new pull request, #21544: [Enhancement](binlog) Add create/drop table, add/drop paritition && alter job, modify columns binlog support

2023-07-05 Thread via GitHub
JackDrogon opened a new pull request, #21544: URL: https://github.com/apache/doris/pull/21544 ## Proposed changes Add create/drop table, add/drop paritition && alter job, modify columns binlog support -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [doris] github-actions[bot] commented on pull request #21542: [branch-1.2-lts](memtable) change memtable flush error code

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21542: URL: https://github.com/apache/doris/pull/21542#issuecomment-1621765871 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #21542: [branch-1.2-lts](memtable) change memtable flush error code

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21542: URL: https://github.com/apache/doris/pull/21542#issuecomment-1621765938 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #21544: [Enhancement](binlog) Add create/drop table, add/drop paritition && alter job, modify columns binlog support

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21544: URL: https://github.com/apache/doris/pull/21544#issuecomment-1621776799 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] dataroaring commented on pull request #21544: [Enhancement](binlog) Add create/drop table, add/drop paritition && alter job, modify columns binlog support

2023-07-05 Thread via GitHub
dataroaring commented on PR #21544: URL: https://github.com/apache/doris/pull/21544#issuecomment-1621789198 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] kaijchen commented on pull request #21476: [refactor](load) expand OlapTableValidator to VOlapTableBlockConvertor

2023-07-05 Thread via GitHub
kaijchen commented on PR #21476: URL: https://github.com/apache/doris/pull/21476#issuecomment-1621808074 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] LiBinfeng-01 commented on pull request #21171: [Fix](Nereids) Add cast comparison with slot reference when inferring predicate

2023-07-05 Thread via GitHub
LiBinfeng-01 commented on PR #21171: URL: https://github.com/apache/doris/pull/21171#issuecomment-1621810332 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] LiBinfeng-01 commented on pull request #20602: [opt](planner) add important time to profile in planner

2023-07-05 Thread via GitHub
LiBinfeng-01 commented on PR #20602: URL: https://github.com/apache/doris/pull/20602#issuecomment-1621810991 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] morningman merged pull request #21419: [Feature](multi-catalog) support query hive-view for nereids planner.

2023-07-05 Thread via GitHub
morningman merged PR #21419: URL: https://github.com/apache/doris/pull/21419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[doris] branch master updated: [Feature](multi-catalog) support query hive-view for nereids planner. (#21419)

2023-07-05 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new b6a5afa87d [Feature](multi-catalog) support q

[GitHub] [doris] github-actions[bot] commented on pull request #21476: [refactor](load) expand OlapTableValidator to VOlapTableBlockConvertor

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21476: URL: https://github.com/apache/doris/pull/21476#issuecomment-1621818708 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #21476: [refactor](load) expand OlapTableValidator to VOlapTableBlockConvertor

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21476: URL: https://github.com/apache/doris/pull/21476#issuecomment-1621819105 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] LiBinfeng-01 commented on pull request #20599: [Fix](Planner) Change return type in where, having and on clause

2023-07-05 Thread via GitHub
LiBinfeng-01 commented on PR #20599: URL: https://github.com/apache/doris/pull/20599#issuecomment-1621819787 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] xinyiZzz opened a new pull request, #21545: [fix](sink) fix OlapTableSink early close causes load failure

2023-07-05 Thread via GitHub
xinyiZzz opened a new pull request, #21545: URL: https://github.com/apache/doris/pull/21545 ## Proposed changes open_partition_finished must be before mark_close ``` Failed to commit txn [121422]. Tablet [1931632] success replica num is 0 < quorum replica num 1 while error backe

[GitHub] [doris] xinyiZzz commented on pull request #21545: [fix](sink) fix OlapTableSink early close causes load failure

2023-07-05 Thread via GitHub
xinyiZzz commented on PR #21545: URL: https://github.com/apache/doris/pull/21545#issuecomment-1621821284 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] xinyiZzz commented on pull request #21545: [fix](sink) fix OlapTableSink early close causes load failure

2023-07-05 Thread via GitHub
xinyiZzz commented on PR #21545: URL: https://github.com/apache/doris/pull/21545#issuecomment-1621824548 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [doris] ByteYue commented on pull request #19609: [feature](compaction) support delete in cumulative compaction

2023-07-05 Thread via GitHub
ByteYue commented on PR #19609: URL: https://github.com/apache/doris/pull/19609#issuecomment-1621824503 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] morningman commented on pull request #21542: [branch-1.2-lts](memtable) change memtable flush error code

2023-07-05 Thread via GitHub
morningman commented on PR #21542: URL: https://github.com/apache/doris/pull/21542#issuecomment-1621830250 BE UT failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] github-actions[bot] commented on pull request #21545: [fix](sink) fix OlapTableSink early close causes load failure

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21545: URL: https://github.com/apache/doris/pull/21545#issuecomment-1621832271 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #19609: [feature](compaction) support delete in cumulative compaction

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #19609: URL: https://github.com/apache/doris/pull/19609#issuecomment-1621841330 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #21545: [fix](sink) fix OlapTableSink early close causes load failure

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21545: URL: https://github.com/apache/doris/pull/21545#issuecomment-1621841675 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #21171: [Fix](Nereids) Add cast comparison with slot reference when inferring predicate

2023-07-05 Thread via GitHub
hello-stephen commented on PR #21171: URL: https://github.com/apache/doris/pull/21171#issuecomment-1621862112 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 48.46 seconds stream load tsv: 457 seconds loaded 74807831229 Bytes, about 156 MB/s

[GitHub] [doris] freemandealer commented on pull request #21536: [regression-test](load) add streamload default value test

2023-07-05 Thread via GitHub
freemandealer commented on PR #21536: URL: https://github.com/apache/doris/pull/21536#issuecomment-1621862772 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] hello-stephen commented on pull request #20599: [Fix](Planner) Change return type in where, having and on clause

2023-07-05 Thread via GitHub
hello-stephen commented on PR #20599: URL: https://github.com/apache/doris/pull/20599#issuecomment-1621873454 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.15 seconds stream load tsv: 461 seconds loaded 74807831229 Bytes, about 154 MB/s

[GitHub] [doris] github-actions[bot] commented on pull request #21177: [Feature](Compaction)Support full compaction

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21177: URL: https://github.com/apache/doris/pull/21177#issuecomment-1621890678 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] morningman merged pull request #21520: [fix](backup) fix show snapshot cauing mysql connection lost

2023-07-05 Thread via GitHub
morningman merged PR #21520: URL: https://github.com/apache/doris/pull/21520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[doris] branch master updated: [fix](backup) fix show snapshot cauing mysql connection lost (#21520)

2023-07-05 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new c1e82ce817 [fix](backup) fix show snapshot ca

[doris] branch branch-1.2-lts updated: [fix](backup) fix show snapshot cauing mysql connection lost (#21520)

2023-07-05 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-1.2-lts by this push: new ee2235a38b [fix](backup) fix

[GitHub] [doris] hello-stephen commented on pull request #21545: [fix](sink) fix OlapTableSink early close causes load failure

2023-07-05 Thread via GitHub
hello-stephen commented on PR #21545: URL: https://github.com/apache/doris/pull/21545#issuecomment-1621914040 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 52.02 seconds stream load tsv: 453 seconds loaded 74807831229 Bytes, about 157 MB/s

[GitHub] [doris] liaoxin01 commented on pull request #21456: [enhancement](merge-on-write) split delete bitmap from tablet meta

2023-07-05 Thread via GitHub
liaoxin01 commented on PR #21456: URL: https://github.com/apache/doris/pull/21456#issuecomment-1621920073 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] github-actions[bot] commented on pull request #21456: [enhancement](merge-on-write) split delete bitmap from tablet meta

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21456: URL: https://github.com/apache/doris/pull/21456#issuecomment-1621931061 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #21536: [regression-test](load) add streamload default value test

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21536: URL: https://github.com/apache/doris/pull/21536#issuecomment-1621935372 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #21536: [regression-test](load) add streamload default value test

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21536: URL: https://github.com/apache/doris/pull/21536#issuecomment-1621935508 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #21545: [fix](sink) fix OlapTableSink early close causes load failure

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21545: URL: https://github.com/apache/doris/pull/21545#issuecomment-1621938768 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #21545: [fix](sink) fix OlapTableSink early close causes load failure

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21545: URL: https://github.com/apache/doris/pull/21545#issuecomment-1621944997 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] kaka11chen commented on pull request #21516: [Fix](multi-catalog) Fix hadoop short circuit reading can not enabled in some environments.

2023-07-05 Thread via GitHub
kaka11chen commented on PR #21516: URL: https://github.com/apache/doris/pull/21516#issuecomment-1621953982 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] hello-stephen commented on pull request #21171: [Fix](Nereids) Add cast comparison with slot reference when inferring predicate

2023-07-05 Thread via GitHub
hello-stephen commented on PR #21171: URL: https://github.com/apache/doris/pull/21171#issuecomment-1621961733 (From new mechine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 56.08 seconds stream load tsv: 516 seconds loaded 74807831229 Bytes

[GitHub] [doris] hello-stephen commented on pull request #20599: [Fix](Planner) Change return type in where, having and on clause

2023-07-05 Thread via GitHub
hello-stephen commented on PR #20599: URL: https://github.com/apache/doris/pull/20599#issuecomment-1621962904 (From new mechine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 51.75 seconds stream load tsv: 512 seconds loaded 74807831229 Bytes

[GitHub] [doris] hello-stephen commented on pull request #21545: [fix](sink) fix OlapTableSink early close causes load failure

2023-07-05 Thread via GitHub
hello-stephen commented on PR #21545: URL: https://github.com/apache/doris/pull/21545#issuecomment-1621966627 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 49.46 seconds stream load tsv: 453 seconds loaded 74807831229 Bytes, about 157 MB/s

[GitHub] [doris] hello-stephen commented on pull request #19609: [feature](compaction) support delete in cumulative compaction

2023-07-05 Thread via GitHub
hello-stephen commented on PR #19609: URL: https://github.com/apache/doris/pull/19609#issuecomment-1621967283 (From new mechine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 51.33 seconds stream load tsv: 509 seconds loaded 74807831229 Bytes

[GitHub] [doris] yiguolei commented on a diff in pull request #21522: [improvement](memory) Refactor doris cache GC

2023-07-05 Thread via GitHub
yiguolei commented on code in PR #21522: URL: https://github.com/apache/doris/pull/21522#discussion_r1253263806 ## be/src/common/config.cpp: ## @@ -315,6 +315,10 @@ DEFINE_String(pk_storage_page_cache_limit, "10%"); // data page size for primary key index DEFINE_Int32(primary_

[GitHub] [doris] hello-stephen commented on pull request #21545: [fix](sink) fix OlapTableSink early close causes load failure

2023-07-05 Thread via GitHub
hello-stephen commented on PR #21545: URL: https://github.com/apache/doris/pull/21545#issuecomment-1621971438 (From new mechine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 53.35 seconds stream load tsv: 510 seconds loaded 74807831229 Bytes

[GitHub] [doris] yiguolei commented on a diff in pull request #21522: [improvement](memory) Refactor doris cache GC

2023-07-05 Thread via GitHub
yiguolei commented on code in PR #21522: URL: https://github.com/apache/doris/pull/21522#discussion_r1253267143 ## be/src/runtime/memory/cache_policy.h: ## @@ -0,0 +1,133 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements

[GitHub] [doris] yiguolei commented on a diff in pull request #21522: [improvement](memory) Refactor doris cache GC

2023-07-05 Thread via GitHub
yiguolei commented on code in PR #21522: URL: https://github.com/apache/doris/pull/21522#discussion_r1253268293 ## be/src/runtime/memory/cache_policy.h: ## @@ -0,0 +1,133 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements

[GitHub] [doris] yiguolei commented on a diff in pull request #21522: [improvement](memory) Refactor doris cache GC

2023-07-05 Thread via GitHub
yiguolei commented on code in PR #21522: URL: https://github.com/apache/doris/pull/21522#discussion_r1253268786 ## be/src/runtime/memory/cache_policy.h: ## @@ -0,0 +1,133 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements

[GitHub] [doris] yiguolei commented on a diff in pull request #21522: [improvement](memory) Refactor doris cache GC

2023-07-05 Thread via GitHub
yiguolei commented on code in PR #21522: URL: https://github.com/apache/doris/pull/21522#discussion_r1253269467 ## be/src/runtime/memory/cache_policy.h: ## @@ -0,0 +1,133 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements

[GitHub] [doris] morningman opened a new pull request, #21546: [fix](kerberos) should renew the kerberos ticket each half of ticket lifetime

2023-07-05 Thread via GitHub
morningman opened a new pull request, #21546: URL: https://github.com/apache/doris/pull/21546 ## Proposed changes Follow #21265, the renew interval of kerberos ticket should be half of `config::kerberos_expiration_time_seconds` ## Further comments If this is a relatively

[GitHub] [doris] yiguolei commented on a diff in pull request #21522: [improvement](memory) Refactor doris cache GC

2023-07-05 Thread via GitHub
yiguolei commented on code in PR #21522: URL: https://github.com/apache/doris/pull/21522#discussion_r1253272168 ## be/src/runtime/memory/cache_policy.h: ## @@ -0,0 +1,133 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements

[GitHub] [doris] morningman commented on pull request #21546: [fix](kerberos) should renew the kerberos ticket each half of ticket lifetime

2023-07-05 Thread via GitHub
morningman commented on PR #21546: URL: https://github.com/apache/doris/pull/21546#issuecomment-1621983783 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] github-actions[bot] commented on pull request #21512: [bugfix](RowsetIterator) use valid stats when creating segment iterator

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21512: URL: https://github.com/apache/doris/pull/21512#issuecomment-1621984729 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] LiBinfeng-01 commented on pull request #20602: [opt](planner) add important time to profile in planner

2023-07-05 Thread via GitHub
LiBinfeng-01 commented on PR #20602: URL: https://github.com/apache/doris/pull/20602#issuecomment-1621985861 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] LiBinfeng-01 commented on pull request #20599: [Fix](Planner) Change return type in where, having and on clause

2023-07-05 Thread via GitHub
LiBinfeng-01 commented on PR #20599: URL: https://github.com/apache/doris/pull/20599#issuecomment-1621988389 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] github-actions[bot] commented on pull request #21177: [Feature](Compaction)Support full compaction

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21177: URL: https://github.com/apache/doris/pull/21177#issuecomment-1621990888 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] morningman commented on a diff in pull request #21487: [improvement](column) Support for the default value of current_timestamp in milliseconds

2023-07-05 Thread via GitHub
morningman commented on code in PR #21487: URL: https://github.com/apache/doris/pull/21487#discussion_r1253278526 ## fe/fe-core/src/main/java/org/apache/doris/analysis/DefaultValueExprDef.java: ## @@ -23,28 +23,44 @@ import org.apache.doris.catalog.Type; import org.apache.dori

[GitHub] [doris] github-actions[bot] commented on pull request #21546: [fix](kerberos) should renew the kerberos ticket each half of ticket lifetime

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21546: URL: https://github.com/apache/doris/pull/21546#issuecomment-1621993452 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] yiguolei commented on a diff in pull request #21522: [improvement](memory) Refactor doris cache GC

2023-07-05 Thread via GitHub
yiguolei commented on code in PR #21522: URL: https://github.com/apache/doris/pull/21522#discussion_r1253283673 ## be/src/olap/segment_loader.h: ## @@ -53,7 +54,7 @@ class BetaRowset; // // Make sure that cache_handle is valid during the segment usage period. using BetaRowset

[GitHub] [doris] hello-stephen commented on pull request #19609: [feature](compaction) support delete in cumulative compaction

2023-07-05 Thread via GitHub
hello-stephen commented on PR #19609: URL: https://github.com/apache/doris/pull/19609#issuecomment-1622002735 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 48.76 seconds stream load tsv: 456 seconds loaded 74807831229 Bytes, about 156 MB/s

[GitHub] [doris] kaijchen opened a new pull request, #21547: [refactor](load) move memtable flush logic into beta rowset writer

2023-07-05 Thread via GitHub
kaijchen opened a new pull request, #21547: URL: https://github.com/apache/doris/pull/21547 ## Proposed changes 1. move memtable flush logic from `Memtable::flush()` to `BetaRowsetWriter::flush_memtable()` 2. move segment id assignment from `DeltaWriter::_flush_memtable_async()` to

[GitHub] [doris] yiguolei commented on a diff in pull request #21522: [improvement](memory) Refactor doris cache GC

2023-07-05 Thread via GitHub
yiguolei commented on code in PR #21522: URL: https://github.com/apache/doris/pull/21522#discussion_r1253290560 ## be/src/runtime/memory/cache_policy.h: ## @@ -0,0 +1,133 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements

[GitHub] [doris] kaijchen commented on pull request #21547: [refactor](load) move memtable flush logic to beta rowset writer

2023-07-05 Thread via GitHub
kaijchen commented on PR #21547: URL: https://github.com/apache/doris/pull/21547#issuecomment-1622010156 This PR depends on #21372. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [doris] kaka11chen opened a new pull request, #21548: [Fix](multi-catalog) Fix hadoop short circuit reading can not enabled…

2023-07-05 Thread via GitHub
kaka11chen opened a new pull request, #21548: URL: https://github.com/apache/doris/pull/21548 ## Proposed changes Merge #21516 to branch-1.2-lts. Fix hadoop short circuit reading can not enabled in some environments. - Revert #21430 because it will cause performance degradati

[GitHub] [doris] yiguolei commented on a diff in pull request #21522: [improvement](memory) Refactor doris cache GC

2023-07-05 Thread via GitHub
yiguolei commented on code in PR #21522: URL: https://github.com/apache/doris/pull/21522#discussion_r1253295314 ## be/src/util/mem_info.h: ## @@ -165,9 +172,162 @@ class MemInfo { static std::string debug_string(); -static void process_cache_gc(int64_t& freed_mem);

[GitHub] [doris] xinyiZzz commented on pull request #21545: [fix](sink) fix OlapTableSink early close causes load failure

2023-07-05 Thread via GitHub
xinyiZzz commented on PR #21545: URL: https://github.com/apache/doris/pull/21545#issuecomment-1622017230 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] yiguolei commented on a diff in pull request #21522: [improvement](memory) Refactor doris cache GC

2023-07-05 Thread via GitHub
yiguolei commented on code in PR #21522: URL: https://github.com/apache/doris/pull/21522#discussion_r1253295875 ## be/src/util/mem_info.h: ## @@ -165,9 +172,162 @@ class MemInfo { static std::string debug_string(); -static void process_cache_gc(int64_t& freed_mem);

[GitHub] [doris] zclllyybb commented on pull request #21305: [fix](datetime) refactor insert behavior to make same with mysql

2023-07-05 Thread via GitHub
zclllyybb commented on PR #21305: URL: https://github.com/apache/doris/pull/21305#issuecomment-1622019111 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] github-actions[bot] commented on pull request #21547: [refactor](load) move memtable flush logic to beta rowset writer

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21547: URL: https://github.com/apache/doris/pull/21547#issuecomment-1622019740 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] xinyiZzz commented on a diff in pull request #21522: [improvement](memory) Refactor doris cache GC

2023-07-05 Thread via GitHub
xinyiZzz commented on code in PR #21522: URL: https://github.com/apache/doris/pull/21522#discussion_r1253302345 ## be/src/common/config.cpp: ## @@ -315,6 +315,10 @@ DEFINE_String(pk_storage_page_cache_limit, "10%"); // data page size for primary key index DEFINE_Int32(primary_

[GitHub] [doris] yiguolei commented on a diff in pull request #21522: [improvement](memory) Refactor doris cache GC

2023-07-05 Thread via GitHub
yiguolei commented on code in PR #21522: URL: https://github.com/apache/doris/pull/21522#discussion_r1253302884 ## be/src/runtime/memory/cache_policy.cpp: ## @@ -0,0 +1,57 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreement

[GitHub] [doris] xinyiZzz commented on a diff in pull request #21522: [improvement](memory) Refactor doris cache GC

2023-07-05 Thread via GitHub
xinyiZzz commented on code in PR #21522: URL: https://github.com/apache/doris/pull/21522#discussion_r1253304073 ## be/src/runtime/memory/cache_policy.h: ## @@ -0,0 +1,133 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements

[GitHub] [doris] xinyiZzz commented on a diff in pull request #21522: [improvement](memory) Refactor doris cache GC

2023-07-05 Thread via GitHub
xinyiZzz commented on code in PR #21522: URL: https://github.com/apache/doris/pull/21522#discussion_r1253304867 ## be/src/runtime/memory/cache_policy.h: ## @@ -0,0 +1,133 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements

[GitHub] [doris] github-actions[bot] commented on pull request #21442: [Enhancement](multi-catalog) Add hdfs read statistics profile.

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21442: URL: https://github.com/apache/doris/pull/21442#issuecomment-1622030284 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #21305: [fix](datetime) refactor insert behavior to make same with mysql

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21305: URL: https://github.com/apache/doris/pull/21305#issuecomment-1622030715 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] TangSiyang2001 commented on pull request #21205: [enhancement](query) enable strong consistency by syncing max journal id from master

2023-07-05 Thread via GitHub
TangSiyang2001 commented on PR #21205: URL: https://github.com/apache/doris/pull/21205#issuecomment-1622031081 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] kaka11chen commented on pull request #21516: [Fix](multi-catalog) Fix hadoop short circuit reading can not enabled in some environments.

2023-07-05 Thread via GitHub
kaka11chen commented on PR #21516: URL: https://github.com/apache/doris/pull/21516#issuecomment-1622031355 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] github-actions[bot] commented on pull request #21516: [Fix](multi-catalog) Fix hadoop short circuit reading can not enabled in some environments.

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21516: URL: https://github.com/apache/doris/pull/21516#issuecomment-1622032483 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #21516: [Fix](multi-catalog) Fix hadoop short circuit reading can not enabled in some environments.

2023-07-05 Thread via GitHub
github-actions[bot] commented on PR #21516: URL: https://github.com/apache/doris/pull/21516#issuecomment-1622032550 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] xinyiZzz commented on a diff in pull request #21522: [improvement](memory) Refactor doris cache GC

2023-07-05 Thread via GitHub
xinyiZzz commented on code in PR #21522: URL: https://github.com/apache/doris/pull/21522#discussion_r1253309280 ## be/src/olap/segment_loader.h: ## @@ -53,7 +54,7 @@ class BetaRowset; // // Make sure that cache_handle is valid during the segment usage period. using BetaRowset

[GitHub] [doris] yiguolei commented on a diff in pull request #21522: [improvement](memory) Refactor doris cache GC

2023-07-05 Thread via GitHub
yiguolei commented on code in PR #21522: URL: https://github.com/apache/doris/pull/21522#discussion_r1253308845 ## be/src/runtime/memory/cache_policy.h: ## @@ -0,0 +1,133 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements

[GitHub] [doris] xinyiZzz commented on a diff in pull request #21522: [improvement](memory) Refactor doris cache GC

2023-07-05 Thread via GitHub
xinyiZzz commented on code in PR #21522: URL: https://github.com/apache/doris/pull/21522#discussion_r1253312929 ## be/src/util/mem_info.h: ## @@ -165,9 +172,162 @@ class MemInfo { static std::string debug_string(); -static void process_cache_gc(int64_t& freed_mem);

[GitHub] [doris] kaijchen commented on pull request #21547: [refactor](load) move memtable flush logic to beta rowset writer

2023-07-05 Thread via GitHub
kaijchen commented on PR #21547: URL: https://github.com/apache/doris/pull/21547#issuecomment-1622038476 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] yiguolei commented on a diff in pull request #21522: [improvement](memory) Refactor doris cache GC

2023-07-05 Thread via GitHub
yiguolei commented on code in PR #21522: URL: https://github.com/apache/doris/pull/21522#discussion_r1253314001 ## be/src/olap/segment_loader.h: ## @@ -53,7 +54,7 @@ class BetaRowset; // // Make sure that cache_handle is valid during the segment usage period. using BetaRowset

[GitHub] [doris] kaijchen commented on pull request #21547: [refactor](load) move memtable flush logic to beta rowset writer

2023-07-05 Thread via GitHub
kaijchen commented on PR #21547: URL: https://github.com/apache/doris/pull/21547#issuecomment-1622045447 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #21530: [enhancement](flush) make async flush status msg visible

2023-07-05 Thread via GitHub
TangSiyang2001 commented on code in PR #21530: URL: https://github.com/apache/doris/pull/21530#discussion_r1252971047 ## be/src/olap/rowset/beta_rowset_writer.cpp: ## @@ -823,7 +823,7 @@ Status BetaRowsetWriter::_flush_segment_writer(std::unique_ptrfinalize(&segment_size, &inde

<    1   2   3   4   5   6   >