TangSiyang2001 commented on code in PR #21530:
URL: https://github.com/apache/doris/pull/21530#discussion_r1252971047
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -823,7 +823,7 @@ Status
BetaRowsetWriter::_flush_segment_writer(std::unique_ptr<segment_v2::Segme
Status s = (*writer)->finalize(&segment_size, &index_size);
if (!s.ok()) {
LOG(WARNING) << "failed to finalize segment: " << s.to_string();
- return Status::Error<WRITER_DATA_WRITE_ERROR>();
+ return Status::Error<WRITER_DATA_WRITE_ERROR>(s.to_string());
Review Comment:
According to the signature, error code will be kept in this way, and I add
msg to it to make it clearer.
```cpp
template <int code, bool stacktrace = true, typename... Args>
Status static Error(std::string_view msg, Args&&... args)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
