[GitHub] [doris] github-actions[bot] commented on pull request #20928: [improvement](serde) Optimizing the performance of mysql result writer

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20928: URL: https://github.com/apache/doris/pull/20928#issuecomment-1595650943 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Yukang-Lian closed pull request #20883: [Fix](core) Get tablet version should hold meta lock

2023-06-17 Thread via GitHub
Yukang-Lian closed pull request #20883: [Fix](core) Get tablet version should hold meta lock URL: https://github.com/apache/doris/pull/20883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [doris] Mryange commented on pull request #20899: [feature](Session) remove enable_function_pushdown variable

2023-06-17 Thread via GitHub
Mryange commented on PR #20899: URL: https://github.com/apache/doris/pull/20899#issuecomment-1595661772 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] zhannngchen commented on pull request #20853: [enhancement](merge-on-write) format logs about MoW and add more stats for publish

2023-06-17 Thread via GitHub
zhannngchen commented on PR #20853: URL: https://github.com/apache/doris/pull/20853#issuecomment-1595662443 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] github-actions[bot] commented on pull request #20899: [feature](Session) remove enable_function_pushdown variable

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20899: URL: https://github.com/apache/doris/pull/20899#issuecomment-1595662966 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #20853: [enhancement](merge-on-write) format logs about MoW and add more stats for publish

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20853: URL: https://github.com/apache/doris/pull/20853#issuecomment-1595663567 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] dataroaring opened a new pull request, #20934: [fix](compress) snappy does not work right

2023-06-17 Thread via GitHub
dataroaring opened a new pull request, #20934: URL: https://github.com/apache/doris/pull/20934 Snapy does not work right and be crashes, the patch fixes it. ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or co

[GitHub] [doris] github-actions[bot] commented on pull request #20934: [fix](compress) snappy does not work right

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20934: URL: https://github.com/apache/doris/pull/20934#issuecomment-1595667884 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #20934: [fix](compress) snappy does not work right

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20934: URL: https://github.com/apache/doris/pull/20934#issuecomment-1595669489 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Mryange commented on pull request #20899: [feature](Session) remove enable_function_pushdown variable

2023-06-17 Thread via GitHub
Mryange commented on PR #20899: URL: https://github.com/apache/doris/pull/20899#issuecomment-1595671507 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] dataroaring commented on pull request #20934: [fix](compress) snappy does not work right

2023-06-17 Thread via GitHub
dataroaring commented on PR #20934: URL: https://github.com/apache/doris/pull/20934#issuecomment-1595671603 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] github-actions[bot] commented on pull request #20853: [enhancement](merge-on-write) format logs about MoW and add more stats for publish

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20853: URL: https://github.com/apache/doris/pull/20853#issuecomment-1595671610 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] TangSiyang2001 commented on pull request #20694: [enhancement](insert-stmt) Make `insert into tbl values();` compatible with mysql

2023-06-17 Thread via GitHub
TangSiyang2001 commented on PR #20694: URL: https://github.com/apache/doris/pull/20694#issuecomment-1595671698 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] deadlinefen closed pull request #20870: [Test](regression) CCR syncer thrift interface regression test

2023-06-17 Thread via GitHub
deadlinefen closed pull request #20870: [Test](regression) CCR syncer thrift interface regression test URL: https://github.com/apache/doris/pull/20870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [doris] deadlinefen opened a new pull request, #20935: [Test](regression) CCR syncer thrift interface regression test

2023-06-17 Thread via GitHub
deadlinefen opened a new pull request, #20935: URL: https://github.com/apache/doris/pull/20935 [Test] (regression) CCR syncer thrift interface regression test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [doris] deadlinefen commented on pull request #20935: [Test](regression) CCR syncer thrift interface regression test

2023-06-17 Thread via GitHub
deadlinefen commented on PR #20935: URL: https://github.com/apache/doris/pull/20935#issuecomment-1595677840 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] zhannngchen commented on pull request #20853: [enhancement](merge-on-write) format logs about MoW and add more stats for publish

2023-06-17 Thread via GitHub
zhannngchen commented on PR #20853: URL: https://github.com/apache/doris/pull/20853#issuecomment-1595685888 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] GoGoWen commented on pull request #18817: [Refine](UT) remove some deplicated code for UT

2023-06-17 Thread via GitHub
GoGoWen commented on PR #18817: URL: https://github.com/apache/doris/pull/18817#issuecomment-1595690826 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] yiguolei commented on a diff in pull request #20771: [fix](pipeline) refactor olap table sink close

2023-06-17 Thread via GitHub
yiguolei commented on code in PR #20771: URL: https://github.com/apache/doris/pull/20771#discussion_r1233009257 ## be/src/vec/sink/vtablet_sink.cpp: ## @@ -939,10 +930,10 @@ void VNodeChannel::_close_check() { CHECK(_cur_mutable_block == nullptr) << name(); } -void VNode

[GitHub] [doris] yiguolei commented on a diff in pull request #20771: [fix](pipeline) refactor olap table sink close

2023-06-17 Thread via GitHub
yiguolei commented on code in PR #20771: URL: https://github.com/apache/doris/pull/20771#discussion_r1233009684 ## be/src/vec/sink/vtablet_sink.cpp: ## @@ -1393,133 +1385,226 @@ Status VOlapTableSink::send(RuntimeState* state, vectorized::Block* input_block, return Status:

[GitHub] [doris] yiguolei commented on a diff in pull request #20771: [fix](pipeline) refactor olap table sink close

2023-06-17 Thread via GitHub
yiguolei commented on code in PR #20771: URL: https://github.com/apache/doris/pull/20771#discussion_r1233010193 ## be/src/vec/sink/vtablet_sink.cpp: ## @@ -1393,133 +1385,226 @@ Status VOlapTableSink::send(RuntimeState* state, vectorized::Block* input_block, return Status:

[GitHub] [doris] starocean999 commented on pull request #20761: [draft](nereids)enable nereids planner by default

2023-06-17 Thread via GitHub
starocean999 commented on PR #20761: URL: https://github.com/apache/doris/pull/20761#issuecomment-1595692816 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] yiguolei commented on a diff in pull request #20771: [fix](pipeline) refactor olap table sink close

2023-06-17 Thread via GitHub
yiguolei commented on code in PR #20771: URL: https://github.com/apache/doris/pull/20771#discussion_r1233010621 ## be/src/vec/sink/vtablet_sink.cpp: ## @@ -1393,133 +1385,226 @@ Status VOlapTableSink::send(RuntimeState* state, vectorized::Block* input_block, return Status:

[GitHub] [doris] yiguolei commented on a diff in pull request #20771: [fix](pipeline) refactor olap table sink close

2023-06-17 Thread via GitHub
yiguolei commented on code in PR #20771: URL: https://github.com/apache/doris/pull/20771#discussion_r1233010892 ## be/src/vec/sink/vtablet_sink.cpp: ## @@ -1393,133 +1385,226 @@ Status VOlapTableSink::send(RuntimeState* state, vectorized::Block* input_block, return Status:

[GitHub] [doris] amorynan commented on a diff in pull request #20928: [improvement](serde) Optimizing the performance of mysql result writer

2023-06-17 Thread via GitHub
amorynan commented on code in PR #20928: URL: https://github.com/apache/doris/pull/20928#discussion_r1233010896 ## be/src/vec/data_types/serde/data_type_hll_serde.cpp: ## @@ -102,30 +102,38 @@ void DataTypeHLLSerDe::write_column_to_arrow(const IColumn& column, const UInt8* }

[GitHub] [doris] dataroaring commented on pull request #20625: [fix](meta) 'clean label from db' does not work

2023-06-17 Thread via GitHub
dataroaring commented on PR #20625: URL: https://github.com/apache/doris/pull/20625#issuecomment-1595701385 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] TangSiyang2001 commented on pull request #20694: [enhancement](insert-stmt) Make `insert into tbl values();` compatible with mysql

2023-06-17 Thread via GitHub
TangSiyang2001 commented on PR #20694: URL: https://github.com/apache/doris/pull/20694#issuecomment-1595702096 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] TangSiyang2001 commented on pull request #20694: [enhancement](insert-stmt) Make `insert into tbl values();` compatible with mysql

2023-06-17 Thread via GitHub
TangSiyang2001 commented on PR #20694: URL: https://github.com/apache/doris/pull/20694#issuecomment-1595703098 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [doris] Mryange commented on pull request #20899: [feature](Session) remove enable_function_pushdown variable

2023-06-17 Thread via GitHub
Mryange commented on PR #20899: URL: https://github.com/apache/doris/pull/20899#issuecomment-1595719823 run clickbench -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] DarvenDuan commented on issue #20835: [Bug] `show data` shows inconsistent results

2023-06-17 Thread via GitHub
DarvenDuan commented on issue #20835: URL: https://github.com/apache/doris/issues/20835#issuecomment-1595720225 Trying set `set_forward_to_master` to `true` before `show data` may be helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [doris] github-actions[bot] commented on pull request #20916: [Feature](inverted index) add inverted index size to tablet meta

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20916: URL: https://github.com/apache/doris/pull/20916#issuecomment-1595720909 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #20916: [Feature](inverted index) add inverted index size to tablet meta

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20916: URL: https://github.com/apache/doris/pull/20916#issuecomment-1595720912 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] Yulei-Yang opened a new pull request, #20936: [feature](function) add ip function ipv4numtostring (alias inet_ntoa)

2023-06-17 Thread via GitHub
Yulei-Yang opened a new pull request, #20936: URL: https://github.com/apache/doris/pull/20936 ## Proposed changes Issue Number: #20584 https://github.com/apache/doris/assets/28004179/82e2ed2c-dc66-4775-b575-d5dc5136bcab";> ## Further comments If this is a

[GitHub] [doris] github-actions[bot] commented on pull request #20936: [feature](function) add ip function ipv4numtostring (alias inet_ntoa)

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20936: URL: https://github.com/apache/doris/pull/20936#issuecomment-1595721710 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Yulei-Yang commented on pull request #20936: [feature](function) add ip function ipv4numtostring (alias inet_ntoa)

2023-06-17 Thread via GitHub
Yulei-Yang commented on PR #20936: URL: https://github.com/apache/doris/pull/20936#issuecomment-1595721757 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] xiaokang merged pull request #20778: [Fix](invert index) fix fd over limit

2023-06-17 Thread via GitHub
xiaokang merged PR #20778: URL: https://github.com/apache/doris/pull/20778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated: [Fix](fd) fix fd limit over 100% (#20778)

2023-06-17 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new cc3f9ed9b7 [Fix](fd) fix fd limit over 100% (#2077

[GitHub] [doris] liutang123 commented on pull request #19924: [improvement](pipeline) task group scan entity

2023-06-17 Thread via GitHub
liutang123 commented on PR #19924: URL: https://github.com/apache/doris/pull/19924#issuecomment-1595723075 @wangbo do you have time to merge this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [doris] gavinchou commented on pull request #20230: (chore) Disable ssl connection to FE by default for compatibility reason

2023-06-17 Thread via GitHub
gavinchou commented on PR #20230: URL: https://github.com/apache/doris/pull/20230#issuecomment-1595726002 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] github-actions[bot] commented on pull request #20853: [enhancement](merge-on-write) format logs about MoW and add more stats for publish

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20853: URL: https://github.com/apache/doris/pull/20853#issuecomment-1595728483 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #20853: [enhancement](merge-on-write) format logs about MoW and add more stats for publish

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20853: URL: https://github.com/apache/doris/pull/20853#issuecomment-1595728493 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] Yulei-Yang commented on pull request #20936: [feature](function) add ip function ipv4numtostring (alias inet_ntoa)

2023-06-17 Thread via GitHub
Yulei-Yang commented on PR #20936: URL: https://github.com/apache/doris/pull/20936#issuecomment-1595729167 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] yiguolei commented on a diff in pull request #20771: [fix](pipeline) refactor olap table sink close

2023-06-17 Thread via GitHub
yiguolei commented on code in PR #20771: URL: https://github.com/apache/doris/pull/20771#discussion_r1233032702 ## be/src/vec/sink/vtablet_sink.cpp: ## @@ -1393,133 +1385,226 @@ Status VOlapTableSink::send(RuntimeState* state, vectorized::Block* input_block, return Status:

[GitHub] [doris] github-actions[bot] commented on pull request #20934: [fix](compress) snappy does not work right

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20934: URL: https://github.com/apache/doris/pull/20934#issuecomment-1595730316 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] platoneko commented on a diff in pull request #20889: [fix](compaction) fix time series compaction policy to adjust vertical compaction max segment size

2023-06-17 Thread via GitHub
platoneko commented on code in PR #20889: URL: https://github.com/apache/doris/pull/20889#discussion_r1233032250 ## be/src/olap/cumulative_compaction_policy.h: ## @@ -33,7 +33,7 @@ namespace doris { class Tablet; struct Version; -inline std::string_view CUMULATIVE_SIZE_BASED

[GitHub] [doris] xiaokang merged pull request #20889: [fix](compaction) fix time series compaction policy to adjust vertical compaction max segment size

2023-06-17 Thread via GitHub
xiaokang merged PR #20889: URL: https://github.com/apache/doris/pull/20889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated: [fix](compaction) fix time series compaction policy to adjust vertical compaction max segment size (#20889)

2023-06-17 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 0585a1f004 [fix](compaction) fix time series compa

[GitHub] [doris] Mryange commented on pull request #20899: [feature](Session) remove enable_function_pushdown variable

2023-06-17 Thread via GitHub
Mryange commented on PR #20899: URL: https://github.com/apache/doris/pull/20899#issuecomment-1595732770 run clickbench -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] github-actions[bot] commented on pull request #20934: [fix](compress) snappy does not work right

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20934: URL: https://github.com/apache/doris/pull/20934#issuecomment-1595733552 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #20934: [fix](compress) snappy does not work right

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20934: URL: https://github.com/apache/doris/pull/20934#issuecomment-1595733560 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #20936: [feature](function) add ip function ipv4numtostring (alias inet_ntoa)

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20936: URL: https://github.com/apache/doris/pull/20936#issuecomment-1595733815 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #20936: [feature](function) add ip function ipv4numtostring (alias inet_ntoa)

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20936: URL: https://github.com/apache/doris/pull/20936#issuecomment-1595734064 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Yulei-Yang commented on pull request #20936: [feature](function) add ip function ipv4numtostring (alias inet_ntoa)

2023-06-17 Thread via GitHub
Yulei-Yang commented on PR #20936: URL: https://github.com/apache/doris/pull/20936#issuecomment-1595734367 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] github-actions[bot] commented on pull request #19990: [Feature](avro) Support Apache Avro file format

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #19990: URL: https://github.com/apache/doris/pull/19990#issuecomment-1595734622 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] Mryange commented on pull request #20899: [feature](Session) remove enable_function_pushdown variable

2023-06-17 Thread via GitHub
Mryange commented on PR #20899: URL: https://github.com/apache/doris/pull/20899#issuecomment-1595738128 run clickbench -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] CalvinKirs commented on pull request #20921: [Dependency](fe)Use the release version of hive-catalog(1.0.1)

2023-06-17 Thread via GitHub
CalvinKirs commented on PR #20921: URL: https://github.com/apache/doris/pull/20921#issuecomment-1595738685 run COMPILE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] DongLiang-0 commented on a diff in pull request #19990: [Feature](avro) Support Apache Avro file format

2023-06-17 Thread via GitHub
DongLiang-0 commented on code in PR #19990: URL: https://github.com/apache/doris/pull/19990#discussion_r1233045075 ## be/src/vec/exec/jni_connector.cpp: ## @@ -62,6 +62,21 @@ JniConnector::~JniConnector() { } } +Status JniConnector::open() { Review Comment: Thanks fo

[GitHub] [doris] DongLiang-0 commented on a diff in pull request #19990: [Feature](avro) Support Apache Avro file format

2023-06-17 Thread via GitHub
DongLiang-0 commented on code in PR #19990: URL: https://github.com/apache/doris/pull/19990#discussion_r1233045127 ## be/src/vec/exec/scan/avro_reader.cpp: ## @@ -0,0 +1,130 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreeme

[GitHub] [doris] DongLiang-0 commented on pull request #19990: [Feature](avro) Support Apache Avro file format

2023-06-17 Thread via GitHub
DongLiang-0 commented on PR #19990: URL: https://github.com/apache/doris/pull/19990#issuecomment-1595745809 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] github-actions[bot] commented on pull request #19990: [Feature](avro) Support Apache Avro file format

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #19990: URL: https://github.com/apache/doris/pull/19990#issuecomment-1595746191 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[doris] branch branch-2.0 updated (6cde7bc8ad -> 0585a1f004)

2023-06-17 Thread kxiao
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a change to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/doris.git from 6cde7bc8ad [feature](Nereids) just reserve logical expression in memo after do dphyp (#20843) add 5dc0f90c7f [

[GitHub] [doris] github-actions[bot] commented on pull request #19990: [Feature](avro) Support Apache Avro file format

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #19990: URL: https://github.com/apache/doris/pull/19990#issuecomment-1595747554 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] DongLiang-0 commented on a diff in pull request #19990: [Feature](avro) Support Apache Avro file format

2023-06-17 Thread via GitHub
DongLiang-0 commented on code in PR #19990: URL: https://github.com/apache/doris/pull/19990#discussion_r1233054832 ## fe/be-java-extensions/hudi-scanner/src/main/java/org/apache/doris/hudi/HudiJniScanner.java: ## @@ -132,6 +133,11 @@ public int getNext() throws IOException {

[GitHub] [doris] DongLiang-0 commented on a diff in pull request #19990: [Feature](avro) Support Apache Avro file format

2023-06-17 Thread via GitHub
DongLiang-0 commented on code in PR #19990: URL: https://github.com/apache/doris/pull/19990#discussion_r1233056487 ## fe/be-java-extensions/java-common/src/main/java/org/apache/doris/common/jni/JniScanner.java: ## @@ -41,6 +42,9 @@ public abstract class JniScanner { // Scan

[GitHub] [doris] deadlinefen commented on pull request #20935: [Test](regression) CCR syncer thrift interface regression test

2023-06-17 Thread via GitHub
deadlinefen commented on PR #20935: URL: https://github.com/apache/doris/pull/20935#issuecomment-1595747787 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] Mryange commented on pull request #20899: [feature](Session) remove enable_function_pushdown variable

2023-06-17 Thread via GitHub
Mryange commented on PR #20899: URL: https://github.com/apache/doris/pull/20899#issuecomment-1595748152 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] github-actions[bot] commented on pull request #20899: [feature](Session) remove enable_function_pushdown variable

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20899: URL: https://github.com/apache/doris/pull/20899#issuecomment-1595750200 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] morrySnow opened a new pull request, #20937: [fix](Nereids) cannot get output when partitioned table with no parititon

2023-06-17 Thread via GitHub
morrySnow opened a new pull request, #20937: URL: https://github.com/apache/doris/pull/20937 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailt

[GitHub] [doris] morrySnow commented on pull request #20937: [fix](Nereids) cannot get output when partitioned table with no parititon

2023-06-17 Thread via GitHub
morrySnow commented on PR #20937: URL: https://github.com/apache/doris/pull/20937#issuecomment-1595760581 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] JNSimba merged pull request #20922: [typo](doc) fix bucket description and style

2023-06-17 Thread via GitHub
JNSimba merged PR #20922: URL: https://github.com/apache/doris/pull/20922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apac

[doris] branch master updated: [typo](doc) fix bucket description and style (#20922)

2023-06-17 Thread diwu
This is an automated email from the ASF dual-hosted git repository. diwu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 06806dc737 [typo](doc) fix bucket description and s

[GitHub] [doris] JNSimba commented on a diff in pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc

2023-06-17 Thread via GitHub
JNSimba commented on code in PR #20647: URL: https://github.com/apache/doris/pull/20647#discussion_r1233067854 ## fe/fe-core/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java: ## @@ -196,6 +198,9 @@ public void preCommitTransaction2PC(Database db, List tableL

[GitHub] [doris] JNSimba commented on a diff in pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc

2023-06-17 Thread via GitHub
JNSimba commented on code in PR #20647: URL: https://github.com/apache/doris/pull/20647#discussion_r1233068145 ## fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java: ## @@ -425,7 +425,10 @@ public void preCommitTransaction2PC(List tableList, long

[GitHub] [doris] JNSimba commented on a diff in pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc

2023-06-17 Thread via GitHub
JNSimba commented on code in PR #20647: URL: https://github.com/apache/doris/pull/20647#discussion_r1233068145 ## fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java: ## @@ -425,7 +425,10 @@ public void preCommitTransaction2PC(List tableList, long

[GitHub] [doris] JNSimba commented on a diff in pull request #20647: [Enhance](2PC) disable info log when holding table write lock in 2pc

2023-06-17 Thread via GitHub
JNSimba commented on code in PR #20647: URL: https://github.com/apache/doris/pull/20647#discussion_r1233068348 ## fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java: ## @@ -675,7 +678,11 @@ public void commitTransaction(List tableList, long transa

[GitHub] [doris] Tanya-W commented on pull request #20924: [fix](inverted index) fix check failed for block erase temp column

2023-06-17 Thread via GitHub
Tanya-W commented on PR #20924: URL: https://github.com/apache/doris/pull/20924#issuecomment-1595774161 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] github-actions[bot] commented on pull request #20924: [fix](inverted index) fix check failed for block erase temp column

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20924: URL: https://github.com/apache/doris/pull/20924#issuecomment-1595775275 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] gavinchou commented on pull request #20230: (chore) Disable ssl connection to FE by default for compatibility reason

2023-06-17 Thread via GitHub
gavinchou commented on PR #20230: URL: https://github.com/apache/doris/pull/20230#issuecomment-1595778748 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] BiteTheDDDDt opened a new pull request, #20938: [Bug](pipeline) fix hang on union_source_operator when child sink_operator all finished

2023-06-17 Thread via GitHub
BiteThet opened a new pull request, #20938: URL: https://github.com/apache/doris/pull/20938 ## Proposed changes When `union_source_operator`'s child `sink_operator` all finished, `union_source_operator.can_read()` is false, then is operator will not be schedured. ## Further co

[GitHub] [doris] BiteTheDDDDt commented on pull request #20938: [Bug](pipeline) fix hang on union_source_operator when child sink_operator all finished

2023-06-17 Thread via GitHub
BiteThet commented on PR #20938: URL: https://github.com/apache/doris/pull/20938#issuecomment-1595781478 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] github-actions[bot] commented on pull request #20938: [Bug](pipeline) fix hang on union_source_operator when child sink_operator all finished

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20938: URL: https://github.com/apache/doris/pull/20938#issuecomment-1595782935 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] dataroaring merged pull request #20853: [enhancement](merge-on-write) format logs about MoW and add more stats for publish

2023-06-17 Thread via GitHub
dataroaring merged PR #20853: URL: https://github.com/apache/doris/pull/20853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[doris] branch master updated: [enhancement](merge-on-write) format logs about MoW and add more stats for publish (#20853)

2023-06-17 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new ce9a20a375 [enhancement](merge-on-write) for

[GitHub] [doris] morrySnow opened a new pull request, #20939: [fix](Nereids) should not hit mv when agg function is distinct

2023-06-17 Thread via GitHub
morrySnow opened a new pull request, #20939: URL: https://github.com/apache/doris/pull/20939 ## Proposed changes Issue Number: close #xxx fix 2 issues: 1. in legacy planner, should not consider aux expr when do mv selection 2. in Nereids, should not hit mv when agg

[GitHub] [doris] github-actions[bot] commented on pull request #20938: [Bug](pipeline) fix hang on union_source_operator when child sink_operator all finished

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20938: URL: https://github.com/apache/doris/pull/20938#issuecomment-1595785543 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #20938: [Bug](pipeline) fix hang on union_source_operator when child sink_operator all finished

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20938: URL: https://github.com/apache/doris/pull/20938#issuecomment-1595785554 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] morningman opened a new pull request, #20940: [minor](scripts) remove release download scripts

2023-06-17 Thread via GitHub
morningman opened a new pull request, #20940: URL: https://github.com/apache/doris/pull/20940 ## Proposed changes No longer used, now the release binaries are packed to one package. So remove these scripts. ## Further comments If this is a relatively large or complex cha

[GitHub] [doris] morningman commented on pull request #20940: [minor](scripts) remove release download scripts

2023-06-17 Thread via GitHub
morningman commented on PR #20940: URL: https://github.com/apache/doris/pull/20940#issuecomment-1595786050 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] morrySnow commented on pull request #20939: [fix](Nereids) should not hit mv when agg function is distinct

2023-06-17 Thread via GitHub
morrySnow commented on PR #20939: URL: https://github.com/apache/doris/pull/20939#issuecomment-1595786125 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] starocean999 commented on pull request #20761: [draft](nereids)enable nereids planner by default

2023-06-17 Thread via GitHub
starocean999 commented on PR #20761: URL: https://github.com/apache/doris/pull/20761#issuecomment-1595787338 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] morrySnow commented on pull request #20939: [fix](Nereids) should not hit mv when agg function is distinct

2023-06-17 Thread via GitHub
morrySnow commented on PR #20939: URL: https://github.com/apache/doris/pull/20939#issuecomment-1595791165 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] shenxingwuying opened a new pull request, #20941: [typo](docs) fix several slight errors in docs

2023-06-17 Thread via GitHub
shenxingwuying opened a new pull request, #20941: URL: https://github.com/apache/doris/pull/20941 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](

[GitHub] [doris] mrhhsg commented on pull request #20928: [improvement](serde) Optimizing the performance of mysql result writer

2023-06-17 Thread via GitHub
mrhhsg commented on PR #20928: URL: https://github.com/apache/doris/pull/20928#issuecomment-1595795407 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [doris] mrhhsg commented on a diff in pull request #20928: [improvement](serde) Optimizing the performance of mysql result writer

2023-06-17 Thread via GitHub
mrhhsg commented on code in PR #20928: URL: https://github.com/apache/doris/pull/20928#discussion_r1233085735 ## be/src/vec/data_types/serde/data_type_hll_serde.cpp: ## @@ -102,30 +102,38 @@ void DataTypeHLLSerDe::write_column_to_arrow(const IColumn& column, const UInt8* }

[GitHub] [doris] github-actions[bot] commented on pull request #20935: [Test](regression) CCR syncer thrift interface regression test

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20935: URL: https://github.com/apache/doris/pull/20935#issuecomment-1595795780 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #20935: [Test](regression) CCR syncer thrift interface regression test

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20935: URL: https://github.com/apache/doris/pull/20935#issuecomment-1595795789 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #20928: [improvement](serde) Optimizing the performance of mysql result writer

2023-06-17 Thread via GitHub
github-actions[bot] commented on PR #20928: URL: https://github.com/apache/doris/pull/20928#issuecomment-1595796060 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] dataroaring opened a new pull request, #20942: [enhancement](pk) add bvar latency recorder for pk

2023-06-17 Thread via GitHub
dataroaring opened a new pull request, #20942: URL: https://github.com/apache/doris/pull/20942 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mai

[GitHub] [doris] dataroaring merged pull request #20935: [Test](regression) CCR syncer thrift interface regression test

2023-06-17 Thread via GitHub
dataroaring merged PR #20935: URL: https://github.com/apache/doris/pull/20935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[doris] branch master updated (ce9a20a375 -> dd482b74c8)

2023-06-17 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from ce9a20a375 [enhancement](merge-on-write) format logs about MoW and add more stats for publish (#20853) add d

  1   2   >