yiguolei commented on code in PR #20771:
URL: https://github.com/apache/doris/pull/20771#discussion_r1233009257
##########
be/src/vec/sink/vtablet_sink.cpp:
##########
@@ -939,10 +930,10 @@ void VNodeChannel::_close_check() {
CHECK(_cur_mutable_block == nullptr) << name();
}
-void VNodeChannel::mark_close() {
- auto st = none_of({_cancelled, _eos_is_produced});
- if (!st.ok()) {
- return;
+Status VNodeChannel::mark_close() {
+ DCHECK(!_eos_is_produced);
Review Comment:
这里的逻辑似乎跟之前不一样了， 之前他的逻辑是遇到cancel 或者 eos produced，这个mark close
实际是幂等的，他可以反复的调用。
但是现在的逻辑会core，或者返回一个错误的status。 感觉可能上层很多逻辑不能正常处理这个。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
